Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recurring Payments: change alignment #13310

Merged
merged 4 commits into from
Sep 4, 2019
Merged

Recurring Payments: change alignment #13310

merged 4 commits into from
Sep 4, 2019

Conversation

artpi
Copy link
Contributor

@artpi artpi commented Aug 23, 2019 •
edited
Loading

Zrzut ekranu 2019-09-3 o 11 40 24

Zrzut ekranu 2019-09-3 o 11 39 51

Changes proposed in this Pull Request:

  • Introduce the align menu to choose left/right/center alignment for the block.

Testing instructions:

  • Choose a site with Recurring Payments set up (full instructions in Membership Block #9802)
  • Insert new button
  • Change alignment to center
  • Publish
  • See that your new button is in the center

Proposed changelog entry for your changes:

  • You can now change the alignment of your recurring payments button. If you want to have it display in the middle of your page - that's an option now!

@artpi artpi requested a review from a team August 23, 2019 13:51
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello artpi! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D31901-code before merging this PR. Thank you!

@jeherve jeherve added [Status] Blocked / Hold [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Block] Payment Button aka Recurring Payments and removed [Status] In Progress labels Aug 23, 2019
@jeherve jeherve added the [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it label Aug 23, 2019
@jetpackbot
Copy link

jetpackbot commented Aug 23, 2019 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: October 1, 2019.
Scheduled code freeze: September 24, 2019

Generated by 🚫 dangerJS against 3140e17

@jeherve jeherve added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Blocked / Hold labels Aug 26, 2019
@jeherve
Copy link
Member

jeherve commented Aug 26, 2019

#13302 has now been merged. 👍

@matticbot
Copy link
Contributor

artpi, Your synced wpcom patch D31901-code has been updated.

@matticbot
Copy link
Contributor

artpi, Your synced wpcom patch D31901-code has been updated.

@artpi artpi changed the title WIP: Recurring payments/center Recurring Payments: change alignment Sep 3, 2019
@artpi artpi added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Sep 3, 2019
@artpi
Copy link
Contributor Author

artpi commented Sep 3, 2019

I rebased with changes from #13302 and incorporated them. With those changes, it is now much easier!
Also addressed the feedback.

@jeherve jeherve added this to the 7.8 milestone Sep 3, 2019
jeherve
jeherve approved these changes Sep 3, 2019
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work well on my end. 👍

@artpi artpi merged commit b239943 into master Sep 4, 2019
@artpi artpi deleted the recurring-payments/center branch September 4, 2019 10:14
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Sep 4, 2019
jeherve added a commit that referenced this pull request Sep 20, 2019
@jeherve
Changelog: add #13310
f7c9c40
jeherve added a commit that referenced this pull request Sep 24, 2019
@jeherve
Changelog: add #13310
9ea4e69
jeherve added a commit that referenced this pull request Sep 24, 2019
@jeherve
Changelog: changes for 7.8 (#13402)
d52a0f3 
* Changelog: initial set of changes for 7.8

* Changelog: add #13310

* Changelog: add #13103

* Changelog: add #13426

* Changelog: add #13389

* Changelog: add #13449

* Changelog: add #13461

* Changelog: add #13460

* Changelog: add #13441

* Changelog: add #13454

* Changelog: add #13457

* Changelog: add #13425

* Changelog: add #13473

* Changelog: add #13355

* Changelog: add #13451

* Changelog: add #13358

* Changelog: add #13464

* Changelog: add #13416

* Changelog: add #13494

* Changelog: add #13465

* Changelog: add #13424

* Changelog: add #13432

* Changelog: add #13471

* Changelog: add 7.7.2 entry

* Changelog: add #13446

* Add more testing elements
jeherve added a commit that referenced this pull request Sep 24, 2019
@jeherve
[not verified] Changelog: changes for 7.8 (#13402)
e50dedc 
* Changelog: initial set of changes for 7.8

* Changelog: add #13310

* Changelog: add #13103

* Changelog: add #13426

* Changelog: add #13389

* Changelog: add #13449

* Changelog: add #13461

* Changelog: add #13460

* Changelog: add #13441

* Changelog: add #13454

* Changelog: add #13457

* Changelog: add #13425

* Changelog: add #13473

* Changelog: add #13355

* Changelog: add #13451

* Changelog: add #13358

* Changelog: add #13464

* Changelog: add #13416

* Changelog: add #13494

* Changelog: add #13465

* Changelog: add #13424

* Changelog: add #13432

* Changelog: add #13471

* Changelog: add 7.7.2 entry

* Changelog: add #13446

* Add more testing elements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simison simison simison left review comments

@jeherve jeherve jeherve approved these changes

Assignees

@artpi artpi

Labels
[Block] Payment Button aka Recurring Payments [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack Touches WP.com Files [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
7.8
Development

Successfully merging this pull request may close these issues.
5 participants
@artpi @matticbot @jetpackbot @jeherve @simison