Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add return for deprecated Jetpack_Sync_Settings functions #13454

Merged
merged 1 commit into from
Sep 14, 2019

Conversation

rebeccahum
Copy link
Contributor

The deprecated functions in Jetpack_Sync_Settings that call the newly re-factored functions expect a returned value but do not return.

Changes proposed in this Pull Request:

  • Certain Jetpack_Sync_Settings deprecated functions will now return

Testing instructions:

  • Wp shell in
  • Call one of the functions where it expects a returned value and see that it returns NULL:
wp> Jetpack_Sync_Settings::is_doing_cron();
=> phar:///root/roles/docker-container-vip-web/usr/local/bin/wp/vendor/wp-cli/shell-command/src/WP_CLI/Shell/REPL.php:52:
NULL
  • Make change and call the function again:
wp> Jetpack_Sync_Settings::is_doing_cron();
bool(false)

Proposed changelog entry for your changes:

  • Deprecated functions in Jetpack_Sync_Settings with expected return values will return.

@rebeccahum rebeccahum requested a review from a team September 11, 2019 16:28
@jetpackbot
Copy link

Warnings
⚠️

The PR is missing at least one [Status] label. Suggestions: [Status] In Progress, [Status] Needs Review

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against 6ed9478

@rebeccahum rebeccahum added the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Sep 11, 2019
@jeherve jeherve added [Package] Sync [Type] Bug When a feature is broken and / or not performing as intended labels Sep 12, 2019
@jeherve jeherve added this to the 7.8 milestone Sep 12, 2019
@jeherve jeherve requested a review from a team September 12, 2019 17:04
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for fixing these ❤️

@tyxla tyxla added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Sep 14, 2019
@tyxla tyxla merged commit 4811b72 into master Sep 14, 2019
@tyxla tyxla deleted the rebceca/fix_deprecated_Jetpack_Sync_Settings branch September 14, 2019 18:10
@jeherve jeherve added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! [Status] Needs Changelog labels Sep 14, 2019
jeherve added a commit that referenced this pull request Sep 20, 2019
jeherve added a commit that referenced this pull request Sep 24, 2019
jeherve added a commit that referenced this pull request Sep 24, 2019
* Changelog: initial set of changes for 7.8

* Changelog: add #13310

* Changelog: add #13103

* Changelog: add #13426

* Changelog: add #13389

* Changelog: add #13449

* Changelog: add #13461

* Changelog: add #13460

* Changelog: add #13441

* Changelog: add #13454

* Changelog: add #13457

* Changelog: add #13425

* Changelog: add #13473

* Changelog: add #13355

* Changelog: add #13451

* Changelog: add #13358

* Changelog: add #13464

* Changelog: add #13416

* Changelog: add #13494

* Changelog: add #13465

* Changelog: add #13424

* Changelog: add #13432

* Changelog: add #13471

* Changelog: add 7.7.2 entry

* Changelog: add #13446

* Add more testing elements
jeherve added a commit that referenced this pull request Sep 24, 2019
* Changelog: initial set of changes for 7.8

* Changelog: add #13310

* Changelog: add #13103

* Changelog: add #13426

* Changelog: add #13389

* Changelog: add #13449

* Changelog: add #13461

* Changelog: add #13460

* Changelog: add #13441

* Changelog: add #13454

* Changelog: add #13457

* Changelog: add #13425

* Changelog: add #13473

* Changelog: add #13355

* Changelog: add #13451

* Changelog: add #13358

* Changelog: add #13464

* Changelog: add #13416

* Changelog: add #13494

* Changelog: add #13465

* Changelog: add #13424

* Changelog: add #13432

* Changelog: add #13471

* Changelog: add 7.7.2 entry

* Changelog: add #13446

* Add more testing elements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Sync [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants