Update: Remove the promotional copy on Jetpack Setup

[enejb]

Fixes #13410.

The main reason we are doing this is so that we can then increase the iframe size and not have too much of a gap between the promotional copy and the iframe.

Changes proposed in this Pull Request:

Fade out the promotional instructions when the user clicks the Setup Jetpack button.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

Testing instructions:

Add the constant define( 'JETPACK_SHOULD_USE_CONNECTION_IFRAME', true ); to you wp-config.php

• Go to Jetpack admin to connect jetpack for the first time.
• Notice that the promotional copy fades away after you click on thee Setup Jetpack button.

Proposed changelog entry for your changes:

• Remove the promiotional copy when in the jetpack setup process.

[jetpackbot]

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: October 1, 2019.
Scheduled code freeze: September 24, 2019

Generated by 🚫 dangerJS against a9b8b11

[tyxla]

This does the job well, thanks!

I've left a minor suggestion, once it's commited, code-wise we're good, so if you get a design ✅ feel free to ship.

[tyxla]

Re-approving after the latest changes.

[keoshi]

This looks great, but I agree with @tyxla — the 100 value is just too fast, but maybe it serves a purpose of switching the layout with a tiny transition just to avoid looking broken in between? In any case, a smoother, longer transition would help here.

Outside the scope, but one minor thing I've noticed when testing this again is that when pressing the button, it turns into a disabled “Loading...” that eventually goes away. Could we replace that for simple text instead of a button, or does it serve any purpose (reverts to the original button in case of error, or changing between elements would also lead to temporary layout misformatting)?

[jeffgolenski]

Just tested at mobile size. Seems to work well for me. Only suggestion is what @keoshi recommended above.

Video testing: https://cloudup.com/cFrSo-BWr71

[gravityrail]

I love this change. Thanks!

[lezama]

Outside the scope, but one minor thing I've noticed when testing this again is that when pressing the button, it turns into a disabled “Loading...” that eventually goes away. Could we replace that for simple text instead of a button, or does it serve any purpose (reverts to the original button in case of error, or changing between elements would also lead to temporary layout misformatting)?

tracked in Asana