Gutenberg extensions: Stripe connection notices #13441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simison
added
[Focus] Accessibility
|
Caution: This PR has changes that must be merged to WordPress.com |
|
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: October 1, 2019. |
jeherve
approved these changes
Sep 9, 2019
sirreal
approved these changes
Sep 13, 2019
| import { dispatch } from '@wordpress/data'; | ||
| import { __ } from '@wordpress/i18n'; | ||
| import '@wordpress/notices'; | ||
| import { parse as parseUrl } from 'url'; |
There was a problem hiding this comment.
We should use @wordpress/url getQueryArg.
Fine to land as-is, there are a bunch of these to migrate.
|
D32595-code was simply missing the new file (I've added it), but I had to force fusion-check green because of it. |
matticbot
added
[Status] Needs Changelog
and removed
[Status] Needs Review
jeherve
added a commit
that referenced
this pull request
Sep 24, 2019
* Changelog: initial set of changes for 7.8 * Changelog: add #13310 * Changelog: add #13103 * Changelog: add #13426 * Changelog: add #13389 * Changelog: add #13449 * Changelog: add #13461 * Changelog: add #13460 * Changelog: add #13441 * Changelog: add #13454 * Changelog: add #13457 * Changelog: add #13425 * Changelog: add #13473 * Changelog: add #13355 * Changelog: add #13451 * Changelog: add #13358 * Changelog: add #13464 * Changelog: add #13416 * Changelog: add #13494 * Changelog: add #13465 * Changelog: add #13424 * Changelog: add #13432 * Changelog: add #13471 * Changelog: add 7.7.2 entry * Changelog: add #13446 * Add more testing elements
jeherve
added a commit
that referenced
this pull request
Sep 24, 2019
* Changelog: initial set of changes for 7.8 * Changelog: add #13310 * Changelog: add #13103 * Changelog: add #13426 * Changelog: add #13389 * Changelog: add #13449 * Changelog: add #13461 * Changelog: add #13460 * Changelog: add #13441 * Changelog: add #13454 * Changelog: add #13457 * Changelog: add #13425 * Changelog: add #13473 * Changelog: add #13355 * Changelog: add #13451 * Changelog: add #13358 * Changelog: add #13464 * Changelog: add #13416 * Changelog: add #13494 * Changelog: add #13465 * Changelog: add #13424 * Changelog: add #13432 * Changelog: add #13471 * Changelog: add 7.7.2 entry * Changelog: add #13446 * Add more testing elements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds success notices for successful and canceled Stripe connections.
Note that copy is now Recurring payments specific since that's the only feature using Stripe like this; in future, if there are multiple features utilizing Stripe, the copy would need to be modified.
Companion for D32394-code and #13398
Changes proposed in this Pull Request:
–
Is this a new feature or does it add/remove features to an existing part of Jetpack?
Updates. paObgF-qE-p2
Testing instructions:
Instead of testing the full flow with other patches, you can just test the contract:
?stripe_connect_success=1or?stripe_connect_cancelled=1URL arguments, you should see corresponding notices respectively.Proposed changelog entry for your changes: