-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update is_fse_active to utilize FSE helper function #13449
Update is_fse_active to utilize FSE helper function #13449
Conversation
This is much more concise and also centralizes logic around this check into the same function which makes things much easier to reason about
This is an automated check which relies on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works well in my tests. 👍
The Gutenberg plugin is also required to be installed for full site editing flows to work properly :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @noahtallen this tests well for me, and the site response now also matches in /me/sites vs /sites/site with D32626-code applied.
* Changelog: initial set of changes for 7.8 * Changelog: add #13310 * Changelog: add #13103 * Changelog: add #13426 * Changelog: add #13389 * Changelog: add #13449 * Changelog: add #13461 * Changelog: add #13460 * Changelog: add #13441 * Changelog: add #13454 * Changelog: add #13457 * Changelog: add #13425 * Changelog: add #13473 * Changelog: add #13355 * Changelog: add #13451 * Changelog: add #13358 * Changelog: add #13464 * Changelog: add #13416 * Changelog: add #13494 * Changelog: add #13465 * Changelog: add #13424 * Changelog: add #13432 * Changelog: add #13471 * Changelog: add 7.7.2 entry * Changelog: add #13446 * Add more testing elements
* Changelog: initial set of changes for 7.8 * Changelog: add #13310 * Changelog: add #13103 * Changelog: add #13426 * Changelog: add #13389 * Changelog: add #13449 * Changelog: add #13461 * Changelog: add #13460 * Changelog: add #13441 * Changelog: add #13454 * Changelog: add #13457 * Changelog: add #13425 * Changelog: add #13473 * Changelog: add #13355 * Changelog: add #13451 * Changelog: add #13358 * Changelog: add #13464 * Changelog: add #13416 * Changelog: add #13494 * Changelog: add #13465 * Changelog: add #13424 * Changelog: add #13432 * Changelog: add #13471 * Changelog: add 7.7.2 entry * Changelog: add #13446 * Add more testing elements
This past week, we added a helper function to FSE which tells us when FSE is active on a site (which has now been deployed). I'm currently updating our API work to use this function, as it centralizes most of the logic needed! (Including all of the previous checks in this function.) Now we'll be able to update anything necessary without having to modify a bunch of API endpoints all the time. (yay!)
This is a bit of a followup to #13392. Testing instructions are practically the same as in that PR since behavior should be identical.
Changes proposed in this Pull Request:
\A8C\FSE\is_full_site_editing_active();
to replace logic inis_fse_active
endpoint.Testing instructions:
https://jurassic.ninja/create/?branch=update/use-fse-active-helper-function-in-plugin
. (also connect it to jetpack so you can see it in Calypso)is_fse_active
is false without the plugin installed. We're using the endpoint/sites/abc.jurassic.ninja
is_fse_active
is still falsehttps://wordpress.com/themes/abc.jurassic.ninja
), activate the "Maywood" themeis_fse_active
should be true.add_filter( 'a8c_disable_full_site_editing', '__return_true' );
is_fse_active
should be false.