Tiled gallery: remove Photon module dependency

[simison]

Make Tiled gallery block available without Photon module being active.

Requiring users to turn on "image optimizations" is confusing and arbitrary, and we don't depend on that technically either.

If there's an agency/partner that wants to hide the block, they shouldn't need to disable photon for doing that and there's a separate mechanism in Jetpack for hiding specific blocks.

It's not great to turn on Photon module for the whole page load either (that's what current tiled gallery does). All the other images on the page should be un-affected by Tiled gallery's dependency on Photon servers.

Resolves #13470

Similar question for Markdown block: #13473

Changes proposed in this Pull Request:

• Remove Photon class & module check in block registration

Is this a new feature or does it add/remove features to an existing part of Jetpack?

Changing

Testing instructions:

• Have a Jetpack site (e.g. via https://jurassic.ninja/)
• Confirm that Tiled gallery block is available in block editor only when Photon module is active. You can activate/disable it via "Performance -> Speed up image load times" toggle in Jetpack settings:
• In this branch (Test e.g. via https://jurassic.ninja/create?jetpack-beta&branch=update/tiled-gallery-photon-dep&wp-debug-log)

Proposed changelog entry for your changes:

• Tiled gallery block is now available in block picker even if "image accelerator" feature is disabled.

[jetpackbot]

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: October 1, 2019.
Scheduled code freeze: September 24, 2019

Generated by 🚫 dangerJS against c551d9f

[matticbot]

Caution: This PR has changes that must be merged to WordPress.com
Hello simison! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D32831-code before merging this PR. Thank you!

[mmtr]

LGTM 👍

[jeherve]

See my comment in #13473. I guess the same applies here as well :)

[simison]

See my comment in #13473. I guess the same applies here as well :)

Replied at #13473 (comment)

[jeherve]

Works for me. Should we update the block description to mention that it relies on our CDN? This would avoid confusion, and folks wouldn't have to contact support when they disable the Image CDN but keep seeing it being used in their galleries (this was a common issue back when tiled galleries were available as a single module).

[simison]

Good idea! So you're suggesting to update both block description and docs?

…

On Thu, 19 Sep 2019, 10:39 Jeremy Herve, ***@***.***> wrote: Works for me. Should we update the block description to mention that it relies on our CDN? This would avoid confusion, and folks wouldn't have to contact support when they disable the Image CDN but keep seeing it being used in their galleries (this was a common issue back when tiled galleries were available as a single module). — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#13471?email_source=notifications&email_token=AAAVJAFYO4UTWBZBGTHOV7DQKMUDHA5CNFSM4IW2Z25KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7CQ7TA#issuecomment-533008332>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAVJACUVLDA243R47MOYVLQKMUDHANCNFSM4IW2Z25A> .

[jeherve]

Yeah, I think it would make sense.

[simison]

Filed another PR for description to not let this being blocked, pending copy review; #13502

Also rebased this.