Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all files that were deprecated in 7.5 #13389

Merged
merged 2 commits into from
Sep 5, 2019

Conversation

dereksmart
Copy link
Member

This will remove all files that were deprecated in the 7.5 release

Changes proposed in this Pull Request:

above

Is this a new feature or does it add/remove features to an existing part of Jetpack?

no

Testing instructions:

Ensure that there are no other references to these files elsewhere in Jetpack.

Proposed changelog entry for your changes:

N/A

@dereksmart dereksmart added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Janitorial labels Sep 2, 2019
@dereksmart dereksmart requested a review from a team September 2, 2019 15:19
@dereksmart dereksmart requested a review from a team as a code owner September 2, 2019 15:19
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello dereksmart! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D32343-code before merging this PR. Thank you!

@jetpackbot
Copy link

jetpackbot commented Sep 2, 2019

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: September 3, 2019.
Scheduled code freeze: August 27, 2019

Generated by 🚫 dangerJS against 7d7b0e9

@@ -151,222 +151,12 @@ function provider_deprecated_file_paths() {
return array(

array(
'class.jetpack-options.php',
'class.jetpack-ixr-client.php',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of files that are newly deprecated in 7.7

@jeherve jeherve added this to the 7.8 milestone Sep 2, 2019
Copy link
Member

@zinigor zinigor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this sooner rather than later so we can test it while developing 7.8.

@zinigor zinigor added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Sep 5, 2019
@jeherve jeherve merged commit 18ce9d0 into master Sep 5, 2019
@jeherve jeherve deleted the remove/deprecated-files-7.5 branch September 5, 2019 14:31
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Sep 5, 2019
jeherve added a commit that referenced this pull request Sep 20, 2019
jeherve added a commit that referenced this pull request Sep 24, 2019
jeherve added a commit that referenced this pull request Sep 24, 2019
* Changelog: initial set of changes for 7.8

* Changelog: add #13310

* Changelog: add #13103

* Changelog: add #13426

* Changelog: add #13389

* Changelog: add #13449

* Changelog: add #13461

* Changelog: add #13460

* Changelog: add #13441

* Changelog: add #13454

* Changelog: add #13457

* Changelog: add #13425

* Changelog: add #13473

* Changelog: add #13355

* Changelog: add #13451

* Changelog: add #13358

* Changelog: add #13464

* Changelog: add #13416

* Changelog: add #13494

* Changelog: add #13465

* Changelog: add #13424

* Changelog: add #13432

* Changelog: add #13471

* Changelog: add 7.7.2 entry

* Changelog: add #13446

* Add more testing elements
jeherve added a commit that referenced this pull request Sep 24, 2019
* Changelog: initial set of changes for 7.8

* Changelog: add #13310

* Changelog: add #13103

* Changelog: add #13426

* Changelog: add #13389

* Changelog: add #13449

* Changelog: add #13461

* Changelog: add #13460

* Changelog: add #13441

* Changelog: add #13454

* Changelog: add #13457

* Changelog: add #13425

* Changelog: add #13473

* Changelog: add #13355

* Changelog: add #13451

* Changelog: add #13358

* Changelog: add #13464

* Changelog: add #13416

* Changelog: add #13494

* Changelog: add #13465

* Changelog: add #13424

* Changelog: add #13432

* Changelog: add #13471

* Changelog: add 7.7.2 entry

* Changelog: add #13446

* Add more testing elements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants