Sync with master repo #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…24408) Co-authored-by: Riad Benguella <benguella@gmail.com>
Adds a new inner block called Post Comment Author. It can be inserted into the Post Comment block.
* Fix invalid HTML structure on the widgets screen * Hide the save button on widget blocks * Add inline CSS to both widgets.php AND the customizer * Only hide the save button on widgets.php * Use a named function instead of anonymous one * Lint
…ts (#24523) * Button Block: Use relative instead of absolute units * Use relative units for calendar paddings * Paragraph block: Use relative instead of absolute units * Text Columns: Prefer relative units * Quote block: Prefer relative units * Pullquote block: Prefer relative units * also apply changes to native * Latest Comments Block: Prefer relative units * Use relative units for social-icons block * Don't use $grid-unit-* vars for front-facing styles * Avoid using $default-block-margin for front-facing styles * Convert all remaining pixel values to rem * Use em instead of rem * Use the vars * restore original code block padding * Update packages/block-library/src/button/style.scss Co-authored-by: Zebulan Stanphill <zebulanstanphill@protonmail.com> * Update packages/block-library/src/latest-comments/style.scss Co-authored-by: Zebulan Stanphill <zebulanstanphill@protonmail.com> * Move vars to separate "group" and fix comments capitalization * this value is closer to the legacy one * no reason for the padding to change here since it was already using em * Update packages/base-styles/_variables.scss Co-authored-by: Zebulan Stanphill <zebulanstanphill@protonmail.com> * Value needs to change since it's now relative to the font-size * Fix calculations for relative units in the gallery block * Fix social links editor styles * Revert social-icons style mods Co-authored-by: Zebulan Stanphill <zebulanstanphill@protonmail.com>
…23841) * Added a min lenght of 3, since request under 3 char are triggering more search for nothing. And minLenght 3 was the classic editor base lenght search before. Limited searc hto 20 per_page. The old -1 was triggering many XHR request on a simple search, for nothing since we have a MAX_TERMS_SUGGESTIONS of 20. * Using defined constant now * Fix linting error Co-authored-by: Nik Tsekouras <ntsekouras@outlook.com>
* Add block inspector component readme * Update block inspector component readme
…4835) Co-authored-by: Riad Benguella <benguella@gmail.com>
* Enhancement: Disable tools while code editor mode is enable * Fix: Disable Tools dropdown button while code editor is open * Fix: Disable Tools dropdown button while code editor is open * Inverted condition to disable tools dropdown in code editor mode
…block_type->supports instances (#24411)
* Refactor AnglePickerControl styles * Update SelectControl. Integrate new SelectControl with AnglePickerControl in GradientPicker * Improve Gradient Select and radio control UI * Update snapshots * Update snapshot * Update snapshot * Add label for gradient picker type * Fixed sizing. * Improve focus. * Harmonize spacing. * Fix so swatches align with the gradient control below. Co-authored-by: jasmussen <joen@automattic.com>
* Take editor features data from blocks as well * Make linter happy
* Don't send empty paragraph tags to view on Android * lint fixes * Limit getHtmlForRecordCreation calls to Android * Removed unnecessary out of bounds check * Try setting quote tagName to p instead of removing empty paragraph tags in getHTMLToRender * Revert setting tagName to p * Re-add multiline tag when no longer empty on edit * Only re-add p tag from onTextUpdate * Distinguish props.onChange from onChangeFromAztec * Updated constant to more precise name
* add tags support in Query block * refactor + tests for getTermsInfo * fetch more terms to show * add typedefs and jsdoc at getTermsInfo * fix add multiple terms * set $query properly
* Add @types/react and @types/react-dom dependency to element Fixes #23130 * Upgrade the type packages * Add changelog
…25062) * Set up advanced attributes on nav screen. * Add new attribs to tests.
Import statement is referencing the wrong package name.
Fix bad english
* fix issue 24539, show external icon on help button * add visually hidden text for external link item * unite duplicate import Co-authored-by: Leutrim Husaj <leutrim.husaj@cm4all.com>
…alse (#25140) The Facebook oEmbed provider returns `html: false` when the URL is not previewable, e.g., when it points to a Facebook page rather than a post or video. The `isFromWordPress` helper used to use Lodash `includes( html, x)` which handles falsy values gracefully. After refactored to `html.includes( x )`, non-string values started to trigger a `TypeError`.
* add filter by author support in Query block * provide useSelect dependencies Co-authored-by: Miguel Fonseca <miguelcsf@gmail.com> * Update packages/block-library/src/query/edit/query-inspector-controls.js change description Co-authored-by: Miguel Fonseca <miguelcsf@gmail.com> Co-authored-by: Miguel Fonseca <miguelcsf@gmail.com>
* Fix link, move ubuntu docker document to devenv * Fix Ubuntu 20.04.1 instructions, fix export var * Apply suggestions from code review Co-authored-by: Albert Juhé Lluveras <contact@albertjuhe.com> * Remove docker-compose instructions Docker-compose is not needed for most now that Ubuntu binaries are updated. Just include link to Docker docs which does a better job of documenting installation. Co-authored-by: Albert Juhé Lluveras <contact@albertjuhe.com>
* Add quick start, expand on wp-env usage as tool * Add Troubleshooting and Uninstall instructions * Update install, add screenshot * Add clarification around file creation * Add clarification around .wp-env.json * Fix typo in uninstall node * Updates based on review * Update with new wp-env changes, remove need for .wp-env.json * Update uninstall section per review * Add clarifiation around WP dashboard * Add confirmation step for uninstall * Reword to try to run * Reword to try to run * Tweak uninstall verbage * Apply suggestions from code review :+1: Co-authored-by: Noah Allen <noahtallen@gmail.com> * Add clean WP db, clarify start - per review * Add link to Docker Ubuntu notes * Add quit and restart to uninstall Co-authored-by: Noah Allen <noahtallen@gmail.com>
* Bump storybook major version Fixes some breakage related to dependency imports. * Increase buffer size on check licenses script The size of the output for `npm ls --json --long --prod` has grown to around 110MB. For this reason, the output was being truncated at the previous maximum buffer size, which was set at around ~104MB.
* refactor reusable selection component * update class names * another classname * use an icon * add onClose * search form needs value... * updated styles to support dropdown from name panel * missing newline, lol * disable button when open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How has this been tested?
Screenshots
Types of changes
Checklist: