Merge from master #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lly (#19417) #### Why I did it src/sonic-swss ``` * b02181ae - (HEAD -> master, origin/master, origin/HEAD) Use shared egress ACL table for PFCWD in BRCM DNX platform (#3136) (9 hours ago) [Song Yuan] * 21378131 - [dash] align dash inbound route actions with the latest SAI headers (#3206) (30 hours ago) [Yakiv Huryk] ``` #### How I did it #### How to verify it #### Description for the changelog
Why I did it Bug Fix: RFS is still loading from cache user@build-server:/sonic-buildimage$ cat target/sonic-mellanox.bin__mellanox__rfs.squashfs.log Build start time: Tue Jun 25 20:13:00 UTC 2024 [ FLAGS FILE ] : [mellanox amd64 bookworm] [ FLAGS DEPENDS ] : [mellanox amd64 bookworm] [ FLAGS DIFF ] : [] target/sonic-mellanox.bin__mellanox__rfs.squashfs target/sonic-mellanox.bin__mellanox__rfs.squashfs.cached.log File /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz is loaded from cache into /sonic [ CACHE::LOADED ] /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz File /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz is not present in cache or cache mode set as cache ! [ CACHE::SKIPPED ] /dpkg_cache/sonic-mellanox.bin__mellanox__rfs.squashfs-adc83b19e793491b1c6ea0f-3bc3261c3a235b9c15daac9.tgz [ CACHE::SKIPPED ] DEP_FILES - Modified Files: [] [ CACHE::SKIPPED ] DEPENDS - Modified Files: [.platform build_debian.sh target/debs/bookworm/initramfs-tools_0.142_all.deb target/debs/bookworm/linux-image-6.1.0-11-2-amd64-unsigned_6.1.38-4_amd64.deb target/sonic-mellanox.bin__mellanox__rfs.squashfs.dep] Build end time: Tue Jun 25 20:13:04 UTC 2024 Elapsed time: 0h 0m 4s - How I did it Replace the tab before the comment so that Make subsystem doesn't run the LOAD_CACHE - How to verify it Re-trigger the RFS and see it being built and not getting loaded from cache Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
- Why I did it Removed 8x mode from SN5400 and simx platforms as current DPB infrastructure doesn't support 8x mode with the subsequent port need to be disabled - How I did it Updated platform.json of both devices. - How to verify it Running show interfaces breakout command and verifying this mode doesn't exist.
- Why I did it Remove lm-sensors dependency on hw-mgmt. lm-sensors installs a oneshot lm-sensors.service which starts early in the boot and can sometime gets stuck in activating state blocking hostcfgd to progress further
- Why I did it For setting the rts and cts configuration for the minicom package to the switch image, The file is copied to minicom configuration location in the switch image This is a machine generated file in minicom , so the configuration can be present in the switch image upon installation
- Why I did it For setting the rts and cts configuration for the minicom package to the switch image, The file is copied to minicom configuration location in the switch image This is a machine generated file in minicom , so the configuration can be present in the switch image upon installation
…19413) What I did:- Populate bgp_asn in DEVICE_METADATA only if is present/valid. Why I did: Without this it causes Yang Validation failure for Systems that are Pure L2/Chassis Supervisor (no BGP) as Yang expects bgp_asn as valid as_number --------- Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Why I did it Upgrade the xgs SAI version to 10.1.21.0 to include the following changes: 10.1.8.0: Support _brcm_sai_port_unlos_set when external port_phy_addr is 0xff 10.1.9.0: [CS00012330893]With PFC test, egress drop observed for lossless queues 10.1.11.0: Include the bcmsim in the odp package 10.1.13.0: handle bind of egress and ingress groups to same lag 10.1.14.0: Backport SDK-381920 to rel_ocp_sai_10_1 High CPU due to SDK calling soc_dnxc_port_resource_get 10.1.16.0: [CSP CS00012336644] callback called twice with same event type 10.1.17.0: [CSP 00012320736][SAI_BRANCH rel_ocp_sai_10_1]Back port MMU related Fixes to 10.1 specific to LTSW/TH4 devices-HSDK 10.1.18.0: [CSP CS00012351984] Backport SONIC-81526 to 10.1 Fixes for rate class bound setting and UCQ stats 10.1.19.0: Reset EGR_L3_NEXT_HOP_2 for TH3 10.1.20.0: Sonic crash due to unsupported return from SAI_SWITCH_ATTR_ECMP_DEFAULT_HASH_OFFSET Work item tracking Microsoft ADO (number only): 28356083 How I did it Upgrade the SAI version in the sai.mk file. How to verify it Run the SONiC basic test: https://elastictest.org/scheduler/testplan/66742d7ef6db3102cef61056
- Why I did it Add the force flag to the reboot, which is needed now that we no longer use power cycle due to # 18325 - How I did it Update the onie fw update script to use efibootmgr for the supported devices, and on the reboot command, call the reboot script with the f flag. - How to verify it Run ONIE upgrade using fwutil
Why I did it Update sonic-platform submodule for Nokia-7250IXRE Platform. How I did it Update submodule sonic-platform for Nokia-7250IXRE platform. This contains fix for changing log level so mgmt test cases will not fail because of error log.
Why I did it Currently yang pattern is restricting interfaces to those that start with Ethernet however interfaces that discard can start with "eth", "Vlan", "PortChannel", and others as well. How I did it Update YANG file and UT How to verify it sonic-mgmt test and UT
How I did it Modify regex for rsyslog_plugin to detect watchdog-timeout How to verify it Manual test/Pipeline test once sonic-mgmt test case is merged
Signed-off-by: anamehra anamehra@cisco.com Cisco platform 202405.0.2 release
…D automatically (#19498) #### Why I did it src/sonic-platform-daemons ``` * 74881e1 - (HEAD -> master, origin/master, origin/HEAD) [xcvrd] Modify to support regular expression when parsing the key in media_settings.json (#471) (10 hours ago) [DennisChiuEC] ``` #### How I did it #### How to verify it #### Description for the changelog
…lly (#19461) #### Why I did it src/sonic-swss ``` * 43ac585c - (HEAD -> master, origin/master, origin/HEAD) Revamp module build script to make it work for 5.15 on Ubuntu 20.04 (#3212) (3 days ago) [Saikrishna Arcot] * c9c78dc4 - Fix in switchorch: unsupported attribute causes skipping of processing the rest of configurations (#3209) (3 days ago) [Amir] * 0158d27d - [Chassis][voq] do not synchronize the system interface state if there is no rif assciated with the port (#3207) (3 days ago) [Arvindsrinivasan Lakshmi Narasimhan] * fdd5bdc9 - [vxlanmgr]: Add disabling of fdb learning for linux vxlan interfaces (#3205) (3 days ago) [yfedoriachenko] ``` #### How I did it #### How to verify it #### Description for the changelog
…lly (#19460) #### Why I did it src/sonic-gnmi ``` * 7801415 - (HEAD -> master, origin/master, origin/HEAD) Use server GracefulStop instead of force stop (#219) (3 days ago) [Zain Budhwani] * 7631184 - make save on set only when err is nil (#242) (3 days ago) [Ryan Lucus] ``` #### How I did it #### How to verify it #### Description for the changelog
…atically (#19419) #### Why I did it src/sonic-utilities ``` * fb2e5cda - (HEAD -> master, origin/master, origin/HEAD) Remove secret from golden_config_db.json and old_config files (#3390) (2 days ago) [Hua Liu] * 414cf3bb - [DPB]Fix return code in case of failure (#3389) (4 days ago) [Sudharsan Dhamal Gopalarathnam] * 06965df2 - Remove suppress-fib-pending CLI and make route_check.py check suppress-fib in BGP configuration (#3331) (5 days ago) [Stepan Blyshchak] * 3a8f0be0 - [Mellanox] Add support for ACS-4280 (#3368) (8 days ago) [Vivek] * 667a1509 - [pbh]: Fix show PBH counters when cache is partial (#3356) (8 days ago) [Nazarii Hnydyn] ``` #### How I did it #### How to verify it #### Description for the changelog
…19473) - Why I did it When module host management is enabled, all modules are managed by the same state machine which initializes all modules/ports. However, on 5600 and 5400, there is a type of port which we called "service port". Those ports are always under firmware control. In that case, those ports should be managed by a different state machine. This PR is to implement the state machine for always firmware control ports. - How I did it Implement a state machine for always firmware control ports. - How to verify it Manual test unit test
- Why I did it Update SDK/FW to 4.6.4072/2012.4072 Now, CMIS host mgmt feature is enabled to work on every SN4700 PSID Work item tracking - How I did it Update Makefiles - How to verify it Run tests
…19456) - Why I did it To include the latest fixes and new functionality - How I did it SDK_VERSION 24.7-RC2 -> 24.7-RC4 SAI_VERSION SAIBuild0.0.31.0 -> SAIBuild0.0.32.0 - How to verify it Build an image and run tests from "sonic-mgmt".
### Why I did it
The load_mgmt_config generated lo_v6 is missing standalone entry which fail YANG validation
##### Work item tracking
- Microsoft ADO **(number only)**:28665800
#### How I did it
Add the standalone entry
#### How to verify it
Manual test in DUT
Before change:
```
admin@str-msn2700a1-03:~$ sonic-cfggen -M /etc/sonic/device_desc.xml --print-data
{
"DEVICE_METADATA": {
"localhost": {
"hostname": "CPQ21-0101-0509-04T0",
"hwsku": "Arista-7260CX3-D108C8"
}
},
"LOOPBACK_INTERFACE": {
"lo_v6|2603:10d0:e:5eb::/128": {} <==== missing standalone entry which fail YANG
},
"MGMT_INTERFACE": {
"eth0|100.84.101.139/26": {
"gwaddr": "100.84.101.129"
},
"eth0|2603:10e2:f0:7478::b/64": {
"gwaddr": "2603:10e2:f0:7478::1"
}
}
}
```
After change:
```
admin@str-msn2700a1-03:~$ sonic-cfggen -M /etc/sonic/device_desc.xml --print-data
{
"DEVICE_METADATA": {
"localhost": {
"hostname": "CPQ21-0101-0509-04T0",
"hwsku": "Arista-7260CX3-D108C8"
}
},
"LOOPBACK_INTERFACE": {
"lo_v6": {}, <=== added standalone entry
"lo_v6|2603:10d0:e:5eb::/128": {}
},
"MGMT_INTERFACE": {
"eth0|100.84.101.139/26": {
"gwaddr": "100.84.101.129"
},
"eth0|2603:10e2:f0:7478::b/64": {
"gwaddr": "2603:10e2:f0:7478::1"
}
}
}
```
- Why I did it Added a script for CMIS Host Management enabling and disabling on a running switch. This intend to prevent issues caused by wrong configuration of the feature. The idea is to provide a more convenient way for users to configure the feature. - How I did it Add the script to /usr/bin/ that supports two options: --enable - receives paths to config files for Port SI parameters and Module SI parameters: media_settings.json, optics_si_settings.json, and enables the feature --disable - disables the feature
- Why I did it Add the possibility to compile BFB (BlueField boot stream) image for the nvidia-bluefield platform. The BFB image fully overwrites the DPU's SSD and can be used for DPU recovery. - How I did it Add new bfb image type to build_image.sh script. Add scripts under the "nvidia-bluefield" platform to create the binary file. - How to verify it Configure nvidia-bluefield platform. Run make target/sonic-nvidia-bluefield.bfb command to compile the image.
- Why I did it To add support for the arm64-nvda_bf-bf3comdpu platform - How I did it Added arm64-nvda_bf-bf3comdpu directory to the devices Signed-off-by: Yakiv Huryk <yhuryk@nvidia.com>
Why I did it In #15058, the NTP server configuration was modified to add additional options, such as conditionally enabling iburst, specifying the association type, and specifying the NTP version. One side effect of this was that the iburst option which was previously always enabled now requires it to be explicitly enabled in the config_db. Fixes #19425. How I did it To restore the old behavior, when loading from minigraph, add "iburst": "true" for each NTP server loaded from minigraph. How to verify it Tested on a KVM setup, verified that the generated ntp.conf file had the iburst option. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
… instead of 'voq' and fix few echo msgs. (#19527) use 'SpineRouter' in checks instead of 'voq' and fix few echo msgs. Signed-off-by: fountzou <ioannis.fountzoulas@nokia.com>
…utomatically (#19415) #### Why I did it src/sonic-host-services ``` * 02d9b55 - (HEAD -> master, origin/master, origin/HEAD) Added support to render template format of `delayed` flag on Feature Table. (#135) (28 hours ago) [abdosi] * 60fdfea - Fixed determine/process reboot-cause service dependency (#17406) (#132) (13 days ago) [anamehra] ``` #### How I did it #### How to verify it #### Description for the changelog
In this PR, we add a new PR checker called onboarding dualtor. This new PR checker is for onboarding dualtor speific test scripts.
sonic-net/SONiC#1367 Why I did it Give ability to: 1. configure limit for active login sessions. 2. configure ssh-server / serial console autologout timeout 3. configure sysrq-capabilities (enable / disable) Work item tracking Microsoft ADO (number only): How I did it Add new service that responsible for serial configuration; Update existing flows for extended ssh-server configurations in hostcfgd; Add YANG model to support new configuration. How to verify it Which release branch to backport (provide reason below if selected) Tested branch (Please provide the tested image version) Description for the changelog Link to config_db schema for YANG module changes [ssh_server](https://github.com/sonic-net/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md#ssh_server) [serial_console](https://github.com/sonic-net/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md#serial_console)
…atically (#20268) #### Why I did it src/sonic-utilities ``` * ed624895 - (HEAD -> master, origin/master, origin/HEAD) SONIC CLI for CLI-Sessions feature (#3175) (2 hours ago) [i-davydenko] * c6637553 - Move from bootctl to mokutil when checking for Secure Boot status (#3486) (3 hours ago) [DavidZagury] * 5fc0ee6c - [spm]: Clean up timers auto generation logic. (#3523) (3 hours ago) [Nazarii Hnydyn] ``` #### How I did it #### How to verify it #### Description for the changelog
Upgrade credo sai package to the latest v0.9.9 to deliver a key fix from Credo to the community or the blackhawk phys used on Arista platform 7060dx5_64s. ADO: 29387310
Why I did it Update default WRED profile values. Work item tracking Microsoft ADO (number only): 29444846 How I did it Update Mellanox qos j2 file to generate WRED profile values. How to verify it Redeploy minigraph with the new image and verify the latest WRED profile values.
Update swss and sairedis submodules (#20213) Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
…lly (#20159) #### Why I did it src/sonic-swss ``` * 20e8b362 - (HEAD -> master, origin/master, origin/HEAD) [dash] Set CA to PA underlay DIP for static encap (#3286) (5 days ago) [Lawrence Lee] * 60f9dde5 - Add pass pl_sip_encoding to SAI (#3285) (5 days ago) [Lawrence Lee] * 3943093d - [Mellanox] Update headroom calculation algorithm (#3235) (6 days ago) [Stephen Sun] ``` #### How I did it #### How to verify it #### Description for the changelog
[fpmsyncd] Fpmsyncd Next Hop Table Enhancement (#16762) Signed-off-by: nakano.kanji <kanji.nakano@ntt.com>
[DASH] Add support for ENI counters Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
Why I did it This module is required in the pmon container for Storage Monitoring Daemon (stormond) to instantiate objects of type (UsbUtil)[sonic-net/sonic-platform-common#493]. Work item tracking Microsoft ADO (number only): 29203991 How I did it Added config to pmon Dockerfile.j2 to install blkinfo How to verify it On an image containing this change, verify following output: root@str2-7050qx-32s-acs-03:/# pip3 list | grep -i blkinfo blkinfo 0.2.0
Why I did it Dhcp implementation included inefficient code How I did it Using redis.keys with pattern instead of looping over all keys. How to verify it Run unit tests.
Why I did it Support Mellanox-SN5600-C256A1 How I did it Add relevant files to support the new SKU How to verify it Regression test
[Smartswitch] support for container checker and frr
#### Why I did it sonic-net/SONiC#1621, need dedicated daemon to monitor config_db and manage openbmpd state. #### How I did it Use swss-common lib to monitor config_db change.
…atically (#20290) #### Why I did it src/sonic-utilities ``` * 867fc540 - (HEAD -> master, origin/master, origin/HEAD) [DASH] Add support for ENI counters (#3496) (28 hours ago) [Vivek] * b4d27c4b - Fix multi-asic behaviour for watermarkstat (#3060) (2 days ago) [bktsim] ``` #### How I did it #### How to verify it #### Description for the changelog
- Why I did it The yang model for bridge-midplane is not aligned with the actual implementation present in #18178, This PR is to align the yang model to change bridge_midplane to bridge-midplane since this is the value used in the systemd-networkd in CONFIG_DB so that the yang validation does not fail - How I did it - How to verify it Enhance unit test
A new SKU for `MSN4600C` platform: `Mellanox-SN4600C-D24C52` Requirements for `Mellanox-SN4600C-D24C52`: * 8 x 100Gbps uplink to T2 switch (C25, C26, C29-C30, C33-C34, C37-C38) * 12 x 100Gbps downlinks to T0 switch (C1-C2, C3-C4, C7-C8, C53-C54, C57-C58, C63-C64) * 1 x 50Gbps downlinks to T0 switch (D62) * Type of transceiver: "100Gb AOC between T0-T1, 100G DAC between T0-Server" * Cable length: “T0-T1 40m default, 300m max; T0-Server 2m” * Breakout mode: "per port layout" * FEC mode: "none" * VxLAN source port: "no" * Static Policy Based Hashing: "no" * Traditional buffer model: "yes" * Shared headroom: “yes” * Over-subscription ratio: “2” * Warm boot: “yes” Additional details: * `Mellanox-SN4600C-D24C52` is a replacement for [Mellanox-SN3800-D24C52](https://github.com/sonic-net/sonic-buildimage/tree/master/device/mellanox/x86_64-mlnx_msn3800-r0/Mellanox-SN3800-D24C52) #### Why I did it * Added `Mellanox-SN4600C-D24C52` to replace `Mellanox-SN3800-D24C52` ### How I did it * Added relevant configuration files #### How to verify it 1. Generate port configuration: ```bash sonic-cfggen -H -k Mellanox-SN4600C-D24C52 --preset t1 > /etc/sonic/config_db.json ``` 2. Generate QoS configuration: ```bash config qos clear config qos reload --no-dynamic-buffer config save -y ```
### Why I did it ### How I did it We try to use Linux kernel drivers to replace our drivers, except for some drivers that we have implemented ourselves. For this purpose, we have submitted the following PR to the sonic-linux-kernel repository: sonic-net/sonic-linux-kernel#411 sonic-net/sonic-linux-kernel#413 sonic-net/sonic-linux-kernel#417
…lly (#20310) #### Why I did it src/sonic-swss ``` * 9a6a86fe - (HEAD -> master, origin/master, origin/HEAD) Add FEC correctable bit error count to ports_stat_ids (#3291) (28 hours ago) [Prince George] * 5126f88b - Fix the SAI status check for unsupported API on SAI_SWITCH_ATTR_SUPPO… (#3282) (32 hours ago) [DavidZagury] ``` #### How I did it #### How to verify it #### Description for the changelog
## How I did it Remove eventd enabled/slim image check from Dockerfile (build time). As part of Dockerfile expose eventd_enabled and slim image flags to ENV which will be used docker_init/start.sh to check if rsyslog plugin should be moved to rsyslog.d #### How to verify it Manual test/pipeline
### Why I did it #19179 removed call to publish_events when memory usage container exceeds threshold, causing test_events to fail. ### How I did it Add back call to publish_events #### How to verify it Manual test
- Why I did it Booting master/202405 images on SN5400 and SN5600 platforms is resulting the log 2024-07-23T21:01:07.972045+00:00 sonic kernel: [ 0.110657] x86/cpu: SGX disabled by BIOS. 2024-07-23T21:01:07.972045+00:00 sonic kernel: [ 0.110657] x86/cpu: SGX disabled by BIOS. Processor on these systems supports the SGX but the BIOS does not. SGX feature is also not important and thus disable using the nosgx kernel boot parameter - How I did it - How to verify it Added the parameter, reboot and check for log
…ion (#20085) [Mellanox] Update asic table template for shared headroom pool relevant information Signed-off-by: Stephen Sun <stephens@nvidia.com>
…restarts (#20291) Why I did it When swss is restarted, let's cleanup the state db tunnel and decap term entries. Signed-off-by: Longxiang Lyu lolv@microsoft.com Work item tracking Microsoft ADO (number only): 29507113 How I did it flush the state db tunnel and decap term entries. Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
- Why I did it Introduce new Mellanox SIMX platform SN5640. Number of up/down links - 256/256. Default cable length for t0 - 40m. Default cable length for t1 - 300m. Default speed - 100G. - How I did it Added all relevant files of new SKU used for ASIC simulation - How to verify it Check that the SKU is up and running on simulation environment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)