forked from DataDog/terraform-provider-datadog
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge upstream #3
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the timezone parameter Adds descriptions to parameters Adds validation to monitor_tags Ensures that the updated downtime id is correctly handled for future immutable downtimes
… supported on lists or sets"
…og/issues/182 as monitor tags order has no meaning and are not guaranteed to be in the same order
Add link to documentation about monitor types
Fixes #182 - Monitor Tags are not sorted
Add default of 10m for monitor no data timeframe
Allow adding metadata aliases for widgets in screenboards and timeboards
Downtime improvements
Add examples section to docs
Upgrade terraform to 0.12.
Revert "#148 Fix log monitor UI issue: generate queryConfig.queryStri…
Suppress diff on default precision
Update to go-datadog-api v2.21.0, run "go mod tidy"
Timeboard extra_col fix
* Set datadog_downtime.timezone attribute in resourceDatadogDowntimeRead, handle it in import test * Make datadog_downtime.tags a TypeSet to be able to properly ignore differences in ordering of its contents * Fix two regressions caused by calling resourceDatadogMonitorRead from resourceDatadogMonitorUpdate and resourceDatadogMonitorCreate: * Make sure that API sometimes changing "metric alert" to "query alert" continues to be ignored * Fix tests for threshold values to always expect floats
Fix several integration tests and related code
Mark datadog_monitor.type as ForceNew, since changing type is not actually possible
* Update and fix tests * Remove the extra log lines
* Update changelog * Address review * Fix links
* ignore changes in metric alert to query alert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.