Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0.x -> 3.x #16523

Closed
wants to merge 39 commits into from
Closed

3.0.x -> 3.x #16523

wants to merge 39 commits into from

Conversation

Mark-H
Copy link
Collaborator

@Mark-H Mark-H commented Feb 10, 2024

What does it do?

Describe the technical changes you made.

Why is it needed?

Describe the issue you are solving.

How to test

Describe how to test the changes you made.

Related issue(s)/PR(s)

Provide any issue that's addressed by this change in the format "Resolves #", and mention other issues/pull requests with relevant information.

opengeek and others added 30 commits January 19, 2023 10:17
When tab panels contain a mix of grid and non-grid tabs, changing between tabs would cause an error due to the attempt to run a grid method (changePage) on a tab not containing a grid.
* Update modPhpThumb.php

Fix PHP warning: "undefined array key ..."  HTTP_IF_MODIFIED_SINCE, sia and down

* Update modPhpThumb.php

1) Fix PHP warning: Undefined array key "HTTP_IF_MODIFIED_SINCE"  (line 305)
2) Fix PHP warning: "Undefined array key sia" and "Undefined array key down" (line 335)
Thanks for the suggestion @smg6511
* Remove PHP version specific fixes lower than the current minimum supported PHP version (7.2.5).

* Check for the correct current minimum supported PHP version (7.2.5)
* Add resource alias in template picker as needed

When friendly URLs are enabled, a resource can not be saved without an alias. The current picker form does not include the alias field.

* grunt build

---------

Co-authored-by: Jim Graham <info@sparkmediagroup.com>
Update uploadObjectsToContainer so the files array passed to the OnFileManagerUpload event includes an up-to-date version of $objects. So if a file name has been renamed, $objects passed to the OnFileManagerUpload also reflects these changes.
* Upgrade legacy modSessionHandler class references in settings

* Update related lexicons with FQCN
* New translations about.inc.php (Greek)

* New translations access.inc.php (Persian)

* New translations context.inc.php (Persian)

* New translations default.inc.php (Swedish)

* New translations formcustomization.inc.php (Russian)

* New translations manager_log.inc.php (Persian)

* New translations menu.inc.php (French)

* New translations menu.inc.php (Persian)

* New translations resource.inc.php (French)

* New translations default.inc.php (French)

* New translations default.inc.php (German)

* New translations default.inc.php (Hebrew)

* New translations setting.inc.php (Romanian)

* New translations setting.inc.php (French)

* New translations setting.inc.php (Spanish)

* New translations setting.inc.php (Arabic)

* New translations setting.inc.php (Belarusian)

* New translations setting.inc.php (Bulgarian)

* New translations setting.inc.php (Czech)

* New translations setting.inc.php (Danish)

* New translations setting.inc.php (German)

* New translations setting.inc.php (Greek)

* New translations setting.inc.php (Finnish)

* New translations setting.inc.php (Hebrew)

* New translations setting.inc.php (Hungarian)

* New translations setting.inc.php (Italian)

* New translations setting.inc.php (Japanese)

* New translations setting.inc.php (Dutch)

* New translations setting.inc.php (Polish)

* New translations setting.inc.php (Portuguese)

* New translations setting.inc.php (Russian)

* New translations setting.inc.php (Swedish)

* New translations setting.inc.php (Turkish)

* New translations setting.inc.php (Ukrainian)

* New translations setting.inc.php (Chinese Simplified)

* New translations setting.inc.php (Indonesian)

* New translations setting.inc.php (Persian)

* New translations setting.inc.php (Thai)

* New translations setting.inc.php (Estonian)

* New translations setting.inc.php (Hindi)

* New translations setting.inc.php (Yoruba)
* New translations setting.inc.php (French)

* New translations setting.inc.php (Czech)

* New translations setting.inc.php (Greek)

* New translations setting.inc.php (Swedish)

* New translations dashboard.inc.php (Belarusian)

* New translations dashboards.inc.php (Belarusian)

* New translations default.inc.php (Belarusian)

* New translations default.inc.php (Belarusian)

* New translations element.inc.php (Belarusian)

* New translations file.inc.php (Belarusian)

* New translations menu.inc.php (Belarusian)

* New translations plugin.inc.php (Belarusian)

* New translations resource.inc.php (Belarusian)

* New translations snippet.inc.php (Belarusian)

* New translations user.inc.php (Belarusian)

* New translations action.inc.php (Belarusian)

* New translations category.inc.php (Belarusian)

* New translations chunk.inc.php (Belarusian)

* New translations configcheck.inc.php (Belarusian)

* New translations content_type.inc.php (Belarusian)

* New translations context.inc.php (Belarusian)

* New translations lexicon.inc.php (Belarusian)

* New translations messages.inc.php (Belarusian)

* New translations setting.inc.php (German)

* New translations access.inc.php (Belarusian)

* New translations setting.inc.php (Ukrainian)
* New translations tv.inc.php (Belarusian)

* New translations about.inc.php (Slovenian)

* New translations access.inc.php (Slovenian)

* New translations action.inc.php (Slovenian)

* New translations category.inc.php (Slovenian)

* New translations chunk.inc.php (Slovenian)

* New translations configcheck.inc.php (Slovenian)

* New translations content_type.inc.php (Slovenian)

* New translations context.inc.php (Slovenian)

* New translations dashboard.inc.php (Slovenian)

* New translations dashboards.inc.php (Slovenian)

* New translations default.inc.php (Slovenian)

* New translations element.inc.php (Slovenian)

* New translations events.inc.php (Slovenian)

* New translations export.inc.php (Slovenian)

* New translations file.inc.php (Slovenian)

* New translations filters.inc.php (Slovenian)

* New translations formcustomization.inc.php (Slovenian)

* New translations languages.inc.php (Slovenian)

* New translations lexicon.inc.php (Slovenian)

* New translations login.inc.php (Slovenian)

* New translations mail.inc.php (Slovenian)

* New translations manager_log.inc.php (Slovenian)

* New translations menu.inc.php (Slovenian)

* New translations messages.inc.php (Slovenian)

* New translations namespace.inc.php (Slovenian)

* New translations package_builder.inc.php (Slovenian)

* New translations permissions.inc.php (Slovenian)

* New translations plugin.inc.php (Slovenian)

* New translations policy.inc.php (Slovenian)

* New translations propertyset.inc.php (Slovenian)

* New translations resource.inc.php (Slovenian)

* New translations rest.inc.php (Slovenian)

* New translations setting.inc.php (Slovenian)

* New translations snippet.inc.php (Slovenian)

* New translations source.inc.php (Slovenian)

* New translations system_events.inc.php (Slovenian)

* New translations system_info.inc.php (Slovenian)

* New translations template.inc.php (Slovenian)

* New translations topmenu.inc.php (Slovenian)

* New translations trash.inc.php (Slovenian)

* New translations tv.inc.php (Slovenian)

* New translations tv_input_types.inc.php (Slovenian)

* New translations tv_widget.inc.php (Slovenian)

* New translations user.inc.php (Slovenian)

* New translations welcome.inc.php (Slovenian)

* New translations workspace.inc.php (Slovenian)

* New translations en.inc.php (Slovenian)

* New translations default.inc.php (Slovenian)

* New translations drivers.inc.php (Slovenian)

* New translations languages.inc.php (Slovenian)

* New translations preload.inc.php (Slovenian)

* New translations test.inc.php (Slovenian)

* New translations upgrades.inc.php (Slovenian)
Update datetime.js

Fixes date parsing issue when time is hidden

Update resource create and update processors

Ensure date TV value is saved with a zero default time when TV's hideTime enabled
- Should not allow loading a user other than the current authenticated user
- Should not return sensitive fields
* New translations messages.inc.php (Turkish)

* New translations plugin.inc.php (Turkish)

* New translations setting.inc.php (Turkish)

* New translations default.inc.php (Belarusian)

* New translations chunk.inc.php (Ukrainian)

* New translations configcheck.inc.php (Ukrainian)

* New translations default.inc.php (Ukrainian)

* New translations file.inc.php (Ukrainian)

* New translations permissions.inc.php (Ukrainian)
Squashed commit of the following:

commit 9121214b1d1f1c093de9779fafb2004497a38a28
Author: Jason Coward <jason@opengeek.com>
Date:   Tue Aug 29 14:13:36 2023 -0600

    grunt build

commit 3a32455b58247735ab67adf362eeb2bebfbc8122
Author: Jim Graham <info@sparkmediagroup.com>
Date:   Tue Apr 4 16:25:45 2023 -0400

    Settings grid adjustments for Extras support
Co-authored-by: Jim Graham <info@sparkmediagroup.com>
Jako and others added 9 commits October 2, 2023 15:54
* Fix deprecation of dynamic properties

Define magic method __set and __get in the class to avoid the deprecation message. See: https://php.watch/versions/8.2/dynamic-properties-deprecated#__get-__set

* Fix 'Cannot assign by reference to overloaded object'

* Use AllowDynamicProperties attribute instead of __get()/__set()

---------

Co-authored-by: Jason Coward <jason@opengeek.com>
* remove functions that require PHP to interact with objects directly, in an effort to dramatically speed up S3 response times.

* fix PHPCS

* fix type conflict
…xt (#16410)

Prevent the fallback render method/class to be loaded twice.
* Update logs controller

Update permissions key to new 3.x mgr_log_view key

* Code formatting update
@Mark-H Mark-H requested a review from opengeek as a code owner February 10, 2024 13:39
@Mark-H
Copy link
Collaborator Author

Mark-H commented Feb 10, 2024

@opengeek Any objections to me doing a regular merge fixing the conflicts on this? Or would you prefer to handle this yourself?

@opengeek
Copy link
Member

I absolutely do NOT want to do merges like this. Most of those changes are already in there. If something specific was merged into 3.0.x and not put into 3.x, that needs to be dealt with individually. I handle this manually with cherry-picks when merging PRs targeting one or the other when the changes need to be in both.

@Mark-H
Copy link
Collaborator Author

Mark-H commented Feb 10, 2024

Alright. It's just confusing that the changelog doesn't list anything past 3.0.3, so I don't know how to make sure all fixes made it into 3.1. Unless all the 3.0.x changes need to be cherry picks from things merged into 3.x?

For what it's worth I've only done merges into 3.x today.

@opengeek
Copy link
Member

The changelog isn't updated at all. The commit log is what matters. Whatever you merged into 3.x which needs to go in 3.0.x, should be manually merged into 3.0.x. If you need me to handle this, I will, but I would prefer in the future that this get done for each PR as we go so that we are sure it applies and is tested against each branch individually.

@opengeek
Copy link
Member

It is critical that each merge is done to both branches. The commit log can then be used to generate the changelog entries at the end of the release cycle with no effort.

@Mark-H Mark-H closed this Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.