Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v22.9.0 proposal #54966

Merged
merged 162 commits into from
Sep 17, 2024
Merged

v22.9.0 proposal #54966

merged 162 commits into from
Sep 17, 2024

Commits on Sep 6, 2024

  1. src: create handle scope in FastInternalModuleStat

    It needs a handle scope for the context handle. Since the
    FastApiCallbackOptions struct doesn't have isolate on it
    in V8 12.4 on Node.js 22, use Isolate::TryGetCurrent() to
    get to the isolate needed for the handle scope creation and
    fallback to the slow callback if no isolate is entered.
    
    PR-URL: #54384
    Refs: #52797
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    joyeecheung authored and RafaelGSS committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    5c9599a View commit details
    Browse the repository at this point in the history
  2. Revert "v8: enable maglev on supported architectures"

    This reverts commit 1a5acd0.
    
    Reason to revert: we have seen several crashes/unexpected JS behaviors
    with maglev on v22 (which ships V8 v12.4). The bugs lie in the codegen
    so it would be difficult for users to work around them or even figure
    out where the bugs are coming from. Some bugs are fixed in the upstream
    while some others probably remain. As v22 will get stuck with V8 v12.4
    as LTS, it will be increasingly difficult to backport patches for them
    even if the bugs are fixed. So disable it by default on v22 to reduce
    the churn and troubles for users.
    
    PR-URL: #54384
    Refs: #52797
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    joyeecheung authored and RafaelGSS committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    5243e32 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. module: do not warn for typeless package.json when there isn't one

    It was intended that warnings should only be emitted for an
    existing package.json without a type. This fixes a confusing
    warning telling users to update /package.json when there are
    no package.json on the lookup path at all, like this:
    
    [MODULE_TYPELESS_PACKAGE_JSON] Warning: ... parsed as an ES module
    because module syntax was detected; to avoid the performance penalty
    of syntax detection, add "type": "module" to /package.json
    
    Drive-by: update the warning message to be clear about
    reparsing and make it clear what's actionable.
    
    PR-URL: #54045
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    joyeecheung authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    b7284ed View commit details
    Browse the repository at this point in the history
  2. doc: add documentation about os.tmpdir() overrides

    This documents the TMPDIR, TEMP and TMP overrides on different
    platforms and that some operating systems set these by default.
    
    PR-URL: #54613
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    joyeecheung authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    5bfb4bc View commit details
    Browse the repository at this point in the history
  3. async_hooks: add an InactiveAsyncContextFrame class

    This gives a class prototype for AsyncContextFrame that contains the
    required methods, so that when we swap the prototype,
    ActiveAsyncContextFrame methods are used instead. Previously, the
    methods were defined in AsyncContextFrame, so swapping the prototype
    didn't swap those static methods.
    
    Also, make the ActiveAsyncContextFrame extend from Map.
    
    Fixes: #54503
    PR-URL: #54510
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    bengl authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    027b0ff View commit details
    Browse the repository at this point in the history
  4. lib: refactor SubtleCrypto experimental warnings

    PR-URL: #54620
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    panva authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    540b1db View commit details
    Browse the repository at this point in the history
  5. doc: fix webcrypto.md AES-GCM backticks

    PR-URL: #54621
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    panva authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    754baa4 View commit details
    Browse the repository at this point in the history
  6. test: improve output of child process utilities

    - Display command and options when it fails
    - Keep the caller line at the top of the stack trace.
    
    PR-URL: #54622
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
    joyeecheung authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    fdb6511 View commit details
    Browse the repository at this point in the history
  7. deps: fix sign-compare warning in ncrypto

    PR-URL: #54624
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
    zcbenz authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    6a32645 View commit details
    Browse the repository at this point in the history
  8. crypto: remove unused kHashTypes internal

    PR-URL: #54627
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    02ac537 View commit details
    Browse the repository at this point in the history
  9. doc: fix typo

    name used instructions differed that what is in the code
    
    Signed-off-by: Michael Dawson <midawson@redhat.com>
    PR-URL: #54640
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    mhdawson authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    5555095 View commit details
    Browse the repository at this point in the history
  10. meta: fix contributing codeowners

    PR-URL: #54641
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    RedYetiDev authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    6c8a20d View commit details
    Browse the repository at this point in the history
  11. test: move more zlib tests to node:test

    PR-URL: #54609
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
    anonrig authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    67e30de View commit details
    Browse the repository at this point in the history
  12. https: only use default ALPNProtocols when appropriate

    PR-URL: #54411
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Tim Perry <pimterry@gmail.com>
    Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    mscdex authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    04ef3e4 View commit details
    Browse the repository at this point in the history
  13. tools: remove readability/fn_size rule

    PR-URL: #54663
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    RafaelGSS authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    d6df542 View commit details
    Browse the repository at this point in the history
  14. lib: ensure no holey array in fixed_queue

    Co-authored-by: Jake Yuesong Li <jake.yuesong@gmail.com>
    PR-URL: #54537
    Fixes: #54472
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
    2 people authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    2a1f56c View commit details
    Browse the repository at this point in the history
  15. timers: document ref option for scheduler.wait

    PR-URL: #54605
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
    ShogunPanda authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    b3d567a View commit details
    Browse the repository at this point in the history
  16. stream: relocate the status checking code in the onwritecomplete

    relocate the status checking code before verifying if the stream is
    destroyed
    
    PR-URL: #54032
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    MCprotein authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    e2307d8 View commit details
    Browse the repository at this point in the history
  17. doc: render type references in SQLite docs

    Render JavaScript types as such in the section "Type conversion between
    JavaScript and SQLite".
    
    PR-URL: #54684
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    tniessen authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    1c7bdf9 View commit details
    Browse the repository at this point in the history
  18. typings: correct param type of SafePromisePrototypeFinally

    PR-URL: #54727
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
    iwuliz authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    071dff1 View commit details
    Browse the repository at this point in the history
  19. meta: fix links in SECURITY.md

    PR-URL: #54696
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    RedYetiDev authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    79b358a View commit details
    Browse the repository at this point in the history
  20. meta: bump github/codeql-action from 3.25.15 to 3.26.6

    Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.15 to 3.26.6.
    - [Release notes](https://github.com/github/codeql-action/releases)
    - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
    - [Commits](github/codeql-action@afb54ba...4dd1613)
    
    ---
    updated-dependencies:
    - dependency-name: github/codeql-action
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    PR-URL: #54702
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    dependabot[bot] authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    c6bd9e4 View commit details
    Browse the repository at this point in the history
  21. meta: bump actions/upload-artifact from 4.3.4 to 4.4.0

    Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.4 to 4.4.0.
    - [Release notes](https://github.com/actions/upload-artifact/releases)
    - [Commits](actions/upload-artifact@0b2256b...5076954)
    
    ---
    updated-dependencies:
    - dependency-name: actions/upload-artifact
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    PR-URL: #54703
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    dependabot[bot] authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    ea58feb View commit details
    Browse the repository at this point in the history
  22. meta: bump step-security/harden-runner from 2.9.0 to 2.9.1

    Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 2.9.0 to 2.9.1.
    - [Release notes](https://github.com/step-security/harden-runner/releases)
    - [Commits](step-security/harden-runner@0d38121...5c7944e)
    
    ---
    updated-dependencies:
    - dependency-name: step-security/harden-runner
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    PR-URL: #54704
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    dependabot[bot] authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    9ebcfb2 View commit details
    Browse the repository at this point in the history
  23. benchmark: adds groups to better separate benchmarks

    Fixes: #26425
    Co-Authored-By: Yaman Kassir <mestery@protonmail.com>
    PR-URL: #54393
    Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
    2 people authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    721c63c View commit details
    Browse the repository at this point in the history
  24. build: turn off -Wrestrict

    PR-URL: #54737
    Refs: #54736
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
    richardlau authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    3b5ed97 View commit details
    Browse the repository at this point in the history
  25. vm: add vm proto property lookup test

    Add more test coverage on vm prototype properties lookup with
    `in` operator and property access.
    
    PR-URL: #54606
    Refs: #54436
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    legendecas authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    ade9da5 View commit details
    Browse the repository at this point in the history
  26. meta: update sccache to v0.8.1

    PR-URL: #54720
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    RedYetiDev authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    19574a8 View commit details
    Browse the repository at this point in the history
  27. meta: bump actions/setup-python from 5.1.1 to 5.2.0

    PR-URL: #54691
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    bdd9fbb View commit details
    Browse the repository at this point in the history
  28. benchmark,doc: mention bar.R to the list of scripts

    PR-URL: #54722
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    RafaelGSS authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    d19efd7 View commit details
    Browse the repository at this point in the history
  29. benchmark,doc: add CPU scaling governor to perf

    PR-URL: #54723
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    RafaelGSS authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    68e45b4 View commit details
    Browse the repository at this point in the history
  30. doc: clarify expandedSQL behavior

    I am not sure what exactly the primary use case is for this function
    given that the Node.js API is not designed for users to manually bind
    parameters of prepared statements, but this at least clarifies what the
    function does.
    
    PR-URL: #54685
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    tniessen authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    62b0007 View commit details
    Browse the repository at this point in the history
  31. lib: add util.getCallSite() API

    PR-URL: #54380
    Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Claudio Wunder <cwunder@gnome.org>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    RafaelGSS authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    a37d805 View commit details
    Browse the repository at this point in the history
  32. doc: specify that preloaded modules affect subprocesses

    Co-Authored-By: Tim Fish <tim@timfish.uk>
    PR-URL: #52939
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    2 people authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    de225f5 View commit details
    Browse the repository at this point in the history
  33. buffer: re-enable Fast API for Buffer.write

    Re-enables fast Fast API for Buffer.write after fixing
    UTF8 handling.
    
    Fixes: #54521
    PR-URL: #54526
    Reviewed-By: Daniel Lemire <daniel@lemire.me>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    ronag authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    85b5ed5 View commit details
    Browse the repository at this point in the history
  34. doc, child_process: add esm snippets

    PR-URL: #53616
    Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
    RedYetiDev authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    5e081a1 View commit details
    Browse the repository at this point in the history
  35. fs: respect dereference when copy symlink directory

    Co-authored-by: Jake Yuesong Li <jake.yuesong@gmail.com>
    PR-URL: #54732
    Fixes: #54730
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    2 people authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    ee89c31 View commit details
    Browse the repository at this point in the history
  36. crypto: return a clearer error when loading an unsupported pkcs12

    PR-URL: #54485
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    pimterry authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    3981853 View commit details
    Browse the repository at this point in the history
  37. benchmark: add strictEqual and notStrictEqual bench

    PR-URL: #54734
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
    RafaelGSS authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    456a1fe View commit details
    Browse the repository at this point in the history
  38. benchmark: add throws and doesNotThrow bench

    PR-URL: #54734
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
    RafaelGSS authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    af7689e View commit details
    Browse the repository at this point in the history
  39. benchmark: add rejects and doesNotReject bench

    PR-URL: #54734
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
    RafaelGSS authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    2844180 View commit details
    Browse the repository at this point in the history
  40. benchmark: add match and doesNotMatch bench

    PR-URL: #54734
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
    RafaelGSS authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    0601644 View commit details
    Browse the repository at this point in the history
  41. zlib: deprecate instantiating classes without new

    PR-URL: #54708
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: LiviaMedeiros <livia@cirno.name>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    anonrig authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    8c4c85c View commit details
    Browse the repository at this point in the history
  42. deps: allow amaro to be externalizable

    - allow amaro to be externalized like other builtins
      containing WASM. More context is available in
      https://github.com/nodejs/node/blob/main/doc/contributing/maintaining/maintaining-dependencies.md#supporting-externalizable-dependencies-with-javascript-code
    
    Signed-off-by: Michael Dawson <midawson@redhat.com>
    PR-URL: #54646
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    mhdawson authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    0659516 View commit details
    Browse the repository at this point in the history
  43. lib: add note about removing node:sys module

    PR-URL: #54743
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    RafaelGSS authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    21fef34 View commit details
    Browse the repository at this point in the history
  44. benchmark: enhance dc publish benchmark

    PR-URL: #54745
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    RafaelGSS authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    ebe91db View commit details
    Browse the repository at this point in the history
  45. sqlite: remove unnecessary auto assignment

    Assignment is not necessary here at all.
    
    PR-URL: #54686
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    tniessen authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    4c1b98b View commit details
    Browse the repository at this point in the history
  46. benchmark: add access async version to bench

    PR-URL: #54747
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    RafaelGSS authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    237d7df View commit details
    Browse the repository at this point in the history
  47. doc: fix typo in module.md

    PR-URL: #54794
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    tniessen authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    dc69eb8 View commit details
    Browse the repository at this point in the history
  48. meta: ping @nodejs/performance on bench changes

    PR-URL: #54752
    Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    RafaelGSS authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    df30e8e View commit details
    Browse the repository at this point in the history
  49. doc: add support link for marco-ippolito

    PR-URL: #54789
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
    marco-ippolito authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    c0f3e46 View commit details
    Browse the repository at this point in the history
  50. tools: add util scripts to land and rebase PRs

    PR-URL: #54656
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: LiviaMedeiros <livia@cirno.name>
    aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    93fab49 View commit details
    Browse the repository at this point in the history
  51. typings: fix TypedArray to a global type

    PR-URL: #54063
    Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    1ilsang authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    689d127 View commit details
    Browse the repository at this point in the history
  52. test: refactor test-esm-type-field-errors

    Co-Authored-By: Jacob Smith <jacob@frende.me>
    PR-URL: #54368
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    2 people authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    f074d74 View commit details
    Browse the repository at this point in the history
  53. doc: replace --allow-fs-read by --allow-fs-write in related section

    PR-URL: #54427
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    M1CK431 authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    5bd4be5 View commit details
    Browse the repository at this point in the history
  54. build: don't store eslint locally

    PR-URL: #54231
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    RedYetiDev authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    6200cf4 View commit details
    Browse the repository at this point in the history
  55. doc: clarify --max-old-space-size and --max-semi-space-size units

    PR-URL: #54477
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
    alexandre-abrioux authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    2c2ae80 View commit details
    Browse the repository at this point in the history
  56. test: refactor fs-watch tests due to macOS issue

    In `macOS`, fsevents generated immediately before start watching may
    leak into the event callback. See: #54450
    for an explanation. This might be fixed at some point in `libuv` though
    it may take some time (see: libuv/libuv#3866).
    This commit comes in anticipation of the soon-to-be-released
    `libuv@1.49.0` which was making these tests very flaky.
    
    PR-URL: #54498
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    santigimeno authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    9601169 View commit details
    Browse the repository at this point in the history
  57. test: fix test-process-load-env-file when path contains '

    If the repo is cloned on a path that contains a quote, the test should
    not fail.
    
    PR-URL: #54511
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    b5137f6 View commit details
    Browse the repository at this point in the history
  58. buffer: fix out of range for toString

    Co-authored-by: Michaël Zasso <targos@protonmail.com>
    PR-URL: #54553
    Fixes: #52298
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
    2 people authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    1fb67af View commit details
    Browse the repository at this point in the history
  59. lib: convert signals to array before validation

    Co-authored-by: Jake Yuesong Li <jake.yuesong@gmail.com>
    PR-URL: #54714
    Fixes: #54674
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
    Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    2 people authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    fc78ced View commit details
    Browse the repository at this point in the history
  60. benchmark: add buffer.isUtf8 bench

    PR-URL: #54740
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    RafaelGSS authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    40c6849 View commit details
    Browse the repository at this point in the history
  61. benchmark: add buffer.isAscii benchmark

    PR-URL: #54740
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    RafaelGSS authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    af1988c View commit details
    Browse the repository at this point in the history
  62. meta: add Windows ARM64 to flaky-tests list

    PR-URL: #54693
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    RedYetiDev authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    82c08ef View commit details
    Browse the repository at this point in the history
  63. crypto: reject dh,x25519,x448 in {Sign,Verify}Final

    Fixes: #53742
    PR-URL: #53774
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    JLHwung authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    5bba078 View commit details
    Browse the repository at this point in the history
  64. doc: fix typo in recognizing-contributors

    PR-URL: #54822
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    tniessen authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    b8ae36b View commit details
    Browse the repository at this point in the history
  65. deps: update cjs-module-lexer to 1.4.0

    PR-URL: #54713
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    nodejs-github-bot authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    2351da5 View commit details
    Browse the repository at this point in the history
  66. doc: mark --conditions CLI flag as stable

    PR-URL: #54209
    Reviewed-By: James M Snell <jasnell@gmail.com>
    guybedford authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    1def181 View commit details
    Browse the repository at this point in the history
  67. test: set test-debugger-heap-profiler as flaky

    PR-URL: #54802
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    anonrig authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    45ef2a8 View commit details
    Browse the repository at this point in the history
  68. test: set test-performance-function as flaky

    PR-URL: #54802
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    anonrig authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    4231af3 View commit details
    Browse the repository at this point in the history
  69. test: set test-runner-watch-mode-complex as flaky

    PR-URL: #54802
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    anonrig authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    5f6f875 View commit details
    Browse the repository at this point in the history
  70. test: set test-http2-large-file as flaky

    PR-URL: #54802
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    anonrig authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    b0458a8 View commit details
    Browse the repository at this point in the history
  71. test: set test-esm-loader-hooks-inspect-wait as flaky

    PR-URL: #54802
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    anonrig authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    3dfb525 View commit details
    Browse the repository at this point in the history
  72. test: set test-async-context-frame as flaky

    PR-URL: #54802
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    anonrig authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    d55fec8 View commit details
    Browse the repository at this point in the history
  73. test: set test-writewrap as flaky

    PR-URL: #54802
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    anonrig authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    b9f3385 View commit details
    Browse the repository at this point in the history
  74. test: set test-sqlite-statement-sync as flaky

    PR-URL: #54802
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    anonrig authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    d2ede46 View commit details
    Browse the repository at this point in the history
  75. test: set test-runner-run-watch as flaky

    PR-URL: #54802
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    anonrig authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    e3b7c40 View commit details
    Browse the repository at this point in the history
  76. test: set test-fs-utimes as flaky

    PR-URL: #54802
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    anonrig authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    2f40884 View commit details
    Browse the repository at this point in the history
  77. test: set test-macos-app-sandbox as flaky

    PR-URL: #54802
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    anonrig authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    6a2da4c View commit details
    Browse the repository at this point in the history
  78. test: set test-single-executable-application-empty as flaky

    PR-URL: #54802
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    anonrig authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    32d340e View commit details
    Browse the repository at this point in the history
  79. test: set test-http-server-request-timeouts-mixed as flaky

    PR-URL: #54802
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    anonrig authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    8291de1 View commit details
    Browse the repository at this point in the history
  80. test: set test-runner-run-watch as flaky

    PR-URL: #54802
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    anonrig authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    56238de View commit details
    Browse the repository at this point in the history
  81. test: set test-worker-arraybuffer-zerofill as flaky

    PR-URL: #54802
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    anonrig authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    1e1ac48 View commit details
    Browse the repository at this point in the history
  82. test: set test-http2-socket-close as flaky

    PR-URL: #54802
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    anonrig authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    41682c7 View commit details
    Browse the repository at this point in the history
  83. src: move hkdf, scrypto, pbkdf2 impl to ncrypto

    PR-URL: #54651
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    jasnell authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    b89cd8d View commit details
    Browse the repository at this point in the history
  84. esm: use Undici/fetch data: URL parser

    Fixes: #53775
    PR-URL: #54748
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    KhafraDev authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    40ba89e View commit details
    Browse the repository at this point in the history
  85. sqlite: fix segfault in expandedSQL

    The call to sqlite3_expanded_sql() may return NULL depending on various
    factors. Handle this case instead of running into a segmentation fault.
    
    PR-URL: #54687
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    tniessen authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    7766349 View commit details
    Browse the repository at this point in the history
  86. doc: add support link for mcollina

    Signed-off-by: Matteo Collina <hello@matteocollina.com>
    PR-URL: #54786
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
    Reviewed-By: Steven R Loomis <srl295@gmail.com>
    mcollina authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    c1b92e0 View commit details
    Browse the repository at this point in the history
  87. test: fix volatile for CauseSegfault with clang

    PR-URL: #54325
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    tie authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    cad404e View commit details
    Browse the repository at this point in the history
  88. tools: add readability/fn_size to filter

    PR-URL: #54744
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    RafaelGSS authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    608a611 View commit details
    Browse the repository at this point in the history
  89. src: fix unhandled error in structuredClone

    Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
    PR-URL: #54764
    Fixes: #54602
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    daeyeon authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    97cbcfb View commit details
    Browse the repository at this point in the history
  90. build: do not build with code cache for core coverage collection

    Disable code cache for built-ins when are building Node.js to
    collect test coverage of built-ins, as code caching makes the
    V8 coverage collection less precises (specifically, all the
    functions deserialized from the code cache will not have
    block-level coverage data).
    
    Data from local testing:
    
    Before:
    
    ---------|----------|---------|---------
     % Stmts | % Branch | % Funcs | % Lines
    ---------|----------|---------|---------
       95.58 |    94.43 |   95.19 |   95.58
    ---------|----------|---------|---------
    
    After:
    
    ---------|----------|---------|---------
     % Stmts | % Branch | % Funcs | % Lines
    ---------|----------|---------|---------
       95.93 |    94.77 |   96.03 |   95.93
    ---------|----------|---------|---------
    
    PR-URL: #54633
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
    joyeecheung authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    948bba3 View commit details
    Browse the repository at this point in the history
  91. doc: add ERR_INVALID_ADDRESS to errors.md

    PR-URL: #54661
    Reviewed-By: James M Snell <jasnell@gmail.com>
    RedYetiDev authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    6f8a6e9 View commit details
    Browse the repository at this point in the history
  92. deps: upgrade npm to 10.8.3

    PR-URL: #54619
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    npm-cli-bot authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    61047dd View commit details
    Browse the repository at this point in the history
  93. test: fix Windows async-context-frame memory failure

    PR-URL: #54823
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Qard authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    8345a60 View commit details
    Browse the repository at this point in the history
  94. meta: bump peter-evans/create-pull-request from 6.1.0 to 7.0.1

    Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 6.1.0 to 7.0.1.
    - [Release notes](https://github.com/peter-evans/create-pull-request/releases)
    - [Commits](peter-evans/create-pull-request@c5a7806...8867c4a)
    
    ---
    updated-dependencies:
    - dependency-name: peter-evans/create-pull-request
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    PR-URL: #54820
    Refs: peter-evans/create-pull-request@8867c4a
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    dependabot[bot] authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    c1cc046 View commit details
    Browse the repository at this point in the history
  95. doc: experimental flag for global accessible APIs

    Explicitly document that adding an API to the global scope requires
    `semver-major` label. Waiving the `semver-major` requires a regular
    TSC consensus process.
    
    PR-URL: #54330
    Refs: #54329
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    legendecas authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    8931f56 View commit details
    Browse the repository at this point in the history
  96. doc: run license-builder

    PR-URL: #54854
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    github-actions[bot] authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    56aca2a View commit details
    Browse the repository at this point in the history
  97. tls: add allowPartialTrustChain flag

    This commit exposes the `X509_V_FLAG_PARTIAL_CHAIN` OpenSSL flag to
    users. This is behavior that has been requested repeatedly in the
    Github issues, and allows aligning behavior with other TLS libraries
    and commonly used applications (e.g. `curl`).
    
    As a drive-by, simplify the `SecureContext` source by deduplicating
    call sites at which a new custom certificate store was created for the
    `secureContext` in question.
    
    Fixes: #36453
    PR-URL: #54790
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    addaleax authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    c2bf013 View commit details
    Browse the repository at this point in the history
  98. repl: doc-deprecate instantiating node:repl classes without new

    PR-URL: #54842
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: LiviaMedeiros <livia@cirno.name>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    RedYetiDev authored and aduh95 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    8433032 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. esm: fix support for URL instances in import.meta.resolve

    PR-URL: #54690
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jacob Smith <jacob@frende.me>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: LiviaMedeiros <livia@cirno.name>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    aduh95 committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    31d4ef9 View commit details
    Browse the repository at this point in the history
  2. fs: refactor rimraf to avoid using primordials

    PR-URL: #54834
    Reviewed-By: LiviaMedeiros <livia@cirno.name>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    anonrig authored and aduh95 committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    375cbb5 View commit details
    Browse the repository at this point in the history
  3. timers: avoid generating holey internal arrays

    PR-URL: #54771
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    gurgunday authored and aduh95 committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    3d47872 View commit details
    Browse the repository at this point in the history
  4. test: move test-http-server-request-timeouts-mixed

    Test was moved to sequential a while back.
    
    PR-URL: #54841
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: LiviaMedeiros <livia@cirno.name>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    jasnell authored and aduh95 committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    5278b8b View commit details
    Browse the repository at this point in the history
  5. test: use node:test in test-cli-syntax.bad

    PR-URL: #54513
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    RedYetiDev authored and aduh95 committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    b96ee30 View commit details
    Browse the repository at this point in the history
  6. lib: move Symbol[Async]Dispose polyfills to internal/util

    PR-URL: #54853
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    aduh95 committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    5f02e1b View commit details
    Browse the repository at this point in the history
  7. path: remove StringPrototypeCharCodeAt from posix.extname

    PR-URL: #54546
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    RedYetiDev authored and aduh95 committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    94fb7ab View commit details
    Browse the repository at this point in the history
  8. test_runner: improve code coverage cleanup

    The test runner's code coverage leaves old coverage data in the
    temp directory. This commit updates the cleanup logic to:
    
    - Stop code collection. Otherwise V8 would write collection data
      again when the process exits.
    - Remove the temp directory containing the coverage data.
    - Attempt to clean up the coverage data even if parsing the
      data resulted in an error.
    
    With this change, I no longer see any coverage data left behind
    in the system temp directory.
    
    Refs: nodejs/build#3864
    Refs: nodejs/build#3887
    PR-URL: #54856
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    cjihrig authored and aduh95 committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    de73d1e View commit details
    Browse the repository at this point in the history
  9. src: eliminate ManagedEVPPkey

    Prior to this change, the ManagedEVPPkey class added an
    additional layer of abstraction to the EVP_PKEY class
    that wasn't strictly necessary.
    
    Previously we had:
    
      KeyObjectHandle ->
          std::shared_ptr<KeyObjectData> ->
              ManagedEVPPkey ->
                  EVPKeyPointer
    
    After this change we have:
    
      KeyObjectHandle ->
          KeyObjectData ->
              EVPKeyPointer
    
    The `KeyObjectData` class no longer needs to be wrapped in
    std::shared_ptr but it will hold the underlying EVPKeyPointer
    in a std::shared_ptr.
    
    This greatly simplifies the abstraction and provides an overall
    reduction in code and complexity, although the changeset in this
    PR is fairly extensive to get there.
    
    This refactor is being done to simplify the codebase as part
    of the process of extracting crypto functionality to the
    separate ncrypto dep.
    
    PR-URL: #54751
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    jasnell authored and aduh95 committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    5e72bd3 View commit details
    Browse the repository at this point in the history
  10. os: improve tmpdir performance

    PR-URL: #54709
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    anonrig authored and aduh95 committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    461e523 View commit details
    Browse the repository at this point in the history
  11. doc: add support link for aduh95

    PR-URL: #54866
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: LiviaMedeiros <livia@cirno.name>
    Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
    Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    aduh95 committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    440c256 View commit details
    Browse the repository at this point in the history
  12. test: reduce fs calls in test-fs-existssync-false

    PR-URL: #54815
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    anonrig authored and aduh95 committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    d1a4114 View commit details
    Browse the repository at this point in the history
  13. esm: throw ERR_REQUIRE_ESM instead of ERR_INTERNAL_ASSERTION

    PR-URL: #54868
    Fixes: #54773
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    aduh95 committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    a624002 View commit details
    Browse the repository at this point in the history
  14. test: reduce stack size for test-error-serdes

    Hopefully reduces the run time and the likelihood of the test
    failing with a flaky timeout error.
    
    remove test-error-serdes from flaky list
    
    move test-error-serdes to sequential
    
    PR-URL: #54840
    Refs: #52630
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: LiviaMedeiros <livia@cirno.name>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    jasnell authored and aduh95 committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    b875f2d View commit details
    Browse the repository at this point in the history
  15. test: add platform timeout support for riscv64

    PR-URL: #54591
    Refs: #54499
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    jakecastelli authored and aduh95 committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    b10e434 View commit details
    Browse the repository at this point in the history
  16. test: use platform timeout

    PR-URL: #54591
    Refs: #54499
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    jakecastelli authored and aduh95 committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    f084ea2 View commit details
    Browse the repository at this point in the history
  17. src: switch crypto APIs to use Maybe<void>

    PR-URL: #54775
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    jasnell authored and aduh95 committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    fbd08e3 View commit details
    Browse the repository at this point in the history
  18. test: remove need to make fs call for zlib test

    PR-URL: #54814
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    anonrig authored and aduh95 committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    b998bb0 View commit details
    Browse the repository at this point in the history
  19. test: fix test-tls-client-mindhsize for OpenSSL32

    Refs: #53382
    
    - OpenSSL32 has a minimum dh key size by 2048 by
      default.
    - Create larter 3072 dh key needed for testing and
      adjust tests to use it for builds with OpenSSL32
    
    Signed-off-by: Michael Dawson <midawson@redhat.com>
    PR-URL: #54739
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    mhdawson authored and aduh95 committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    c968d65 View commit details
    Browse the repository at this point in the history
  20. test: reduce the allocation size in test-worker-arraybuffer-zerofill

    Test has been flaky with timeouts in CI. This is possibly due to the
    repeated large allocations on the main thread. This commit reduces the
    allocation size and makes a number of other cleanups. The main goal
    is to hopefully make this test more reliable / not-flaky.
    
    Also move the test to sequential. The frequent large allocations
    could be causing the test to be flaky if run parallel to other tests.
    
    PR-URL: #54839
    Refs: #52274
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    jasnell authored and aduh95 committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    4b53558 View commit details
    Browse the repository at this point in the history
  21. test: reduce test-esm-loader-hooks-inspect-wait flakiness

    Refs: #51560
    PR-URL: #54827
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    lpinca authored and aduh95 committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    194cb83 View commit details
    Browse the repository at this point in the history
  22. test: remove dead code in test-http2-misbehaving-multiplex

    PR-URL: #54860
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: LiviaMedeiros <livia@cirno.name>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    lpinca authored and aduh95 committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    b198a91 View commit details
    Browse the repository at this point in the history
  23. doc, meta: fix broken link in onboarding.md

    PR-URL: #54886
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    RedYetiDev authored and aduh95 committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    2b68c30 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. build,win: enable clang-cl compilation

    This uses the backported ICU fix needed for compiling with ClangCL.
    
    Refs: #54502
    Fixes: #34201
    PR-URL: #54655
    Refs: #52809
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Steven R Loomis <srl295@gmail.com>
    StefanStojanovic authored and RafaelGSS committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    e38e305 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. test_runner: allow --import with no isolation

    Co-Authored-By: Colin Ihrig <cjihrig@gmail.com>
    PR-URL: #54697
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    2 people authored and RafaelGSS committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    36da793 View commit details
    Browse the repository at this point in the history
  2. test: deflake test-http2-misbehaving-multiplex

    Fixes: #54859
    PR-URL: #54872
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    lpinca authored and RafaelGSS committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    2efec62 View commit details
    Browse the repository at this point in the history
  3. test_runner: apply filtering when tests begin

    This commit updates the way filtering is applied to tests and
    suites. After this change, filters are applied just before the
    test/suite is started. The results are the same, but this allows
    us to eventually move away from the --test-only flag except
    when process level isolation is used.
    
    PR-URL: #54832
    Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    cjihrig authored and RafaelGSS committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    021f59b View commit details
    Browse the repository at this point in the history
  4. test_runner: detect only tests when isolation is off

    This commit updates the way the test runner processes 'only'
    tests when process-based test isolation is disabled. The
    --test-only flag is no longer necessary in this scenario. The
    test runner will automatically detect 'only' tests and apply the
    appropriate filtering.
    
    PR-URL: #54832
    Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    cjihrig authored and RafaelGSS committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    3396a49 View commit details
    Browse the repository at this point in the history
  5. test: strip color chars in test-runner-run

    Fixes: #54551
    PR-URL: #54552
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    puskin94 authored and RafaelGSS committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    ee385d6 View commit details
    Browse the repository at this point in the history
  6. test: move more url tests to node:test

    PR-URL: #54636
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    anonrig authored and RafaelGSS committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    7a1d633 View commit details
    Browse the repository at this point in the history
  7. test_runner: update kPatterns

    PR-URL: #54728
    Fixes: #54726
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    pmarchini authored and RafaelGSS committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    6552fdd View commit details
    Browse the repository at this point in the history
  8. test_runner: report coverage thresholds in test:coverage

    PR-URL: #54813
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    RedYetiDev authored and RafaelGSS committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    a52c199 View commit details
    Browse the repository at this point in the history
  9. src: add Cleanable class to Environment

    We store a linked list of `Cleanable` objects on the
    `node::Environment` and invoke their `Clean()` method during env
    teardown.
    
    This eliminates the need for adding many cleanup hooks.
    
    PR-URL: #54880
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    gabrielschulhof authored and RafaelGSS committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    424bdc0 View commit details
    Browse the repository at this point in the history
  10. lib: make WeakRef safe in abort_controller

    PR-URL: #54791
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    jazelly authored and RafaelGSS committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    2b9a637 View commit details
    Browse the repository at this point in the history
  11. build: fix conflicting V8 object print flags

    Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
    PR-URL: #54785
    Reviewed-By: James M Snell <jasnell@gmail.com>
    daeyeon authored and RafaelGSS committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    69ec9d8 View commit details
    Browse the repository at this point in the history
  12. http: reduce likelihood of race conditions on keep-alive timeout

    Fixes: #52649
    Refs: #54293
    
    Co-authored-by: Arrigo Zanette <zanettea@gmail.com>
    PR-URL: #54863
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: LiviaMedeiros <livia@cirno.name>
    Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
    Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
    2 people authored and RafaelGSS committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    7123bf7 View commit details
    Browse the repository at this point in the history
  13. deps: update simdutf to 5.5.0

    PR-URL: #54434
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    nodejs-github-bot authored and RafaelGSS committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    bf4bf7c View commit details
    Browse the repository at this point in the history
  14. test: add missing await

    Add missing `await` in
    `test/parallel/test-inspector-async-stack-traces-promise-then.js`.
    
    PR-URL: #54828
    Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    lpinca authored and RafaelGSS committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    115a7ca View commit details
    Browse the repository at this point in the history
  15. test: use correct file naming syntax for util-parse-env

    PR-URL: #53705
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    RedYetiDev authored and RafaelGSS committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    d9264bc View commit details
    Browse the repository at this point in the history
  16. node-api: add support for UTF-8 and Latin-1 property keys

    PR-URL: #52984
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com>
    Mert Can Altin authored and RafaelGSS committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    4a7576e View commit details
    Browse the repository at this point in the history
  17. node-api: add external buffer creation benchmark

    Add a micro benchmark for external buffer creation.
    
    PR-URL: #54877
    Refs: #53804
    Refs: #44111
    Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    legendecas authored and RafaelGSS committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    ddd24a6 View commit details
    Browse the repository at this point in the history
  18. doc, build: fixup build docs

    PR-URL: #54899
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    RedYetiDev authored and RafaelGSS committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    22d8732 View commit details
    Browse the repository at this point in the history
  19. test: fix test test-tls-dhe for OpenSSL32

    Refs: #53382
    
    - OpenSSL32 has a minimum dh key size by 2048 by default.
    - Adjust test to use larger 3072 key instead of 1024
      when OpenSSL32 is present.
    
    Signed-off-by: Michael Dawson <midawson@redhat.com>
    PR-URL: #54903
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    mhdawson authored and RafaelGSS committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    bb4849f View commit details
    Browse the repository at this point in the history
  20. test: deflake test-dns

    Prevent responses from being cached.
    
    Fixes: #54124
    PR-URL: #54902
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    lpinca authored and RafaelGSS committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    ed736a6 View commit details
    Browse the repository at this point in the history
  21. test: improve test-internal-fs-syncwritestream

    A subtest about the behavior when `autoClose=false`.
    
    PR-URL: #54671
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    sungpaks authored and RafaelGSS committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    097f6d3 View commit details
    Browse the repository at this point in the history
  22. lib: remove unnecessary async

    Co-authored-by: Jason Zhang <xzha4350@gmail.com>
    PR-URL: #54829
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    2 people authored and RafaelGSS committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    dc5593b View commit details
    Browse the repository at this point in the history
  23. deps: update cjs-module-lexer to 1.4.1

    PR-URL: #54846
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    nodejs-github-bot authored and RafaelGSS committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    323d9da View commit details
    Browse the repository at this point in the history
  24. zlib: add typings for better dx

    PR-URL: #54699
    Reviewed-By: LiviaMedeiros <livia@cirno.name>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    anonrig authored and RafaelGSS committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    8385958 View commit details
    Browse the repository at this point in the history
  25. build: upgrade clang-format to v18

    PR-URL: #53957
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    RedYetiDev authored and RafaelGSS committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    9a07527 View commit details
    Browse the repository at this point in the history
  26. test: fix test-http2-socket-close.js

    Fixes: #54819
    PR-URL: #54900
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    huseyinacacak-janea authored and RafaelGSS committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    cefa692 View commit details
    Browse the repository at this point in the history
  27. test: adjust tls test for OpenSSL32

    Refs: #53382
    
    Looks like test is forcing an error through bad data and
    the error code we get is different for OpenSSL32. Adjust
    test to cope with the variation across versions.
    
    Signed-off-by: Michael Dawson <midawson@redhat.com>
    PR-URL: #54909
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    mhdawson authored and RafaelGSS committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    2b5e708 View commit details
    Browse the repository at this point in the history
  28. test: remove duplicate skip AIX

    PR-URL: #54917
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
    Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
    iwuliz authored and RafaelGSS committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    23fb03b View commit details
    Browse the repository at this point in the history
  29. doc: fix broken Android building link

    PR-URL: #54922
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
    nikwen authored and RafaelGSS committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    8f62f19 View commit details
    Browse the repository at this point in the history
  30. repl: avoid interpreting 'npm' as a command when errors are recoverable

    This change ensures that 'npm' within JavaScript code is not mistakenly
    interpreted as an npm command when the error is recoverable.
    This allows 'npm' to be treated as expected in such scenarios.
    
    Fixes: #54830
    PR-URL: #54848
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
    islandryu authored and RafaelGSS committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    67b1d4c View commit details
    Browse the repository at this point in the history
  31. test_runner: reimplement assert.ok to allow stack parsing

    PR-URL: #54776
    Refs: nodejs/help#4461
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    RedYetiDev authored and RafaelGSS committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    de0f445 View commit details
    Browse the repository at this point in the history
  32. test,crypto: update WebCryptoAPI WPT

    PR-URL: #54925
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    panva authored and RafaelGSS committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    55a12a4 View commit details
    Browse the repository at this point in the history
  33. test: adjust test-tls-junk-server for OpenSSL32

    Refs: #53382
    
    OpenSSL32 returns different error text. Looking through
    the test it seems like the expected error text has been adjusted
    for different OpenSSL versions in the past and what the test
    is testing is not related to the error being returned.
    
    Update test to allow for error returned by OpenSSL32
    
    Signed-off-by: Michael Dawson <midawson@redhat.com>
    PR-URL: #54926
    Refs: #53382
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    mhdawson authored and RafaelGSS committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    ff54cab View commit details
    Browse the repository at this point in the history
  34. benchmark: --no-warnings to avoid DEP/ExpWarn log

    PR-URL: #54928
    Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    RafaelGSS committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    0227670 View commit details
    Browse the repository at this point in the history
  35. lib,src: use built-in array buffer detach, transfer

    PR-URL: #54837
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    anonrig authored and RafaelGSS committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    b59c8b8 View commit details
    Browse the repository at this point in the history
  36. src: add --env-file-if-exists flag

    Fixes: #50993
    Refs: #51451
    
    test: remove unnecessary comment
    
    src: conform to style guidelines
    
    src: change flag to `--env-file-optional`
    
    test: revert automatic linter changes
    
    doc: fix typos
    
    src: change flag to `--env-file-if-exists`
    
    src: refactor `env_file_data` and `GetEnvFileDataFromArgs`
    
    test: clean up tests
    
    src: print error when file not found
    
    test: remove unnecessary extras
    PR-URL: #53060
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    BoscoDomingo authored and RafaelGSS committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    77d162a View commit details
    Browse the repository at this point in the history
  37. fs: translate error code properly in cpSync

    UV error code needs to be negative integer so it can be mapped
    correctly. The filesystem error are positive integer, so we need to
    handle it before throwing.
    
    Co-authored-by: Jake Yuesong Li <jake.yuesong@gmail.com>
    PR-URL: #54906
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    2 people authored and RafaelGSS committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    93116dd View commit details
    Browse the repository at this point in the history
  38. 2024-09-17, Version 22.9.0 (Current)

    Notable changes:
    
    lib:
      * (SEMVER-MINOR) add util.getCallSite() API (Rafael Gonzaga) #54380
    repl:
      * doc-deprecate instantiating `node:repl` classes without `new` (Aviv Keller) #54842
    src:
      * create handle scope in FastInternalModuleStat (Joyee Cheung) #54384
    stream:
      * (SEMVER-MINOR) relocate the status checking code in the onwritecomplete (YoonSoo_Shin) #54032
    tls:
      * (SEMVER-MINOR) add `allowPartialTrustChain` flag (Anna Henningsen) #54790
    v8:
      * Revert "v8: enable maglev on supported architectures (Joyee Cheung) #54384
    
    PR-URL: #54966
    RafaelGSS committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    4631be0 View commit details
    Browse the repository at this point in the history