Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with upstream v0.10 #303

Closed
wants to merge 318 commits into from
This pull request is big! We’re only showing the most recent 250 commits.

Commits on Jan 19, 2024

  1. Merge pull request kubernetes-sigs#1763 from elastx/openstack_floatin…

    …g_ip_pool
    
    ✨ IPAM provider for floating ips
    k8s-ci-robot authored Jan 19, 2024
    Configuration menu
    Copy the full SHA
    05571b9 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. Merge pull request kubernetes-sigs#1834 from shiftstack/ci-test

    e2e: remove "allow-all-in-cluster-traffic" patch
    k8s-ci-robot authored Jan 22, 2024
    Configuration menu
    Copy the full SHA
    5d62dd5 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. Configuration menu
    Copy the full SHA
    42ca30e View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. Configuration menu
    Copy the full SHA
    26575b2 View commit details
    Browse the repository at this point in the history
  2. Merge pull request kubernetes-sigs#1839 from shiftstack/issue_1838

    🐛 controllers: do not return a RequeueAfter and an error at the same time
    k8s-ci-robot authored Jan 26, 2024
    Configuration menu
    Copy the full SHA
    e89ec9c View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. Enhance Tilt integration with CAPO using a ClusterClass template

    Signed-off-by: Max Rantil <max.rantil@est.tech>
    Max Rantil committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    9a71402 View commit details
    Browse the repository at this point in the history
  2. Merge pull request kubernetes-sigs#1833 from Nordix/clusterclass-tilt…

    …-capo/max
    
    🌱 Enhance Tilt integration with CAPO using a ClusterClass template
    k8s-ci-robot authored Jan 30, 2024
    Configuration menu
    Copy the full SHA
    64fd897 View commit details
    Browse the repository at this point in the history
  3. Merge pull request kubernetes-sigs#1845 from shiftstack/issue_1835

    🐛 Fill up OpenStack cluster ReferencedResources with Image ID
    k8s-ci-robot authored Jan 30, 2024
    Configuration menu
    Copy the full SHA
    cf4ccc5 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. Update the dev-test ClusterClass

    This adds a patch to set the image automatically based on the kubernetes
    version. It also removes the requirement to have the CLUSTER_NAME
    variable set for the ClusterClass.
    Finally, the docs are updated to reflect this and with a few additions.
    
    Signed-off-by: Lennart Jern <lennart.jern@est.tech>
    lentzi90 committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    d410f82 View commit details
    Browse the repository at this point in the history
  2. Merge pull request kubernetes-sigs#1848 from Nordix/lentzi90/dev-test…

    …-class-update
    
    🌱 Update the dev-test ClusterClass
    k8s-ci-robot authored Jan 31, 2024
    Configuration menu
    Copy the full SHA
    54d6fd0 View commit details
    Browse the repository at this point in the history
  3. Decrease number of machines in e2e tests

    The e2e tests are currently very unstable. I suspect lack of resources
    in the devstack to be the issue. In an attempt to solve this, the number
    of control-plane nodes are reduced in this commit. Now only the multi-az
    test will use 3 CP. The rest will have 1 CP only.
    
    Signed-off-by: Lennart Jern <lennart.jern@est.tech>
    lentzi90 committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    b0480b1 View commit details
    Browse the repository at this point in the history
  4. Convert ServerMetadata from a map to a list

    While we're changing it, we also add validation that keys and values
    don't exceed 255 characters.
    mdbooth committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    dfb963d View commit details
    Browse the repository at this point in the history
  5. Merge pull request kubernetes-sigs#1828 from shiftstack/server-metadata

    ⚠️ Convert ServerMetadata from a map to a list
    k8s-ci-robot authored Jan 31, 2024
    Configuration menu
    Copy the full SHA
    a80cdd2 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. Merge pull request kubernetes-sigs#1849 from Nordix/lentzi90/e2e-scal…

    …e-down
    
    🌱 Decrease number of machines in e2e tests
    k8s-ci-robot authored Feb 1, 2024
    Configuration menu
    Copy the full SHA
    5cc483b View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2024

  1. Configuration menu
    Copy the full SHA
    06d940a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b416af7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    403c98f View commit details
    Browse the repository at this point in the history
  4. Merge pull request kubernetes-sigs#1857 from elastx/dockerfile-go-1.21

    Migrate Dockerfile to use golang 1.21 to match go.mod in project
    k8s-ci-robot authored Feb 2, 2024
    Configuration menu
    Copy the full SHA
    87ea61c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9e356ad View commit details
    Browse the repository at this point in the history
  6. Merge pull request kubernetes-sigs#1853 from elastx/lb-stacktrace-fix

    🐛Fix a stacktrace in LB logic by removing listener name from an error message when not set
    k8s-ci-robot authored Feb 2, 2024
    Configuration menu
    Copy the full SHA
    84e1f4e View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. test: bump Flatcar version

    Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
    tormath1 committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    d690827 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8fe1c8f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3f806e0 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    cca2213 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. Merge pull request kubernetes-sigs#1858 from tormath1/tormath1/flatca…

    …r-update
    
    🌱 test: bump Flatcar version
    k8s-ci-robot authored Feb 7, 2024
    Configuration menu
    Copy the full SHA
    77d1ad0 View commit details
    Browse the repository at this point in the history
  2. Merge pull request kubernetes-sigs#1865 from okozachenko1203/doc/fix-…

    …block-device-volume-name
    
    fix: fix the block device type name in doc
    k8s-ci-robot authored Feb 7, 2024
    Configuration menu
    Copy the full SHA
    f128d15 View commit details
    Browse the repository at this point in the history
  3. add TLS configuration flags support

    Add --tls-min-version and --tls-max-versin configuration flags.
    Same flags can be found in k8s, CAPI, CAPM3 etc.
    
    Co-authored-by: Jawad Zaheer <jawad.zaheer@est.tech>
    Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
    tuminoid and as20203 committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    2c8a1a6 View commit details
    Browse the repository at this point in the history
  4. api: openstackcluster.status default to false

    When a reconcile loop for the bastion is requeued, we have
    this error:
    ```
    OpenStackCluster.infrastructure.cluster.x-k8s.io \"cluster-e2e-rha0r3\" is invalid: ready: Required value"
    ```
    
    The OpenStackMachine.Status is false by default now, so if the status
    has not been set to anything, patching the object will not fail with the
    previous error.
    EmilienM committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    e6092b8 View commit details
    Browse the repository at this point in the history
  5. Prevent the bastion to be removed before it's been disabled

    We now have a webhook that checks that a bastion has been disabled if a
    change has to be made (update or delete) in the bastion field.
    We also document it better.
    
    Also, we added some code to prevent that we don't have a nil pointer if
    the Spec.Bastion or Status.Bastion are unset.
    EmilienM committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    20f2a3c View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. Merge pull request kubernetes-sigs#1842 from shiftstack/issue_1841

    🐛 api: openstackcluster.status default to false
    k8s-ci-robot authored Feb 9, 2024
    Configuration menu
    Copy the full SHA
    c9b628f View commit details
    Browse the repository at this point in the history
  2. Merge pull request kubernetes-sigs#1864 from elastx/fix_pool_name_index

    🐛 Adds Kind to ipaddress pool name index
    k8s-ci-robot authored Feb 9, 2024
    Configuration menu
    Copy the full SHA
    4d81532 View commit details
    Browse the repository at this point in the history
  3. Merge pull request kubernetes-sigs#1867 from Nordix/tuomo/tls-configu…

    …ration-flags
    
    ✨ add TLS configuration flags
    k8s-ci-robot authored Feb 9, 2024
    Configuration menu
    Copy the full SHA
    7622602 View commit details
    Browse the repository at this point in the history
  4. Merge pull request kubernetes-sigs#1870 from elastx/ip_pool_duplicate…

    …_addresses
    
    OpenstackFloatingIPPool: Adds popped ip to claimedIPs kubernetes-sigs#1869
    k8s-ci-robot authored Feb 9, 2024
    Configuration menu
    Copy the full SHA
    ca15733 View commit details
    Browse the repository at this point in the history
  5. Merge pull request kubernetes-sigs#1854 from elastx/compare-cidr-fix

    🐛Make sure that allowedCidrs lists are compared correctly to avoid patching LB listener when not needed
    k8s-ci-robot authored Feb 9, 2024
    Configuration menu
    Copy the full SHA
    622defd View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2024

  1. loadbalancer: resolve ControlPlaneEndpoint.Host when needed

    `ControlPlaneEndpoint.Host` is not guaranteed to be an IP address, it
    can also be an hostname.
    
    Now we'll try to lookup the hostname if it's not an IP and set that for
    the LB VipAddress.
    EmilienM committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    b319893 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. Configuration menu
    Copy the full SHA
    42c0ef9 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. Merge pull request kubernetes-sigs#1866 from shiftstack/issue_1855

    🐛 Prevent the bastion to be removed before it's been disabled
    k8s-ci-robot authored Feb 14, 2024
    Configuration menu
    Copy the full SHA
    8ca470a View commit details
    Browse the repository at this point in the history
  2. Move subnet options to SubnetSpec

    This commit introduces SubnetSpec field onto the OpenStackClusterSpec
    that is supposed to hold all options related to subnets created by CAPO.
    This means nodeCidr and DNSNameservers are moved into that struct.
    dulek committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    12a7b72 View commit details
    Browse the repository at this point in the history
  3. Merge pull request kubernetes-sigs#1856 from shiftstack/subnet-spec

    ✨ Move subnet options to SubnetSpec
    k8s-ci-robot authored Feb 14, 2024
    Configuration menu
    Copy the full SHA
    3c07a7b View commit details
    Browse the repository at this point in the history
  4. Bump Go to 1.22.0

    EmilienM committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    a68d946 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. Merge pull request kubernetes-sigs#1877 from shiftstack/go1.22

    ✨ Bump Go to 1.22.0
    k8s-ci-robot authored Feb 15, 2024
    Configuration menu
    Copy the full SHA
    bd0c05c View commit details
    Browse the repository at this point in the history
  2. Fix cluster network cleanup

    dulek committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    2f3e5f4 View commit details
    Browse the repository at this point in the history
  3. Merge pull request kubernetes-sigs#1880 from shiftstack/cluster-netwo…

    …rk-cleanup
    
    🐛 Fix cluster network cleanup
    k8s-ci-robot authored Feb 15, 2024
    Configuration menu
    Copy the full SHA
    88dcecf View commit details
    Browse the repository at this point in the history
  4. provider: Ignore environment variables

    Users should configure things via a secret, not via environment
    variables.
    
    Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
    stephenfin committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    23e30c7 View commit details
    Browse the repository at this point in the history
  5. Stop serving v1alpha5

    mdbooth committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    d33c1bc View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. Merge pull request kubernetes-sigs#1883 from shiftstack/issues-1881

    🐛 Ignore 'OS_*' environment variables
    k8s-ci-robot authored Feb 16, 2024
    Configuration menu
    Copy the full SHA
    522ed82 View commit details
    Browse the repository at this point in the history
  2. Merge pull request kubernetes-sigs#1888 from shiftstack/deprecations

    ⚠️ Stop serving v1alpha5
    k8s-ci-robot authored Feb 16, 2024
    Configuration menu
    Copy the full SHA
    05abe55 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2024

  1. Configuration menu
    Copy the full SHA
    4eec0e7 View commit details
    Browse the repository at this point in the history
  2. Merge pull request kubernetes-sigs#1889 from shiftstack/nodecidr-docs

    🌱 Fix doc references to NodeCIDR in v1alpha8
    k8s-ci-robot authored Feb 19, 2024
    Configuration menu
    Copy the full SHA
    1b320cb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c51197e View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2024

  1. E2E: Add clusterctl upgrade test for v0.9 -> main

    Signed-off-by: Lennart Jern <lennart.jern@est.tech>
    lentzi90 committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    ce11691 View commit details
    Browse the repository at this point in the history
  2. Merge pull request kubernetes-sigs#1893 from shiftstack/issue_1885

    🐛 e2e: stop testing upgrades from v1alpha5 (v0.6)
    k8s-ci-robot authored Feb 20, 2024
    Configuration menu
    Copy the full SHA
    c6ab0a3 View commit details
    Browse the repository at this point in the history
  3. ⚠ Enforce restricted pod security standards

    We should be able to run with the restricted policy and this will
    inprove our security.
    
    Signed-off-by: Lennart Jern <lennart.jern@est.tech>
    lentzi90 committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    3121d3a View commit details
    Browse the repository at this point in the history
  4. Merge pull request kubernetes-sigs#1895 from Nordix/lentzi90/restrict…

    …ed-pod-security-standards
    
    🌱 Enforce restricted pod security standards
    k8s-ci-robot authored Feb 20, 2024
    Configuration menu
    Copy the full SHA
    5f5f1af View commit details
    Browse the repository at this point in the history
  5. Merge pull request kubernetes-sigs#1862 from elastx/floating_pool_max…

    …_ips
    
    ✨ Adds MaxIPs to OpenstackFloatingIPPool
    k8s-ci-robot authored Feb 20, 2024
    Configuration menu
    Copy the full SHA
    d189b1b View commit details
    Browse the repository at this point in the history
  6. Merge pull request kubernetes-sigs#1894 from Nordix/lentzi90/add-0.9-…

    …upgrade
    
    🌱 E2E: Add clusterctl upgrade test for v0.9 -> main
    k8s-ci-robot authored Feb 20, 2024
    Configuration menu
    Copy the full SHA
    5b2cc5b View commit details
    Browse the repository at this point in the history
  7. AllNodes security groups API

    Co-Authored-By: Emilien Macchi <emilien@redhat.com>
    Co-Authored-By: Matthew Booth <mdbooth@redhat.com>
    3 people committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    418ce3d View commit details
    Browse the repository at this point in the history
  8. Merge pull request kubernetes-sigs#1738 from shiftstack/issue_1714

    🐛 loadbalancer: resolve ControlPlaneEndpoint.Host when needed
    k8s-ci-robot authored Feb 20, 2024
    Configuration menu
    Copy the full SHA
    82b3122 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. Merge pull request kubernetes-sigs#1826 from shiftstack/secGroup-v1beta1

    ✨ AllNodes security groups API
    k8s-ci-robot authored Feb 21, 2024
    Configuration menu
    Copy the full SHA
    fc47622 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c1e0f50 View commit details
    Browse the repository at this point in the history
  3. api/additionalPorts: don't create UDP rules

    When providing additional ports to open on the control plane security
    group, we'll only open TCP from now as it was initially documented.
    
    Opening UDP by default might not be desired for security reasons.
    EmilienM committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    a559017 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    350b7e6 View commit details
    Browse the repository at this point in the history
  5. Merge pull request kubernetes-sigs#1898 from shiftstack/EmilienMreviewer

    Add emilienm to CAPO reviewers
    k8s-ci-robot authored Feb 21, 2024
    Configuration menu
    Copy the full SHA
    2382d56 View commit details
    Browse the repository at this point in the history
  6. Modify OpenStackCluster.Spec.Network API

    For the BYO scenario, when the `OpenStackCluster.Spec.Network`
    is not specified the query to OpenStack would return all the
    Networks available in the cloud and fail the reconciliation.
    To avoid this, if any Subnets were specified under
    `OpenStackCluster.Spec.Subnets` this can be used to identify
    which Network to use.
    MaysaMacedo committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    2e4ca73 View commit details
    Browse the repository at this point in the history
  7. Deprecate v1alpha6

    EmilienM committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    05537fb View commit details
    Browse the repository at this point in the history
  8. Merge pull request kubernetes-sigs#1836 from shiftstack/find-network-…

    …by-subnet
    
    ✨ Modify OpenStackCluster.Spec.Network API
    k8s-ci-robot authored Feb 21, 2024
    Configuration menu
    Copy the full SHA
    029d643 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2024

  1. Merge pull request kubernetes-sigs#1900 from shiftstack/issue_1886

    🌱 Deprecate v1alpha6
    k8s-ci-robot authored Feb 22, 2024
    Configuration menu
    Copy the full SHA
    8801eda View commit details
    Browse the repository at this point in the history
  2. Merge pull request kubernetes-sigs#1892 from shiftstack/issue_1878

    ✨ Move `spec.allowAllInClusterTraffic` to `spec.ManagedSecurityGroups`
    k8s-ci-robot authored Feb 22, 2024
    Configuration menu
    Copy the full SHA
    5cfeccc View commit details
    Browse the repository at this point in the history
  3. e2e: bastion tests

    EmilienM committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    4ff2cf8 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2024

  1. Remove IdentityRef.Kind

    EmilienM committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    fc810d8 View commit details
    Browse the repository at this point in the history
  2. Merge pull request kubernetes-sigs#1822 from shiftstack/issue_1821

    🐛 e2e: bastion tests
    k8s-ci-robot authored Feb 26, 2024
    Configuration menu
    Copy the full SHA
    fd64e36 View commit details
    Browse the repository at this point in the history
  3. Merge pull request kubernetes-sigs#1903 from shiftstack/issue_1882

    🐛 Remove `IdentityRef.Kind`
    k8s-ci-robot authored Feb 26, 2024
    Configuration menu
    Copy the full SHA
    dd85470 View commit details
    Browse the repository at this point in the history
  4. Add support to set allocation_pools for subnet

    This commit adds API that allows users to set `allocations_pools` in the
    subnet created by CAPO. This allows the users to restrict the IP address
    ranges that will be allocated automatically by OpenStack when creating
    Machines.
    
    Users can utilize this to reserve addresses for VIPs (virtual IPs) or
    special nodes that will have predefined addresses and will be created
    later.
    dulek authored and EmilienM committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    ccfcb59 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7ec4c14 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. Allow running individual generate targets

    generate-controller-gen and generate-conversion-gen targets are split
    out of generate-go
    mdbooth committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    3ba8082 View commit details
    Browse the repository at this point in the history
  2. conversion-gen: Fix package name generation

    When conversion-gen has to generate a dependency between 2 input
    packages it uses the value passed to --input-dirs as the package name in
    the generated import. This does not work if that value is a directory
    name. If you specify a package name here instead it works correctly.
    
    We also stop trying to generate conversions for versions which don't
    need them.
    mdbooth committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    4bb8966 View commit details
    Browse the repository at this point in the history
  3. Remove logger from scope

    Scope encapsulates an initialised OpenStack client which can be safely
    shared between reconciles which share the same credentials. The logger
    is initialised with context specific to an individual reconcile, so it
    cannot be shared between reconciles.
    
    To avoid code churn we preserve the previous interface of Scope with the
    creation of scope.WithLogger, which changes the initialisation to ensure
    that the returned logger always comes from the current reconcile even if
    the scope was cached.
    
    While touching logging in tests, we also take the opportunity to replace
    uses of logr.Discard with GinkgoLogr or logr/testr as appropriate, so
    test logs are now captured.
    mdbooth committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    5a1e175 View commit details
    Browse the repository at this point in the history
  4. Merge pull request kubernetes-sigs#1788 from shiftstack/ports

    ✨ Re-work ports management
    k8s-ci-robot authored Feb 27, 2024
    Configuration menu
    Copy the full SHA
    fd37971 View commit details
    Browse the repository at this point in the history
  5. Merge pull request kubernetes-sigs#1847 from shiftstack/allocation-pools

    ✨ Add support to set `allocation_pools` for subnet
    k8s-ci-robot authored Feb 27, 2024
    Configuration menu
    Copy the full SHA
    1b0f1ea View commit details
    Browse the repository at this point in the history
  6. Rename v1alpha8 to v1beta1

    EmilienM committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    e9fb53c View commit details
    Browse the repository at this point in the history
  7. Merge pull request kubernetes-sigs#1902 from shiftstack/issue_1901

    🌱 Rename `v1alpha8` to `v1beta1`
    k8s-ci-robot authored Feb 27, 2024
    Configuration menu
    Copy the full SHA
    634ccc7 View commit details
    Browse the repository at this point in the history
  8. Reduce cyclomatic complexity of ReconcileLoadBalancer

    This function had become genuinely too complex over time, to the point
    that even the linter was starting to complain about it when making
    almost any change.
    
    This change refactors ReconcileLoadBalancer into several smaller logical
    functions which are much easier to read and reason about. It also
    revealed some trivial optimisations:
    * Only fetch Octavia providers if we need them to create a new
      loadbalancer
    * Only calculate allowed CIDRs once
    * Don't re-fetch a loadbalancer to check it's active if it's already
      active
    
    Co-Authored-By: Emilien Macchi <emacchi@redhat.com>
    mdbooth and EmilienM committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    e8ccd21 View commit details
    Browse the repository at this point in the history
  9. Merge pull request kubernetes-sigs#1911 from shiftstack/conversion-gen

    🌱 Enhancements to how controller-gen is invoked
    k8s-ci-robot authored Feb 27, 2024
    Configuration menu
    Copy the full SHA
    c0b54d0 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. Merge pull request kubernetes-sigs#1904 from shiftstack/ReconcileLoad…

    …Balancer
    
    🌱 Reduce cyclomatic complexity of ReconcileLoadBalancer
    k8s-ci-robot authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    05d4e9b View commit details
    Browse the repository at this point in the history
  2. Merge pull request kubernetes-sigs#1913 from shiftstack/issue1840

    🐛 Remove logger from scope
    k8s-ci-robot authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    0c5f230 View commit details
    Browse the repository at this point in the history
  3. Reduce cyclomatic complexity of reconcileNetworkComponents

    This change refactors reconcileNetworkComponents into several smaller
    logical functions which are easier to read and reason about.
    
    It also makes the gocyclo linter happy when making new changes to this
    code.
    
    Co-Authored-By: Emilien Macchi <emacchi@redhat.com>
    mdbooth and EmilienM committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    268645a View commit details
    Browse the repository at this point in the history
  4. Merge pull request kubernetes-sigs#1905 from shiftstack/reconcileNetw…

    …orkComponents
    
    🌱 Reduce cyclomatic complexity of reconcileNetworkComponents
    k8s-ci-robot authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    a405eeb View commit details
    Browse the repository at this point in the history
  5. Add API reference documentation generation

    Signed-off-by: alexandre.vilain <alexandre.vilain@corp.ovh.com>
    alexandrevilain committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    af5545c View commit details
    Browse the repository at this point in the history
  6. Merge pull request kubernetes-sigs#1702 from alexandrevilain/docs/add…

    …-api-reference
    
    📖 Add API reference documentation generation
    k8s-ci-robot authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    36e94d9 View commit details
    Browse the repository at this point in the history
  7. Merge pull request kubernetes-sigs#1899 from shiftstack/issue_1704

    🐛 api/additionalPorts: don't create UDP rules
    k8s-ci-robot authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    7b202d1 View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. API cleanup of PortOpts

    Internally, all optional fields become pointers. This change has no
    direct effect on the CRD, but means that unset values and zero values
    now have different meanings.
    
    SecurityGroupFilters is renamed to SecurityGroups for consistency with
    other filter fields used throughout the API. Note that this change
    thoroughly confuses conversion-gen. Consequently we explicitly disable
    the conversion of these fields in v1alpha6 and v1alpha5 and do the
    conversion entirely manually.
    mdbooth authored and EmilienM committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    4c01e65 View commit details
    Browse the repository at this point in the history
  2. Merge pull request kubernetes-sigs#1914 from shiftstack/portOptsCleanup

    ⚠️ API cleanup of PortOpts
    k8s-ci-robot authored Feb 29, 2024
    Configuration menu
    Copy the full SHA
    9e00969 View commit details
    Browse the repository at this point in the history
  3. Move CloudName into IdentityRef and make cluster IdentityRef required

    This change came from attempting to write validation markers for
    CloudName and IdentityRef in both the machine and cluster specs.
    
    Firstly I noticed that IdentityRef was marked optional in the cluster
    spec, but it is certainly required: the cluster cannot be provisioned
    without cloud credentials. I made IdentityRef required in the cluster
    spec.
    
    In contrast, IdentityRef is genuinely optional in the machine spec
    because, if not specified, we will use the credentials defined in the
    cluster spec.
    
    CloudName on the machine spec is also marked optional. However, it is
    required if IdentityRef was specified. This is because it refers to the
    same object as IdentityRef. The most sensible way to to represent this
    in the API is to put it in the IdentityRef. This means that if
    IdentityRef is provided, it must be provided completely, including
    CloudName.
    mdbooth committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    564b6bd View commit details
    Browse the repository at this point in the history
  4. Merge pull request kubernetes-sigs#1915 from shiftstack/cloudName

    ⚠️Move CloudName into IdentityRef and make cluster IdentityRef required
    k8s-ci-robot authored Feb 29, 2024
    Configuration menu
    Copy the full SHA
    c4fe920 View commit details
    Browse the repository at this point in the history
  5. Transform neutron filter tags into slices

    Co-Authored-By: Matthew Booth <mbooth@redhat.com>
    EmilienM and mdbooth committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    7927f65 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. Configuration menu
    Copy the full SHA
    412cae3 View commit details
    Browse the repository at this point in the history
  2. Update ginkgo to 2.15.0

    mdbooth committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    c2e8b49 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    120bc68 View commit details
    Browse the repository at this point in the history
  4. tests: Add TEST_PATHS target for make test

    TEST_PATHS defaults to the previous hardcoded value of './...', but can
    now be overridden. e.g. To run just the controller tests:
    
      make test TEST_PATHS=./controllers/...
    mdbooth committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    a4e2079 View commit details
    Browse the repository at this point in the history
  5. Merge pull request kubernetes-sigs#1916 from shiftstack/fixCloudname

    🐛 ci: fix upgrades by dropping cloudName
    k8s-ci-robot authored Mar 1, 2024
    Configuration menu
    Copy the full SHA
    645741c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    8533ef5 View commit details
    Browse the repository at this point in the history
  7. Merge pull request kubernetes-sigs#1909 from shiftstack/tags

    Transform neutron filter tags into lists
    k8s-ci-robot authored Mar 1, 2024
    Configuration menu
    Copy the full SHA
    0f02b30 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    4d3e79c View commit details
    Browse the repository at this point in the history
  9. Merge pull request kubernetes-sigs#1918 from elastx/fix-crash-additon…

    …al-ports
    
    🐛 Make LB additional ports security-group generation are dynamic
    k8s-ci-robot authored Mar 1, 2024
    Configuration menu
    Copy the full SHA
    1cb5d53 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2024

  1. Move webhooks into pkg/webhooks

    Moves webhooks from api to pkg/webhooks making only mechanical code
    changes except for the removal of the defaulting webhooks, because they
    weren't used. This results in there now being no mutating webhook
    configured.
    mdbooth committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    750b84d View commit details
    Browse the repository at this point in the history
  2. Register API versions with test scheme in validation tests

    The conversion webhook does not try to register conversions for versions
    which are not present in the scheme.
    mdbooth committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    13e95db View commit details
    Browse the repository at this point in the history
  3. Implement convertible for OpenStackClusterTemplateList

    The conversion webhook fails to register without this.
    mdbooth committed Mar 2, 2024
    Configuration menu
    Copy the full SHA
    cb09d5f View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2024

  1. Merge pull request kubernetes-sigs#1919 from shiftstack/apivalidation…

    …tests
    
    ✨ Add API validation test framework
    k8s-ci-robot authored Mar 4, 2024
    Configuration menu
    Copy the full SHA
    23b9f34 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. Split v1alpha6&v1alpha7 conversion into multiple files

    This is 100% code motion with no code changes whatsoever.
    
    conversion.go has become unwieldy, making changes to it harder to
    understand. This simply splits it into several files based on the
    corresponding _types.go.
    
    We don't touch v1alpha5 as it's about to be deleted. It can stay a mess.
    mdbooth committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    1eca090 View commit details
    Browse the repository at this point in the history
  2. Merge pull request kubernetes-sigs#1920 from shiftstack/webhooks

    🌱 Move webhooks into pkg/webhooks
    k8s-ci-robot authored Mar 5, 2024
    Configuration menu
    Copy the full SHA
    e6bb34f View commit details
    Browse the repository at this point in the history
  3. v1alpha7 restorev1beta1ClusterSpec should not restore Bastion

    The bastion has a separate restorer.
    mdbooth committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    392edfd View commit details
    Browse the repository at this point in the history
  4. v1alpha6: Simplify v1alpha6 cluster restorer

    This is a breaking change, although it should not have any negative
    effects in practise.
    
    The v1alpha6 cluster restorer had become too complex with too many
    individual fields. This change reduces the number of fields to be
    consistent with the v1alpha7 restorer.
    
    With this change, an object stored as v1alpha6 with previous v1beta1
    annotations could have fields in its spec restored to a semantically
    equivalent but slightly different serialisation when converted to
    v1beta1. Differences in the bastion and status are not affected.
    
    In practise this should not matter for 2 reasons:
    * The storage version is v1beta1, so the annotation should have been
      freshly generated in the new format anyway.
    * Even if it were not, and the v1alpha6 were under external control, the
      external controller would observe a difference and restore it to the
      previous version. It would then converted again with the new
      annotation.
    
    Note that if the object is not under external control these differences
    don't matter anyway.
    mdbooth committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    a81ef96 View commit details
    Browse the repository at this point in the history
  5. Merge pull request kubernetes-sigs#1923 from shiftstack/conversion_cl…

    …eanup
    
    🌱 Split v1alpha6 & v1alpha7 conversion into multiple files
    k8s-ci-robot authored Mar 5, 2024
    Configuration menu
    Copy the full SHA
    af6dbae View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. Merge pull request kubernetes-sigs#1925 from shiftstack/simple_cluste…

    …r_restore
    
    ⚠️ Simplify v1alpha6 cluster restorer
    k8s-ci-robot authored Mar 6, 2024
    Configuration menu
    Copy the full SHA
    d76b07d View commit details
    Browse the repository at this point in the history
  2. Fix CRD generation

    When moving the webhooks we didn't separate CRD generation from webhook
    generation, meaning controller-gen was looking for CRDs to generate in
    pkg/webhook. This resulted in CRDs not being generated.
    mdbooth committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    30ba121 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9fb6072 View commit details
    Browse the repository at this point in the history
  4. Move filter conversions out of /api

    Removes a gophercloud dependency for consumers of the API.
    mdbooth committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    d33fee8 View commit details
    Browse the repository at this point in the history
  5. Allow generating api-docs for individual versions

    This change creates separate targets for individual API targets when
    generating api documentation. The generate-api-docs target continues to
    execute all of them as before.
    mdbooth committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    1734ebb View commit details
    Browse the repository at this point in the history
  6. Merge pull request kubernetes-sigs#1929 from shiftstack/apidoc-gen

    🌱 Allow generating api-docs for individual versions
    k8s-ci-robot authored Mar 6, 2024
    Configuration menu
    Copy the full SHA
    b4670cb View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. Rename fields to correctly do uppercase acronyms

    K8s API conventions require the acronyms in the field names to be
    uppercase if not being the first word in the name. We aren't following
    this in several places and this commit fixes these occurrences:
    
    * `projectId` becomes `projectID`
    * `gateway_ip` becomes `gatewayIP`
    * `ipv6RaMode` becomes `ipv6RAMode`
    * `networkMtu` becomes `networkMTU`
    * `hostId` becomes `hostID`
    * `allowedCidrs` becomes `allowedCIDRs`
    dulek committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    c7c5baf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    968df70 View commit details
    Browse the repository at this point in the history
  3. Merge pull request kubernetes-sigs#1934 from shiftstack/fix-serializa…

    …tions
    
    ⚠️ Rename fields to correctly do uppercase acronyms
    k8s-ci-robot authored Mar 7, 2024
    Configuration menu
    Copy the full SHA
    47f0c1b View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. Merge pull request kubernetes-sigs#1932 from shiftstack/externalnet

    🐛 CI: Specify external network by name
    k8s-ci-robot authored Mar 8, 2024
    Configuration menu
    Copy the full SHA
    381263d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    000b67d View commit details
    Browse the repository at this point in the history
  3. Merge pull request kubernetes-sigs#1935 from shiftstack/junit

    ✨ Add junit output to e2e tests
    k8s-ci-robot authored Mar 8, 2024
    Configuration menu
    Copy the full SHA
    4ece380 View commit details
    Browse the repository at this point in the history
  4. Merge pull request kubernetes-sigs#1924 from shiftstack/filter_convert

    🌱 Move filter conversions out of /api
    k8s-ci-robot authored Mar 8, 2024
    Configuration menu
    Copy the full SHA
    300c45c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0caecf4 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    cc32a8a View commit details
    Browse the repository at this point in the history
  7. make nil resource filters ToListOpts() return empty ListOpts

    This makes the behaviour slightly more ergonomic and safer as we turn
    these into pointers.
    mdbooth committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    7a0e942 View commit details
    Browse the repository at this point in the history
  8. Make NetworkFilter.IsEmpty() return true on nil receiver

    This improves safety and ergonomics checking it when NetworkFilter can be be a
    pointer type.
    mdbooth committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    cdc16d2 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    2d96db6 View commit details
    Browse the repository at this point in the history
  10. OpenStackCluster: Set explicit listType=atomic

    For non-mergeable list types, make the default 'atomic' behaviour
    explicit.
    mdbooth committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    75079c7 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    ffbfd40 View commit details
    Browse the repository at this point in the history
  12. OpenStackClusterSpec: ExternalNetwork->pointer

    ExternalNetwork was already marked optional. This change allows it to be
    omitted when marshalling and unmarshalling the object in Go.
    
    This change also adds the 'external' flag when executing an explicit
    external network query.
    mdbooth committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    e39c730 View commit details
    Browse the repository at this point in the history
  13. OpenStackClusterSpec: ApiServerLoadBalancer->pointer

    Affects go marshalling only.
    mdbooth committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    e5d9630 View commit details
    Browse the repository at this point in the history
  14. OpenStackClusterSpec: APIServerFloatingIP, APIServerFixedIP, APIServe…

    …rPort->optional
    
    Affects go marshalling only.
    mdbooth committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    2c7b44b View commit details
    Browse the repository at this point in the history
  15. OpenStackClusterSpec: scalar fields to optional types

    The following types become a corresponding optional type:
    * NetworkMTU
    * DisableExternalNetwork
    * DisableAPIServerFloatingIP
    * DisablePortSecurity
    * ControlPlaneOmitAvailabilityZone
    mdbooth committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    9223883 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    70bfdaf View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    e6a194b View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. Merge pull request kubernetes-sigs#1930 from shiftstack/openstackclus…

    …ter_apicleanup
    
    ⚠️ OpenStackCluster api general cleanup
    k8s-ci-robot authored Mar 11, 2024
    Configuration menu
    Copy the full SHA
    8d70c19 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    44d4732 View commit details
    Browse the repository at this point in the history
  3. Cleanup APILoadBalancer

    Enabled now defaults to true. Provider becomes optional.String.
    mdbooth committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    470d30b View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. Merge pull request kubernetes-sigs#1937 from shiftstack/openstackclus…

    …ter_apicleanup
    
    ⚠️ Cleanup APILoadBalancer
    k8s-ci-robot authored Mar 12, 2024
    Configuration menu
    Copy the full SHA
    2074438 View commit details
    Browse the repository at this point in the history
  2. Rename Ports fields in status

    The json field names were unnecessarily leaking the internal name of a
    struct.
    mdbooth committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    4afdb80 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7dce82c View commit details
    Browse the repository at this point in the history
  4. Merge pull request kubernetes-sigs#1938 from shiftstack/openstackclus…

    …ter_apicleanup
    
    🌱 Rename Ports fields in status
    k8s-ci-robot authored Mar 12, 2024
    Configuration menu
    Copy the full SHA
    654d714 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. ImageFilter - add validations, switch to pointers

    This commit changes `ID` and `Name` of `ImageFilter` to pointers which
    should only affect go marshalling.
    
    Other than that it adds CEL validation of the ImageFilter, so that Name
    or Tags can only be set when ID is unset. Conversions are updated
    accordingly to make sure we only set Name when ID is unset.
    
    Moreover validation is added that ID has to be UUID. It's not enforced
    in conversions, as non-UUID IDs would produce clusters or machines that
    would not work properly.
    dulek committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    a00fa80 View commit details
    Browse the repository at this point in the history
  2. Add ImageFilter API validations

    This adds tests related to kubebuilder validations of ImageFilter.
    dulek committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    dc3959e View commit details
    Browse the repository at this point in the history
  3. test: bump Flatcar version

    Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
    tormath1 committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    f79fdf8 View commit details
    Browse the repository at this point in the history
  4. Templates: Set provider ID directly via kubelet

    This commit sets the provider ID in the flatcar templates.
    To avoid issues with potential mismatches between node names and
    openstack servers we can configure the kubelet to set the provider ID.
    Otherwise, the cloud controller will try to match nodes and servers
    based on just the name. The names can differ because of special
    characters, like dots. When this happens, the cloud controller will be
    unable to match them and thus believe that the node has no underlying
    server.
    
    Co-authored-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
    lentzi90 and tormath1 committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    957c9fc View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    559cbf2 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. Merge pull request kubernetes-sigs#1949 from shiftstack/issue1948

    🐛 v1alpha5: Fix panic in conversion when port has no binding profile
    k8s-ci-robot authored Mar 15, 2024
    Configuration menu
    Copy the full SHA
    4ab8b3a View commit details
    Browse the repository at this point in the history
  2. Merge pull request kubernetes-sigs#1939 from shiftstack/filters-pointers

    ⚠️ ImageFilter - add exclusive validation -> pointers
    k8s-ci-robot authored Mar 15, 2024
    Configuration menu
    Copy the full SHA
    e7d0e19 View commit details
    Browse the repository at this point in the history
  3. Merge pull request kubernetes-sigs#1762 from elastx/floating_ip_from_…

    …pool
    
    ✨ Adds IPAM support for floating ips in OpenStackMachine
    k8s-ci-robot authored Mar 15, 2024
    Configuration menu
    Copy the full SHA
    f6fb753 View commit details
    Browse the repository at this point in the history
  4. Fix port name after port creation failure

    CreatePorts was creating a port name based on the index of the port in
    the *current reconcile*. This could be different to the absolute index
    of the port if ports had been partially created in a previous reconcile.
    
    We fix this by passing all current state into CreatePorts so it can
    create an absolute index. This also ensures that partially created ports
    will be persisted on failure so we don't have to rely on adoption in the
    next reconcile.
    mdbooth committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    cc78607 View commit details
    Browse the repository at this point in the history
  5. Simplify bastion resource initialisation

    Firstly, we remove the resource reconcile calls from the cluster flow
    before calling reconcileNormal/reconcileDelete because the guards around
    them and various other guards throughout the code are heavily
    inter-depdendent and hard to reason about. Instead, we push them to the
    the places we:
    * know they are required
    * know we are sufficiently initialised that they can work
    
    Firstly we resolve references at the top of reconcileBastion. We know
    the cluster has been initialised at this point, so we don't need to
    guard against it. This also means that it is always called when entering
    that function, so we don't need to guard against it not having been
    called during first cluster initialisation.
    
    We also force that function to re-reconcile if it calls deleteBastion(),
    because deleteBastion() removes the bastion status. We reconcile again,
    so we always know that it is set.
    
    We also add an explicit call to resource reconcile in the
    reconcileDelete flow. This is the only place we now need a 'weird' guard
    against the cluster network not having been set. We add a comment about
    that appropriate to its weirdness.
    mdbooth committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    801f5ef View commit details
    Browse the repository at this point in the history
  6. Merge pull request kubernetes-sigs#1936 from tormath1/tormath1/flatcar

    test: bump Flatcar version
    k8s-ci-robot authored Mar 15, 2024
    Configuration menu
    Copy the full SHA
    0aa2205 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2024

  1. Merge pull request kubernetes-sigs#1941 from shiftstack/issue1940

    🐛 Fix port name after port creation failure
    k8s-ci-robot authored Mar 16, 2024
    Configuration menu
    Copy the full SHA
    6b87daf View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2024

  1. Fix accidental parsing of password

    When clouds.yaml gets parsed by `env.rc`, the `yq` command
    is accidentally parsing the contents of the password
    variable.
    
    Under most circumstances the password contents is detected
    correctly as a string. This fixes failures when the
    password is accidentally parseable as a yaml structure.
    
    More info at:
    https://mikefarah.gitbook.io/yq/operators/env-variable-operators
    JanGutter committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    acd9297 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. Merge pull request kubernetes-sigs#1953 from JanGutter/fix-env-rc-pas…

    …sword-quoting
    
    🐛  Fix accidental parsing of password
    k8s-ci-robot authored Mar 18, 2024
    Configuration menu
    Copy the full SHA
    c1fc60d View commit details
    Browse the repository at this point in the history
  2. Fix a race when updating status before reconcile completes

    We were ignoring any update which only touched the status. This code has
    been there an extremely long time, and was originally copied from CAPA.
    Unfortunately this introduces a race for recently added code which sets
    port status and exits the reconcile early for transactional safety.
    mdbooth committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    6f8ac4f View commit details
    Browse the repository at this point in the history
  3. Merge pull request kubernetes-sigs#1955 from shiftstack/issue1954

    🐛 Fix a race when updating status before reconcile completes
    k8s-ci-robot authored Mar 18, 2024
    Configuration menu
    Copy the full SHA
    67fa7b7 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. Deduplicate AdoptMachinePorts and AdoptBastionPorts

    Both of these methods rely on ReferencedMachineResources and
    DependentMachineResources, so they can be easily refactored to have a
    common implementation.
    mdbooth committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    567469e View commit details
    Browse the repository at this point in the history
  2. Don't re-reconcile when adopting resources

    Unlike referenced resources, which specify a future intent, adoption
    only affects resources which have already been created. Successive
    executions will produce the same output, so there is no need to
    re-reconcile if we found orphaned resources.
    
    Also we seem to be hitting this a lot in practise, most likely due to
    the controller-runtime read-after-write cache inconsistency issue.
    mdbooth committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    ad00c64 View commit details
    Browse the repository at this point in the history
  3. Fix premature attempt to resolve machine resources

    We can't resolve machine resources until the cluster is initialised.
    mdbooth committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    750af59 View commit details
    Browse the repository at this point in the history
  4. Merge pull request kubernetes-sigs#1944 from shiftstack/issue1942

    🌱 Deduplicate AdoptMachinePorts and AdoptBastionPorts
    k8s-ci-robot authored Mar 19, 2024
    Configuration menu
    Copy the full SHA
    27b3cef View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c4e5c2a View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. Update FloatingIPPool to use v1beta1

    Also make IdentityRef required, as it doesn't currently permit fallback
    to cluster credentials.
    mdbooth committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    24b7961 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4cd4e9f View commit details
    Browse the repository at this point in the history
  3. Merge pull request kubernetes-sigs#1957 from shiftstack/securitygroup…

    …rules
    
    ⚠️ Remove security group rules from status
    k8s-ci-robot authored Mar 20, 2024
    Configuration menu
    Copy the full SHA
    10b1ff4 View commit details
    Browse the repository at this point in the history
  4. API: Cleanup Bastion

    This commit works with .spec.bastion:
    * makes availablityZone, floatingIP and instance pointers
    * adds floatingIP IPv4 validation
    * adds validation that if Bastion is enabled, instance cannot be null
    dulek committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    ffa82b3 View commit details
    Browse the repository at this point in the history
  5. Rename Bastion.Instance to Bastion.Spec

    Bastion.Spec is way more descriptive and it suggests it's an
    OpenStackMachineSpec.
    dulek committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    c321574 View commit details
    Browse the repository at this point in the history
  6. Merge pull request kubernetes-sigs#1963 from shiftstack/gitattributes

    🌱 Add .gitattributes to identify generated files to GitHub
    k8s-ci-robot authored Mar 20, 2024
    Configuration menu
    Copy the full SHA
    66d93db View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    ad3fd18 View commit details
    Browse the repository at this point in the history
  8. Merge pull request kubernetes-sigs#1962 from shiftstack/floatingipv1b…

    …eta1
    
    🌱 Update FloatingIPPool to use v1beta1
    k8s-ci-robot authored Mar 20, 2024
    Configuration menu
    Copy the full SHA
    99f3a60 View commit details
    Browse the repository at this point in the history
  9. Merge pull request kubernetes-sigs#1964 from shiftstack/servermetadata

    🐛 Fix server metadata length validation
    k8s-ci-robot authored Mar 20, 2024
    Configuration menu
    Copy the full SHA
    9809a60 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    c6efdea View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. Configuration menu
    Copy the full SHA
    61b0560 View commit details
    Browse the repository at this point in the history
  2. Merge pull request kubernetes-sigs#1966 from shiftstack/upgradefix

    🐛 Revert accidental update to previous API templates
    k8s-ci-robot authored Mar 21, 2024
    Configuration menu
    Copy the full SHA
    2b03429 View commit details
    Browse the repository at this point in the history
  3. Store []ResolvedPortSpec in ReferencedMachineResources

    The purpose of this change is fix an issue where we are storing
    unresolved references in ReferencedMachineResources. Specifically we are
    storing a PortOpts, which is a user-intent struct. PortOpts can contain
    unresolved references to both subnets and security groups, as well
    fields requiring additional processing which reference external objects:
    the port name, description, and tags.
    
    We create a new type, ResolvedPortSpec, which can contain only fully
    resolved data. This can be seen in the new signature of CreatePorts(),
    which no longer requires any source of data other than the
    []ResolvedPortSpec from ReferencedMachineResources, and is now greatly
    simplified.
    
    Fully resolving the port name also allows a simplification in port
    adoption.
    
    All of the complexity now moves to ConstructPorts(), which is updated to
    return []ResolvedPortSpec instead of []PortOpts. ConstructPorts() is
    updated to resolve security groups, port name, description, and all
    subnets referenced in FixedIPs.
    mdbooth committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    8017c89 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2024

  1. Configuration menu
    Copy the full SHA
    b6d7748 View commit details
    Browse the repository at this point in the history
  2. Merge pull request kubernetes-sigs#1951 from shiftstack/issue1943

    ⚠️ Store []ResolvedPortSpec in ReferencedMachineResources
    k8s-ci-robot authored Mar 22, 2024
    Configuration menu
    Copy the full SHA
    cb99e17 View commit details
    Browse the repository at this point in the history
  3. Rename DependentResources to Resources

    The intent of this structure is to hold all OpenStack resources created
    for the machine, including the server. 'dependent' was redundant.
    mdbooth committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    5f09ba2 View commit details
    Browse the repository at this point in the history
  4. Rename ReferencedResources to Resolved

    This struct has already moved beyond external references, and seems be
    evolving towards a fully-resolved machine spec. For want of a better
    name we call it 'resolved', which is more accurate.
    mdbooth committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    5d11950 View commit details
    Browse the repository at this point in the history
  5. Merge pull request kubernetes-sigs#1965 from shiftstack/machineresources

    🌱 Rename referencedResources and dependentResources
    k8s-ci-robot authored Mar 22, 2024
    Configuration menu
    Copy the full SHA
    59689c9 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. Configuration menu
    Copy the full SHA
    2758a6d View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. Merge pull request kubernetes-sigs#1967 from shiftstack/machineresour…

    …cespointers
    
    ⚠️ Resolved and Resources become optional pointer types
    k8s-ci-robot authored Mar 26, 2024
    Configuration menu
    Copy the full SHA
    ec77c18 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. Consolidate and fix v1beta1 fuzzer funcs

    Firstly this change consolidates common fuzzer funcs for fuzzing v1beta1
    between v1alpha6 and v1alpha7.
    
    Secondly, we fix a couple of bugs where we were generating invalid
    output:
    
    In OpenStackClusterSpec we were creating a second subnet with
    FuzzNoCustom, which doesn't use our custom functions for generating
    valid output.
    
    When generating filters we were appending a second tag after
    validating tags, which meant we occasionally got invalid tags. We now
    add tags before validation, and also add tags to all tag fields instead
    of just 'Tags'. We also consolidate tag validation in a
    FilterByNeutronTags func instead of individually for each Filter.
    mdbooth committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    26e8c07 View commit details
    Browse the repository at this point in the history
  2. Merge pull request kubernetes-sigs#1981 from shiftstack/issue1980

    🐛 Consolidate and fix v1beta1 fuzzer funcs
    k8s-ci-robot authored Mar 28, 2024
    Configuration menu
    Copy the full SHA
    eace85b View commit details
    Browse the repository at this point in the history
  3. NetworkFilter to NetworkParam

    mdbooth committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    73c81de View commit details
    Browse the repository at this point in the history
  4. SubnetFilter to SubnetParam

    mdbooth committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    4d85f6f View commit details
    Browse the repository at this point in the history
  5. Merge pull request kubernetes-sigs#1972 from shiftstack/networkparam

    ⚠️ NetworkFilter to NetworkParam
    k8s-ci-robot authored Mar 28, 2024
    Configuration menu
    Copy the full SHA
    1d5d2d5 View commit details
    Browse the repository at this point in the history
  6. Merge pull request kubernetes-sigs#1971 from shiftstack/subnetparam

    ⚠️ SubnetFilter to SubnetParam
    k8s-ci-robot authored Mar 28, 2024
    Configuration menu
    Copy the full SHA
    de29a18 View commit details
    Browse the repository at this point in the history
  7. Add fuzz tests for v1alpha5 conversion

    Unlike the v1alpha6 and v1alpha7 tests, these only test if the
    conversion causes a panic. It found 1 panic, which is also fixed here.
    mdbooth committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    3cea05d View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2024

  1. Merge pull request kubernetes-sigs#1984 from shiftstack/v1alpha5panics

    🐛 Add fuzz tests for v1alpha5 conversion
    k8s-ci-robot authored Mar 29, 2024
    Configuration menu
    Copy the full SHA
    4a5cd42 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    865933d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    91669cf View commit details
    Browse the repository at this point in the history
  4. ImageFilter to ImageParam

    mdbooth committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    44be48e View commit details
    Browse the repository at this point in the history
  5. RouterFilter to RouterParam

    mdbooth committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    5c3fe97 View commit details
    Browse the repository at this point in the history
  6. Merge pull request kubernetes-sigs#1974 from shiftstack/securitygroup…

    …param
    
    ⚠️SecurityGroupFilter to SecurityGroupParam
    k8s-ci-robot authored Mar 29, 2024
    Configuration menu
    Copy the full SHA
    52652d3 View commit details
    Browse the repository at this point in the history
  7. Merge pull request kubernetes-sigs#1970 from shiftstack/imageparam

    ⚠️ Split ImageFilter into ImageParam
    k8s-ci-robot authored Mar 29, 2024
    Configuration menu
    Copy the full SHA
    e32bcc2 View commit details
    Browse the repository at this point in the history
  8. Merge pull request kubernetes-sigs#1978 from shiftstack/routerparam

    ⚠️ RouterFilter to RouterParam
    k8s-ci-robot authored Mar 29, 2024
    Configuration menu
    Copy the full SHA
    4e2150f View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2024

  1. Fix v1alpha7 machine restorer and test

    The v1alpha7 machine spec restorer was missing the exclusion for
    ProviderID and InstanceID was missing, and the test which was supposed
    to ensure it worked was broken. This fixes both.
    mdbooth committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    a2ba9c5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5c1ad44 View commit details
    Browse the repository at this point in the history
  3. Merge pull request kubernetes-sigs#1987 from shiftstack/issue1986

    🐛 Fix v1alpha7 machine restorer and test
    k8s-ci-robot authored Apr 1, 2024
    Configuration menu
    Copy the full SHA
    85ed836 View commit details
    Browse the repository at this point in the history
  4. Bastion is enabled by default if specified

    Bastion.Enabled is a wart. Ideally it would not be required, but because
    of limitations in how we delete the bastion we require an intermediate
    'disabled' step before removal. Ultimately we intend to remove this
    limitation.
    
    Eventually we would like to be able to ignore enabled entirely. e.g. To
    create a Bastion just specify it:
    
    ```yaml
    spec:
      bastion:
        spec:
          ...
        floatingIP: x.x.x.x
    ```
    
    and to delete it just remove the bastion field.
    
    Right now with enabled defaulting to `false`, doing the above will not
    result in the creation of a bastion, because enabled must be explicitly
    set to true.
    
    Paving the way for the eventual deprecation of Bastion.Enabled, we
    change the default value of enabled to be true so the above does today
    what we eventually want it to do. This is also generally more intuitive:
    why would you include a bastion and a spec if you didn't want to create
    a bastion? Having to also set enabled to true is currently a trip
    hazard.
    
    Until we resolve the limitations of bastion deletion, though, we still
    need to be able to disable the bastion. For this case enabled can be
    explicitly set to false.
    
    In the future when we remove the requirement to disable the bastion
    before deletion the user can simply ignore Bastion.Enabled, which will
    continue to work but without the limitations.
    mdbooth committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    7dd2c35 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. Merge pull request kubernetes-sigs#1990 from shiftstack/bastionenabled

    ⚠️ Bastion is enabled by default if specified
    k8s-ci-robot authored Apr 2, 2024
    Configuration menu
    Copy the full SHA
    a6732bc View commit details
    Browse the repository at this point in the history
  2. Merge pull request kubernetes-sigs#1988 from shiftstack/instanceidsta…

    …tus2
    
    ⚠️ Move InstanceID from Spec to Status
    k8s-ci-robot authored Apr 2, 2024
    Configuration menu
    Copy the full SHA
    4c162b6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8ea3ccf View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    de0dffa View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2901efe View commit details
    Browse the repository at this point in the history
  6. Merge pull request kubernetes-sigs#1989 from shiftstack/morefuzz

    🐛 Fix multiple panics in restore functions
    k8s-ci-robot authored Apr 2, 2024
    Configuration menu
    Copy the full SHA
    f5b0181 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    7c0d741 View commit details
    Browse the repository at this point in the history
  8. Merge pull request kubernetes-sigs#1991 from shiftstack/servergroupparam

    ⚠️ ServerGroupFilter to ServerGroupParam
    k8s-ci-robot authored Apr 2, 2024
    Configuration menu
    Copy the full SHA
    e636957 View commit details
    Browse the repository at this point in the history
  9. Merge pull request kubernetes-sigs#1982 from shiftstack/filterparamdocs

    📖 Document changes to Filters
    k8s-ci-robot authored Apr 2, 2024
    Configuration menu
    Copy the full SHA
    0990569 View commit details
    Browse the repository at this point in the history
  10. Add API docs for v1alpha1

    mdbooth committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    8fe2114 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    ed829b3 View commit details
    Browse the repository at this point in the history
  12. Merge pull request kubernetes-sigs#1993 from shiftstack/v1alpha1docs

    ✨ Add API docs for v1alpha1
    k8s-ci-robot authored Apr 2, 2024
    Configuration menu
    Copy the full SHA
    17daeca View commit details
    Browse the repository at this point in the history
  13. Merge pull request kubernetes-sigs#1994 from shiftstack/v10-metadata

    🌱 Bump version artifacts for release-0.10
    k8s-ci-robot authored Apr 2, 2024
    Configuration menu
    Copy the full SHA
    79fcb6a View commit details
    Browse the repository at this point in the history
  14. Merge pull request kubernetes-sigs#1992 from shiftstack/v1alpha7cruft

    🌱 Remove legacy v1alpha7 filterconvert utils
    k8s-ci-robot authored Apr 2, 2024
    Configuration menu
    Copy the full SHA
    acc680d View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. make floatingIPNetwork a pointer and if there's only one external

    network use it as default
    bilbobrovall committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    9c66684 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    df19807 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. Rules are optional in security group rules before v1beta1

    Rules were removed from the security group status in v1beta1. If the
    status is modified then an up-converted v1alphaN object will not have
    its security group rules restored on down-conversion. As the CRD
    requires rules, this results in an API error.
    mdbooth committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    f747456 View commit details
    Browse the repository at this point in the history
  2. Merge pull request kubernetes-sigs#2000 from shiftstack/issue1999

    🐛 Rules are optional in security group rules before v1beta1
    k8s-ci-robot authored Apr 4, 2024
    Configuration menu
    Copy the full SHA
    78f7b3f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    55918b1 View commit details
    Browse the repository at this point in the history
  4. API validations: cleanup objects after creation

    * Adds a helper function which registers a cleanup helper if an object
      was created
    * Moves infrav1 tests under a separate context in anticipation of adding
      other version tests.
    mdbooth committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    038c11f View commit details
    Browse the repository at this point in the history
  5. Fix API conversion webhooks in the apivalidation tests

    API versions must be registered in the scheme before starting the
    envtest in order for conversion webhooks to be registered.
    mdbooth committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    c59ee80 View commit details
    Browse the repository at this point in the history
  6. Merge pull request kubernetes-sigs#1998 from elastx/issue#1997

    🐛 Make floatingIPNetwork a pointer and if there's only one external network use it as default
    k8s-ci-robot authored Apr 4, 2024
    Configuration menu
    Copy the full SHA
    d2d1cb2 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. Configuration menu
    Copy the full SHA
    fe80a3f View commit details
    Browse the repository at this point in the history
  2. Merge pull request kubernetes-sigs#2001 from shiftstack/validationtes…

    …tcleanups
    
    🌱 Minor improvements to api validation tests
    k8s-ci-robot authored Apr 5, 2024
    Configuration menu
    Copy the full SHA
    b7a6685 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. feat: add configurable loadbalancer network

    Previously when loadbalacer was created it used the same network/subnet as the
    control plane nodes for the VIP. This was not always the right assumption as some
    users might want to be able to customize this according to their env.
    
    This commit fixes the above by adding two fields into
    OpenStackClusterSpec/Status two fields `network` and `subnets` under
    `APIServerLoadBalancer` so that user can define which network/subnet
    to use for allocation of the loadbalancer.
    
    Signed-off-by: Ondrej Blazek <ondrej.blazek@firma.seznam.cz>
    oblazek committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    e2897fb View commit details
    Browse the repository at this point in the history
  2. Merge pull request kubernetes-sigs#2003 from shiftstack/docs_migratio…

    …n_instanceid
    
    📖 Document the change of instanceID in v1beta1
    k8s-ci-robot authored Apr 8, 2024
    Configuration menu
    Copy the full SHA
    6c83bc4 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. Don't try to resolve machine on delete if cluster not ready

    This fixes a bug where if we created a machine for a cluster which never
    became ready, we would never be able to 'resolve' the machine and
    therefore never delete it. We address this situation in several layers:
    
    Firstly, we move the point in the machine controller at which we add the
    finalizer in the first place. We don't add the finalizer until we're
    writing resolved, so this situation can never occur for newly created
    machines. This makes sense because we don't create resources until we've
    observed that both the finalizer has been added and resolved is up to
    date, so we don't need the finalizer to protect resources which can't
    have been created yet.
    
    Secondly, we shortcut the delete flow if the cluster is not ready. This
    is safe for the same reason as above, but is only relevant to machines
    created before v0.10.
    
    Lastly we surface and restrict the circumstances in which 'Resolved' is
    required on delete anyway. On closer inspection, this is only required
    in the very specific circumstance that the machine has volumes defined,
    and we are deleting it without the machine having been created. To make
    this more obvious we split volume deletion out of DeleteInstance and
    only resolve the machine spec in the event that it's required.
    
    2 other factors make this change larger than it might otherwise be.
    
    We hit a cyclomatic complexity limit in reconcileDelete(), requiring a
    refactor.
    
    We remove the DeleteInstance tests which, after separating out
    DeleteVolumes, are quite trivial, and replace them with much more
    comprehensive set of tests for reconcileDelete.
    mdbooth committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    9ebb706 View commit details
    Browse the repository at this point in the history
  2. Merge pull request kubernetes-sigs#1922 from oblazek/ob-loadbalancer-…

    …network
    
    feat: add configurable loadbalancer network
    k8s-ci-robot authored Apr 9, 2024
    Configuration menu
    Copy the full SHA
    9aaf481 View commit details
    Browse the repository at this point in the history
  3. Merge pull request kubernetes-sigs#1996 from elastx/issue#1985

    🐛 Include more device_owners when looking for a port for floating ip
    k8s-ci-robot authored Apr 9, 2024
    Configuration menu
    Copy the full SHA
    626738a View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. Configuration menu
    Copy the full SHA
    6d74e98 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    43d2499 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. Configuration menu
    Copy the full SHA
    4ce032d View commit details
    Browse the repository at this point in the history
  2. Merge pull request kubernetes-sigs#2010 from shiftstack/cleanuptestsg

    🌱 Cleanup security group created by e2e test
    k8s-ci-robot authored Apr 11, 2024
    Configuration menu
    Copy the full SHA
    c834e9c View commit details
    Browse the repository at this point in the history
  3. Merge pull request kubernetes-sigs#2006 from shiftstack/issue1792

    🐛 Don't try to resolve machine on delete if cluster not ready
    k8s-ci-robot authored Apr 11, 2024
    Configuration menu
    Copy the full SHA
    7925a4b View commit details
    Browse the repository at this point in the history
  4. Bump k8s dep to 0.29.3

    This deprecates k8s.io/util/pointer, which we replace with
    k8s.io/util/ptr to keep the linter happy.
    mdbooth committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    d04c4d5 View commit details
    Browse the repository at this point in the history
  5. Merge pull request kubernetes-sigs#2004 from shiftstack/apiserver-lb-azs

    Add opt to use AZ for APISeverLoadBalancer
    k8s-ci-robot authored Apr 11, 2024
    Configuration menu
    Copy the full SHA
    7e34a22 View commit details
    Browse the repository at this point in the history
  6. Allow explicitly empty volume AZ

    Replaces an AvailabilityZone string for volumes with a
    VolumeAvailabilityZone struct which allows more flexibility in
    defaulting behaviour. Specifically it enables us to express both the
    current default behaviour where we take the volume AZ from the Machine,
    and a new default behaviour where to don't specify a volume AZ at all.
    
    In making this change to both RootVolume and AdditionalBlockDevices we
    use common code for both APIs. This has the result of updating
    RootVolume to be consistent with AdditionalBlockDevices.
    mdbooth committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    9aa449c View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. Merge pull request kubernetes-sigs#2014 from shiftstack/pointer-to-ptr

    🌱 Bump k8s dep to 0.29.3
    k8s-ci-robot authored Apr 12, 2024
    Configuration menu
    Copy the full SHA
    639ca12 View commit details
    Browse the repository at this point in the history
  2. Merge pull request kubernetes-sigs#2008 from shiftstack/volumeaz

    ⚠️ Allow explicitly empty volume AZ
    k8s-ci-robot authored Apr 12, 2024
    Configuration menu
    Copy the full SHA
    8c7e661 View commit details
    Browse the repository at this point in the history
  3. Merge pull request kubernetes-sigs#2011 from shiftstack/issue2009

    🐛 Fix idempotent restore when setting ControlPlaneEndpoint
    k8s-ci-robot authored Apr 12, 2024
    Configuration menu
    Copy the full SHA
    4cf3c1b View commit details
    Browse the repository at this point in the history
  4. Add a No Bastion e2e test

    mdbooth committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    2837b29 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    118f715 View commit details
    Browse the repository at this point in the history
  6. Merge pull request kubernetes-sigs#2017 from shiftstack/issue2016

    🐛 Fix crash on delete with no bastion
    k8s-ci-robot authored Apr 12, 2024
    Configuration menu
    Copy the full SHA
    f4e5bdf View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Configuration menu
    Copy the full SHA
    b1e4390 View commit details
    Browse the repository at this point in the history