-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync with upstream v0.10 #303
Commits on Jan 19, 2024
-
Merge pull request kubernetes-sigs#1763 from elastx/openstack_floatin…
…g_ip_pool ✨ IPAM provider for floating ips
Configuration menu - View commit details
-
Copy full SHA for 05571b9 - Browse repository at this point
Copy the full SHA 05571b9View commit details
Commits on Jan 22, 2024
-
Merge pull request kubernetes-sigs#1834 from shiftstack/ci-test
e2e: remove "allow-all-in-cluster-traffic" patch
Configuration menu - View commit details
-
Copy full SHA for 5d62dd5 - Browse repository at this point
Copy the full SHA 5d62dd5View commit details
Commits on Jan 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 42ca30e - Browse repository at this point
Copy the full SHA 42ca30eView commit details
Commits on Jan 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 26575b2 - Browse repository at this point
Copy the full SHA 26575b2View commit details -
Merge pull request kubernetes-sigs#1839 from shiftstack/issue_1838
🐛 controllers: do not return a RequeueAfter and an error at the same time
Configuration menu - View commit details
-
Copy full SHA for e89ec9c - Browse repository at this point
Copy the full SHA e89ec9cView commit details
Commits on Jan 30, 2024
-
Enhance Tilt integration with CAPO using a ClusterClass template
Signed-off-by: Max Rantil <max.rantil@est.tech>
Max Rantil committedJan 30, 2024 Configuration menu - View commit details
-
Copy full SHA for 9a71402 - Browse repository at this point
Copy the full SHA 9a71402View commit details -
Merge pull request kubernetes-sigs#1833 from Nordix/clusterclass-tilt…
…-capo/max 🌱 Enhance Tilt integration with CAPO using a ClusterClass template
Configuration menu - View commit details
-
Copy full SHA for 64fd897 - Browse repository at this point
Copy the full SHA 64fd897View commit details -
Merge pull request kubernetes-sigs#1845 from shiftstack/issue_1835
🐛 Fill up OpenStack cluster ReferencedResources with Image ID
Configuration menu - View commit details
-
Copy full SHA for cf4ccc5 - Browse repository at this point
Copy the full SHA cf4ccc5View commit details
Commits on Jan 31, 2024
-
Update the dev-test ClusterClass
This adds a patch to set the image automatically based on the kubernetes version. It also removes the requirement to have the CLUSTER_NAME variable set for the ClusterClass. Finally, the docs are updated to reflect this and with a few additions. Signed-off-by: Lennart Jern <lennart.jern@est.tech>
Configuration menu - View commit details
-
Copy full SHA for d410f82 - Browse repository at this point
Copy the full SHA d410f82View commit details -
Merge pull request kubernetes-sigs#1848 from Nordix/lentzi90/dev-test…
…-class-update 🌱 Update the dev-test ClusterClass
Configuration menu - View commit details
-
Copy full SHA for 54d6fd0 - Browse repository at this point
Copy the full SHA 54d6fd0View commit details -
Decrease number of machines in e2e tests
The e2e tests are currently very unstable. I suspect lack of resources in the devstack to be the issue. In an attempt to solve this, the number of control-plane nodes are reduced in this commit. Now only the multi-az test will use 3 CP. The rest will have 1 CP only. Signed-off-by: Lennart Jern <lennart.jern@est.tech>
Configuration menu - View commit details
-
Copy full SHA for b0480b1 - Browse repository at this point
Copy the full SHA b0480b1View commit details -
Convert ServerMetadata from a map to a list
While we're changing it, we also add validation that keys and values don't exceed 255 characters.
Configuration menu - View commit details
-
Copy full SHA for dfb963d - Browse repository at this point
Copy the full SHA dfb963dView commit details -
Merge pull request kubernetes-sigs#1828 from shiftstack/server-metadata
⚠️ Convert ServerMetadata from a map to a listConfiguration menu - View commit details
-
Copy full SHA for a80cdd2 - Browse repository at this point
Copy the full SHA a80cdd2View commit details
Commits on Feb 1, 2024
-
Merge pull request kubernetes-sigs#1849 from Nordix/lentzi90/e2e-scal…
…e-down 🌱 Decrease number of machines in e2e tests
Configuration menu - View commit details
-
Copy full SHA for 5cc483b - Browse repository at this point
Copy the full SHA 5cc483bView commit details
Commits on Feb 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 06d940a - Browse repository at this point
Copy the full SHA 06d940aView commit details -
Configuration menu - View commit details
-
Copy full SHA for b416af7 - Browse repository at this point
Copy the full SHA b416af7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 403c98f - Browse repository at this point
Copy the full SHA 403c98fView commit details -
Merge pull request kubernetes-sigs#1857 from elastx/dockerfile-go-1.21
Migrate Dockerfile to use golang 1.21 to match go.mod in project
Configuration menu - View commit details
-
Copy full SHA for 87ea61c - Browse repository at this point
Copy the full SHA 87ea61cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e356ad - Browse repository at this point
Copy the full SHA 9e356adView commit details -
Merge pull request kubernetes-sigs#1853 from elastx/lb-stacktrace-fix
🐛Fix a stacktrace in LB logic by removing listener name from an error message when not set
Configuration menu - View commit details
-
Copy full SHA for 84e1f4e - Browse repository at this point
Copy the full SHA 84e1f4eView commit details
Commits on Feb 6, 2024
-
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Configuration menu - View commit details
-
Copy full SHA for d690827 - Browse repository at this point
Copy the full SHA d690827View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8fe1c8f - Browse repository at this point
Copy the full SHA 8fe1c8fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f806e0 - Browse repository at this point
Copy the full SHA 3f806e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for cca2213 - Browse repository at this point
Copy the full SHA cca2213View commit details
Commits on Feb 7, 2024
-
Merge pull request kubernetes-sigs#1858 from tormath1/tormath1/flatca…
…r-update 🌱 test: bump Flatcar version
Configuration menu - View commit details
-
Copy full SHA for 77d1ad0 - Browse repository at this point
Copy the full SHA 77d1ad0View commit details -
Merge pull request kubernetes-sigs#1865 from okozachenko1203/doc/fix-…
…block-device-volume-name fix: fix the block device type name in doc
Configuration menu - View commit details
-
Copy full SHA for f128d15 - Browse repository at this point
Copy the full SHA f128d15View commit details -
add TLS configuration flags support
Add --tls-min-version and --tls-max-versin configuration flags. Same flags can be found in k8s, CAPI, CAPM3 etc. Co-authored-by: Jawad Zaheer <jawad.zaheer@est.tech> Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
Configuration menu - View commit details
-
Copy full SHA for 2c8a1a6 - Browse repository at this point
Copy the full SHA 2c8a1a6View commit details -
api: openstackcluster.status default to false
When a reconcile loop for the bastion is requeued, we have this error: ``` OpenStackCluster.infrastructure.cluster.x-k8s.io \"cluster-e2e-rha0r3\" is invalid: ready: Required value" ``` The OpenStackMachine.Status is false by default now, so if the status has not been set to anything, patching the object will not fail with the previous error.
Configuration menu - View commit details
-
Copy full SHA for e6092b8 - Browse repository at this point
Copy the full SHA e6092b8View commit details -
Prevent the bastion to be removed before it's been disabled
We now have a webhook that checks that a bastion has been disabled if a change has to be made (update or delete) in the bastion field. We also document it better. Also, we added some code to prevent that we don't have a nil pointer if the Spec.Bastion or Status.Bastion are unset.
Configuration menu - View commit details
-
Copy full SHA for 20f2a3c - Browse repository at this point
Copy the full SHA 20f2a3cView commit details
Commits on Feb 9, 2024
-
Merge pull request kubernetes-sigs#1842 from shiftstack/issue_1841
🐛 api: openstackcluster.status default to false
Configuration menu - View commit details
-
Copy full SHA for c9b628f - Browse repository at this point
Copy the full SHA c9b628fView commit details -
Merge pull request kubernetes-sigs#1864 from elastx/fix_pool_name_index
🐛 Adds Kind to ipaddress pool name index
Configuration menu - View commit details
-
Copy full SHA for 4d81532 - Browse repository at this point
Copy the full SHA 4d81532View commit details -
Merge pull request kubernetes-sigs#1867 from Nordix/tuomo/tls-configu…
…ration-flags ✨ add TLS configuration flags
Configuration menu - View commit details
-
Copy full SHA for 7622602 - Browse repository at this point
Copy the full SHA 7622602View commit details -
Merge pull request kubernetes-sigs#1870 from elastx/ip_pool_duplicate…
…_addresses OpenstackFloatingIPPool: Adds popped ip to claimedIPs kubernetes-sigs#1869
Configuration menu - View commit details
-
Copy full SHA for ca15733 - Browse repository at this point
Copy the full SHA ca15733View commit details -
Merge pull request kubernetes-sigs#1854 from elastx/compare-cidr-fix
🐛Make sure that allowedCidrs lists are compared correctly to avoid patching LB listener when not needed
Configuration menu - View commit details
-
Copy full SHA for 622defd - Browse repository at this point
Copy the full SHA 622defdView commit details
Commits on Feb 12, 2024
-
loadbalancer: resolve ControlPlaneEndpoint.Host when needed
`ControlPlaneEndpoint.Host` is not guaranteed to be an IP address, it can also be an hostname. Now we'll try to lookup the hostname if it's not an IP and set that for the LB VipAddress.
Configuration menu - View commit details
-
Copy full SHA for b319893 - Browse repository at this point
Copy the full SHA b319893View commit details
Commits on Feb 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 42c0ef9 - Browse repository at this point
Copy the full SHA 42c0ef9View commit details
Commits on Feb 14, 2024
-
Merge pull request kubernetes-sigs#1866 from shiftstack/issue_1855
🐛 Prevent the bastion to be removed before it's been disabled
Configuration menu - View commit details
-
Copy full SHA for 8ca470a - Browse repository at this point
Copy the full SHA 8ca470aView commit details -
Move subnet options to SubnetSpec
This commit introduces SubnetSpec field onto the OpenStackClusterSpec that is supposed to hold all options related to subnets created by CAPO. This means nodeCidr and DNSNameservers are moved into that struct.
Configuration menu - View commit details
-
Copy full SHA for 12a7b72 - Browse repository at this point
Copy the full SHA 12a7b72View commit details -
Merge pull request kubernetes-sigs#1856 from shiftstack/subnet-spec
✨ Move subnet options to SubnetSpec
Configuration menu - View commit details
-
Copy full SHA for 3c07a7b - Browse repository at this point
Copy the full SHA 3c07a7bView commit details -
Configuration menu - View commit details
-
Copy full SHA for a68d946 - Browse repository at this point
Copy the full SHA a68d946View commit details
Commits on Feb 15, 2024
-
Merge pull request kubernetes-sigs#1877 from shiftstack/go1.22
✨ Bump Go to 1.22.0
Configuration menu - View commit details
-
Copy full SHA for bd0c05c - Browse repository at this point
Copy the full SHA bd0c05cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f3e5f4 - Browse repository at this point
Copy the full SHA 2f3e5f4View commit details -
Merge pull request kubernetes-sigs#1880 from shiftstack/cluster-netwo…
…rk-cleanup 🐛 Fix cluster network cleanup
Configuration menu - View commit details
-
Copy full SHA for 88dcecf - Browse repository at this point
Copy the full SHA 88dcecfView commit details -
provider: Ignore environment variables
Users should configure things via a secret, not via environment variables. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 23e30c7 - Browse repository at this point
Copy the full SHA 23e30c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for d33c1bc - Browse repository at this point
Copy the full SHA d33c1bcView commit details
Commits on Feb 16, 2024
-
Merge pull request kubernetes-sigs#1883 from shiftstack/issues-1881
🐛 Ignore 'OS_*' environment variables
Configuration menu - View commit details
-
Copy full SHA for 522ed82 - Browse repository at this point
Copy the full SHA 522ed82View commit details -
Merge pull request kubernetes-sigs#1888 from shiftstack/deprecations
⚠️ Stop serving v1alpha5Configuration menu - View commit details
-
Copy full SHA for 05abe55 - Browse repository at this point
Copy the full SHA 05abe55View commit details
Commits on Feb 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4eec0e7 - Browse repository at this point
Copy the full SHA 4eec0e7View commit details -
Merge pull request kubernetes-sigs#1889 from shiftstack/nodecidr-docs
🌱 Fix doc references to NodeCIDR in v1alpha8
Configuration menu - View commit details
-
Copy full SHA for 1b320cb - Browse repository at this point
Copy the full SHA 1b320cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for c51197e - Browse repository at this point
Copy the full SHA c51197eView commit details
Commits on Feb 20, 2024
-
E2E: Add clusterctl upgrade test for v0.9 -> main
Signed-off-by: Lennart Jern <lennart.jern@est.tech>
Configuration menu - View commit details
-
Copy full SHA for ce11691 - Browse repository at this point
Copy the full SHA ce11691View commit details -
Merge pull request kubernetes-sigs#1893 from shiftstack/issue_1885
🐛 e2e: stop testing upgrades from v1alpha5 (v0.6)
Configuration menu - View commit details
-
Copy full SHA for c6ab0a3 - Browse repository at this point
Copy the full SHA c6ab0a3View commit details -
⚠ Enforce restricted pod security standards
We should be able to run with the restricted policy and this will inprove our security. Signed-off-by: Lennart Jern <lennart.jern@est.tech>
Configuration menu - View commit details
-
Copy full SHA for 3121d3a - Browse repository at this point
Copy the full SHA 3121d3aView commit details -
Merge pull request kubernetes-sigs#1895 from Nordix/lentzi90/restrict…
…ed-pod-security-standards 🌱 Enforce restricted pod security standards
Configuration menu - View commit details
-
Copy full SHA for 5f5f1af - Browse repository at this point
Copy the full SHA 5f5f1afView commit details -
Merge pull request kubernetes-sigs#1862 from elastx/floating_pool_max…
…_ips ✨ Adds MaxIPs to OpenstackFloatingIPPool
Configuration menu - View commit details
-
Copy full SHA for d189b1b - Browse repository at this point
Copy the full SHA d189b1bView commit details -
Merge pull request kubernetes-sigs#1894 from Nordix/lentzi90/add-0.9-…
…upgrade 🌱 E2E: Add clusterctl upgrade test for v0.9 -> main
Configuration menu - View commit details
-
Copy full SHA for 5b2cc5b - Browse repository at this point
Copy the full SHA 5b2cc5bView commit details -
Co-Authored-By: Emilien Macchi <emilien@redhat.com> Co-Authored-By: Matthew Booth <mdbooth@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 418ce3d - Browse repository at this point
Copy the full SHA 418ce3dView commit details -
Merge pull request kubernetes-sigs#1738 from shiftstack/issue_1714
🐛 loadbalancer: resolve ControlPlaneEndpoint.Host when needed
Configuration menu - View commit details
-
Copy full SHA for 82b3122 - Browse repository at this point
Copy the full SHA 82b3122View commit details
Commits on Feb 21, 2024
-
Merge pull request kubernetes-sigs#1826 from shiftstack/secGroup-v1beta1
✨ AllNodes security groups API
Configuration menu - View commit details
-
Copy full SHA for fc47622 - Browse repository at this point
Copy the full SHA fc47622View commit details -
Configuration menu - View commit details
-
Copy full SHA for c1e0f50 - Browse repository at this point
Copy the full SHA c1e0f50View commit details -
api/additionalPorts: don't create UDP rules
When providing additional ports to open on the control plane security group, we'll only open TCP from now as it was initially documented. Opening UDP by default might not be desired for security reasons.
Configuration menu - View commit details
-
Copy full SHA for a559017 - Browse repository at this point
Copy the full SHA a559017View commit details -
Configuration menu - View commit details
-
Copy full SHA for 350b7e6 - Browse repository at this point
Copy the full SHA 350b7e6View commit details -
Merge pull request kubernetes-sigs#1898 from shiftstack/EmilienMreviewer
Add emilienm to CAPO reviewers
Configuration menu - View commit details
-
Copy full SHA for 2382d56 - Browse repository at this point
Copy the full SHA 2382d56View commit details -
Modify
OpenStackCluster.Spec.Network
APIFor the BYO scenario, when the `OpenStackCluster.Spec.Network` is not specified the query to OpenStack would return all the Networks available in the cloud and fail the reconciliation. To avoid this, if any Subnets were specified under `OpenStackCluster.Spec.Subnets` this can be used to identify which Network to use.
Configuration menu - View commit details
-
Copy full SHA for 2e4ca73 - Browse repository at this point
Copy the full SHA 2e4ca73View commit details -
Configuration menu - View commit details
-
Copy full SHA for 05537fb - Browse repository at this point
Copy the full SHA 05537fbView commit details -
Merge pull request kubernetes-sigs#1836 from shiftstack/find-network-…
…by-subnet ✨ Modify OpenStackCluster.Spec.Network API
Configuration menu - View commit details
-
Copy full SHA for 029d643 - Browse repository at this point
Copy the full SHA 029d643View commit details
Commits on Feb 22, 2024
-
Merge pull request kubernetes-sigs#1900 from shiftstack/issue_1886
🌱 Deprecate v1alpha6
Configuration menu - View commit details
-
Copy full SHA for 8801eda - Browse repository at this point
Copy the full SHA 8801edaView commit details -
Merge pull request kubernetes-sigs#1892 from shiftstack/issue_1878
✨ Move `spec.allowAllInClusterTraffic` to `spec.ManagedSecurityGroups`
Configuration menu - View commit details
-
Copy full SHA for 5cfeccc - Browse repository at this point
Copy the full SHA 5cfecccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ff2cf8 - Browse repository at this point
Copy the full SHA 4ff2cf8View commit details
Commits on Feb 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fc810d8 - Browse repository at this point
Copy the full SHA fc810d8View commit details -
Merge pull request kubernetes-sigs#1822 from shiftstack/issue_1821
🐛 e2e: bastion tests
Configuration menu - View commit details
-
Copy full SHA for fd64e36 - Browse repository at this point
Copy the full SHA fd64e36View commit details -
Merge pull request kubernetes-sigs#1903 from shiftstack/issue_1882
🐛 Remove `IdentityRef.Kind`
Configuration menu - View commit details
-
Copy full SHA for dd85470 - Browse repository at this point
Copy the full SHA dd85470View commit details -
Add support to set
allocation_pools
for subnetThis commit adds API that allows users to set `allocations_pools` in the subnet created by CAPO. This allows the users to restrict the IP address ranges that will be allocated automatically by OpenStack when creating Machines. Users can utilize this to reserve addresses for VIPs (virtual IPs) or special nodes that will have predefined addresses and will be created later.
Configuration menu - View commit details
-
Copy full SHA for ccfcb59 - Browse repository at this point
Copy the full SHA ccfcb59View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ec4c14 - Browse repository at this point
Copy the full SHA 7ec4c14View commit details
Commits on Feb 27, 2024
-
Allow running individual generate targets
generate-controller-gen and generate-conversion-gen targets are split out of generate-go
Configuration menu - View commit details
-
Copy full SHA for 3ba8082 - Browse repository at this point
Copy the full SHA 3ba8082View commit details -
conversion-gen: Fix package name generation
When conversion-gen has to generate a dependency between 2 input packages it uses the value passed to --input-dirs as the package name in the generated import. This does not work if that value is a directory name. If you specify a package name here instead it works correctly. We also stop trying to generate conversions for versions which don't need them.
Configuration menu - View commit details
-
Copy full SHA for 4bb8966 - Browse repository at this point
Copy the full SHA 4bb8966View commit details -
Scope encapsulates an initialised OpenStack client which can be safely shared between reconciles which share the same credentials. The logger is initialised with context specific to an individual reconcile, so it cannot be shared between reconciles. To avoid code churn we preserve the previous interface of Scope with the creation of scope.WithLogger, which changes the initialisation to ensure that the returned logger always comes from the current reconcile even if the scope was cached. While touching logging in tests, we also take the opportunity to replace uses of logr.Discard with GinkgoLogr or logr/testr as appropriate, so test logs are now captured.
Configuration menu - View commit details
-
Copy full SHA for 5a1e175 - Browse repository at this point
Copy the full SHA 5a1e175View commit details -
Merge pull request kubernetes-sigs#1788 from shiftstack/ports
✨ Re-work ports management
Configuration menu - View commit details
-
Copy full SHA for fd37971 - Browse repository at this point
Copy the full SHA fd37971View commit details -
Merge pull request kubernetes-sigs#1847 from shiftstack/allocation-pools
✨ Add support to set `allocation_pools` for subnet
Configuration menu - View commit details
-
Copy full SHA for 1b0f1ea - Browse repository at this point
Copy the full SHA 1b0f1eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for e9fb53c - Browse repository at this point
Copy the full SHA e9fb53cView commit details -
Merge pull request kubernetes-sigs#1902 from shiftstack/issue_1901
🌱 Rename `v1alpha8` to `v1beta1`
Configuration menu - View commit details
-
Copy full SHA for 634ccc7 - Browse repository at this point
Copy the full SHA 634ccc7View commit details -
Reduce cyclomatic complexity of ReconcileLoadBalancer
This function had become genuinely too complex over time, to the point that even the linter was starting to complain about it when making almost any change. This change refactors ReconcileLoadBalancer into several smaller logical functions which are much easier to read and reason about. It also revealed some trivial optimisations: * Only fetch Octavia providers if we need them to create a new loadbalancer * Only calculate allowed CIDRs once * Don't re-fetch a loadbalancer to check it's active if it's already active Co-Authored-By: Emilien Macchi <emacchi@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for e8ccd21 - Browse repository at this point
Copy the full SHA e8ccd21View commit details -
Merge pull request kubernetes-sigs#1911 from shiftstack/conversion-gen
🌱 Enhancements to how controller-gen is invoked
Configuration menu - View commit details
-
Copy full SHA for c0b54d0 - Browse repository at this point
Copy the full SHA c0b54d0View commit details
Commits on Feb 28, 2024
-
Merge pull request kubernetes-sigs#1904 from shiftstack/ReconcileLoad…
…Balancer 🌱 Reduce cyclomatic complexity of ReconcileLoadBalancer
Configuration menu - View commit details
-
Copy full SHA for 05d4e9b - Browse repository at this point
Copy the full SHA 05d4e9bView commit details -
Merge pull request kubernetes-sigs#1913 from shiftstack/issue1840
🐛 Remove logger from scope
Configuration menu - View commit details
-
Copy full SHA for 0c5f230 - Browse repository at this point
Copy the full SHA 0c5f230View commit details -
Reduce cyclomatic complexity of reconcileNetworkComponents
This change refactors reconcileNetworkComponents into several smaller logical functions which are easier to read and reason about. It also makes the gocyclo linter happy when making new changes to this code. Co-Authored-By: Emilien Macchi <emacchi@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 268645a - Browse repository at this point
Copy the full SHA 268645aView commit details -
Merge pull request kubernetes-sigs#1905 from shiftstack/reconcileNetw…
…orkComponents 🌱 Reduce cyclomatic complexity of reconcileNetworkComponents
Configuration menu - View commit details
-
Copy full SHA for a405eeb - Browse repository at this point
Copy the full SHA a405eebView commit details -
Add API reference documentation generation
Signed-off-by: alexandre.vilain <alexandre.vilain@corp.ovh.com>
Configuration menu - View commit details
-
Copy full SHA for af5545c - Browse repository at this point
Copy the full SHA af5545cView commit details -
Merge pull request kubernetes-sigs#1702 from alexandrevilain/docs/add…
…-api-reference 📖 Add API reference documentation generation
Configuration menu - View commit details
-
Copy full SHA for 36e94d9 - Browse repository at this point
Copy the full SHA 36e94d9View commit details -
Merge pull request kubernetes-sigs#1899 from shiftstack/issue_1704
🐛 api/additionalPorts: don't create UDP rules
Configuration menu - View commit details
-
Copy full SHA for 7b202d1 - Browse repository at this point
Copy the full SHA 7b202d1View commit details
Commits on Feb 29, 2024
-
Internally, all optional fields become pointers. This change has no direct effect on the CRD, but means that unset values and zero values now have different meanings. SecurityGroupFilters is renamed to SecurityGroups for consistency with other filter fields used throughout the API. Note that this change thoroughly confuses conversion-gen. Consequently we explicitly disable the conversion of these fields in v1alpha6 and v1alpha5 and do the conversion entirely manually.
Configuration menu - View commit details
-
Copy full SHA for 4c01e65 - Browse repository at this point
Copy the full SHA 4c01e65View commit details -
Merge pull request kubernetes-sigs#1914 from shiftstack/portOptsCleanup
⚠️ API cleanup of PortOptsConfiguration menu - View commit details
-
Copy full SHA for 9e00969 - Browse repository at this point
Copy the full SHA 9e00969View commit details -
Move CloudName into IdentityRef and make cluster IdentityRef required
This change came from attempting to write validation markers for CloudName and IdentityRef in both the machine and cluster specs. Firstly I noticed that IdentityRef was marked optional in the cluster spec, but it is certainly required: the cluster cannot be provisioned without cloud credentials. I made IdentityRef required in the cluster spec. In contrast, IdentityRef is genuinely optional in the machine spec because, if not specified, we will use the credentials defined in the cluster spec. CloudName on the machine spec is also marked optional. However, it is required if IdentityRef was specified. This is because it refers to the same object as IdentityRef. The most sensible way to to represent this in the API is to put it in the IdentityRef. This means that if IdentityRef is provided, it must be provided completely, including CloudName.
Configuration menu - View commit details
-
Copy full SHA for 564b6bd - Browse repository at this point
Copy the full SHA 564b6bdView commit details -
Merge pull request kubernetes-sigs#1915 from shiftstack/cloudName
⚠️ Move CloudName into IdentityRef and make cluster IdentityRef requiredConfiguration menu - View commit details
-
Copy full SHA for c4fe920 - Browse repository at this point
Copy the full SHA c4fe920View commit details -
Transform neutron filter tags into slices
Co-Authored-By: Matthew Booth <mbooth@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 7927f65 - Browse repository at this point
Copy the full SHA 7927f65View commit details
Commits on Mar 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 412cae3 - Browse repository at this point
Copy the full SHA 412cae3View commit details -
Configuration menu - View commit details
-
Copy full SHA for c2e8b49 - Browse repository at this point
Copy the full SHA c2e8b49View commit details -
Configuration menu - View commit details
-
Copy full SHA for 120bc68 - Browse repository at this point
Copy the full SHA 120bc68View commit details -
tests: Add TEST_PATHS target for make test
TEST_PATHS defaults to the previous hardcoded value of './...', but can now be overridden. e.g. To run just the controller tests: make test TEST_PATHS=./controllers/...
Configuration menu - View commit details
-
Copy full SHA for a4e2079 - Browse repository at this point
Copy the full SHA a4e2079View commit details -
Merge pull request kubernetes-sigs#1916 from shiftstack/fixCloudname
🐛 ci: fix upgrades by dropping cloudName
Configuration menu - View commit details
-
Copy full SHA for 645741c - Browse repository at this point
Copy the full SHA 645741cView commit details -
Make sure that additional ports security groups are dynamic and canno…
…t go out of range
Configuration menu - View commit details
-
Copy full SHA for 8533ef5 - Browse repository at this point
Copy the full SHA 8533ef5View commit details -
Merge pull request kubernetes-sigs#1909 from shiftstack/tags
Transform neutron filter tags into lists
Configuration menu - View commit details
-
Copy full SHA for 0f02b30 - Browse repository at this point
Copy the full SHA 0f02b30View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d3e79c - Browse repository at this point
Copy the full SHA 4d3e79cView commit details -
Merge pull request kubernetes-sigs#1918 from elastx/fix-crash-additon…
…al-ports 🐛 Make LB additional ports security-group generation are dynamic
Configuration menu - View commit details
-
Copy full SHA for 1cb5d53 - Browse repository at this point
Copy the full SHA 1cb5d53View commit details
Commits on Mar 2, 2024
-
Move webhooks into pkg/webhooks
Moves webhooks from api to pkg/webhooks making only mechanical code changes except for the removal of the defaulting webhooks, because they weren't used. This results in there now being no mutating webhook configured.
Configuration menu - View commit details
-
Copy full SHA for 750b84d - Browse repository at this point
Copy the full SHA 750b84dView commit details -
Register API versions with test scheme in validation tests
The conversion webhook does not try to register conversions for versions which are not present in the scheme.
Configuration menu - View commit details
-
Copy full SHA for 13e95db - Browse repository at this point
Copy the full SHA 13e95dbView commit details -
Implement convertible for OpenStackClusterTemplateList
The conversion webhook fails to register without this.
Configuration menu - View commit details
-
Copy full SHA for cb09d5f - Browse repository at this point
Copy the full SHA cb09d5fView commit details
Commits on Mar 4, 2024
-
Merge pull request kubernetes-sigs#1919 from shiftstack/apivalidation…
…tests ✨ Add API validation test framework
Configuration menu - View commit details
-
Copy full SHA for 23b9f34 - Browse repository at this point
Copy the full SHA 23b9f34View commit details
Commits on Mar 5, 2024
-
Split v1alpha6&v1alpha7 conversion into multiple files
This is 100% code motion with no code changes whatsoever. conversion.go has become unwieldy, making changes to it harder to understand. This simply splits it into several files based on the corresponding _types.go. We don't touch v1alpha5 as it's about to be deleted. It can stay a mess.
Configuration menu - View commit details
-
Copy full SHA for 1eca090 - Browse repository at this point
Copy the full SHA 1eca090View commit details -
Merge pull request kubernetes-sigs#1920 from shiftstack/webhooks
🌱 Move webhooks into pkg/webhooks
Configuration menu - View commit details
-
Copy full SHA for e6bb34f - Browse repository at this point
Copy the full SHA e6bb34fView commit details -
v1alpha7 restorev1beta1ClusterSpec should not restore Bastion
The bastion has a separate restorer.
Configuration menu - View commit details
-
Copy full SHA for 392edfd - Browse repository at this point
Copy the full SHA 392edfdView commit details -
v1alpha6: Simplify v1alpha6 cluster restorer
This is a breaking change, although it should not have any negative effects in practise. The v1alpha6 cluster restorer had become too complex with too many individual fields. This change reduces the number of fields to be consistent with the v1alpha7 restorer. With this change, an object stored as v1alpha6 with previous v1beta1 annotations could have fields in its spec restored to a semantically equivalent but slightly different serialisation when converted to v1beta1. Differences in the bastion and status are not affected. In practise this should not matter for 2 reasons: * The storage version is v1beta1, so the annotation should have been freshly generated in the new format anyway. * Even if it were not, and the v1alpha6 were under external control, the external controller would observe a difference and restore it to the previous version. It would then converted again with the new annotation. Note that if the object is not under external control these differences don't matter anyway.
Configuration menu - View commit details
-
Copy full SHA for a81ef96 - Browse repository at this point
Copy the full SHA a81ef96View commit details -
Merge pull request kubernetes-sigs#1923 from shiftstack/conversion_cl…
…eanup 🌱 Split v1alpha6 & v1alpha7 conversion into multiple files
Configuration menu - View commit details
-
Copy full SHA for af6dbae - Browse repository at this point
Copy the full SHA af6dbaeView commit details
Commits on Mar 6, 2024
-
Merge pull request kubernetes-sigs#1925 from shiftstack/simple_cluste…
…r_restore
⚠️ Simplify v1alpha6 cluster restorerConfiguration menu - View commit details
-
Copy full SHA for d76b07d - Browse repository at this point
Copy the full SHA d76b07dView commit details -
When moving the webhooks we didn't separate CRD generation from webhook generation, meaning controller-gen was looking for CRDs to generate in pkg/webhook. This resulted in CRDs not being generated.
Configuration menu - View commit details
-
Copy full SHA for 30ba121 - Browse repository at this point
Copy the full SHA 30ba121View commit details -
Merge pull request kubernetes-sigs#1928 from shiftstack/crdgen
Fix CRD generation
Configuration menu - View commit details
-
Copy full SHA for 9fb6072 - Browse repository at this point
Copy the full SHA 9fb6072View commit details -
Move filter conversions out of /api
Removes a gophercloud dependency for consumers of the API.
Configuration menu - View commit details
-
Copy full SHA for d33fee8 - Browse repository at this point
Copy the full SHA d33fee8View commit details -
Allow generating api-docs for individual versions
This change creates separate targets for individual API targets when generating api documentation. The generate-api-docs target continues to execute all of them as before.
Configuration menu - View commit details
-
Copy full SHA for 1734ebb - Browse repository at this point
Copy the full SHA 1734ebbView commit details -
Merge pull request kubernetes-sigs#1929 from shiftstack/apidoc-gen
🌱 Allow generating api-docs for individual versions
Configuration menu - View commit details
-
Copy full SHA for b4670cb - Browse repository at this point
Copy the full SHA b4670cbView commit details
Commits on Mar 7, 2024
-
Rename fields to correctly do uppercase acronyms
K8s API conventions require the acronyms in the field names to be uppercase if not being the first word in the name. We aren't following this in several places and this commit fixes these occurrences: * `projectId` becomes `projectID` * `gateway_ip` becomes `gatewayIP` * `ipv6RaMode` becomes `ipv6RAMode` * `networkMtu` becomes `networkMTU` * `hostId` becomes `hostID` * `allowedCidrs` becomes `allowedCIDRs`
Configuration menu - View commit details
-
Copy full SHA for c7c5baf - Browse repository at this point
Copy the full SHA c7c5bafView commit details -
Configuration menu - View commit details
-
Copy full SHA for 968df70 - Browse repository at this point
Copy the full SHA 968df70View commit details -
Merge pull request kubernetes-sigs#1934 from shiftstack/fix-serializa…
…tions
⚠️ Rename fields to correctly do uppercase acronymsConfiguration menu - View commit details
-
Copy full SHA for 47f0c1b - Browse repository at this point
Copy the full SHA 47f0c1bView commit details
Commits on Mar 8, 2024
-
Merge pull request kubernetes-sigs#1932 from shiftstack/externalnet
🐛 CI: Specify external network by name
Configuration menu - View commit details
-
Copy full SHA for 381263d - Browse repository at this point
Copy the full SHA 381263dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 000b67d - Browse repository at this point
Copy the full SHA 000b67dView commit details -
Merge pull request kubernetes-sigs#1935 from shiftstack/junit
✨ Add junit output to e2e tests
Configuration menu - View commit details
-
Copy full SHA for 4ece380 - Browse repository at this point
Copy the full SHA 4ece380View commit details -
Merge pull request kubernetes-sigs#1924 from shiftstack/filter_convert
🌱 Move filter conversions out of /api
Configuration menu - View commit details
-
Copy full SHA for 300c45c - Browse repository at this point
Copy the full SHA 300c45cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0caecf4 - Browse repository at this point
Copy the full SHA 0caecf4View commit details -
Configuration menu - View commit details
-
Copy full SHA for cc32a8a - Browse repository at this point
Copy the full SHA cc32a8aView commit details -
make nil resource filters ToListOpts() return empty ListOpts
This makes the behaviour slightly more ergonomic and safer as we turn these into pointers.
Configuration menu - View commit details
-
Copy full SHA for 7a0e942 - Browse repository at this point
Copy the full SHA 7a0e942View commit details -
Make NetworkFilter.IsEmpty() return true on nil receiver
This improves safety and ergonomics checking it when NetworkFilter can be be a pointer type.
Configuration menu - View commit details
-
Copy full SHA for cdc16d2 - Browse repository at this point
Copy the full SHA cdc16d2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d96db6 - Browse repository at this point
Copy the full SHA 2d96db6View commit details -
OpenStackCluster: Set explicit listType=atomic
For non-mergeable list types, make the default 'atomic' behaviour explicit.
Configuration menu - View commit details
-
Copy full SHA for 75079c7 - Browse repository at this point
Copy the full SHA 75079c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for ffbfd40 - Browse repository at this point
Copy the full SHA ffbfd40View commit details -
OpenStackClusterSpec: ExternalNetwork->pointer
ExternalNetwork was already marked optional. This change allows it to be omitted when marshalling and unmarshalling the object in Go. This change also adds the 'external' flag when executing an explicit external network query.
Configuration menu - View commit details
-
Copy full SHA for e39c730 - Browse repository at this point
Copy the full SHA e39c730View commit details -
OpenStackClusterSpec: ApiServerLoadBalancer->pointer
Affects go marshalling only.
Configuration menu - View commit details
-
Copy full SHA for e5d9630 - Browse repository at this point
Copy the full SHA e5d9630View commit details -
OpenStackClusterSpec: APIServerFloatingIP, APIServerFixedIP, APIServe…
…rPort->optional Affects go marshalling only.
Configuration menu - View commit details
-
Copy full SHA for 2c7b44b - Browse repository at this point
Copy the full SHA 2c7b44bView commit details -
OpenStackClusterSpec: scalar fields to optional types
The following types become a corresponding optional type: * NetworkMTU * DisableExternalNetwork * DisableAPIServerFloatingIP * DisablePortSecurity * ControlPlaneOmitAvailabilityZone
Configuration menu - View commit details
-
Copy full SHA for 9223883 - Browse repository at this point
Copy the full SHA 9223883View commit details -
Configuration menu - View commit details
-
Copy full SHA for 70bfdaf - Browse repository at this point
Copy the full SHA 70bfdafView commit details -
Configuration menu - View commit details
-
Copy full SHA for e6a194b - Browse repository at this point
Copy the full SHA e6a194bView commit details
Commits on Mar 11, 2024
-
Merge pull request kubernetes-sigs#1930 from shiftstack/openstackclus…
…ter_apicleanup
⚠️ OpenStackCluster api general cleanupConfiguration menu - View commit details
-
Copy full SHA for 8d70c19 - Browse repository at this point
Copy the full SHA 8d70c19View commit details -
Configuration menu - View commit details
-
Copy full SHA for 44d4732 - Browse repository at this point
Copy the full SHA 44d4732View commit details -
Enabled now defaults to true. Provider becomes optional.String.
Configuration menu - View commit details
-
Copy full SHA for 470d30b - Browse repository at this point
Copy the full SHA 470d30bView commit details
Commits on Mar 12, 2024
-
Merge pull request kubernetes-sigs#1937 from shiftstack/openstackclus…
…ter_apicleanup
⚠️ Cleanup APILoadBalancerConfiguration menu - View commit details
-
Copy full SHA for 2074438 - Browse repository at this point
Copy the full SHA 2074438View commit details -
The json field names were unnecessarily leaking the internal name of a struct.
Configuration menu - View commit details
-
Copy full SHA for 4afdb80 - Browse repository at this point
Copy the full SHA 4afdb80View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7dce82c - Browse repository at this point
Copy the full SHA 7dce82cView commit details -
Merge pull request kubernetes-sigs#1938 from shiftstack/openstackclus…
…ter_apicleanup 🌱 Rename Ports fields in status
Configuration menu - View commit details
-
Copy full SHA for 654d714 - Browse repository at this point
Copy the full SHA 654d714View commit details
Commits on Mar 14, 2024
-
ImageFilter - add validations, switch to pointers
This commit changes `ID` and `Name` of `ImageFilter` to pointers which should only affect go marshalling. Other than that it adds CEL validation of the ImageFilter, so that Name or Tags can only be set when ID is unset. Conversions are updated accordingly to make sure we only set Name when ID is unset. Moreover validation is added that ID has to be UUID. It's not enforced in conversions, as non-UUID IDs would produce clusters or machines that would not work properly.
Configuration menu - View commit details
-
Copy full SHA for a00fa80 - Browse repository at this point
Copy the full SHA a00fa80View commit details -
Add ImageFilter API validations
This adds tests related to kubebuilder validations of ImageFilter.
Configuration menu - View commit details
-
Copy full SHA for dc3959e - Browse repository at this point
Copy the full SHA dc3959eView commit details -
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Configuration menu - View commit details
-
Copy full SHA for f79fdf8 - Browse repository at this point
Copy the full SHA f79fdf8View commit details -
Templates: Set provider ID directly via kubelet
This commit sets the provider ID in the flatcar templates. To avoid issues with potential mismatches between node names and openstack servers we can configure the kubelet to set the provider ID. Otherwise, the cloud controller will try to match nodes and servers based on just the name. The names can differ because of special characters, like dots. When this happens, the cloud controller will be unable to match them and thus believe that the node has no underlying server. Co-authored-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Configuration menu - View commit details
-
Copy full SHA for 957c9fc - Browse repository at this point
Copy the full SHA 957c9fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 559cbf2 - Browse repository at this point
Copy the full SHA 559cbf2View commit details
Commits on Mar 15, 2024
-
Merge pull request kubernetes-sigs#1949 from shiftstack/issue1948
🐛 v1alpha5: Fix panic in conversion when port has no binding profile
Configuration menu - View commit details
-
Copy full SHA for 4ab8b3a - Browse repository at this point
Copy the full SHA 4ab8b3aView commit details -
Merge pull request kubernetes-sigs#1939 from shiftstack/filters-pointers
⚠️ ImageFilter - add exclusive validation -> pointersConfiguration menu - View commit details
-
Copy full SHA for e7d0e19 - Browse repository at this point
Copy the full SHA e7d0e19View commit details -
Merge pull request kubernetes-sigs#1762 from elastx/floating_ip_from_…
…pool ✨ Adds IPAM support for floating ips in OpenStackMachine
Configuration menu - View commit details
-
Copy full SHA for f6fb753 - Browse repository at this point
Copy the full SHA f6fb753View commit details -
Fix port name after port creation failure
CreatePorts was creating a port name based on the index of the port in the *current reconcile*. This could be different to the absolute index of the port if ports had been partially created in a previous reconcile. We fix this by passing all current state into CreatePorts so it can create an absolute index. This also ensures that partially created ports will be persisted on failure so we don't have to rely on adoption in the next reconcile.
Configuration menu - View commit details
-
Copy full SHA for cc78607 - Browse repository at this point
Copy the full SHA cc78607View commit details -
Simplify bastion resource initialisation
Firstly, we remove the resource reconcile calls from the cluster flow before calling reconcileNormal/reconcileDelete because the guards around them and various other guards throughout the code are heavily inter-depdendent and hard to reason about. Instead, we push them to the the places we: * know they are required * know we are sufficiently initialised that they can work Firstly we resolve references at the top of reconcileBastion. We know the cluster has been initialised at this point, so we don't need to guard against it. This also means that it is always called when entering that function, so we don't need to guard against it not having been called during first cluster initialisation. We also force that function to re-reconcile if it calls deleteBastion(), because deleteBastion() removes the bastion status. We reconcile again, so we always know that it is set. We also add an explicit call to resource reconcile in the reconcileDelete flow. This is the only place we now need a 'weird' guard against the cluster network not having been set. We add a comment about that appropriate to its weirdness.
Configuration menu - View commit details
-
Copy full SHA for 801f5ef - Browse repository at this point
Copy the full SHA 801f5efView commit details -
Merge pull request kubernetes-sigs#1936 from tormath1/tormath1/flatcar
test: bump Flatcar version
Configuration menu - View commit details
-
Copy full SHA for 0aa2205 - Browse repository at this point
Copy the full SHA 0aa2205View commit details
Commits on Mar 16, 2024
-
Merge pull request kubernetes-sigs#1941 from shiftstack/issue1940
🐛 Fix port name after port creation failure
Configuration menu - View commit details
-
Copy full SHA for 6b87daf - Browse repository at this point
Copy the full SHA 6b87dafView commit details
Commits on Mar 17, 2024
-
Fix accidental parsing of password
When clouds.yaml gets parsed by `env.rc`, the `yq` command is accidentally parsing the contents of the password variable. Under most circumstances the password contents is detected correctly as a string. This fixes failures when the password is accidentally parseable as a yaml structure. More info at: https://mikefarah.gitbook.io/yq/operators/env-variable-operators
Configuration menu - View commit details
-
Copy full SHA for acd9297 - Browse repository at this point
Copy the full SHA acd9297View commit details
Commits on Mar 18, 2024
-
Merge pull request kubernetes-sigs#1953 from JanGutter/fix-env-rc-pas…
…sword-quoting 🐛 Fix accidental parsing of password
Configuration menu - View commit details
-
Copy full SHA for c1fc60d - Browse repository at this point
Copy the full SHA c1fc60dView commit details -
Fix a race when updating status before reconcile completes
We were ignoring any update which only touched the status. This code has been there an extremely long time, and was originally copied from CAPA. Unfortunately this introduces a race for recently added code which sets port status and exits the reconcile early for transactional safety.
Configuration menu - View commit details
-
Copy full SHA for 6f8ac4f - Browse repository at this point
Copy the full SHA 6f8ac4fView commit details -
Merge pull request kubernetes-sigs#1955 from shiftstack/issue1954
🐛 Fix a race when updating status before reconcile completes
Configuration menu - View commit details
-
Copy full SHA for 67fa7b7 - Browse repository at this point
Copy the full SHA 67fa7b7View commit details
Commits on Mar 19, 2024
-
Deduplicate AdoptMachinePorts and AdoptBastionPorts
Both of these methods rely on ReferencedMachineResources and DependentMachineResources, so they can be easily refactored to have a common implementation.
Configuration menu - View commit details
-
Copy full SHA for 567469e - Browse repository at this point
Copy the full SHA 567469eView commit details -
Don't re-reconcile when adopting resources
Unlike referenced resources, which specify a future intent, adoption only affects resources which have already been created. Successive executions will produce the same output, so there is no need to re-reconcile if we found orphaned resources. Also we seem to be hitting this a lot in practise, most likely due to the controller-runtime read-after-write cache inconsistency issue.
Configuration menu - View commit details
-
Copy full SHA for ad00c64 - Browse repository at this point
Copy the full SHA ad00c64View commit details -
Fix premature attempt to resolve machine resources
We can't resolve machine resources until the cluster is initialised.
Configuration menu - View commit details
-
Copy full SHA for 750af59 - Browse repository at this point
Copy the full SHA 750af59View commit details -
Merge pull request kubernetes-sigs#1944 from shiftstack/issue1942
🌱 Deduplicate AdoptMachinePorts and AdoptBastionPorts
Configuration menu - View commit details
-
Copy full SHA for 27b3cef - Browse repository at this point
Copy the full SHA 27b3cefView commit details -
Configuration menu - View commit details
-
Copy full SHA for c4e5c2a - Browse repository at this point
Copy the full SHA c4e5c2aView commit details
Commits on Mar 20, 2024
-
Update FloatingIPPool to use v1beta1
Also make IdentityRef required, as it doesn't currently permit fallback to cluster credentials.
Configuration menu - View commit details
-
Copy full SHA for 24b7961 - Browse repository at this point
Copy the full SHA 24b7961View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4cd4e9f - Browse repository at this point
Copy the full SHA 4cd4e9fView commit details -
Merge pull request kubernetes-sigs#1957 from shiftstack/securitygroup…
…rules
⚠️ Remove security group rules from statusConfiguration menu - View commit details
-
Copy full SHA for 10b1ff4 - Browse repository at this point
Copy the full SHA 10b1ff4View commit details -
This commit works with .spec.bastion: * makes availablityZone, floatingIP and instance pointers * adds floatingIP IPv4 validation * adds validation that if Bastion is enabled, instance cannot be null
Configuration menu - View commit details
-
Copy full SHA for ffa82b3 - Browse repository at this point
Copy the full SHA ffa82b3View commit details -
Rename Bastion.Instance to Bastion.Spec
Bastion.Spec is way more descriptive and it suggests it's an OpenStackMachineSpec.
Configuration menu - View commit details
-
Copy full SHA for c321574 - Browse repository at this point
Copy the full SHA c321574View commit details -
Merge pull request kubernetes-sigs#1963 from shiftstack/gitattributes
🌱 Add .gitattributes to identify generated files to GitHub
Configuration menu - View commit details
-
Copy full SHA for 66d93db - Browse repository at this point
Copy the full SHA 66d93dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for ad3fd18 - Browse repository at this point
Copy the full SHA ad3fd18View commit details -
Merge pull request kubernetes-sigs#1962 from shiftstack/floatingipv1b…
…eta1 🌱 Update FloatingIPPool to use v1beta1
Configuration menu - View commit details
-
Copy full SHA for 99f3a60 - Browse repository at this point
Copy the full SHA 99f3a60View commit details -
Merge pull request kubernetes-sigs#1964 from shiftstack/servermetadata
🐛 Fix server metadata length validation
Configuration menu - View commit details
-
Copy full SHA for 9809a60 - Browse repository at this point
Copy the full SHA 9809a60View commit details -
Merge pull request kubernetes-sigs#1959 from shiftstack/bastion-cleanup
⚠️ Bastion cleanupConfiguration menu - View commit details
-
Copy full SHA for c6efdea - Browse repository at this point
Copy the full SHA c6efdeaView commit details
Commits on Mar 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 61b0560 - Browse repository at this point
Copy the full SHA 61b0560View commit details -
Merge pull request kubernetes-sigs#1966 from shiftstack/upgradefix
🐛 Revert accidental update to previous API templates
Configuration menu - View commit details
-
Copy full SHA for 2b03429 - Browse repository at this point
Copy the full SHA 2b03429View commit details -
Store []ResolvedPortSpec in ReferencedMachineResources
The purpose of this change is fix an issue where we are storing unresolved references in ReferencedMachineResources. Specifically we are storing a PortOpts, which is a user-intent struct. PortOpts can contain unresolved references to both subnets and security groups, as well fields requiring additional processing which reference external objects: the port name, description, and tags. We create a new type, ResolvedPortSpec, which can contain only fully resolved data. This can be seen in the new signature of CreatePorts(), which no longer requires any source of data other than the []ResolvedPortSpec from ReferencedMachineResources, and is now greatly simplified. Fully resolving the port name also allows a simplification in port adoption. All of the complexity now moves to ConstructPorts(), which is updated to return []ResolvedPortSpec instead of []PortOpts. ConstructPorts() is updated to resolve security groups, port name, description, and all subnets referenced in FixedIPs.
Configuration menu - View commit details
-
Copy full SHA for 8017c89 - Browse repository at this point
Copy the full SHA 8017c89View commit details
Commits on Mar 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b6d7748 - Browse repository at this point
Copy the full SHA b6d7748View commit details -
Merge pull request kubernetes-sigs#1951 from shiftstack/issue1943
⚠️ Store []ResolvedPortSpec in ReferencedMachineResourcesConfiguration menu - View commit details
-
Copy full SHA for cb99e17 - Browse repository at this point
Copy the full SHA cb99e17View commit details -
Rename DependentResources to Resources
The intent of this structure is to hold all OpenStack resources created for the machine, including the server. 'dependent' was redundant.
Configuration menu - View commit details
-
Copy full SHA for 5f09ba2 - Browse repository at this point
Copy the full SHA 5f09ba2View commit details -
Rename ReferencedResources to Resolved
This struct has already moved beyond external references, and seems be evolving towards a fully-resolved machine spec. For want of a better name we call it 'resolved', which is more accurate.
Configuration menu - View commit details
-
Copy full SHA for 5d11950 - Browse repository at this point
Copy the full SHA 5d11950View commit details -
Merge pull request kubernetes-sigs#1965 from shiftstack/machineresources
🌱 Rename referencedResources and dependentResources
Configuration menu - View commit details
-
Copy full SHA for 59689c9 - Browse repository at this point
Copy the full SHA 59689c9View commit details
Commits on Mar 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2758a6d - Browse repository at this point
Copy the full SHA 2758a6dView commit details
Commits on Mar 26, 2024
-
Merge pull request kubernetes-sigs#1967 from shiftstack/machineresour…
…cespointers
⚠️ Resolved and Resources become optional pointer typesConfiguration menu - View commit details
-
Copy full SHA for ec77c18 - Browse repository at this point
Copy the full SHA ec77c18View commit details
Commits on Mar 28, 2024
-
Consolidate and fix v1beta1 fuzzer funcs
Firstly this change consolidates common fuzzer funcs for fuzzing v1beta1 between v1alpha6 and v1alpha7. Secondly, we fix a couple of bugs where we were generating invalid output: In OpenStackClusterSpec we were creating a second subnet with FuzzNoCustom, which doesn't use our custom functions for generating valid output. When generating filters we were appending a second tag after validating tags, which meant we occasionally got invalid tags. We now add tags before validation, and also add tags to all tag fields instead of just 'Tags'. We also consolidate tag validation in a FilterByNeutronTags func instead of individually for each Filter.
Configuration menu - View commit details
-
Copy full SHA for 26e8c07 - Browse repository at this point
Copy the full SHA 26e8c07View commit details -
Merge pull request kubernetes-sigs#1981 from shiftstack/issue1980
🐛 Consolidate and fix v1beta1 fuzzer funcs
Configuration menu - View commit details
-
Copy full SHA for eace85b - Browse repository at this point
Copy the full SHA eace85bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 73c81de - Browse repository at this point
Copy the full SHA 73c81deView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d85f6f - Browse repository at this point
Copy the full SHA 4d85f6fView commit details -
Merge pull request kubernetes-sigs#1972 from shiftstack/networkparam
⚠️ NetworkFilter to NetworkParamConfiguration menu - View commit details
-
Copy full SHA for 1d5d2d5 - Browse repository at this point
Copy the full SHA 1d5d2d5View commit details -
Merge pull request kubernetes-sigs#1971 from shiftstack/subnetparam
⚠️ SubnetFilter to SubnetParamConfiguration menu - View commit details
-
Copy full SHA for de29a18 - Browse repository at this point
Copy the full SHA de29a18View commit details -
Add fuzz tests for v1alpha5 conversion
Unlike the v1alpha6 and v1alpha7 tests, these only test if the conversion causes a panic. It found 1 panic, which is also fixed here.
Configuration menu - View commit details
-
Copy full SHA for 3cea05d - Browse repository at this point
Copy the full SHA 3cea05dView commit details
Commits on Mar 29, 2024
-
Merge pull request kubernetes-sigs#1984 from shiftstack/v1alpha5panics
🐛 Add fuzz tests for v1alpha5 conversion
Configuration menu - View commit details
-
Copy full SHA for 4a5cd42 - Browse repository at this point
Copy the full SHA 4a5cd42View commit details -
Configuration menu - View commit details
-
Copy full SHA for 865933d - Browse repository at this point
Copy the full SHA 865933dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 91669cf - Browse repository at this point
Copy the full SHA 91669cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 44be48e - Browse repository at this point
Copy the full SHA 44be48eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c3fe97 - Browse repository at this point
Copy the full SHA 5c3fe97View commit details -
Merge pull request kubernetes-sigs#1974 from shiftstack/securitygroup…
…param
⚠️ SecurityGroupFilter to SecurityGroupParamConfiguration menu - View commit details
-
Copy full SHA for 52652d3 - Browse repository at this point
Copy the full SHA 52652d3View commit details -
Merge pull request kubernetes-sigs#1970 from shiftstack/imageparam
⚠️ Split ImageFilter into ImageParamConfiguration menu - View commit details
-
Copy full SHA for e32bcc2 - Browse repository at this point
Copy the full SHA e32bcc2View commit details -
Merge pull request kubernetes-sigs#1978 from shiftstack/routerparam
⚠️ RouterFilter to RouterParamConfiguration menu - View commit details
-
Copy full SHA for 4e2150f - Browse repository at this point
Copy the full SHA 4e2150fView commit details
Commits on Apr 1, 2024
-
Fix v1alpha7 machine restorer and test
The v1alpha7 machine spec restorer was missing the exclusion for ProviderID and InstanceID was missing, and the test which was supposed to ensure it worked was broken. This fixes both.
Configuration menu - View commit details
-
Copy full SHA for a2ba9c5 - Browse repository at this point
Copy the full SHA a2ba9c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c1ad44 - Browse repository at this point
Copy the full SHA 5c1ad44View commit details -
Merge pull request kubernetes-sigs#1987 from shiftstack/issue1986
🐛 Fix v1alpha7 machine restorer and test
Configuration menu - View commit details
-
Copy full SHA for 85ed836 - Browse repository at this point
Copy the full SHA 85ed836View commit details -
Bastion is enabled by default if specified
Bastion.Enabled is a wart. Ideally it would not be required, but because of limitations in how we delete the bastion we require an intermediate 'disabled' step before removal. Ultimately we intend to remove this limitation. Eventually we would like to be able to ignore enabled entirely. e.g. To create a Bastion just specify it: ```yaml spec: bastion: spec: ... floatingIP: x.x.x.x ``` and to delete it just remove the bastion field. Right now with enabled defaulting to `false`, doing the above will not result in the creation of a bastion, because enabled must be explicitly set to true. Paving the way for the eventual deprecation of Bastion.Enabled, we change the default value of enabled to be true so the above does today what we eventually want it to do. This is also generally more intuitive: why would you include a bastion and a spec if you didn't want to create a bastion? Having to also set enabled to true is currently a trip hazard. Until we resolve the limitations of bastion deletion, though, we still need to be able to disable the bastion. For this case enabled can be explicitly set to false. In the future when we remove the requirement to disable the bastion before deletion the user can simply ignore Bastion.Enabled, which will continue to work but without the limitations.
Configuration menu - View commit details
-
Copy full SHA for 7dd2c35 - Browse repository at this point
Copy the full SHA 7dd2c35View commit details
Commits on Apr 2, 2024
-
Merge pull request kubernetes-sigs#1990 from shiftstack/bastionenabled
⚠️ Bastion is enabled by default if specifiedConfiguration menu - View commit details
-
Copy full SHA for a6732bc - Browse repository at this point
Copy the full SHA a6732bcView commit details -
Merge pull request kubernetes-sigs#1988 from shiftstack/instanceidsta…
…tus2
⚠️ Move InstanceID from Spec to StatusConfiguration menu - View commit details
-
Copy full SHA for 4c162b6 - Browse repository at this point
Copy the full SHA 4c162b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ea3ccf - Browse repository at this point
Copy the full SHA 8ea3ccfView commit details -
Configuration menu - View commit details
-
Copy full SHA for de0dffa - Browse repository at this point
Copy the full SHA de0dffaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2901efe - Browse repository at this point
Copy the full SHA 2901efeView commit details -
Merge pull request kubernetes-sigs#1989 from shiftstack/morefuzz
🐛 Fix multiple panics in restore functions
Configuration menu - View commit details
-
Copy full SHA for f5b0181 - Browse repository at this point
Copy the full SHA f5b0181View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c0d741 - Browse repository at this point
Copy the full SHA 7c0d741View commit details -
Merge pull request kubernetes-sigs#1991 from shiftstack/servergroupparam
⚠️ ServerGroupFilter to ServerGroupParamConfiguration menu - View commit details
-
Copy full SHA for e636957 - Browse repository at this point
Copy the full SHA e636957View commit details -
Merge pull request kubernetes-sigs#1982 from shiftstack/filterparamdocs
📖 Document changes to Filters
Configuration menu - View commit details
-
Copy full SHA for 0990569 - Browse repository at this point
Copy the full SHA 0990569View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8fe2114 - Browse repository at this point
Copy the full SHA 8fe2114View commit details -
Configuration menu - View commit details
-
Copy full SHA for ed829b3 - Browse repository at this point
Copy the full SHA ed829b3View commit details -
Merge pull request kubernetes-sigs#1993 from shiftstack/v1alpha1docs
✨ Add API docs for v1alpha1
Configuration menu - View commit details
-
Copy full SHA for 17daeca - Browse repository at this point
Copy the full SHA 17daecaView commit details -
Merge pull request kubernetes-sigs#1994 from shiftstack/v10-metadata
🌱 Bump version artifacts for release-0.10
Configuration menu - View commit details
-
Copy full SHA for 79fcb6a - Browse repository at this point
Copy the full SHA 79fcb6aView commit details -
Merge pull request kubernetes-sigs#1992 from shiftstack/v1alpha7cruft
🌱 Remove legacy v1alpha7 filterconvert utils
Configuration menu - View commit details
-
Copy full SHA for acc680d - Browse repository at this point
Copy the full SHA acc680dView commit details
Commits on Apr 3, 2024
-
make floatingIPNetwork a pointer and if there's only one external
network use it as default
Configuration menu - View commit details
-
Copy full SHA for 9c66684 - Browse repository at this point
Copy the full SHA 9c66684View commit details -
Configuration menu - View commit details
-
Copy full SHA for df19807 - Browse repository at this point
Copy the full SHA df19807View commit details
Commits on Apr 4, 2024
-
Rules are optional in security group rules before v1beta1
Rules were removed from the security group status in v1beta1. If the status is modified then an up-converted v1alphaN object will not have its security group rules restored on down-conversion. As the CRD requires rules, this results in an API error.
Configuration menu - View commit details
-
Copy full SHA for f747456 - Browse repository at this point
Copy the full SHA f747456View commit details -
Merge pull request kubernetes-sigs#2000 from shiftstack/issue1999
🐛 Rules are optional in security group rules before v1beta1
Configuration menu - View commit details
-
Copy full SHA for 78f7b3f - Browse repository at this point
Copy the full SHA 78f7b3fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 55918b1 - Browse repository at this point
Copy the full SHA 55918b1View commit details -
API validations: cleanup objects after creation
* Adds a helper function which registers a cleanup helper if an object was created * Moves infrav1 tests under a separate context in anticipation of adding other version tests.
Configuration menu - View commit details
-
Copy full SHA for 038c11f - Browse repository at this point
Copy the full SHA 038c11fView commit details -
Fix API conversion webhooks in the apivalidation tests
API versions must be registered in the scheme before starting the envtest in order for conversion webhooks to be registered.
Configuration menu - View commit details
-
Copy full SHA for c59ee80 - Browse repository at this point
Copy the full SHA c59ee80View commit details -
Merge pull request kubernetes-sigs#1998 from elastx/issue#1997
🐛 Make floatingIPNetwork a pointer and if there's only one external network use it as default
Configuration menu - View commit details
-
Copy full SHA for d2d1cb2 - Browse repository at this point
Copy the full SHA d2d1cb2View commit details
Commits on Apr 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fe80a3f - Browse repository at this point
Copy the full SHA fe80a3fView commit details -
Merge pull request kubernetes-sigs#2001 from shiftstack/validationtes…
…tcleanups 🌱 Minor improvements to api validation tests
Configuration menu - View commit details
-
Copy full SHA for b7a6685 - Browse repository at this point
Copy the full SHA b7a6685View commit details
Commits on Apr 8, 2024
-
feat: add configurable loadbalancer network
Previously when loadbalacer was created it used the same network/subnet as the control plane nodes for the VIP. This was not always the right assumption as some users might want to be able to customize this according to their env. This commit fixes the above by adding two fields into OpenStackClusterSpec/Status two fields `network` and `subnets` under `APIServerLoadBalancer` so that user can define which network/subnet to use for allocation of the loadbalancer. Signed-off-by: Ondrej Blazek <ondrej.blazek@firma.seznam.cz>
Configuration menu - View commit details
-
Copy full SHA for e2897fb - Browse repository at this point
Copy the full SHA e2897fbView commit details -
Merge pull request kubernetes-sigs#2003 from shiftstack/docs_migratio…
…n_instanceid 📖 Document the change of instanceID in v1beta1
Configuration menu - View commit details
-
Copy full SHA for 6c83bc4 - Browse repository at this point
Copy the full SHA 6c83bc4View commit details
Commits on Apr 9, 2024
-
Don't try to resolve machine on delete if cluster not ready
This fixes a bug where if we created a machine for a cluster which never became ready, we would never be able to 'resolve' the machine and therefore never delete it. We address this situation in several layers: Firstly, we move the point in the machine controller at which we add the finalizer in the first place. We don't add the finalizer until we're writing resolved, so this situation can never occur for newly created machines. This makes sense because we don't create resources until we've observed that both the finalizer has been added and resolved is up to date, so we don't need the finalizer to protect resources which can't have been created yet. Secondly, we shortcut the delete flow if the cluster is not ready. This is safe for the same reason as above, but is only relevant to machines created before v0.10. Lastly we surface and restrict the circumstances in which 'Resolved' is required on delete anyway. On closer inspection, this is only required in the very specific circumstance that the machine has volumes defined, and we are deleting it without the machine having been created. To make this more obvious we split volume deletion out of DeleteInstance and only resolve the machine spec in the event that it's required. 2 other factors make this change larger than it might otherwise be. We hit a cyclomatic complexity limit in reconcileDelete(), requiring a refactor. We remove the DeleteInstance tests which, after separating out DeleteVolumes, are quite trivial, and replace them with much more comprehensive set of tests for reconcileDelete.
Configuration menu - View commit details
-
Copy full SHA for 9ebb706 - Browse repository at this point
Copy the full SHA 9ebb706View commit details -
Merge pull request kubernetes-sigs#1922 from oblazek/ob-loadbalancer-…
…network feat: add configurable loadbalancer network
Configuration menu - View commit details
-
Copy full SHA for 9aaf481 - Browse repository at this point
Copy the full SHA 9aaf481View commit details -
Merge pull request kubernetes-sigs#1996 from elastx/issue#1985
🐛 Include more device_owners when looking for a port for floating ip
Configuration menu - View commit details
-
Copy full SHA for 626738a - Browse repository at this point
Copy the full SHA 626738aView commit details
Commits on Apr 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6d74e98 - Browse repository at this point
Copy the full SHA 6d74e98View commit details -
Configuration menu - View commit details
-
Copy full SHA for 43d2499 - Browse repository at this point
Copy the full SHA 43d2499View commit details
Commits on Apr 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4ce032d - Browse repository at this point
Copy the full SHA 4ce032dView commit details -
Merge pull request kubernetes-sigs#2010 from shiftstack/cleanuptestsg
🌱 Cleanup security group created by e2e test
Configuration menu - View commit details
-
Copy full SHA for c834e9c - Browse repository at this point
Copy the full SHA c834e9cView commit details -
Merge pull request kubernetes-sigs#2006 from shiftstack/issue1792
🐛 Don't try to resolve machine on delete if cluster not ready
Configuration menu - View commit details
-
Copy full SHA for 7925a4b - Browse repository at this point
Copy the full SHA 7925a4bView commit details -
This deprecates k8s.io/util/pointer, which we replace with k8s.io/util/ptr to keep the linter happy.
Configuration menu - View commit details
-
Copy full SHA for d04c4d5 - Browse repository at this point
Copy the full SHA d04c4d5View commit details -
Merge pull request kubernetes-sigs#2004 from shiftstack/apiserver-lb-azs
Add opt to use AZ for APISeverLoadBalancer
Configuration menu - View commit details
-
Copy full SHA for 7e34a22 - Browse repository at this point
Copy the full SHA 7e34a22View commit details -
Allow explicitly empty volume AZ
Replaces an AvailabilityZone string for volumes with a VolumeAvailabilityZone struct which allows more flexibility in defaulting behaviour. Specifically it enables us to express both the current default behaviour where we take the volume AZ from the Machine, and a new default behaviour where to don't specify a volume AZ at all. In making this change to both RootVolume and AdditionalBlockDevices we use common code for both APIs. This has the result of updating RootVolume to be consistent with AdditionalBlockDevices.
Configuration menu - View commit details
-
Copy full SHA for 9aa449c - Browse repository at this point
Copy the full SHA 9aa449cView commit details
Commits on Apr 12, 2024
-
Merge pull request kubernetes-sigs#2014 from shiftstack/pointer-to-ptr
🌱 Bump k8s dep to 0.29.3
Configuration menu - View commit details
-
Copy full SHA for 639ca12 - Browse repository at this point
Copy the full SHA 639ca12View commit details -
Merge pull request kubernetes-sigs#2008 from shiftstack/volumeaz
⚠️ Allow explicitly empty volume AZConfiguration menu - View commit details
-
Copy full SHA for 8c7e661 - Browse repository at this point
Copy the full SHA 8c7e661View commit details -
Merge pull request kubernetes-sigs#2011 from shiftstack/issue2009
🐛 Fix idempotent restore when setting ControlPlaneEndpoint
Configuration menu - View commit details
-
Copy full SHA for 4cf3c1b - Browse repository at this point
Copy the full SHA 4cf3c1bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2837b29 - Browse repository at this point
Copy the full SHA 2837b29View commit details -
Configuration menu - View commit details
-
Copy full SHA for 118f715 - Browse repository at this point
Copy the full SHA 118f715View commit details -
Merge pull request kubernetes-sigs#2017 from shiftstack/issue2016
🐛 Fix crash on delete with no bastion
Configuration menu - View commit details
-
Copy full SHA for f4e5bdf - Browse repository at this point
Copy the full SHA f4e5bdfView commit details
Commits on Apr 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b1e4390 - Browse repository at this point
Copy the full SHA b1e4390View commit details