Merge master to stable for release 0.17.0 #1519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add job id adv type. clean up css for hint, add margin to bottom of ncj form * as per review * commit so can work from home * validation give up * More validation * Parameter input * tests
* fix css for action links * reset other css * make hover slightly lighter than background so it doesnt disappear completely * also fix the CSS for cloud file picker and SAS picker that got broken with input prefix
* Begin work on one click connect feature * Terminal launches and persists on windows * Successfully connect with applicable username The user may set their own username in settings if they wish, and it will automatically connect using that. Otherwise, a random six-letter string will be used. Connection works from a windows local OS to a host Linux node. * Add support to connect to linux node from a linux machine * Add tooltip to quickstart button when disabled * Add support for connecting to linux on mac terminal * Update settings variable names * Update .gitignore; remove untracked files * Change proc to process in terminal-service.ts * Explicitly state types in launchApplication declaration * Split arguments into name and application args * Make travis build-and-test file executable * Add test for quickstart button, node-connect.component * More rigid tests for node-connect component * Add tests for terminalService; all tests run and pass * Remove console logs * Move connectionSettings from ngOnUpdate * Fix linter errors and spec change * hopefully fix CI build * Fix typo * Fix prod build
* delete button added to html, no functionality #1379 * pinned items can now be removed from dropdown * Delete Button icon added #1379 * Add Pool and Certificate Titles created for bookmark dropdown * adding context menu to favorite ddl * Favorites unpin with middle mouse click #1379 * couple of fixes * small fixed based on comments #1379 * fix up CSS * lint * tests for remove logic * lint error * small fixes * add other type to methods * title to [title]
* Redesign inital part of node connect form * Add loading icon while waiting for connection * Add finishing touches to main and connect menus * Add ngModel directive to username * Validate password on main page for windows * Update const Application to ExternalApplication * Merge in master, and display IP in all cases * Add loader to connect button for ssh * Add download rdp button, migrate download-rdp component to node-connect * Add server error message to node-connect component * Enable RDP * NodeUserCredentials Form sends information back to the main template * Update node-connect.component.spec.ts and migrate tests from download-rdp.component.spec.ts * Fix tests and css * Revert package-lock.json * Code cleanup Split node-connect into two components and add a service * Update unit tests, add tests for new component * revert package-lock.json * Fix unit tests * Working dataflow in modular structure * Enable linux connection with password * Update unit tests * Fix alignment in .vscode/settings.json * Remove unused variables * Disable automatic ssh, utilize two-way data binding * Connect button is always enabled * Remove unused section from node-property-display.html * Update rxjs references to v6 * Remove nodeAgentSkus
* first go at workspace * placeholder to create directory * comments * create basic templates, read templates, workspace definition * more definition * andrew * workspaces dropdown added * found issue with DDL. [footer]='false' was overflowing footer * move loaded * moved metadata up one level and renamed to workspace setting fields to 'features' * small fix in workspaceDefinition * expanded workspace definitions with interfaces for each CommonFeature * remove current workspace subscriber * add isFeatureEnabled to workspace service * moar definitions * add current workspace id observable, might need to delete currentWorkpace, we will see * add directive, not working * fixed * working, plus changed workspace selector * partially revert what i just did * testing skeleton * initial tests * commit while sorting out tests for nehal * json * getting tests working * tests for when no workspaces and when 1 and 2 workspaces * css for quicksearch filter browse layout. tooltips and other stuff * Entity configuration * fix up css colors * add subscriber to current workspace and push changes to UI * persist currently selected workspace * testing workspace dropdown complete * ok so we can call jobs done * more changes * fix up schedules * schedule, tags and json config view * Use command name to pick which feature to enable * More * Fix * Missing files * Tags removed from end user view: Pools * Action buttons: clone, pin and export hiden from pools * clean up and fix hiding buttons * Hid appropriate action buttons in end user workspace for jobs, pool and data * end user json updated * pool view features hidden * updating json and workspace model - bug fix * pinned dropdown hidden in basic end user view * tlint fixes * review changes * feature view hiding fixed * small fixes * fixing build errors, reverting end-user json tag var names * fix up broken tests * fix broken entity buttons. add space to graph DDL * fix flask reference lint errors * travis build error potential fix * stop job-id validation for every keypress. multiple feature handling in single request * fix job-id component tests * spelling * comment out broken async tests to see if the build works * workspace service test spec initial outline * Update settings.json * import errors fixed and workspace service testing - requires something to detect changes * testing minor changes * workspace service tests * tests workspace service feature enabled and disabled * tims review changes * change fixture description slightly * comment out manage workspace ddl item. * add change detector to directive * unsure how that got in there ... * _ broke build. figure it's required as Tim did it. * Fix setinterval error * Fix setinterval error * as per PR comments * uncomment jobId tests, fix up RXJS
Codecov Report
@@ Coverage Diff @@
## stable #1519 +/- ##
==========================================
+ Coverage 53.64% 60.87% +7.23%
==========================================
Files 1020 1077 +57
Lines 24267 25254 +987
Branches 2788 3497 +709
==========================================
+ Hits 13017 15374 +2357
+ Misses 11250 9880 -1370
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.17.0
All items
Feature:
Bug fixes:
Accessibility:
Other: