merge #10
Merged
merge #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add additional tag tests add arn resource + test update doc remove tags_apigateway.go file use enums where applicable
Output from acceptance testing: ``` --- PASS: TestAccAWSAMI_snapshotSize (47.60s) --- PASS: TestAccAWSAMI_basic (48.16s) --- PASS: TestAccAWSAMI_tags (59.53s) ```
…ckage (#10753) Output from AWS Commercial: ``` --- PASS: TestAccAWSCloudWatchLogGroup_disappears (7.38s) --- PASS: TestAccAWSCloudWatchLogGroup_namePrefix (9.73s) --- PASS: TestAccAWSCloudWatchLogGroup_basic (12.21s) --- PASS: TestAccAWSCloudWatchLogGroup_generatedName (14.72s) --- PASS: TestAccAWSCloudWatchLogGroup_multiple (15.03s) --- PASS: TestAccAWSCloudWatchLogGroup_retentionPolicy (15.13s) --- PASS: TestAccAWSCloudWatchLogGroup_namePrefix_retention (17.91s) --- PASS: TestAccAWSCloudWatchLogGroup_tagging (29.56s) --- PASS: TestAccAWSCloudWatchLogGroup_kmsKey (36.66s) ``` Output from AWS GovCloud (US): ``` --- PASS: TestAccAWSCloudWatchLogGroup_disappears (7.85s) --- PASS: TestAccAWSCloudWatchLogGroup_basic (9.39s) --- PASS: TestAccAWSCloudWatchLogGroup_generatedName (10.20s) --- PASS: TestAccAWSCloudWatchLogGroup_namePrefix_retention (12.38s) --- PASS: TestAccAWSCloudWatchLogGroup_retentionPolicy (12.57s) --- PASS: TestAccAWSCloudWatchLogGroup_namePrefix (12.59s) --- PASS: TestAccAWSCloudWatchLogGroup_multiple (16.86s) --- PASS: TestAccAWSCloudWatchLogGroup_tagging (19.05s) --- PASS: TestAccAWSCloudWatchLogGroup_kmsKey (40.68s) ```
Output from acceptance testing: ``` --- PASS: TestAccAWSSwfDomain_NamePrefix (13.27s) --- PASS: TestAccAWSSwfDomain_GeneratedName (13.30s) --- PASS: TestAccAWSSwfDomain_basic (13.34s) --- PASS: TestAccAWSSwfDomain_Description (13.66s) --- PASS: TestAccAWSSwfDomain_tags (30.87s) ```
…luetags package (#10756) Output from acceptance testing: ``` --- PASS: TestAccAWSCloudFormationStack_dataSource_yaml (58.17s) --- PASS: TestAccAWSCloudFormationStack_dataSource_basic (67.22s) ```
r/aws_launch_template: Tag on create
) Output from acceptance testing: ``` --- SKIP: TestAccAWSEc2Fleet_LaunchTemplateConfig_Override_MaxPrice (0.00s) --- PASS: TestAccAWSEc2Fleet_disappears (42.43s) --- PASS: TestAccAWSEc2Fleet_basic (42.61s) --- PASS: TestAccAWSEc2Fleet_TargetCapacitySpecification_DefaultTargetCapacityType (65.16s) --- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfig_Override_Priority (68.59s) --- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfig_LaunchTemplateSpecification_Version (68.95s) --- PASS: TestAccAWSEc2Fleet_SpotOptions_InstanceInterruptionBehavior (69.67s) --- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfig_Override_WeightedCapacity (69.58s) --- PASS: TestAccAWSEc2Fleet_SpotOptions_InstancePoolsToUseCount (69.90s) --- PASS: TestAccAWSEc2Fleet_SpotOptions_AllocationStrategy (71.31s) --- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfig_Override_AvailabilityZone (71.36s) --- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfig_Override_Priority_Multiple (71.31s) --- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfig_Override_InstanceType (71.44s) --- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfig_Override_WeightedCapacity_Multiple (71.70s) --- PASS: TestAccAWSEc2Fleet_ReplaceUnhealthyInstances (71.92s) --- PASS: TestAccAWSEc2Fleet_OnDemandOptions_AllocationStrategy (72.08s) --- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfig_LaunchTemplateSpecification_LaunchTemplateId (72.12s) --- PASS: TestAccAWSEc2Fleet_TargetCapacitySpecification_DefaultTargetCapacityType_OnDemand (30.06s) --- PASS: TestAccAWSEc2Fleet_TargetCapacitySpecification_DefaultTargetCapacityType_Spot (30.11s) --- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfig_Override_SubnetId (72.82s) --- PASS: TestAccAWSEc2Fleet_LaunchTemplateConfig_LaunchTemplateSpecification_LaunchTemplateName (73.05s) --- PASS: TestAccAWSEc2Fleet_ExcessCapacityTerminationPolicy (95.00s) --- PASS: TestAccAWSEc2Fleet_Type (26.85s) --- PASS: TestAccAWSEc2Fleet_Tags (97.60s) --- PASS: TestAccAWSEc2Fleet_TerminateInstancesWithExpiration (48.92s) --- PASS: TestAccAWSEc2Fleet_TargetCapacitySpecification_TotalTargetCapacity (457.29s) ```
Output from acceptance testing: ``` --- PASS: TestAccAWSCloudFormationStack_yaml (63.93s) --- PASS: TestAccAWSCloudFormationStack_disappears (66.27s) --- PASS: TestAccAWSCloudFormationStack_basic (66.37s) --- PASS: TestAccAWSCloudFormationStack_defaultParams (59.60s) --- PASS: TestAccAWSCloudFormationStack_allAttributes (74.47s) --- PASS: TestAccAWSCloudFormationStack_withUrl_withParams_withYaml (64.79s) --- PASS: TestAccAWSCloudFormationStack_withUrl_withParams_noUpdate (75.45s) --- PASS: TestAccAWSCloudFormationStack_withParams (109.61s) --- PASS: TestAccAWSCloudFormationStack_withUrl_withParams (117.44s) ```
Output from acceptance testing: ``` --- PASS: TestAccAWSSSMMaintenanceWindowTask_emptyNotificationConfig (12.47s) --- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationStepFunctionParameters (13.21s) --- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskParameters (14.11s) --- PASS: TestAccAWSSSMMaintenanceWindowTask_updateForcesNewResource (19.92s) --- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationRunCommandParameters (21.25s) --- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationAutomationParameters (21.32s) --- PASS: TestAccAWSSSMMaintenanceWindowTask_basic (22.05s) --- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationLambdaParameters (28.96s) ```
This check ensures that all resource and data source docs have a subcategory specified, so that the Terraform Registry can properly render the docs navigation.
This was removed, but should show up in the subcategory on the Terraform Registry, and not the top-level data sources folder.
We will soon be displaying documentation for this provider both on [terraform.io](https://www.terraform.io/docs/providers/index.html) and on [the Terraform Registry](https://registry.terraform.io/providers). Documentation displayed on the Terraform Registry will not use the ERB layout containing the existing navigation, and will instead build the navigation dynamically based on the directory and YAML frontmatter of a file. For providers that group similar resources and data sources by service or use case (subcategories), we'll need to add this information to the Markdown source file. This modifies Resource and Data Source documentation source files by adding a subcategory to the metadata if those files were grouped previously. For more information about how documentation is rendered on the Terraform Registry, please see this reference: [Terraform Registry - Provider Documentation](https://www.terraform.io/docs/registry/providers/docs.html).
…-docs-preparation website: Add subcategories to docs for display on the Terraform Registry
Output from acceptance testing: ``` --- PASS: TestAccAWSEBSVolume_withTags (22.85s) --- PASS: TestAccAWSEbsVolumeDataSource_basic (23.47s) --- PASS: TestAccAWSEBSVolume_NoIops (24.20s) --- PASS: TestAccAWSEBSVolume_basic (24.24s) --- PASS: TestAccAWSEbsVolumeDataSource_multipleFilters (24.38s) --- PASS: TestAccAWSEBSVolume_updateType (39.55s) --- PASS: TestAccAWSEBSVolume_updateSize (40.22s) --- PASS: TestAccAWSEBSVolume_updateIops (41.02s) --- PASS: TestAccAWSEBSVolume_kmsKey (43.46s) --- PASS: TestAccAWSEBSVolume_updateAttachedEbsVolume (149.67s) ```
…s package. (#10775) Output from acceptance testing: ``` --- SKIP: TestAccAWSEc2CapacityReservation_tenancy (0.00s) --- PASS: TestAccAWSEc2CapacityReservation_ephemeralStorage (11.85s) --- PASS: TestAccAWSEc2CapacityReservation_ebsOptimized (12.03s) --- PASS: TestAccAWSEc2CapacityReservation_instanceMatchCriteria (13.00s) --- PASS: TestAccAWSEc2CapacityReservation_basic (13.05s) --- PASS: TestAccAWSEc2CapacityReservation_instanceCount (18.59s) --- PASS: TestAccAWSEc2CapacityReservation_endDate (19.48s) --- PASS: TestAccAWSEc2CapacityReservation_instanceType (19.68s) --- PASS: TestAccAWSEc2CapacityReservation_tags (24.69s) --- PASS: TestAccAWSEc2CapacityReservation_endDateType (24.72s) ```
…constants (#10797) Output from acceptance testing: ``` --- PASS: TestAccAWSSQSQueue_ExpectContentBasedDeduplicationError (7.85s) --- PASS: TestAccAWSSQSQueue_FIFOExpectNameError (7.97s) --- PASS: TestAccAWSSQSQueue_Encryption (12.30s) --- PASS: TestAccAWSSQSQueue_FIFO (13.44s) --- PASS: TestAccAWSSQSQueue_namePrefix_fifo (14.22s) --- PASS: TestAccAWSSQSQueue_namePrefix (14.31s) --- PASS: TestAccAWSSQSQueue_redrivePolicy (14.47s) --- PASS: TestAccAWSSQSQueuePolicy_basic (14.83s) --- PASS: TestAccAWSSQSQueue_FIFOWithContentBasedDeduplication (15.08s) --- PASS: TestAccAWSSQSQueue_Policybasic (14.99s) --- PASS: TestAccAWSSQSQueue_policy (15.18s) --- PASS: TestAccAWSSQSQueue_basic (23.56s) --- PASS: TestAccAWSSQSQueue_tags (24.21s) --- PASS: TestAccAWSSQSQueue_queueDeletedRecently (84.02s) ```
…ain list tags errors Reference: #10797 (review)
Output from acceptance testing: ``` --- PASS: TestAccAWSAPIGatewayStage_accessLogSettings (208.06s) --- PASS: TestAccAWSAPIGatewayStage_basic (414.68s)
…d alphabetize Reference: #10570 (review)
Output from acceptance testing: ``` --- PASS: TestAccAWSAPIGatewayUsagePlan_throttlingInitialRateLimit (42.37s) --- PASS: TestAccAWSAPIGatewayUsagePlan_basic (129.58s) --- PASS: TestAccAWSAPIGatewayUsagePlan_productCode (307.70s) --- PASS: TestAccAWSAPIGatewayUsagePlan_apiStages (342.27s) --- PASS: TestAccAWSAPIGatewayUsagePlan_description (371.72s) --- PASS: TestAccAWSAPIGatewayUsagePlan_throttling (400.19s) --- PASS: TestAccAWSAPIGatewayUsagePlan_quota (500.22s) ```
…ackage (#10786) Output from acceptance testing: ``` --- SKIP: TestAccAWSCloudFormationStackSet_Parameters_Default (0.00s) --- SKIP: TestAccAWSCloudFormationStackSet_Parameters_NoEcho (0.00s) --- PASS: TestAccAWSCloudFormationStackSet_Description (23.40s) --- PASS: TestAccAWSCloudFormationStackSet_Name (27.19s) --- PASS: TestAccAWSCloudFormationStackSet_Parameters (39.54s) --- PASS: TestAccAWSCloudFormationStackSet_disappears (41.55s) --- PASS: TestAccAWSCloudFormationStackSet_basic (41.82s) --- PASS: TestAccAWSCloudFormationStackSet_TemplateUrl (50.20s) --- PASS: TestAccAWSCloudFormationStackSet_TemplateBody (53.26s) --- PASS: TestAccAWSCloudFormationStackSet_ExecutionRoleName (79.36s) --- PASS: TestAccAWSCloudFormationStackSet_AdministrationRoleArn (79.94s) --- PASS: TestAccAWSCloudFormationStackSet_Tags (96.49s) ```
…tags.WafListTags() (#10798) Output from acceptance testing: ``` --- PASS: TestAccAWSWafRule_disappears (37.44s) --- PASS: TestAccAWSWafRule_changeNameForceNew (78.08s) --- PASS: TestAccAWSWafRule_Tags (97.69s) --- PASS: TestAccAWSWafRule_basic (109.39s) --- PASS: TestAccAWSWafRule_noPredicates (120.43s) --- PASS: TestAccAWSWafRule_changePredicates (137.63s) --- PASS: TestAccAWSWafRule_geoMatchSetPredicate (171.14s) ```
…yvaluetags.WafListTags() (#10799) Output from acceptance testing: ``` --- PASS: TestAccAWSWafRuleGroup_noActivatedRules (19.50s) --- PASS: TestAccAWSWafRuleGroup_basic (34.23s) --- PASS: TestAccAWSWafRuleGroup_changeNameForceNew (40.88s) --- PASS: TestAccAWSWafRuleGroup_Tags (41.96s) --- PASS: TestAccAWSWafRuleGroup_disappears (59.83s) --- PASS: TestAccAWSWafRuleGroup_changeActivatedRules (75.38s) ```
Output from acceptance testing: ``` --- PASS: TestAccAWSDataSourceIAMGroup_basic (10.27s) --- PASS: TestAccAWSDataSourceIAMGroup_users (12.62s) ```
…10801) Output from acceptance testing (failure unrelated): ``` --- PASS: TestAccAWSWafWebAcl_disappears (12.41s) --- PASS: TestAccAWSWafWebAcl_basic (16.78s) --- PASS: TestAccAWSWafWebAcl_DefaultAction (27.95s) --- PASS: TestAccAWSWafWebAcl_Tags (42.49s) --- PASS: TestAccAWSWafWebAcl_changeNameForceNew (51.29s) --- FAIL: TestAccAWSWafWebAcl_Rules (61.07s) --- PASS: TestAccAWSWafWebAcl_LoggingConfiguration (109.63s) ```
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes #0000
Release note for CHANGELOG:
Output from acceptance testing: