Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move mustache typings to devDependencies #24165

Merged

Conversation

weltenwort
Copy link
Member

Summary

This moves the @types/mustache package from dependencies to devDependencies to avoid unnecessary inclusion in the build artifacts.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@weltenwort weltenwort added :Ingest UI Feature:Metrics UI Metrics UI feature loe:small Small Level of Effort labels Oct 17, 2018
@weltenwort weltenwort self-assigned this Oct 17, 2018
@elasticmachine
Copy link
Contributor

💔 Build Failed

@weltenwort weltenwort force-pushed the infra-ui-fix-mustache-type-deps branch from 5e18374 to 2762872 Compare October 18, 2018 08:20
@weltenwort
Copy link
Member Author

rebased on master, trying again...

@elasticmachine
Copy link
Contributor

💔 Build Failed

@weltenwort
Copy link
Member Author

that was quick...

00:06:48.568 FATAL: no longer a configured node for kibana-ci-immutable-flyweight-1539850858081048102
00:06:48.569 java.lang.IllegalStateException: no longer a configured node for kibana-ci-immutable-flyweight-1539850858081048102
00:06:48.569 	at hudson.model.AbstractBuild$AbstractBuildExecution.getCurrentNode(AbstractBuild.java:415)
00:06:48.569 	at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:455)
00:06:48.569 	at com.tikal.jenkins.plugins.multijob.MultiJobBuild$MultiJobRunnerImpl.run(MultiJobBuild.java:148)
00:06:48.569 	at hudson.model.Run.execute(Run.java:1815)
00:06:48.569 	at com.tikal.jenkins.plugins.multijob.MultiJobBuild.run(MultiJobBuild.java:76)
00:06:48.569 	at hudson.model.ResourceController.execute(ResourceController.java:97)
00:06:48.569 	at hudson.model.Executor.run(Executor.java:429)
00:06:48.588 Setting status of 2762872094617cb603edcb5e4a99bb9812249db8 to FAILURE with url https://kibana-ci.elastic.co/job/elastic-kibana-pull-request/5239/ and message: 'Build finished. '

jenkins, test this again... I guess... 🎠

@elasticmachine
Copy link
Contributor

💔 Build Failed

@weltenwort
Copy link
Member Author

00:00:48.598 Installing dependencies in [@kbn/babel-preset]:
00:00:48.599 
00:00:49.082 [1/4] Resolving packages...
00:00:49.181 [2/4] Fetching packages...
00:01:19.310 error An unexpected error occurred: "https://registry.yarnpkg.com/babel-helper-function-name/-/babel-helper-function-name-6.24.1.tgz: ETIMEDOUT".
00:01:19.310 info If you think this is a bug, please open a bug report with the information provided in "/var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-intake/kibana/packages/kbn-babel-preset/yarn-error.log".
00:01:19.313 info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
00:01:19.323 
00:01:19.323 [bootstrap] failed:
00:01:19.323 
00:01:19.328 Error: Command failed: yarn install --check-files --non-interactive --mutex=file
00:01:19.328     at makeError (/var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-intake/kibana/packages/kbn-pm/dist/index.js:35532:9)
00:01:19.328     at Promise.all.then.arr (/var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-intake/kibana/packages/kbn-pm/dist/index.js:35637:16)
00:01:19.332     at <anonymous>
00:01:19.332     at process._tickCallback (internal/process/next_tick.js:188:7)
00:01:19.335 error Command failed with exit code 1.

jenkins, test this again 🎠

@elasticmachine
Copy link
Contributor

💔 Build Failed

@weltenwort
Copy link
Member Author

00:53:51.146              └- ✖ fail: "dashboard app using legacy data dashboard clone Clones on confirm duplicate title warning"
00:53:51.146              │      retry.try timeout: Error: retry.try timeout: [POST http://localhost:9515/session/39655221907c830631546fd42c75932a/element/0.8136785890260154-73/click] unknown error: Element <a class="kuiLocalBreadcrumb__link" href="#/dashboards">...</a> is not clickable at point (227, 14). Other element would receive the click: <div class="euiOverlayMask">...</div>
00:53:51.146              │   (Session info: chrome=70.0.3538.67)
00:53:51.150              │   (Driver info: chromedriver=2.42.591071 (0b695ff80972cc1a65a5cd643186d2ae582cd4ac),platform=Linux 3.10.0-862.14.4.el7.x86_64 x86_64)

looks like a flaky dashboard test... jenkins, test this once more

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Member

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weltenwort weltenwort merged commit 5441d74 into elastic:master Oct 18, 2018
weltenwort added a commit to weltenwort/kibana that referenced this pull request Oct 18, 2018
This moves the `@types/mustache` package from `dependencies` to `devDependencies` to avoid unnecessary inclusion in the build artifacts.
weltenwort added a commit that referenced this pull request Oct 18, 2018
Backports the following commits to 6.x:
 - Move mustache typings to devDependencies  (#24165)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Metrics UI Metrics UI feature loe:small Small Level of Effort
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants