-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move mustache typings to devDependencies #24165
Merged
weltenwort
merged 1 commit into
elastic:master
from
weltenwort:infra-ui-fix-mustache-type-deps
Oct 18, 2018
Merged
Move mustache typings to devDependencies #24165
weltenwort
merged 1 commit into
elastic:master
from
weltenwort:infra-ui-fix-mustache-type-deps
Oct 18, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weltenwort
added
:Ingest UI
Feature:Metrics UI
Metrics UI feature
loe:small
Small Level of Effort
labels
Oct 17, 2018
tylersmalley
approved these changes
Oct 17, 2018
💔 Build Failed |
weltenwort
force-pushed
the
infra-ui-fix-mustache-type-deps
branch
from
October 18, 2018 08:20
5e18374
to
2762872
Compare
rebased on |
💔 Build Failed |
that was quick...
jenkins, test this again... I guess... 🎠 |
💔 Build Failed |
jenkins, test this again 🎠 |
💔 Build Failed |
looks like a flaky dashboard test... jenkins, test this once more |
💚 Build Succeeded |
mistic
approved these changes
Oct 18, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
weltenwort
added a commit
to weltenwort/kibana
that referenced
this pull request
Oct 18, 2018
This moves the `@types/mustache` package from `dependencies` to `devDependencies` to avoid unnecessary inclusion in the build artifacts.
weltenwort
added a commit
that referenced
this pull request
Oct 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This moves the
@types/mustache
package fromdependencies
todevDependencies
to avoid unnecessary inclusion in the build artifacts.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately[ ] This includes a feature addition or change that requires a release note and was labeled appropriately