Skip to content

Conversation

@will-
Copy link
Contributor

@will- will- commented Sep 9, 2017

No description provided.

cclauss and others added 30 commits January 5, 2018 02:43
* feat(ui): Add "readonly" text input with copy button
* feat(ui): Tweak form field layout
Force rerender when selected group store is changed
Changes the following views:
* Issue tracking
* Plugin Details
* Release Tracking

* small refactor to plugin action creators, add a simple throttle to fetchPlugins actions
* Add HoC for "plugins"
* fix project settings in new settings, that requires project context
* fix link from new project settings -> old
* add plugin navigation menu component
* change acceptance to wait until indicator disappears
)

* ref: Change SentryInternalClient to use regular pipeline

Send the event to the StoreApi view using a generated Request object. This is so that the events go through all the same steps as regular events, instead of a custom reimplementation of the event saving logic that had some bugs.
Every event is now inserted at the same time. In some cases more than
100 being inserted at once.

Right now, this falls back on the Django default behavior for each
EventTag object and stamps out a `timezone.now()` call.

This just simply avoids the overhead and we explicitly assign a value to
all of them at the same time. There's no reason to calculate a new value
for each row.
In production, emotion does not insert styles into DOM (rather CSSOM).

On travis we build with NODE_ENV=production, so turn off above behavior when we are 1) in travis env, 2) detect a percy token.
This exposes 'cancelDeletion' on the PUT /organizations/:id/ endpoint and moves the restore organization server-rendered view to use the endpoint.

Additionally it:

- changes OrganizationStatus to use IntEnum
- adds OrganizationStatus.ACTIVE to supercede VISIBLE
- allows restoration even after a deletion has begun (accept the consequences).
- exposes 'status' in the organization details API
- allows fetching data for organizations which are in deletion phases
* ref: Swap (most) usage of integration 'id' to 'key'
* ref(identity): Refactor models
* feat: Implement generic identity association pipeline

Refactors integrations to compose the identity provider found in the
sentry.identity module.
…forced (getsentry#6877)

* Added methods to email 2fa noncompliant users in an organization to setup 2fa.

* added email debug view, moved sending 2fa emails to organization only.

* Added sending emails to the endpoint

* fixed setup_2fa.txt spacing. edited org and org details based on feedback.

* Added a test to check that an owner can disable enforce 2fa
…#6887)

* Don't hard-cap EventMapping retention at 7d.

* Move EventMapping to vanilla BulkDeleteQuery.

* Add order_by clause to bulk delete EventMapping.
* Added a resend code link to sms 2fa page

* removed in-line js
- Override most organization pages to show deletion notification (React)
- Fix 'status.id' to be lowercase in API response
* fix(minidump): Respond with formatted UUID only

* feat: Allow symbolication of linux symbols

* fix(minidump): Reverse frame order to appear correctly

* fix(minidump): Fix version parsing for Linux
…nd tabs (getsentry#6914)

* fix(settings): refactor settings page header to support titles and tabs

* Remove outdated comments
* ref(csp): Validate CSP reports with JSON schema

In preparation for accepting other types of browser security reports,
start using JSON schema to validate the structure of these documents
to avoid duplicating a bunch of manual validation for the different
report types.

* feat: Expect-CT and Expect-Staple support

Refactored the CSP endpoint and helpers to allow for support of these
violation reports. Added schema validation and filtering logic to make
it easier to add more interfaces in future. Each can be checked against
its own schema. Create a new `/security` endpoint that all types of 
reports go to. The type is inferred from the content.
macqueen and others added 19 commits February 1, 2018 13:13
* Change sudo endpoint to respond with 204
* remove updating password from user details endpoint
* move modifying user appearance options into user details endpoint
* change stacktraceOrder to be an int
…entry#6953)

Also makes "All environments" the default if one is not set, and none of the names matches the list of likely production names
…7136)

Will be required for React UI to close an account
* add validations when deleting user acct
* Add icon-circle svgs

* use currentColor instead of pure black
@ghost
Copy link

ghost commented Feb 4, 2018

3 Warnings
⚠️ Changes to build requirements
⚠️ Changes require @getsentry/security sign-off
⚠️ PR includes migrations

Security concerns found

  • examples/oauth2_consumer_webserver/app.py
  • src/sentry/api/endpoints/auth_index.py
  • src/sentry/api/endpoints/authenticator_index.py
  • src/sentry/api/endpoints/organization_auth_provider_details.py
  • src/sentry/api/endpoints/organization_auth_provider_send_reminders.py
  • src/sentry/api/endpoints/organization_auth_providers.py
  • src/sentry/api/endpoints/sudo.py
  • src/sentry/api/endpoints/user_emails.py
  • src/sentry/api/permissions.py
  • src/sentry/api/serializers/models/auth_provider.py
  • src/sentry/api/serializers/models/user_social_auth.py
  • src/sentry/api/serializers/models/useremail.py
  • src/sentry/auth/access.py
  • src/sentry/auth/helper.py
  • src/sentry/auth/provider.py
  • src/sentry/auth/providers/dummy.py
  • src/sentry/auth/providers/saml2.py
  • src/sentry/auth/superuser.py
  • src/sentry/auth/utils.py
  • src/sentry/{integrations/oauth.py => identity/oauth2.py}
  • src/sentry/middleware/auth.py
  • src/sentry/models/userpermission.py
  • src/sentry/receivers/auth.py
  • src/sentry/tasks/auth.py
  • src/sentry/tasks/email.py
  • src/sentry/utils/email.py
  • src/sentry/web/frontend/accounts_twofactor.py
  • src/sentry/web/frontend/auth_login.py
  • src/sentry/web/frontend/debug/debug_new_user_feedback_email.py
  • src/sentry/web/frontend/debug/debug_setup_2fa_email.py
  • src/sentry/web/frontend/debug/debug_sso_link_email.py
  • src/sentry/web/frontend/organization_auth_settings.py

Migration Checklist

  • new columns need to be nullable (unless table is new)
  • migration with any new index needs to be done concurrently
  • data migrations should not be done inside a transaction
  • before merging, check to make sure there aren't conflicting migration ids

Generated by 🚫 danger

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.