Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4.8.0 proposal #10973

Merged
merged 124 commits into from
Feb 22, 2017
Merged

v4.8.0 proposal #10973

merged 124 commits into from
Feb 22, 2017

Commits on Feb 1, 2017

  1. test,lib,benchmark: match function names

    In most cases, named functions match the variable or property to which
    they are being assigned. That also seems to be the practice in a series
    of PRs currently being evaluated that name currently-anonymous
    functions.
    
    This change applies that rule to instances in the code base that don't
    comply with that practice.
    
    This will be enforceable with a lint rule once we upgrade to ESLint
    3.8.0.
    
    PR-URL: #9113
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    Trott authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    cfa2b87 View commit details
    Browse the repository at this point in the history
  2. deps: V8: fix debug backtrace for symbols

    The cherry-pick of #7612 to v4.x (4369055) added in #9298 wasn't quite
    correct as it depends on a runtime function %SymbolDescriptiveString
    that doesn't exist on v4.x. We can use %SymbolDescription instead.
    
    Ref: #7612
    Ref: #9298
    
    PR-URL: #10732
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    ofrobots authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    81e9a3b View commit details
    Browse the repository at this point in the history
  3. deps: backport d800a65 from V8 upstream

    This backport does not include the original changes to SLOW_DCHECK
    as it does not exist in the V8 in node v4.x
    
    Original commit message:
      Filter out stale left-trimmed handles
    
      BUG=chromium:620553
      LOG=N
      R=jochen@chromium.org
    
      Review-Url: https://codereview.chromium.org/2078403002
      Cr-Commit-Position: refs/heads/master@{#37108}
    
    PR-URL: #10668
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
    Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
    MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    8bd3d83 View commit details
    Browse the repository at this point in the history
  4. deps: backport 7a88ff3 from V8 upstream

    This backport does not include the changes to `src/heap/scavenger.cc`
    as it does not exist in the V8 included in the v4.x stream.
    
    Original commit message:
      Filter out stale left-trimmed handles for scavenges
    
      The missing part from
        https://codereview.chromium.org/2078403002/
    
      R=jochen@chromium.org
      BUG=chromium:621869
      LOG=N
    
      Review-Url: https://codereview.chromium.org/2077353004
      Cr-Commit-Position: refs/heads/master@{#37184}
    
    PR-URL: #10668
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
    Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
    MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    ce66c8e View commit details
    Browse the repository at this point in the history
  5. deps: backport a715957 from V8 upstream

    This commit does not include the changes to `src/heap/scavenger.cc`.
    
    These changes would revert the changes that should have come in
    086bd5aede, meaning that there is no issue with that change missing
    in the previous commit.
    
    Original commit message:
      Iterate handles with special left-trim visitor
    
      BUG=chromium:620553
      LOG=N
      R=hpayer@chromium.org
    
      Review-Url: https://codereview.chromium.org/2102243002
      Cr-Commit-Position: refs/heads/master@{#37366}
    
    PR-URL: #10668
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
    Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
    MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    a234d44 View commit details
    Browse the repository at this point in the history
  6. deps: update patch level in V8

    PR-URL: #10668
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
    Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
    MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    4e07bd4 View commit details
    Browse the repository at this point in the history
  7. v8,src: expose statistics about heap spaces

    Provide means to inspect information about the separate heap spaces
    via a callable API. This is helpful to analyze memory issues.
    
    Fixes: #2079
    PR-URL: #4463
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    bripkens authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    30d60cf View commit details
    Browse the repository at this point in the history
  8. child_process: add shell option to spawn()

    This commit adds a shell option, to spawn() and spawnSync(). This
    option allows child processes to be spawned with or without a
    shell. The option also allows a custom shell to be defined, for
    compatibility with exec()'s shell option.
    
    Fixes: #1009
    PR-URL: #4598
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    cjihrig authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    5824522 View commit details
    Browse the repository at this point in the history
  9. fs: add the fs.mkdtemp() function.

    This uses libuv's mkdtemp function to provide a way to create a
    temporary folder, using a prefix as the path. The prefix is appended
    six random characters. The callback function will receive the name
    of the folder that was created.
    
    Usage example:
    
    fs.mkdtemp('/tmp/foo-', function(err, folder) {
        console.log(folder);
            // Prints: /tmp/foo-Tedi42
    });
    
    The fs.mkdtempSync version is also provided. Usage example:
    
    console.log(fs.mkdtemp('/tmp/foo-'));
        // Prints: tmp/foo-Tedi42
    
    This pull request also includes the relevant documentation changes
    and tests.
    
    PR-URL: #5333
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    ralt authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    2269d7d View commit details
    Browse the repository at this point in the history
  10. process: add process.memoryUsage.external

    PR-URL: #9587
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Roman Reiss <me@silverwind.io>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    indutny authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    23a573f View commit details
    Browse the repository at this point in the history
  11. test: refactor test-net-keepalive.js

    - Replace require() vars with const.
    - Replace assert.equal() with assert.strictEqual().
    - Add common.mustCall() to the setTimeout() callback.
    
    PR-URL: #9995
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    kmccmk9 authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    4f5f0e4 View commit details
    Browse the repository at this point in the history
  12. test: check for error on invalid signal

    Asserts that an error should be thrown when
    an invalid signal is passed to process.kill().
    
    PR-URL: #10026
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    mattcphillips authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    210290d View commit details
    Browse the repository at this point in the history
  13. tools: add macosx-firwall script to avoid popups

    Currently, there are a number of popups that get displayed when running
    the tests asking to accept incoming network connections. Rules can be
    added manually to the socket firewall on Mac OS X but getting this right
    might not be obvious and quite a lot of time can be wasted trying to get
    the rules right. This script hopes to simplify things a little so that
    it can be re-run when needed.
    
    The script should be runnable from both the projects root directory and
    from the tools directory, for example:
    $ sudo ./tools/macosx-firewall.sh
    
    Fixes: #8911
    PR-URL: #10114
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    danbev authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    b5e18f2 View commit details
    Browse the repository at this point in the history
  14. test: stream readableListening internal state

    PR-URL: #9864
    Refs: #8683
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    italoacasas authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    f12bab6 View commit details
    Browse the repository at this point in the history
  15. test: refactor test-handle-wrap-close-abort

    * use common.mustCall() to confirm number of uncaught exceptions
    * var -> const
    * specify duration of 1ms for setTimeout() and setInterval()
    
    PR-URL: #10188
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    Trott authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    278d718 View commit details
    Browse the repository at this point in the history
  16. process: add process.cpuUsage() - implementation, doc, tests

    Backport to v4.x
    
    Original commit message:
      Add process.cpuUsage() method that returns the user and system
      CPU time usage of the current process
    
      PR-URL: #6157
      Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com>
      Reviewed-By: James M Snell <jasnell@gmail.com>
      Reviewed-By: Trevor Norris <trev.norris@gmail.com>
      Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    
    PR-URL: #10796
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
    Reviewed-By: Brian White <mscdex@mscdex.net>
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    Patrick Mueller authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    7a9c8d8 View commit details
    Browse the repository at this point in the history
  17. tls, crypto: add ALPN Support

    cherry-pick 802a2e7 from v6-staging.
    
    ALPN is added to tls according to RFC7301, which supersedes NPN.
    When the server receives both NPN and ALPN extensions from the client,
    ALPN takes precedence over NPN and the server does not send NPN
    extension to the client. alpnProtocol in TLSSocket always returns
    false when no selected protocol exists by ALPN.
    In https server, http/1.1 token is always set when no
    options.ALPNProtocols exists.
    
    PR-URL: #2564
    Reviewed-By: Fedor Indutny <fedor@indutny.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Shigeki Ohtsu authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    e750f14 View commit details
    Browse the repository at this point in the history
  18. tls,crypto: move NPN protcol data to hidden value

    cherry-pick 7eee372 from v6-staging.
    
    This fix is to be consistent implementation with ALPN. Tow NPN
    protocol data in the persistent memebers move to hidden variables in
    the wrap object.
    
    PR-URL: #2564
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Shigeki Ohtsu authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    ef547f3 View commit details
    Browse the repository at this point in the history
  19. test: fix alpn tests for openssl1.0.2h

    cherry-pick 65030c7 from v6-staging.
    
    openssl/openssl@af2db04
    changed some ALPN behaviors. The tests when ALPN has no selection
    should be fixed because openssl was changed NPN callback to be invoked
    in this case.
    
    Fixes: #6458
    PR-URL: #6550
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Shigeki Ohtsu authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    7ca31e3 View commit details
    Browse the repository at this point in the history
  20. tls: copy the Buffer object before using

    cherry-pick c26b9af from v6-staging.
    
    `convertNPNProtocols` and `convertALPNProtocols' uses the `protocols`
    buffer object as it is, and if it is modified outside of core, it
    might have an impact. This patch makes a copy of the buffer object,
    before using it.
    
    PR-URL: #8055
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    thefourtheye authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    a67ada7 View commit details
    Browse the repository at this point in the history
  21. crypto: remove unnecessary variables of alpn/npn

    The Local variables of `npn_buffer` and `alpn_buffer` are not
    necessary to be created from `args[0]`. Remove and fold them into the
    subsequent call.
    
    PR-URL: #10831
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    shigeki authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    4cf7dcf View commit details
    Browse the repository at this point in the history
  22. test: refactor http pipelined socket test

    In test-http-incoming-pipelined-socket-destory:
    
    * setTimeout() with no duration -> setImmediate()
    * eliminate unneeded exit listener
    * use common.mustCall()
    * var -> const/let
    
    PR-URL: #10189
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    Trott authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    121b68a View commit details
    Browse the repository at this point in the history
  23. test: refactor assert.equal, update syntax to ES6

    Prieto, Marcos authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    827bbe7 View commit details
    Browse the repository at this point in the history
  24. test: refactor test-http-after-connect.js

    - Replace assert.equal() to assert.strictEqual()
    - Replace var with const where applicable
    - Removed firstBodyChunk which is never used
    - Remove the process.on('exit', ...) and replace its functionality by
    - Using common.mustCall() where applicable
    
    PR-URL: #10229
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Italo A. Casas <me@italoacasas.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    larissayvette authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    9c9d422 View commit details
    Browse the repository at this point in the history
  25. test: refactor test-fs-fsync

    - replace var with const.
    - remove successes var.
    - use assert.ifError() for handling all errors.
    - wrap all callbacks with common.mustCall().
    
    PR-URL: #10176
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    Reviewed-By: Italo A. Casas <me@italoacasas.com>
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    radelmann authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    730c3b2 View commit details
    Browse the repository at this point in the history
  26. test: refactor test-crypto-random

    * specify constructor for assert.throws()
    * load additional modules only if crypto check passes
    * normalize some potentially confusing indentation
    * provided actual first and expected second in assertions
    
    PR-URL: #10232
    Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Trott authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    2f44d7f View commit details
    Browse the repository at this point in the history
  27. test: use const/let and common.mustCall

    remove process.on('exit') because all callbacks are
    wrapped by common.mustCall.
    
    PR-URL: #9959
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Roman Reiss <me@silverwind.io>
    outsideris authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    fc67a95 View commit details
    Browse the repository at this point in the history
  28. test: cleanup test-stdout-close-catch.js

    Added common.mustCall in child process on 'close' callback
    Changed several 'var' statements to 'const' or 'let' where appropriate
    Also linting
    
    PR-URL: #10006
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Roman Reiss <me@silverwind.io>
    furnox authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    0f8a323 View commit details
    Browse the repository at this point in the history
  29. test: refactor test-tls-ecdh-disable

    * use common.mustCall()
    * use String.prototype.includes() instead of String.prototype.indexOf()
    
    PR-URL: #9989
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Aaron Williams authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    5335b0a View commit details
    Browse the repository at this point in the history
  30. win,msi: add required UIRef for localized strings

    Reviewed-By: João Reis <reis@janeasystems.com>
    PR-URL: #8884
    billti authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    fa11f4b View commit details
    Browse the repository at this point in the history
  31. test: refactor test-timers-this

    * use common.mustCall() and eliminate exit handler
    * provide timer durtion of 1ms where previously omitted
    * var -> const
    
    PR-URL: #10315
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Trott authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    90a79b3 View commit details
    Browse the repository at this point in the history
  32. doc: add Michaël Zasso to the CTC

    Approved by the CTC at #9420
    Reviewers are CTC members who voted for this.
    
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
    Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
    Reviewed-By: Julien Gilli <jgilli@nodejs.org>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    Reviewed-By: Rod Vagg <rod@vagg.org>
    Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Brian White <mscdex@mscdex.net>
    targos authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    c4df02c View commit details
    Browse the repository at this point in the history
  33. test: add test-require-invalid-package

    Add test for requiriing an invalid package path.
    
    PR-URL: #9903
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    Duy Le authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    34861ef View commit details
    Browse the repository at this point in the history
  34. test: refactor test-net-reconnect-error

    * var -> const/let
    * assert.equal() -> assert.strictEqual()
    
    PR-URL: #9903
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    Duy Le authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    3b67001 View commit details
    Browse the repository at this point in the history
  35. test: use strictEqual in test-cwd-enoent-repl.js

    In file /test/parallel/test-cwd-enoent-repl.js at
    line: 26:3 and 27:3 assert.equal was used.
    
    This commit changes use of assert.equal to assert.strictEqual.
    
    PR-URL: #9952
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    nitsnwits authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    f301df4 View commit details
    Browse the repository at this point in the history
  36. test: refactor the code in test-http-keep-alive

    * use common.mustCall to control the functions execution automatically
    * use let and const instead of var
    * use assert.strictEqual instead assert.equal
    
    PR-URL: #10350
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Italo A. Casas <me@italoacasas.com>
    edsadr authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    4514fd7 View commit details
    Browse the repository at this point in the history
  37. test: change assert.strict to assert.strictEqual()

    PR-URL: #9988
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    ashita92 authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    b87ee26 View commit details
    Browse the repository at this point in the history
  38. test: refactor test-stream2-writable

    * add duration to setTimeout()
    * assert.equal() -> assert.strictEqual()
    * remove unused function arguments
    * normalize indentation
    
    PR-URL: #10353
    Reviewed-By: Julian Duque <julianduquej@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Trott authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    76bb3cb View commit details
    Browse the repository at this point in the history
  39. test: refactor test-stdin-script-child

    - var -> const where possible
    - assert.equal -> assert.strictEqual
    - passed the setTimeout function a second parameter for readability
    - used assert.strictEqual for assert(!c) as it is expected to be 0 and
      not some other value
    
    PR-URL: #10321
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Italo A. Casas <me@italoacasas.com>
    emanuelbuholzer authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    7d61bbf View commit details
    Browse the repository at this point in the history
  40. test: refactoring test-cluster-worker-constructor

    - Using assert.strictEqual instead assert.equal
    
    PR-URL: #9956
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Italo A. Casas <me@italoacasas.com>
    crokita authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    d5e911c View commit details
    Browse the repository at this point in the history
  41. test: change var declarations, add mustCall check

    In this test, I changed the var declarations to be either a let or a
    const. For some of the callbacks, I added a mustCall check to ensure
    that the functions have run. I also changed assert.equal() to
    assert.strictEqual().
    
    PR-URL: #9962
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Daniel Sims authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    122917d View commit details
    Browse the repository at this point in the history
  42. doc: clarify macosx-firewall suggestion BUILDING

    `./tools/macosx-firewall.sh` fails if run before build step. Since the
    suggestion comes before the build steps in the document, this change
    clarifies that the script should be run after building.
    
    PR-URL: #10311
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Italo A. Casas <me@italoacasas.com>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    chasestarr authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    3b252a6 View commit details
    Browse the repository at this point in the history
  43. doc: consistent 'Returns:' part two

    Follow up from 8eb19c4. Lower case `return` was not updated
    
    PR-URL: #10391
    Ref: #9554
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Julian Duque <julianduquej@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Roman Reiss <me@silverwind.io>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    dda777b View commit details
    Browse the repository at this point in the history
  44. test: refactor test-child-process-stdin

    Use assert.strictEqual instead of assert.equal and assert.ok
    
    PR-URL: #10420
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    navulirs authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    fb9a0ad View commit details
    Browse the repository at this point in the history
  45. test: improve test-cluster-net-listen.js

    convert var to const
    
    PR-URL: #9953
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Rico Cai authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    ab3e4c6 View commit details
    Browse the repository at this point in the history
  46. test: update test-tls-check-server-identity.js

    Changed var to const, assert.equal to assert.strictEqual, and
    used a template string for error output.
    
    PR-URL: #9986
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    koxauvin authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    19b314e View commit details
    Browse the repository at this point in the history
  47. test: refactor test-cluster-send-handle-twice.js

    - `var` --> `const` as applicable
    - `assert.equal`  --> `assert.strictEqual`
    - `assert(false, ..)` --> `common.fail()`
    - `common.mustCall` for functions that need to be called exactly once
    - modified an `assert(!signal, 'Worker exited by a signal');` call to
      `assert.strictEqual(signal, null);` call as that made more sense
    
    PR-URL: #10049
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    amarzavery authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    6db76da View commit details
    Browse the repository at this point in the history
  48. test: refactor test-tls-interleave

    var -> let / const
    added common.mustCall() to callback
    assert.equal() -> assert.strictEqual()
    
    PR-URL: #10017
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    bchirgwin authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    a983400 View commit details
    Browse the repository at this point in the history
  49. test: refactor test-pipe-file-to-http

    Changing var defs to const/let, changing assert.equal to
    assert.strictEqual. Wrapping functions called once with
    common.mustCall
    
    PR-URL: #10054
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Josh Mays authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    80f4a37 View commit details
    Browse the repository at this point in the history
  50. test: fix and improve debug-break-on-uncaught

    This test runs based on a expectation that the stderr will get the
    string 'Debugger listening on port'. But the actual message printed
    to stderr has changed to 'Debugger listening on host:port'. So the
    the actuals tests did not even start and eventually timeout.
    
    Apart from that, changed `var`s to `let`s or `const`s.
    
    Refs: #10361
    PR-URL: #10370
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com
    thefourtheye authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    dbfec29 View commit details
    Browse the repository at this point in the history
  51. test: refactor test-child-process-ipc

    Change var to const or let.
    Change assert.equal() to assert.strictEqual().
    
    PR-URL: #9990
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Roman Reiss <me@silverwind.io>
    malenesok007 authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    4efdbaf View commit details
    Browse the repository at this point in the history
  52. test: improve code in test-vm-symbols

    * use const instead of var
    * use assert.strictEqual instead of assert.equal
    
    PR-URL: #10429
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    edsadr authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    9840f50 View commit details
    Browse the repository at this point in the history
  53. test: improve code in test-fs-readfile-error

    * use const instead of var
    * use common.mustCall to control the functions execution automatically
    * use assert.strictEqual instead of assert.equal
    * use assert.notStrictEqual instead of assert.notEqual
    * use arrow functions
    
    PR-URL: #10367
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    edsadr authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    4bbd50e View commit details
    Browse the repository at this point in the history
  54. test: improve the code in test-pipe.js

    * use const and let instead of var
    * use common.mustCall to control functions executions
    * use assert.strictEqual instead of assert.equal
    * use assert.ifError to handle errors
    * use arrow functions
    * remove console.log and process.stdout.write
    
    PR-URL: #10452
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Brian White <mscdex@mscdex.net>
    edsadr authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    31aa877 View commit details
    Browse the repository at this point in the history
  55. doc: var -> const / let in the console.md

    PR-URL: #10451
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    vsemozhetbyt authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    70ea38f View commit details
    Browse the repository at this point in the history
  56. doc: more efficient example in the console.md

    Object.setPrototypeOf() -> Object.create()
    
    PR-URL: #10451
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    vsemozhetbyt authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    919e0cb View commit details
    Browse the repository at this point in the history
  57. test: refactor the code in test-fs-chmod

    * use const and let instead of var
    * use common.mustCall to control functions executions
    * use assert.strictEqual instead of assert.equal
    * use assert.ifError to handle errors
    * use arrow functions
    * remove unnecessary variables
    
    PR-URL: #10440
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    edsadr authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    424c861 View commit details
    Browse the repository at this point in the history
  58. doc: add Working Group dissolution text

    PR-URL: #9656
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    williamkapke authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    0e51cbb View commit details
    Browse the repository at this point in the history
  59. test: refactor test-stdin-from-file

    Remove console.log statement. Replace error check with
    assert.ifError().
    
    PR-URL: #10331
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Italo A. Casas <me@italoacasas.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    radelmann authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    14e07c9 View commit details
    Browse the repository at this point in the history
  60. test: fix flaky test-http-client-timeout-with-data

    test-http-client-timeout-with-data has failed here and there in CI on
    FreeBSD and OS X. The test has a socket timeout set to 50ms and a timer
    set for 100ms. However, they are not necessarily set in the same tick of
    the event loop and their ordering is therefore not guaranteed.
    
    Instead of using a timer, this change listens for an event on the
    listener to know when the socket timeout has occurred and then runs the
    code originally in the timer.
    
    Additional refactoring: Replaced `process.on('exit', ...)` checks with
    `common.mustCall()` and replaced usage of `assert.equal()` with
    `assert.strictEqual()`.
    
    PR-URL: #10431
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    380a5d5 View commit details
    Browse the repository at this point in the history
  61. test: s/ASSERT/assert/

    This commit addresses an inconsistency with eight tests. These
    tests use the assert module, but named the variable ASSERT. This
    goes against the project's typical coding style, and negatively
    impacts global find and replace updates.
    
    PR-URL: #10544
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Reviewed-By: Jackson Tian <shyvo1987@gmail.com>
    Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    cjihrig authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    2f8bc9a View commit details
    Browse the repository at this point in the history
  62. doc: redirect 'Start a Working Group' to TSC repo

    PR-URL: #9655
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    williamkapke authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    d3a7fb8 View commit details
    Browse the repository at this point in the history
  63. crypto: Use reference count to manage cert_store

    Setting reference count at the time of setting cert_store instead of
    trying to manage it by modifying internal states in destructor.
    
    PR-URL: #9409
    Reviewed-By: Fedor Indutny <fedor@indutny.com>
    Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
    AdamMajer authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    bf882fb View commit details
    Browse the repository at this point in the history
  64. debugger: call this.resume() after this.run()

    When the debugger has started we need to call `this.resume` otherwise,
    the prompt won't appear.
    
    Fixes: #9854
    PR-URL: #10099
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    lance authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    d8b902f View commit details
    Browse the repository at this point in the history
  65. test: stream readableState readingMore state

    PR-URL: #9868
    Refs: #8685
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Italo A. Casas <me@italoacasas.com>
    chmln authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    544920f View commit details
    Browse the repository at this point in the history
  66. test: fail for missing output files

    Instead of ignoring missing `.out` files for message/pseudo-tty tests,
    raise an error to indicate that something is not quite right.
    
    Ref: #10037
    PR-URL: #10150
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    addaleax authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    13c6cec View commit details
    Browse the repository at this point in the history
  67. test: refactor test-domain.js

    apply setTimeout duration, add const, remove unused var
    
    PR-URL: #10207
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    sidthekidder authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    928291c View commit details
    Browse the repository at this point in the history
  68. test: update test-domain-uncaught-exception.js

    file: test/parallel/test-domain-uncaught-exception.js
    
    1. There are three setTimeout() in the file and they do not specify a
    duration (the second argument), so I change them to setImmediate()
    instead.
    
    2. There are four callbacks that take an argument called `err` but that
    argument is never used, so I removed them.
    
    PR-URL: #10193
    Reviewed-By: Sam Roberts <sam@strongloop.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    amazingandyyy authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    14c28eb View commit details
    Browse the repository at this point in the history
  69. test: clean up domain-no-error-handler test

    Added duration to setTimeout and removed extraneous callback args,
    as per Rich Trott's instructions
    
    PR-URL: #10291
    Reviewed-By: Italo A. Casas <me@italoacasas.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    weyj4 authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    f412b1f View commit details
    Browse the repository at this point in the history
  70. src: fix string format mistake for 32 bit node

      warning: format ‘%lx’ expects argument of type ‘long
      unsigned int’, but argument 3 has type ‘unsigned int’ [-Wformat=]
         BIO_printf(bio, "0x%lx", exponent_word);
    
    PR-URL: #10082
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    posix4e authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    3f29cbb View commit details
    Browse the repository at this point in the history
  71. stream, test: test _readableState.emittedReadable

    Part of #8683, increase coverage of the internal
    state machine of streams.
    
    PR-URL: #10249
    See: #8683
    See: #10230
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    joyeecheung authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    271f578 View commit details
    Browse the repository at this point in the history
  72. test: stream readable needReadable state

    PR-URL: #10241
    Ref: #8683
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Italo A. Casas <me@italoacasas.com>
    joyeecheung authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    135a7c9 View commit details
    Browse the repository at this point in the history
  73. test: stream readable resumeScheduled state

    PR-URL: #10299
    Ref: #8683
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    italoacasas authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    fd195b4 View commit details
    Browse the repository at this point in the history
  74. doc: clarify the review and landing process

    Adds/mentions:
    - Link to glossary
    - Commit squashing and CI run
    - 48/72 hour wait and PR review feature
    - Extra notes section
    - "Landed in <sha>" comment
    
    PR-URL: #10202
    Ref: #10151
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    joyeecheung authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    5777c79 View commit details
    Browse the repository at this point in the history
  75. doc: require() tries first core not native modules

    Change a single word in documentation with a more precise one.
    
    Native is a module compiled in machine "native" code.
    A module normally written in a compiled language, not in JavaScript.
    
    Core modules form Node's built-in "core" functionalities.
    You don't need to install them. They are included in every Node installation
    and documented in https://nodejs.org/api/ .
    
    PR-URL: #10324
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Italo A. Casas <me@italoacasas.com>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    vice authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    4f168a4 View commit details
    Browse the repository at this point in the history
  76. test: improve test-cluster-worker-constructor.js

    * use let and const instead of var
    * use assert.strictEqual instead assert.equal
    
    PR-URL: #10396
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Italo A. Casas <me@italoacasas.com>
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    edsadr authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    eeb2d78 View commit details
    Browse the repository at this point in the history
  77. test: fix flaky test-https-timeout

    Remove `setTimeout()` in test and instead rely on `common.mustCall()` on
    a `timeout` event handler.
    
    The test was flaky on CI. The flakiness was replicable by running the
    test under load. This version, in contrast, is robust under load.
    
    Took the opportunity to do some `var` -> `const` while refactoring.
    
    PR-URL: #10404
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Italo A. Casas <me@italoacasas.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    8a26ba1 View commit details
    Browse the repository at this point in the history
  78. test: improve code in test-vm-preserves-property

    * use const instead of var
    * use assert.strictEqual instead assert.equal
    
    PR-URL #10428
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    edsadr authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    56b193a View commit details
    Browse the repository at this point in the history
  79. doc: use "Node.js" in V8 guide

    PR-URL: #10438
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    d260fb2 View commit details
    Browse the repository at this point in the history
  80. src: describe what NODE_MODULE_VERSION is for

    Current comment described what to do with it when the ABI changes, but
    implied that Node.js would load modules with newer ABI numbers, which it
    will not.
    
    PR-URL: #10414
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Reviewed-By: Italo A. Casas <me@italoacasas.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    sam-github authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    be62037 View commit details
    Browse the repository at this point in the history
  81. build: add (not) cross-compiled configure flags

    Adds --cross-compiling and --no-cross-compiling flags
    
    Fixes: #10271
    PR-URL: #10287
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    piranna authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    0bb77f2 View commit details
    Browse the repository at this point in the history
  82. os: fix os.release() for aix and add test

    PR-URL: #10245
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    jBarz authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    7505b86 View commit details
    Browse the repository at this point in the history
  83. test: add test for SIGWINCH handling by stdio.js

    PR-URL: #10063
    Reviewed-By: James M Snell <jasnell@gmail.com>
    sarahmeyer authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    7020e9f View commit details
    Browse the repository at this point in the history
  84. test: refactor test-stream2-unpipe-drain

    - Change var to const
    - Remove dependency crypto
    
    PR-URL: #10033
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    storytimesolutions authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    a9cd1d1 View commit details
    Browse the repository at this point in the history
  85. build: add /opt/freeware/... to AIX library path

    To ease the use of the AIX binaries, add
    /opt/freeware/lib/pthread{/ppc64} into the search path encoded into the
    library, so that any version the user has installed from the common
    download locations will work out of the box without having to explicitly
    set LIBPATH in their environment.
    
    PR-URL: #10128
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Stewart X Addison authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    78010aa View commit details
    Browse the repository at this point in the history
  86. test: use strictEqual in test-http-server

    PR-URL: #10478
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Italo A. Casas <me@italoacasas.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    ftatieze authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    b74bc51 View commit details
    Browse the repository at this point in the history
  87. doc: require two-factor authentication

    Collaborators have elevated privileges. The CTC now requires
    Collaborator accounts to have two-factor authentication. This changes
    wording in the onboarding documentation to make it clear that two-factor
    authentication is required and not merely recommended.
    
    PR-URL: #10529
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
    Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Trott authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    08e924e View commit details
    Browse the repository at this point in the history
  88. test: improve test-fs-empty-readStream.js

    * use const instead of var
    * use common.mustCall to control functions execution
    * use assert.strictEqual instead of assert.equal
    * use arrow functions
    
    PR-URL: #10479
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Italo A. Casas <me@italoacasas.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Brian White <mscdex@mscdex.net>
    edsadr authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    52edebc View commit details
    Browse the repository at this point in the history
  89. doc: warn about unvalidated input in child_process

    child_process.exec*() and child_process.spawn*() (if options.shell is
    true) allow trivial arbitrary command execution if code passes
    unsanitised user input to it. Add warnings in the docs to make that
    clear.
    
    PR-URL: #10466
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Matthew Garrett authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    c7378c4 View commit details
    Browse the repository at this point in the history
  90. test: improve test-http-allow-req-after-204-res

    * use const instead of var
    * use common.mustCall to control functions execution
    * use assert.strictEqual instead of assert.equal
    * use arrow functions
    
    PR-URL: #10503
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Italo A. Casas <me@italoacasas.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    edsadr authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    28a5ce1 View commit details
    Browse the repository at this point in the history
  91. test: avoid assigning this to variables

    This commit removes assignments of this to a variable in the
    tests.
    
    PR-URL: #10548
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    cjihrig authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    f5e54f5 View commit details
    Browse the repository at this point in the history
  92. test: update test-cluster-shared-handle-bind-error

    - Remove assignment of this to variable.
    - Add common.mustCall() as needed.
    - Move from var to const.
    
    PR-URL: #10547
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    cjihrig authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    37a3622 View commit details
    Browse the repository at this point in the history
  93. test: add tests for clearBuffer state machine

    This checks to see that clearBuffer appropriately decrements the
    correct values in _writableState when clearBuffer is invoked in
    end.
    
    Fixes: #8687
    PR-URL: #9922
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Italo A. Casas <me@italoacasas.com>
    captainsafia authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    1fac431 View commit details
    Browse the repository at this point in the history
  94. doc: add joyeecheung to collaborators

    PR-URL: #10603
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    joyeecheung authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    acbe4d3 View commit details
    Browse the repository at this point in the history
  95. vm: add error message if we abort

    Add an error message in watchdog if we abort because uv_loop_init fails.
    
    PR-URL: #8634
    Fixes: #8555
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    fhinkel authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    9556ef3 View commit details
    Browse the repository at this point in the history
  96. test: add stdin-setrawmode.out file

    Adds an accompanying .out file for test/pseudo-tty/stdin-setrawmode.js.
    The test was originally merged without this file and an astute
    observer found that it was causing an error message. See discussion
    at #10037.
    
    PR-URL: #10149
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Italo A. Casas <me@italoacasas.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Jonathan Darling authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    53404db View commit details
    Browse the repository at this point in the history
  97. test: set stdin too for pseudo-tty tests

    Ref: #10037
    Ref: #10146
    PR-URL: #10149
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Italo A. Casas <me@italoacasas.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    addaleax authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    42da81e View commit details
    Browse the repository at this point in the history
  98. doc: update CONTRIBUTING.MD with link to V8 guide

    Currently, two of the guides in the `/doc/guides` directory are actually
    guides for working on the Nodei.js project. Of those, one is linked from
    this page. This change adds a note to point people to the other.
    
    PR-URL: #10070
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    sarahmeyer authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    79d4986 View commit details
    Browse the repository at this point in the history
  99. test: use mustCall() for simple flow tracking

    Many of the tests use variables to track when callback functions
    are invoked or events are emitted. These variables are then
    asserted on process exit. This commit replaces this pattern in
    straightforward cases with common.mustCall(). This makes the
    tests easier to reason about, leads to a net reduction in lines
    of code, and uncovered a few bugs in tests. This commit also
    replaces some callbacks that should never be called with
    common.fail().
    
    PR-URL: #7753
    Reviewed-By: Wyatt Preul <wpreul@gmail.com>
    Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    cjihrig authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    19907c2 View commit details
    Browse the repository at this point in the history
  100. test: refactor test-tls-server-verify

    Refactored `test-tls-server-verify.js` to replace uses of `var` with
    `const` and `let`. Also replaced uses of `assert.equal` with
    `assert.strictEqual`.
    
    PR-URL: #10076
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Hutson Betts authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    812c636 View commit details
    Browse the repository at this point in the history
  101. test: refactor test-net-dns-custom-lookup

    Use asssert.strictEqual to disallow coersion.
    
    PR-URL: #10071
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    funkent authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    61cbc20 View commit details
    Browse the repository at this point in the history
  102. test: refactor test-repl-mode.js

    * var -> const/let
    * assert.equal() -> assert.strictEqual()
    
    PR-URL: #10061
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    cesarhq authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    ce91bb2 View commit details
    Browse the repository at this point in the history
  103. test: use common.fixturesDir almost everywhere

    Updating tests to use `common.fixturesDir` whenever possible/reasonable.
    Left out things like tests for `path` and `require.resolve`.
    
    PR-URL: #6997
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    bengl authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    324c82b View commit details
    Browse the repository at this point in the history
  104. test: test: refactor test-sync-fileread

    change equal to strictEqual and var to const
    
    PR-URL: #9941
    Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    jhwohlgemuth authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    98496b6 View commit details
    Browse the repository at this point in the history
  105. test: refactor test-tls-0-dns-altname

    * var -> const, let
    * assert.equal() -> assert.strictEqual()
    
    PR-URL: #9948
    Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Italo A. Casas <me@italoacasas.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Richard Karmazin authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    96ca40b View commit details
    Browse the repository at this point in the history
  106. tools: add ESLint rule for assert.throws arguments

    The second argument to "assert.throws" is usually a validation RegExp or
    function for the thrown error. However, the function also accepts a
    string and in this case it is interpreted as a message for the
    AssertionError and not used for validation. It is common for people to
    forget this and pass a validation string by mistake.
    This new rule checks that we never pass a string literal as a second argument
    to "assert.throws". Additionally, there is an option to enforce the
    function to be called with at least two arguments. It is currently off
    because we have many tests that do not comply with this rule.
    
    PR-URL: #10089
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    targos authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    c801de9 View commit details
    Browse the repository at this point in the history
  107. tools: forbid template literals in assert.throws

    Extend the assert-throws-arguments custom ESLint rule to also check for
    the use of template literals as a second argument to assert.throws.
    
    PR-URL: #10301
    Ref: #10282 (comment)
    Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Roman Reiss <me@silverwind.io>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Italo A. Casas <me@italoacasas.com>
    targos authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    9f13b5f View commit details
    Browse the repository at this point in the history
  108. test: add second argument to assert.throws()

    The assert.throws() calls in test-event-emitter-max-listeners.js
    should include a constructor or RegExp as a second argument.
    
    PR-URL: #9987
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    russokj authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    11115c0 View commit details
    Browse the repository at this point in the history
  109. test: refactoring test-pipe-head

    - Updated assert.equal to assert.strictEqual
    - Updated 'var' to 'const'
    - Using template literals
    
    PR-URL: #10036
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Italo A. Casas <me@italoacasas.com>
    furnox authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    22226fa View commit details
    Browse the repository at this point in the history
  110. test: invalid package.json causes error when require()ing in directory

    Requiring a file from a directory that contains an invalid package.json
    file should throw an error.
    
    PR-URL: #10044
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Sam Shull authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    e7c4dfb View commit details
    Browse the repository at this point in the history
  111. test: refactor test-preload

    * assert.equal() -> assert.strictEqual()
    * replace template string with a string; no variable substitution or
      concatenation or anything like that
    
    PR-URL: #9803
    Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    f9f8e4e View commit details
    Browse the repository at this point in the history
  112. lib,test: use consistent operator linebreak style

    We have a tacit rule that for multiline statements, the operator should
    be placed before the linebreak. This commit commit fixes the few
    violations of this rule in the code base.
    This allows us to enable the corresponding ESLint rule.
    
    PR-URL: #10178
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Roman Reiss <me@silverwind.io>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    targos authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    2eda3c7 View commit details
    Browse the repository at this point in the history
  113. tools: enforce consistent operator linebreak style

    Adds the `operator-linebreak` rule to our ESLint config.
    
    PR-URL: #10178
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Roman Reiss <me@silverwind.io>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    targos authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    31434a1 View commit details
    Browse the repository at this point in the history
  114. test: cleanup stream tests

    const and let instead var
    assert.strictEqual instead assert.equal
    
    PR-URL: #8668
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    italoacasas authored and MylesBorins committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    735119c View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2017

  1. crypto: allow adding extra certs to well-known CAs

    In closed environments, self-signed or privately signed certificates are
    commonly used, and rejected by Node.js since their root CAs are not
    well-known. Allow extending the set of well-known compiled-in CAs via
    environment, so they can be set as a matter of policy.
    
    PR-URL: #9139
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
    sam-github authored and MylesBorins committed Feb 6, 2017
    Configuration menu
    Copy the full SHA
    1595328 View commit details
    Browse the repository at this point in the history
  2. doc: replace newlines in deprecation with space

    As it is, each line in the deprecation heading which are wrapped at 80
    characters in the *.md files, are shown in different lines. For example
    
        > Stability: 0 - Deprecated: Use
        > `Buffer.from(arrayBuffer[, byteOffset [, length]])`
        > instead.
    
    is shown in three different lines. This patch replaces the newlines
    with space characters, so that the output will be in single line.
    
    PR-URL: #11074
    
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    thefourtheye authored and MylesBorins committed Feb 6, 2017
    Configuration menu
    Copy the full SHA
    28b707b View commit details
    Browse the repository at this point in the history
  3. doc: change logical to bitwise OR in dns lookup

    The `hints` value will be a number. To specify more than one hints,
    their corresponding bits have to be set. So bitwise OR should be used
    instead of logical OR.
    
    PR-URL: #11037
    
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    thefourtheye authored and MylesBorins committed Feb 6, 2017
    Configuration menu
    Copy the full SHA
    7db7e47 View commit details
    Browse the repository at this point in the history
  4. doc: killSignal option accepts integer values

    `killSignal` option accepts the signal name or signal number as well.
    
    PR-URL: #10424
    Reviewed-By: Julian Duque <julianduquej@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    thefourtheye authored and MylesBorins committed Feb 6, 2017
    Configuration menu
    Copy the full SHA
    8eeccd8 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2017

  1. doc: unify dirname and filename description

    __dirname is path.dirname(__filename), but its docs, specifically the
    attempt to describe javascript scope in terms of "running" and
    "executing" had drifted apart. Rework to describe one as a variation of
    the other, move the example, and just describe the names in terms of the
    module, and it's local variables rather than the ill defined execution
    concepts.
    
    Fix: #5525
    PR-URL: #10527
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    sam-github authored and MylesBorins committed Feb 21, 2017
    Configuration menu
    Copy the full SHA
    d61c181 View commit details
    Browse the repository at this point in the history
  2. doc: update BUILDING.md

    Added note about vcbuild being included as batch to clarify
    that it's not needed from msbuild tools or visual studio.
    
    PR-URL: #8704
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    rainabba authored and MylesBorins committed Feb 21, 2017
    Configuration menu
    Copy the full SHA
    d3c5bc1 View commit details
    Browse the repository at this point in the history
  3. doc: correct vcbuild options for windows testing

    Corrected parameter for running tests on Windows. Without the corrected
    parameters, Windows users encounter an error about failing to sign the
    build, "Failed to sign exe", which can be discouraging to new Windows
    community members.
    
    PR-URL: #10686
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
    jboarman authored and MylesBorins committed Feb 21, 2017
    Configuration menu
    Copy the full SHA
    d8961bd View commit details
    Browse the repository at this point in the history
  4. test: add --abort-on-timeout option to test.py

    Currently, when a process times out, it is terminated by sending it the
    SIGTERM signal. Sending SIGBART instead allows the operating system to
    generate a core file that can be investigated later using post-mortem
    debuggers such as llnode or mdb_v8.
    
    This can be very useful when investigating flaky tests that time out,
    since in that case the failure is difficult to reproduce, and being able
    to look at a core file makes a big difference.
    
    With these changes, passing the --abort-on-timeout command line option
    to tools/test.py now sends SIGABRT to processes timing out on all
    platforms but Windows.
    
    PR-URL: #11086
    Ref: #11026
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Julien Gilli authored and MylesBorins committed Feb 21, 2017
    Configuration menu
    Copy the full SHA
    0f5d82e View commit details
    Browse the repository at this point in the history
  5. test: fix test.py command line options processing

    #11086 had introduced a regression
    that broke command line options processing for tools/test.py.
    
    Basically, it made tools/test.py discard the command line argument that
    would be passed after `--abort-on-timeout`. For instance, when running:
    
    ```
    $ python tools/test.py --abort-on-timeout path/to/some-test
    ```
    
    all tests would be run because the last command line argument
    (`/path/to/some-test`) would be discarded.
    
    This change fixes this regression.
    
    Refs: #11086
    PR-URL: #11153
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Julien Gilli authored and MylesBorins committed Feb 21, 2017
    Configuration menu
    Copy the full SHA
    c279cbe View commit details
    Browse the repository at this point in the history
  6. 2017-02-21, Version 4.8.0 'Argon' (LTS)

    Notable Changes:
    
    * child_process: add shell option to spawn() (cjihrig)
      #4598
    * crypto:
      * add ALPN Support (Shigeki Ohtsu)
        #2564
      * allow adding extra certs to well-known CAs (Sam Roberts)
        #9139
    * deps:
      * v8: expose statistics about heap spaces (Ben Ripkens)
        #4463
    * fs: add the fs.mkdtemp() function. (Florian MARGAINE)
      #5333
    * process:
      * add `externalMemory` to `process` (Fedor Indutny)
        #9587
      * add process.cpuUsage() (Patrick Mueller)
        #10796
    MylesBorins committed Feb 21, 2017
    Configuration menu
    Copy the full SHA
    58ab54f View commit details
    Browse the repository at this point in the history