-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V18.14.0 proposal #46396
V18.14.0 proposal #46396
Commits on Jan 17, 2023
-
deps: V8: cherry-pick 5fe919f78321
Original commit message: PPC: clear VXCVI before doing a conversion This bit may not get cleared automatically and could show results from older executed instructions. Change-Id: I5976f9a6c5bf87b1a63ef0f35493b222729e20f6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3812037 Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#82237} Refs: v8/v8@5fe919f PR-URL: #45587 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8dce62c - Browse repository at this point
Copy the full SHA 8dce62cView commit details
Commits on Jan 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4844935 - Browse repository at this point
Copy the full SHA 4844935View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7599b91 - Browse repository at this point
Copy the full SHA 7599b91View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e11247 - Browse repository at this point
Copy the full SHA 1e11247View commit details -
doc: sort http.createServer() options alphabetically
PR-URL: #45680 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for b709af3 - Browse repository at this point
Copy the full SHA b709af3View commit details -
doc: fix wrong output of example in util
In `mime.type` of util, `application/javascript` is actual output, but described as `application/javascript/javascript`. PR-URL: #45825 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 67efe2a - Browse repository at this point
Copy the full SHA 67efe2aView commit details -
tls: fix re-entrancy issue with TLS close_notify
Like errno, OpenSSL's API requires SSL_get_error and error queue be checked immediately after the failing operation, otherwise the error queue or SSL object may have changed state and no longer report information about the operation the caller wanted. TLSWrap almost heeds this rule, except in TLSWrap::ClearOut. If SSL_read picks up a closing alert (detected by checking SSL_get_shutdown), Node calls out to JS with EmitRead(UV_EOF) and only afterwards proceeds to dispatch on the error. But, by this point, Node has already re-entered JS, which may change the error. In particular, I've observed that, on close_notify, JS seems to sometimes call back into TLSWrap::DoShutdown, calling SSL_shutdown. (I think this comes from onStreamRead in stream_base_commons.js?) Instead, SSL_get_error and the error queue should be sampled earlier. Back in #1661, Node needed to account for GetSSLError being called after ssl_ was destroyed. This was the real cause. With this fixed, there's no need to account for this. (Any case where ssl_ may be destroyed before SSL_get_error is a case where ssl_ or the error queue could change state, so it's a bug either way.) This is the first of two fixes in error-handling here. The EmitRead(UV_EOF) seems to additionally swallow fatal alerts from the peer. Some of the ECONNRESET expectations in the tests aren't actually correct. The next commit will fix this as well. PR-URL: #44563 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c6457cb - Browse repository at this point
Copy the full SHA c6457cbView commit details -
tls: don't treat fatal TLS alerts as EOF
SSL_RECEIVED_SHUTDOWN means not just close_notify or fatal alert. From what I can tell, this was just a mistake? OnStreamRead's comment suggests eof_ was intended to be for close_notify. This fixes a bug in TLSSocket error reporting that seems to have made it into existing tests. If we receive a fatal alert, EmitRead(UV_EOF) would, via onConnectEnd in _tls_wrap.js, synthesize an ECONNRESET before the alert itself is surfaced. As a result, TLS alerts received during the handshake are misreported by Node. See the tests that had to be updated as part of this. PR-URL: #44563 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 757a022 - Browse repository at this point
Copy the full SHA 757a022View commit details -
PR-URL: #45812 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 874f6c3 - Browse repository at this point
Copy the full SHA 874f6c3View commit details -
PR-URL: #45815 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 87a0e86 - Browse repository at this point
Copy the full SHA 87a0e86View commit details
Commits on Jan 24, 2023
-
tools: update eslint to 8.29.0
PR-URL: #45733 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7438ff1 - Browse repository at this point
Copy the full SHA 7438ff1View commit details -
tools: fix incorrect version history order
This fixes an error in parseYAML(text), the version sorting coudn't be right as we compared an arrify string (ie. a = ["v18.11, v16.7.0"]) with an array of strings (ie. b = ["v18.07", "v16.7.0"]) in versionSort(a, b). minVersion(a) couldn't find the minimum version with an arrify string like a = ["v18.11, v16.7.0"]. That's why incorrect version history orders sometimes appeared. Furthermore, no need to sort the added version as it always comes first. So, it can be the last one to be pushed in the meta.changes array. Fixes: #45670 Co-authored-by: Luigi Pinca <luigipinca@gmail.com> PR-URL: #45728 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e0cda56 - Browse repository at this point
Copy the full SHA e0cda56View commit details -
repl: improve robustness wrt to prototype pollution
PR-URL: #45604 Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 784ed59 - Browse repository at this point
Copy the full SHA 784ed59View commit details -
PR-URL: #45827 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f874d0b - Browse repository at this point
Copy the full SHA f874d0bView commit details -
test: add postject to fixtures
This should make it possible to test out the creation of Single Executable Applications on a PR without making outbound requests to download and run postject using npm. This is needed for #45038. Refs: https://github.com/nodejs/single-executable/blob/1840f3d9c5f4fa0d29aabd5618c4ff9745f7be87/meetings/2022-10-31.md?plain=1#L75-L76 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #45298 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im>
Configuration menu - View commit details
-
Copy full SHA for 4aaec07 - Browse repository at this point
Copy the full SHA 4aaec07View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5eb93f1 - Browse repository at this point
Copy the full SHA 5eb93f1View commit details -
crypto: fix error when getRandomValues is called without arguments
PR-URL: #45854 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for c643645 - Browse repository at this point
Copy the full SHA c643645View commit details -
crypto: fix CryptoKey WebIDL conformance
PR-URL: #45855 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for 1a8aa50 - Browse repository at this point
Copy the full SHA 1a8aa50View commit details -
test,crypto: update WebCryptoAPI WPT
PR-URL: #45860 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for da78f9c - Browse repository at this point
Copy the full SHA da78f9cView commit details -
doc: remove release cleanup step
- The pull request is automatically closed. - The branch is automatically deleted. PR-URL: #45858 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 726b285 - Browse repository at this point
Copy the full SHA 726b285View commit details -
doc: add backticks to webcrypto rsaOaepParams
PR-URL: #45883 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 48ea28a - Browse repository at this point
Copy the full SHA 48ea28aView commit details -
test: add CryptoKey transferring tests
PR-URL: #45811 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5fa6a70 - Browse repository at this point
Copy the full SHA 5fa6a70View commit details -
doc: reduce likelihood of mismerges during release
Switch to the `patience` git diff algorithm to reduce the likelihood of mismerges when the release commit is cherry-picked to the `main` branch. Refs: nodejs/Release#771 (comment) PR-URL: #45864 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Configuration menu - View commit details
-
Copy full SHA for 662f574 - Browse repository at this point
Copy the full SHA 662f574View commit details -
test: update url wpt to latest
PR-URL: #45852 Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 22c1e91 - Browse repository at this point
Copy the full SHA 22c1e91View commit details -
test_runner: run t.after() if test body throws
This commit fixes a bug where t.after() was not called if the test body threw an exception. PR-URL: #45870 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for cade2fc - Browse repository at this point
Copy the full SHA cade2fcView commit details -
test: update encoding wpt to latest
PR-URL: #45850 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 286acaa - Browse repository at this point
Copy the full SHA 286acaaView commit details -
test: fix mock.method to support class instances
It fixes a problem when trying to spy a method from a class instance or static functions on a class instance PR-URL: #45608 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 55e4140 - Browse repository at this point
Copy the full SHA 55e4140View commit details -
tools: add
ArrayPrototypeConcat
to the list of primordials to avoidPR-URL: #44445 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for 1e32520 - Browse repository at this point
Copy the full SHA 1e32520View commit details -
Configuration menu - View commit details
-
Copy full SHA for a749ced - Browse repository at this point
Copy the full SHA a749cedView commit details -
tools: enforce use of trailing commas in
tools/
PR-URL: #45889 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Configuration menu - View commit details
-
Copy full SHA for 5aaa8c3 - Browse repository at this point
Copy the full SHA 5aaa8c3View commit details -
PR-URL: #45899 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3bef8bc - Browse repository at this point
Copy the full SHA 3bef8bcView commit details -
test: fix test broken under --node-builtin-modules-path
PR-URL: #45894 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Configuration menu - View commit details
-
Copy full SHA for 7cb6fef - Browse repository at this point
Copy the full SHA 7cb6fefView commit details -
PR-URL: #45797 Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d94dba9 - Browse repository at this point
Copy the full SHA d94dba9View commit details -
src: fix tls certificate root store data race
OpenSSL internally synchronizes access to the X509_STORE. Creation of the global root store in Node was not properly synchronized, however, introducing the possibility of data races when multiple threads try to create it concurrently. This commit coincidentally removes the last call to the thread-unsafe ERR_error_string() function. Fixes: #45743 PR-URL: #45767 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for f069246 - Browse repository at this point
Copy the full SHA f069246View commit details -
Configuration menu - View commit details
-
Copy full SHA for 14c95ec - Browse repository at this point
Copy the full SHA 14c95ecView commit details -
node-api: generalize finalizer second pass callback
Generalize the finalizer's second pass callback to make it cancellable and simplify the code around the second pass callback. With this change, it is determined that Reference::Finalize or RefBase::Finalize are called once, either from the env's shutdown, or from the env's second pass callback. All existing node-api js tests should pass without a touch. The js_native_api cctest is no longer applicable with this change, just removing it. PR-URL: #44141 Refs: #44071 Reviewed-By: Michael Dawson <midawson@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 6e9676e - Browse repository at this point
Copy the full SHA 6e9676eView commit details -
tools: update lint-md dependencies
Update to @rollupw/plugin-commonjs@24.0.0 and rollup@3.7.5. PR-URL: #45813 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 974442e - Browse repository at this point
Copy the full SHA 974442eView commit details -
deps: update timezone to 2022g
PR-URL: #45731 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6963c96 - Browse repository at this point
Copy the full SHA 6963c96View commit details -
crypto: fix CryptoKey prototype WPT
PR-URL: #45857 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7a97f3f - Browse repository at this point
Copy the full SHA 7a97f3fView commit details
Commits on Jan 31, 2023
-
src: check size of args before using for exec_path
If we are in an artifically created Environment that has no args set, and uv_exepath returns an error (for instance, if /proc is not mounted on a Linux system), then we crash with a nullptr deref attempting to use argv[0]. Fixes: #45901 PR-URL: #45902 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 574afac - Browse repository at this point
Copy the full SHA 574afacView commit details -
Configuration menu - View commit details
-
Copy full SHA for e4fc3ab - Browse repository at this point
Copy the full SHA e4fc3abView commit details -
doc: fix wrong output of example in
url.password
Tailing slash of url.href is ommited. PR-URL: #45928 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 546e083 - Browse repository at this point
Copy the full SHA 546e083View commit details -
benchmark: include webstreams benchmark
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: #45876 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Configuration menu - View commit details
-
Copy full SHA for 79e0bf9 - Browse repository at this point
Copy the full SHA 79e0bf9View commit details -
build: add option to disable shared readonly heap
PR-URL: #45887 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 48e3ad3 - Browse repository at this point
Copy the full SHA 48e3ad3View commit details -
os: add availableParallelism()
This commit exposes uv_available_parallelism() as an alternative to cpus().length. uv_available_parallelism() is inspired by Rust's available_parallelism(). PR-URL: #45895 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for b2facef - Browse repository at this point
Copy the full SHA b2facefView commit details -
doc: add parallelism note to os.cpus()
With the introduction of os.availableParallelism(), users should no longer rely on os.cpus().length to determine the amount of available parallelism. This commit adds a note to the os.cpus() docs. PR-URL: #45895 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for 53684e4 - Browse repository at this point
Copy the full SHA 53684e4View commit details -
src: use string_view for FastStringKey implementation
PR-URL: #45914 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for 9ca31cd - Browse repository at this point
Copy the full SHA 9ca31cdView commit details -
PR-URL: #45803 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <midawson@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for c9845fc - Browse repository at this point
Copy the full SHA c9845fcView commit details -
util: add fast path for text-decoder fatal flag
PR-URL: #45803 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <midawson@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for f1dcbe7 - Browse repository at this point
Copy the full SHA f1dcbe7View commit details -
deps: disable avx512 for simutf on benchmark ci
Co-authored-by: Daniel Lemire <daniel@lemire.me> PR-URL: #45803 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <midawson@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 64d3e3f - Browse repository at this point
Copy the full SHA 64d3e3fView commit details -
errors: refactor to use a method that formats a list string
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com> PR-URL: #45793 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2047577 - Browse repository at this point
Copy the full SHA 2047577View commit details -
src: fix creating
Isolate
s from addonsdaae938 broke addons which create their own `Isolate` instances, because enabling the shared-readonly-heap feature of V8 requires all snapshots used for different `Isolate`s to be identical. Usage of addons that do this has probably decreased quite a bit since Worker threads were introduced in Node.js, but it’s still a valid use case, and in any case the breakage was probably not intentional (although the referenced commit did require test changes because of this issue). This commit addresses this issue partially by caching the V8 snapshot parameters and ignoring ones passed in from users in `NewIsolate()` when this feature is enabled, and makes the `NodeMainInstance` snapshot-based isolate creation also re-use this code. PR-URL: #45885 Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 27d6a8b - Browse repository at this point
Copy the full SHA 27d6a8bView commit details -
meta: add
nodejs/test_runner
to CODEOWNERSPR-URL: #45935 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Configuration menu - View commit details
-
Copy full SHA for 56247d7 - Browse repository at this point
Copy the full SHA 56247d7View commit details -
tools: update GitHub workflow action
Update the GitHub workflow action used for closing stalled issues and PRs. PR-URL: #45937 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for b0e8837 - Browse repository at this point
Copy the full SHA b0e8837View commit details -
doc: show output of example in http
User can check output of example easily. PR-URL: #45915 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 162d3a9 - Browse repository at this point
Copy the full SHA 162d3a9View commit details -
meta: add
nodejs/loaders
to CODEOWNERSPR-URL: #45940 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Jacob Smith <jacob@frende.me>
Configuration menu - View commit details
-
Copy full SHA for 10a276a - Browse repository at this point
Copy the full SHA 10a276aView commit details -
doc: remove port from example in
url.hostname
If port is used for `url.hostname`, `url.hostname` is not working. So remove port from example in `url.hostname`. PR-URL: #45927 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 83875f4 - Browse repository at this point
Copy the full SHA 83875f4View commit details -
http: improved timeout defaults handling
Co-authored-by: Luigi Pinca <luigipinca@gmail.com> PR-URL: #45778 Fixes: #43355 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3c0c5e0 - Browse repository at this point
Copy the full SHA 3c0c5e0View commit details -
PR-URL: #45957 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Configuration menu - View commit details
-
Copy full SHA for 53a94a9 - Browse repository at this point
Copy the full SHA 53a94a9View commit details -
doc: update error message of example in repl
Error message in document is different from actual result. PR-URL: #45920 Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for aab35a9 - Browse repository at this point
Copy the full SHA aab35a9View commit details -
build: fix arm64 cross-compile from powershell
Starting vcbuild.bat for cross-compiling from powershell was failing the licensertf step because it couldn't find x64_node_exe after downloading. PR-URL: #45890 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 560ee24 - Browse repository at this point
Copy the full SHA 560ee24View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4063cdc - Browse repository at this point
Copy the full SHA 4063cdcView commit details -
buffer: add buffer.isUtf8 for utf8 validation
PR-URL: #45947 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for 16ee02f - Browse repository at this point
Copy the full SHA 16ee02fView commit details -
process,worker: ensure code after exit() effectless
Cope with the delay(to the next function call) of v8::Isolate::TerminateExecution() PR-URL: #45620 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ea73702 - Browse repository at this point
Copy the full SHA ea73702View commit details -
doc: replace single executable champion in strategic initiatives doc
Jesse has informed me that he won't be able to contribute to this initiative, unfortunately. If you would like to know why, feel free to ask him or me privately. I would like to take over. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #45956 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 335acf7 - Browse repository at this point
Copy the full SHA 335acf7View commit details -
deps: fix updater github workflow job
PR-URL: #45972 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7812752 - Browse repository at this point
Copy the full SHA 7812752View commit details -
test: print failed JS/parallel tests
PR-URL: #45960 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Christian Clauss <cclauss@me.com>
Configuration menu - View commit details
-
Copy full SHA for 4d6dd10 - Browse repository at this point
Copy the full SHA 4d6dd10View commit details -
tools: update lint-md-dependencies to rollup@3.8.1
PR-URL: #45967 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Configuration menu - View commit details
-
Copy full SHA for 623b0eb - Browse repository at this point
Copy the full SHA 623b0ebView commit details -
PR-URL: #45968 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d31c478 - Browse repository at this point
Copy the full SHA d31c478View commit details -
Notable changes: - Windows applications not in ConsoleMode now properly guess handle types for FILE_TYPE_CHAR file types which cannot be stat'ed. - The UVWASI_DEBUG macro can now be used without a format string. - The libuv dependency has been updated to v1.44.2. PR-URL: #45970 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 422a981 - Browse repository at this point
Copy the full SHA 422a981View commit details -
tools: add url to
AUTHORS
update automationThis should simplify the review of `AUTHORS` file updates. PR-URL: #45971 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3b93b0c - Browse repository at this point
Copy the full SHA 3b93b0cView commit details -
doc: make EventEmitterAsyncResource's
options
as optionalRefs: https://github.com/nodejs/node/blob/main/lib/events.js#L140 PR-URL: #45985 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Configuration menu - View commit details
-
Copy full SHA for 86b2c8c - Browse repository at this point
Copy the full SHA 86b2c8cView commit details -
PR-URL: #45975 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d148f35 - Browse repository at this point
Copy the full SHA d148f35View commit details -
http: replace
var
withconst
on code of comment`const` or `let` is more preferred than `var` except iteration. PR-URL: #45951 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: theanarkh <theratliter@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8c06e2f - Browse repository at this point
Copy the full SHA 8c06e2fView commit details -
doc: use
os.availableParallelism()
in async_context and clusterConfiguration menu - View commit details
-
Copy full SHA for 61dbca2 - Browse repository at this point
Copy the full SHA 61dbca2View commit details -
debugger: refactor console in lib/internal/debugger/inspect.js
Configuration menu - View commit details
-
Copy full SHA for 4cdf000 - Browse repository at this point
Copy the full SHA 4cdf000View commit details -
src: fix crash on OnStreamRead on Windows
On Windows it's perfectly possible that the `uv_tcp_t` `read_cb` is called with an error and a null `uv_buf_t` if it corresponds to a `UV_HANDLE_ZERO_READ` read. Handle this case without crashing. Fixes: #40764 PR-URL: #45878 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 99c033e - Browse repository at this point
Copy the full SHA 99c033eView commit details -
`vois` -> `void` PR-URL: #45991 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 325fc08 - Browse repository at this point
Copy the full SHA 325fc08View commit details -
doc: fix wrong output of example in
url.protocol
Tailing slash of url.href is ommited. PR-URL: #45954 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 29d509c - Browse repository at this point
Copy the full SHA 29d509cView commit details -
`undefinec` -> `undefined` PR-URL: #45998 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Configuration menu - View commit details
-
Copy full SHA for 02a61dd - Browse repository at this point
Copy the full SHA 02a61ddView commit details -
lib: use
kEmptyObject
as default value for options`kEmptyObject` is more suitable than {} if options don't need mutation. PR-URL: #46011 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c1cc1f9 - Browse repository at this point
Copy the full SHA c1cc1f9View commit details -
esm: rewrite loader hooks test
Rewrite the test that validates that custom loader hooks are called from being a test that depends on internals to one that spawns a child process and checks its output to confirm expected behavior. PR-URL: #46016 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me>
Configuration menu - View commit details
-
Copy full SHA for 0bdf2db - Browse repository at this point
Copy the full SHA 0bdf2dbView commit details -
stream: refactor to use
validateFunction
PR-URL: #46007 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Configuration menu - View commit details
-
Copy full SHA for 441d9de - Browse repository at this point
Copy the full SHA 441d9deView commit details -
fs: refactor to use
validateInteger
PR-URL: #46008 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Configuration menu - View commit details
-
Copy full SHA for aec340b - Browse repository at this point
Copy the full SHA aec340bView commit details -
doc: use console.error for error case in timers and tls
console.error is more suitable than console.log for error case. PR-URL: #46002 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for fa5b65e - Browse repository at this point
Copy the full SHA fa5b65eView commit details -
async_hooks: refactor to use
validateObject
PR-URL: #46004 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4ee3238 - Browse repository at this point
Copy the full SHA 4ee3238View commit details -
vm: refactor to use
validateStringArray
PR-URL: #46020 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 96f1b2e - Browse repository at this point
Copy the full SHA 96f1b2eView commit details -
events: fix violation of symbol naming convention
Capital letter is followed after 'k' prefix. PR-URL: #45978 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b239f06 - Browse repository at this point
Copy the full SHA b239f06View commit details -
test: use
process.hrtime.bigint
instead ofprocess.hrtime
`process.hrtime` is legacy. So replace `process.hrtime` with `process.hrtime.bigint` in test. Refs: https://github.com/nodejs/node/blob/main/doc/api/process.md#processhrtimetime Signed-off-by: Deokjin Kim <deokjin81.kim@gmail.com> PR-URL: #45877 Refs: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f3518f3 - Browse repository at this point
Copy the full SHA f3518f3View commit details -
lib: update JSDoc of
getOwnPropertyValueOrDefault
PR-URL: #46010 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Configuration menu - View commit details
-
Copy full SHA for 7fc7b19 - Browse repository at this point
Copy the full SHA 7fc7b19View commit details -
tools: add release host var to promotion script
Adds a `NODEJS_RELEASE_HOST` environment variable that enable releasers to provide a custom proxy host to connect to when performing the promotion steps of a given release. Signed-off-by: Ruy Adorno <ruyadorno@google.com> PR-URL: #45913 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b48e82e - Browse repository at this point
Copy the full SHA b48e82eView commit details -
doc: update isUtf8 description
PR-URL: #45973 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2307a74 - Browse repository at this point
Copy the full SHA 2307a74View commit details -
tools: update doc to unist-util-select@4.0.2
PR-URL: #46038 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 18503fa - Browse repository at this point
Copy the full SHA 18503faView commit details -
tools: update lint-md-dependencies to rollup@3.9.0
PR-URL: #46039 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0a80cbd - Browse repository at this point
Copy the full SHA 0a80cbdView commit details -
PR-URL: #46040 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for e3f0194 - Browse repository at this point
Copy the full SHA e3f0194View commit details -
crypto: ensure exported webcrypto EC keys use uncompressed point format
Configuration menu - View commit details
-
Copy full SHA for 782b6f6 - Browse repository at this point
Copy the full SHA 782b6f6View commit details -
net: handle socket.write(cb) edge case
Make sure that when calling `write()` on a connecting socket, the callback is called if the socket is destroyed before the connection is established. Fixes: #30841 PR-URL: #45922 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3ad584c - Browse repository at this point
Copy the full SHA 3ad584cView commit details -
deps: update corepack to 0.15.3
PR-URL: #46037 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c8492b7 - Browse repository at this point
Copy the full SHA c8492b7View commit details -
dgram: sync the old handle state to new handle
PR-URL: #46041 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8de6425 - Browse repository at this point
Copy the full SHA 8de6425View commit details -
src: speed up process.getActiveResourcesInfo()
This change reduces the number of calls that were crossing the JS-C++ boundary to 1 and also removes the need for calling Array::New() multiple times internally and ArrayPrototypeConcat-ing the results later on, thus improving performance. Refs: #44445 (review) Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #46014 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 41f5a29 - Browse repository at this point
Copy the full SHA 41f5a29View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4df1fcc - Browse repository at this point
Copy the full SHA 4df1fccView commit details -
crypto: add KeyObject Symbol.toStringTag
PR-URL: #46043 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for 2de50fe - Browse repository at this point
Copy the full SHA 2de50feView commit details -
tools: fix lint rule recommendation
The lint rule recommends destructuring console out of the internal/console/global.js export. However, that does not exist. The top level export is actually the console object. PR-URL: #46044 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 31b8cf1 - Browse repository at this point
Copy the full SHA 31b8cf1View commit details -
lib: fix incorrect use of console intrinsic
The console object was not being frozen because the intrinsic freezing code was accessing undefined instead of the console object. PR-URL: #46044 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 86554bf - Browse repository at this point
Copy the full SHA 86554bfView commit details -
node-api: disambiguate napi_add_finalizer
napi_add_finalizer doesn't support any operations related to napi_wrap. Remove the ambiguous statements in the doc about napi_wrap and avoid reusing the v8impl::Wrap call. PR-URL: #45401 Reviewed-By: Michael Dawson <midawson@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 2ab35cf - Browse repository at this point
Copy the full SHA 2ab35cfView commit details -
test,esm: validate more edge cases for dynamic imports
PR-URL: #46059 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3269423 - Browse repository at this point
Copy the full SHA 3269423View commit details -
doc: describe argument of
Symbol.for
Symbol is described with argument, but argument of Symbol.for is ommited. So describe argument of Symbol.for for consistency. Refs: https://github.com/nodejs/node/blob/main/doc/contributing/using-symbols.md#symbolstring PR-URL: #46019 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 76c7ea1 - Browse repository at this point
Copy the full SHA 76c7ea1View commit details -
meta: update comment in
CODEOWNERS
to better reflect current policyWe do not enforce signing off by any code owners when landing PRs. PR-URL: #45944 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d8ce990 - Browse repository at this point
Copy the full SHA d8ce990View commit details -
tools: make update-eslint.sh work with npm@9
Make the `update-eslint.sh` script work with `npm@9`. PR-URL: #46088 Refs: https://github.com/nodejs/node/actions/runs/3814364920/jobs/6488613583#step:3:64 Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 609df01 - Browse repository at this point
Copy the full SHA 609df01View commit details -
tools: move update-eslint.sh to dep_updaters/
Move the `update-eslint.sh` script to the `dep_updaters/` directory. PR-URL: #46088 Refs: https://github.com/nodejs/node/actions/runs/3814364920/jobs/6488613583#step:3:64 Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for fafbd1c - Browse repository at this point
Copy the full SHA fafbd1cView commit details -
doc: include updating release optional step
PR-URL: #46089 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 84dc65a - Browse repository at this point
Copy the full SHA 84dc65aView commit details -
doc: mention how to run ncu-ci citgm
PR-URL: #46090 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1fabef3 - Browse repository at this point
Copy the full SHA 1fabef3View commit details -
doc: add personal pronouns option
PR-URL: #46118 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5539977 - Browse repository at this point
Copy the full SHA 5539977View commit details -
src: keep PipeWrap::Open function consistent with TCPWrap
PR-URL: #46064 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for b454a76 - Browse repository at this point
Copy the full SHA b454a76View commit details -
doc: fix
event.cancelBubble
documentationSetter of `event.cancelBubble` is a no-op if the value passed to it is not `true`. Refs: https://dom.spec.whatwg.org/#interface-event PR-URL: #45986 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for 1ec14c2 - Browse repository at this point
Copy the full SHA 1ec14c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3968698 - Browse repository at this point
Copy the full SHA 3968698View commit details -
doc,crypto: fix WebCryptoAPI import keyData and export return
PR-URL: #46076 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for ebe2921 - Browse repository at this point
Copy the full SHA ebe2921View commit details -
src: fix typo in node_snapshotable.cc
ImmeidateInfo -> ImmediateInfo PR-URL: #46103 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0ac4e5d - Browse repository at this point
Copy the full SHA 0ac4e5dView commit details -
events: change status of
event.srcElement
to legacy`event.srcElement` is described as legacy in spec. Refs: https://dom.spec.whatwg.org/#interface-event PR-URL: #46085 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 36be0c4 - Browse repository at this point
Copy the full SHA 36be0c4View commit details -
crypto: return correct bit length in KeyObject's asymmetricKeyDetails
PR-URL: #46106 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Configuration menu - View commit details
-
Copy full SHA for 24a1016 - Browse repository at this point
Copy the full SHA 24a1016View commit details -
module: fix unintended mutation
Refs: #46061 (comment) PR-URL: #46108 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me>
Configuration menu - View commit details
-
Copy full SHA for baf30ee - Browse repository at this point
Copy the full SHA baf30eeView commit details -
doc: fix spelling in SECURITY.md
PR-URL: #46124 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1834e94 - Browse repository at this point
Copy the full SHA 1834e94View commit details -
assert: remove
assert.snapshot
PR-URL: #46112 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for 1352f08 - Browse repository at this point
Copy the full SHA 1352f08View commit details -
doc: fix ERR_TLS_RENEGOTIATION_DISABLED text
PR-URL: #46122 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Configuration menu - View commit details
-
Copy full SHA for a3c9c1b - Browse repository at this point
Copy the full SHA a3c9c1bView commit details -
PR-URL: #46130 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Configuration menu - View commit details
-
Copy full SHA for 10afecd - Browse repository at this point
Copy the full SHA 10afecdView commit details -
doc: fix (EC)DHE remark in TLS docs
It is not true that all TLS 1.3 cipher suites use ECDH. TLS 1.3 allows DH over finite fields instead of elliptic curves. Also, the key exchange mechanism is independent of the cipher suite in TLS 1.3. PR-URL: #46114 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 849a3e2 - Browse repository at this point
Copy the full SHA 849a3e2View commit details -
PR-URL: #46128 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2497702 - Browse repository at this point
Copy the full SHA 2497702View commit details -
test: add test to once() in event lib
This test verify if eventEmmiter param is right PR-URL: #46126 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 40d52fb - Browse repository at this point
Copy the full SHA 40d52fbView commit details -
src: use constant strings for memory info names
PR-URL: #46087 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6772996 - Browse repository at this point
Copy the full SHA 6772996View commit details -
tools: update lint-md-dependencies to rollup@3.9.1
PR-URL: #46129 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for f3dc432 - Browse repository at this point
Copy the full SHA f3dc432View commit details -
src: use simdutf for converting externalized builtins to UTF-16
Remove the dependency on ICU for this part, as well as the hacky way of converting embedder main sources to UTF-8 via V8 APIs. Allow `UnionBytes` to own the memory its pointing to in order to simplify the code on the `BuiltinLoader` side. PR-URL: #46119 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for fab72b1 - Browse repository at this point
Copy the full SHA fab72b1View commit details -
deps: add simdutf version to metadata
PR-URL: #46145 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 874054f - Browse repository at this point
Copy the full SHA 874054fView commit details -
doc: remove outdated sections from
maintaining-v8
PR-URL: #46137 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Configuration menu - View commit details
-
Copy full SHA for 512feaa - Browse repository at this point
Copy the full SHA 512feaaView commit details -
tools: update eslint to 8.31.0
PR-URL: #46131 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3f4c0c0 - Browse repository at this point
Copy the full SHA 3f4c0c0View commit details -
This updates the tests and the status file via running `git node wpt dom/events`. PR-URL: #46051 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7e1462d - Browse repository at this point
Copy the full SHA 7e1462dView commit details -
perf_hooks: fix checking range of
options.figures
in createHistogramFor `options.figures`, number between 1 and 5 is allowed. So need to use `validateInteger` to limit max as 5. Refs: https://github.com/nodejs/node/blob/main/doc/api/perf_hooks.md#perf_hookscreatehistogramoptions PR-URL: #45999 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8fac4c5 - Browse repository at this point
Copy the full SHA 8fac4c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for d0f905b - Browse repository at this point
Copy the full SHA d0f905bView commit details -
events: change status of
event.cancelBubble
to legacy`event.cancelBubble` is described as legacy in spec. Refs: https://dom.spec.whatwg.org/#interface-event PR-URL: #46146 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for d088d6e - Browse repository at this point
Copy the full SHA d088d6eView commit details -
deps: add /deps/**/.github/ to .gitignore
- Ignore `.github` directories in the `deps` directory. - Remove `deps/base64/base64/.github/`. PR-URL: #46091 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for d251a66 - Browse repository at this point
Copy the full SHA d251a66View commit details -
doc: add PerformanceObserver.supportedEntryTypes to doc
PR-URL: #45962 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ec34cad - Browse repository at this point
Copy the full SHA ec34cadView commit details -
Configuration menu - View commit details
-
Copy full SHA for 257224d - Browse repository at this point
Copy the full SHA 257224dView commit details -
Configuration menu - View commit details
-
Copy full SHA for ed1ac82 - Browse repository at this point
Copy the full SHA ed1ac82View commit details -
lib: reuse invalid state errors on webstreams
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: #46086 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for bc17f37 - Browse repository at this point
Copy the full SHA bc17f37View commit details -
src: remove unnecessary semicolons
PR-URL: #46171 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c4c8931 - Browse repository at this point
Copy the full SHA c4c8931View commit details -
doc: make options of readableStream.pipeTo as optional
Refs: https://github.com/nodejs/node/blob/main/lib/internal/webstreams/readablestream.js#L380 PR-URL: #46180 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 335110b - Browse repository at this point
Copy the full SHA 335110bView commit details -
doc: https update default request timeout
PR-URL: #46184 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e54483c - Browse repository at this point
Copy the full SHA e54483cView commit details -
tools: update create-or-update-pull-request-action
Fixes GitHub's `set-output` deprecation. PR-URL: #46169 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 38df662 - Browse repository at this point
Copy the full SHA 38df662View commit details -
src: remove return after abort
PR-URL: #46172 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 53ecd20 - Browse repository at this point
Copy the full SHA 53ecd20View commit details -
http: refactor to use min of validateNumber for maxTotalSockets
Remove duplicate implementation by using min of validateNumber. PR-URL: #46115 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3d1dd96 - Browse repository at this point
Copy the full SHA 3d1dd96View commit details -
vm: refactor to use validate function
Throwing error after checking type is repeated. So replace it with validate function. PR-URL: #46176 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 277d9da - Browse repository at this point
Copy the full SHA 277d9daView commit details -
doc: use "file system" instead of "filesystem"
#44004 (comment) PR-URL: #46178 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d7a8c07 - Browse repository at this point
Copy the full SHA d7a8c07View commit details -
tools: add automation for updating postject dependency
Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #46157 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 1b0cc79 - Browse repository at this point
Copy the full SHA 1b0cc79View commit details -
lib: refactor to use validate function
Throwing error after checking type is repeated. So replace it with validate function. PR-URL: #46101 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d6fc855 - Browse repository at this point
Copy the full SHA d6fc855View commit details -
src: distinguish env stopping flags
`Environment::FreeEnvironment` creates a `DisallowJavascriptExecutionScope`, so the flag `Environment::can_call_into_js()` should also be set as `false`. As `Environment::can_call_into_js_` is a simple boolean flag, it should not be accessed off-threads. PR-URL: #45907 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9648b06 - Browse repository at this point
Copy the full SHA 9648b06View commit details -
crypto: ensure auth tag set for chacha20-poly1305
Because OpenSSL v1.x doesn't do that by itself (OpenSSL v3.x does.) Fixes: #45874 PR-URL: #46185 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 599d1dc - Browse repository at this point
Copy the full SHA 599d1dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9bfd404 - Browse repository at this point
Copy the full SHA 9bfd404View commit details -
deps: bump googletest to 2023.01.13
commit hash: 356fc301251378e0f6fa6aa794d73714202887ac PR-URL: #46198 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for cce2af4 - Browse repository at this point
Copy the full SHA cce2af4View commit details -
tools: fix macro name in update-undici
PR-URL: #46217 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 09adb86 - Browse repository at this point
Copy the full SHA 09adb86View commit details -
tools: update lint-md-dependencies
Update to remark-preset-lint-node@3.4.0 rollup@3.10.0. PR-URL: #46214 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for fcca2d5 - Browse repository at this point
Copy the full SHA fcca2d5View commit details -
PR-URL: #46215 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for db61722 - Browse repository at this point
Copy the full SHA db61722View commit details -
PR-URL: #46189 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4f2d9ea - Browse repository at this point
Copy the full SHA 4f2d9eaView commit details -
lib: use kEmptyObject and update JSDoc in webstreams
Use kEmptyObject as default value of strategy. Plus, make reason and chunk as optional. And refactor to use validateBuffer. Refs: https://github.com/nodejs/node/blob/main/doc/api/webstreams.md#transformstreamdefaultcontrollerenqueuechunk Refs: https://github.com/nodejs/node/blob/main/doc/api/webstreams.md#transformstreamdefaultcontrollererrorreason Refs: https://github.com/nodejs/node/blob/main/doc/api/webstreams.md#writablestreamdefaultwriterabortreason Refs: https://github.com/nodejs/node/blob/main/doc/api/webstreams.md#writablestreamdefaultwriterwritechunk PR-URL: #46183 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for edcd4fc - Browse repository at this point
Copy the full SHA edcd4fcView commit details -
src: hide kMaxDigestMultiplier outside HKDF impl
There is no reason to expose this constant outside of the HKDF implementation, especially with such a generic name. PR-URL: #46206 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Configuration menu - View commit details
-
Copy full SHA for 3ce39bb - Browse repository at this point
Copy the full SHA 3ce39bbView commit details -
src,lib: the handle keeps loop alive in cluster rr mode
PR-URL: #46161 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 08a6a61 - Browse repository at this point
Copy the full SHA 08a6a61View commit details -
doc: update to match changed
--dns-result-order
defaultUpdate documentation to match the changed `--dns-result-order` default value in Node.js 17.0.0. PR-URL: #46148 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for be85d5a - Browse repository at this point
Copy the full SHA be85d5aView commit details -
PR-URL: #46194 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3bf2371 - Browse repository at this point
Copy the full SHA 3bf2371View commit details -
deps: cherrypick simdutf patch
PR-URL: #46194 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 340d76a - Browse repository at this point
Copy the full SHA 340d76aView commit details -
PR-URL: #46193 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7c03a3d - Browse repository at this point
Copy the full SHA 7c03a3dView commit details -
http: writeHead if statusmessage is undefined dont override headers
Configuration menu - View commit details
-
Copy full SHA for 3e70b7d - Browse repository at this point
Copy the full SHA 3e70b7dView commit details -
src: replace unreachable code with static_assert
This function base64-decodes a given JavaScript string to obtain the secret key, whose length must not exceed INT_MAX. However, because JavaScript strings are limited to v8::String::kMaxLength chars and because base64 decoding never yields more bytes than input chars, the size of the decoded key must be strictly less than v8::String::kMaxLength bytes. Therefore, it is sufficient to statically assert that String::kMaxLength <= INT_MAX (which is always true because String::kMaxLength itself is an int). Aside from being unreachable, Coverity considers the current code "suspicious" because it indicates that buffers larger than INT_MAX might actually be allocated. PR-URL: #46209 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 94605b1 - Browse repository at this point
Copy the full SHA 94605b1View commit details -
http: refactor to use
validateHeaderName
Remove duplicate implementation by using validateHeaderName. PR-URL: #46143 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e620de6 - Browse repository at this point
Copy the full SHA e620de6View commit details -
esm: mark
importAssertions
as requiredWe already always specify a value, and failing to do so would likely be a bug. PR-URL: #46164 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 463bb96 - Browse repository at this point
Copy the full SHA 463bb96View commit details -
doc: add text around collaborative expectations
- add text discussed by the TSC Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #46121 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joe Sepi <sepi@joesepi.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5294371 - Browse repository at this point
Copy the full SHA 5294371View commit details -
Configuration menu - View commit details
-
Copy full SHA for a558774 - Browse repository at this point
Copy the full SHA a558774View commit details -
doc: add note to tls docs about secureContext availability
tls.createServer() and new tls.Server() ignore secureContext option. PR-URL: #46224 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a9db45e - Browse repository at this point
Copy the full SHA a9db45eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 896027c - Browse repository at this point
Copy the full SHA 896027cView commit details -
stream: implement finished() for ReadableStream and WritableStream
Configuration menu - View commit details
-
Copy full SHA for cde5960 - Browse repository at this point
Copy the full SHA cde5960View commit details -
PR-URL: #46242 Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for eaeb870 - Browse repository at this point
Copy the full SHA eaeb870View commit details -
Configuration menu - View commit details
-
Copy full SHA for 52a7887 - Browse repository at this point
Copy the full SHA 52a7887View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6317502 - Browse repository at this point
Copy the full SHA 6317502View commit details -
test: improve test coverage for WHATWG
TextDecoder
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com> PR-URL: #45241 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1790569 - Browse repository at this point
Copy the full SHA 1790569View commit details -
PR-URL: #46257 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b7fe8c7 - Browse repository at this point
Copy the full SHA b7fe8c7View commit details -
src: fix endianness of simdutf
PR-URL: #46257 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 646cadc - Browse repository at this point
Copy the full SHA 646cadcView commit details -
test: refactor to avoid mutation of global by a loader
This makes the test compatible with off-thread loaders. Co-Authored-By: Geoffrey Booth <webadmin@geoffreybooth.com> PR-URL: #46220 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Configuration menu - View commit details
-
Copy full SHA for a3056f4 - Browse repository at this point
Copy the full SHA a3056f4View commit details -
events: change status of
event.returnvalue
to legacy`event.returnvalue` is described as legacy in spec. Plus, add missed '#'(private member) of defaultPrevented in implementation. Refs: https://dom.spec.whatwg.org/#interface-event Refs: https://developer.mozilla.org/en-US/docs/Web/API/Event/returnValue PR-URL: #46175 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 297773c - Browse repository at this point
Copy the full SHA 297773cView commit details -
trace_events: refactor to use
validateStringArray
`options.categories` is string[]. So used `validateStringArray` Refs: https://nodejs.org/dist/latest-v19.x/docs/api/tracing.html#trace_eventscreatetracingoptions PR-URL: #46012 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0defe4e - Browse repository at this point
Copy the full SHA 0defe4eView commit details -
stream: fix pipeline calling end on destination more than once
Configuration menu - View commit details
-
Copy full SHA for a87963d - Browse repository at this point
Copy the full SHA a87963dView commit details -
doc: fix mismatched arguments of
NodeEventTarget
Arguments of some APIs are mismatched and 2 APIs are not as described. PR-URL: #45678 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for de2b7a9 - Browse repository at this point
Copy the full SHA de2b7a9View commit details -
test: update postject to 1.0.0-alpha.4
PR-URL: #46212 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tierney Cyren <hello@bnb.im>
Configuration menu - View commit details
-
Copy full SHA for 536322f - Browse repository at this point
Copy the full SHA 536322fView commit details -
src: rename internal module declaration as internal bindings
This is a continuation of the name reification on the internal bindings. Renames NODE_MODULE_CONTEXT_AWARE_INTERNAL and NODE_MODULE_EXTERNAL_REFERENCE to NODE_BINDING_CONTEXT_AWARE_INTERNAL and NODE_BINDING_EXTERNAL_REFERENCE respectively. PR-URL: #45551 Backport-PR-URL: #46336 Refs: #44036 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Configuration menu - View commit details
-
Copy full SHA for fcfde34 - Browse repository at this point
Copy the full SHA fcfde34View commit details
Commits on Feb 1, 2023
-
2023-02-02, Version 18.14.0 'Hydrogen' (LTS)
Notable changes: * deps: * upgrade npm to 9.3.1 (npm team) #46242 * doc: * add parallelism note to os.cpus() (Colin Ihrig) #45895 * http: * join authorization headers (Marco Ippolito) #45982 * improved timeout defaults handling (Paolo Insogna) #45778 * stream: * implement finished() for ReadableStream and WritableStream (Debadree Chatterjee) #46205 PR-URL: #46396
Configuration menu - View commit details
-
Copy full SHA for 220a5a1 - Browse repository at this point
Copy the full SHA 220a5a1View commit details