Hide user collection tag #794

…ndled to catch the override before running migrations

Base Containter Note and Bundle Before Migrations

support overriding gems via knapsack

📚 Doc two different methods for getting started

This involves adding a utility function `bin/knapsacker` Also reconciled the license in regards to Samvera licenses and copyright holders.

📚 Incorporate docs from Adventist knapsack

This commit documents the need for Knapsack to reference a branch; as well as provides documentation for doing so.

🧹 Configure Knapsack to Use Hyku Prime

references hyrax-webapp[tags/v5.2.0]. Required to get the build/pipeline working.

Get the build working

commit: samvera-labs/hyku_knapsack@5a7c54c which wasn't intentional bumped rails to 7+

This reverts commit 0363299.

This reverts commit 5a7c54c.

get fixes from adventist

This is a quality of life improvement. Use this generator to create a new work type in the Knapsack because using the Hyrax work generator will create files in the submodule and we don't want that. ```sh rails generate hyku_knapsack:work WorkType ```

This decorator needs to be in play for the work types to load their respective yaml files.

🎁 Add works generator

🎁 Add SimpleSchemaLoaderDecorator for work types

This commit will fix a bug where the controller template was not being found as well as the model spec. The path was corrected to match the path found in Hyrax. Lastly, the generator now includes adding Hyku specific includes to the controller and model files that were generated.

Update `HykuKnapsack::WorkResourceGenerator`

These files are what we changed in HykuUp Knapsack to get the build, test, and lint workflows working. Also, updating the Hyku submodule to bring in the Valkyrie work.

Attempt to resolve error on pipeline: mv: cannot stat 'rspec.xml': No such file or directory

Ultimately the actions step needs to updated to not run if rspec.xml doesn't exist. We've added specs but there isn't enough to satisfy the pipeline since its processes splits into three test tasks. We'd need at least three separate spec files.

…psack into prime_main

🎁 Contribute back from HykuUp Knapsack

update engine.rb to specify engine root for migrations

Contribute back from pals

…knapsack

This causes a missing partial error. Where is ajax_modal supposed to come from?

updates to the latest of Hyku to pull in theme fixes

this base is being copied from valkyrizing pals

Files are in Hyrax... why were they here?

Cannot duplicate decorators between knapsack & webapp.

Fix wasn't applied to knapsack prime

Term is obsolete

to avoid error: ".yarn-tarball.tgz: no space left on device" ref: https://assaydepot.slack.com/archives/C0313NK5NMA/p1713461713731049

Still need yaml files customized.

…cords fix: Ensure multiple? method is called correctly for new and existing records - Updated the view logic to check if the instance responds to `multiple?` first. - If the instance does not respond, then check if the class responds to `multiple?`. - This ensures the correct method is called for both new and existing records, preventing method undefined errors.

# Story Creates remaining resources for existing models. (Conference item was already created) Refs - #687

# Story A dev was unable to edit a resource without receiving an error from the partial. This PR updates the partials to handle resources and dog biscuit records. Refs - #687 # Expected Behavior Before Changes ![image](https://github.com/user-attachments/assets/86ee18b6-0f3e-4f07-af84-a771ababf81b) # Expected Behavior After Changes ![image](https://github.com/user-attachments/assets/3bb6c57d-f295-4117-8f86-3178fbc796ef)

These changes are probably not necessary since this is already included in HykuIndexing but for consistency with Hyku, we are explicitly including bulkrax on all indexers.

# Story Brings in a few missing includes from prior resource creation work. Refs - #702 - #687 # Expected Behavior Before Changes # Expected Behavior After Changes # Screenshots / Video <details> <summary></summary> </details> # Notes

Good job stopped working after valkyrizing adventist. issue - bensheldon/good_job#1280 solution - samvera/hyku#2125

Duplicate terms will be moved to basic_metadata or equivalent as common terms are identified.

File adl_basic_metadata is currently unused, and contains basic_metadata from Hyrax. This will be updated to match adl's desired variations from Hyrax's basic metadata, as the duplicate data in each work type's yaml is cleaned up.

Remove index_keys when no index specified. Remove duplicated terms that come via their own metadata yaml.

Term is already present via basic_metadata.

# Story Adding yaml metadata to match adl's current work types. Slugs were removed as those will be handled in a separate ticket. More work will be done to move duplicate terms into the `basic_metadata.yaml` and to standardize to Hyrax's terms. Refs - #689 # Expected Behavior Before Changes # Expected Behavior After Changes # Screenshots / Video <details> <summary></summary> </details> # Notes

Add new valkyrized slug files: - adds slug_metadata.yaml (corresponding to slug_metadata.rb) - adds slug_bug_valkyrie.rb (corresponding to slug_bug.rb) - adds slug_valkyrie_overrides.rb and find_by_slug.rb custom_queries (corresponding to slug_overrides.rb) - adds slugs to resource models - initializes custom queries in engine.rb Clean up ActiveFedora slug files: - removes slug_for_upgrade from slug_metadata - removes use of slug_for_upgrade from slug_bug.rb - moves IiifPrint.config.ancestory_identifier_function to hyrax.rb Still to do: - transation steps &/or callbacks to set slugs & clean up after updates Refs #713

- Fix some metadata yaml files - Add slugs to all Valkyrie resources, forms, & indexers. - Add transaction steps to maintain slugs as part of save/update. - Add custom queries to find by slug. - Rename the solr_document_decorator since Hyku already has one.

# Story This work implements slugs for resources. Note for future implementers: it has not been tested with collection resources. Refs #713 # Expected Behavior Before Changes There was no way to add or update slugs for resources. # Expected Behavior After Changes - [ ] Aark_id is included on work all of Adventist's work types (not base hyku's etd or oer resources, and not collections). - [ ] Aark_id is used along with title to build a slug used in the url - [ ] The resource's original id is indexed as resource_id_ssi - [ ] Relationships function appropriately for works with or without slugs: collection membership, file sets, child works, etc # Screenshots / Video <details> <summary>Using slugs</summary> https://github.com/user-attachments/assets/a62aad0d-63ce-42d4-858f-049c9ede3c29 </details> # Notes This has not been tested on Fedora data, because I am unable to get a local Valkyrized app to include Fedora data. Will there be issues regarding the changing of the slug predicate?

After deleting a work, Hyrax's listener removes the index. `Hyrax.index_adapter.delete(resource: event[:object])` In the case of slugs, this wouldn't find the index since solr's id is the slug, not the UUID of the resource. This commit overrides Hyrax's listener to remove the indexes by query instead.

# Story Overrides the Hyrax listener to clean up the indexes by either slug or id. Also updates code in set_slug which does the same thing in the process of updating a slug to avoid stray indexes. Refs: - #718 # Expected Behavior Before Changes Resource deleted but index did not. # Expected Behavior After Changes Both resource and its index are deleted together. # Screenshots / Video <details> <summary></summary> </details> # Notes Not yet tested... awaiting ability to build app

protects against error that prevented the uv from loading

Temporary patches until the changes are pushed into IiifPrint. See #728 and child_work_attributes_function should call Array.wrap not to_a #729

works with bulkrax: handle-remote-files-for-valkyrie

1) presenter no longer responds to label. 2) Hyrax.config.curation_concerns does not include Resources.

# Story This fixes issues preventing universal viewer from building the manifest with the items. Two issues were found: 1) `Hyrax.config.curation_concerns` does not include the Resource objects. It is comparing to `solr_doc.hydra_model` which is the full work type name so the work types never match for resources. This is a concerning bug because it comes from IiifPrint, and it is logical that it would affect any resources in a valkyrized app using IiifPrint. 2) The logic to prevent the tn.jpg files from displaying in the viewer broke because the presenter no longer responds to `label`. Refs #730 # Expected Behavior Before Changes Manifest had no items so it was empty. # Expected Behavior After Changes Manifest includes image files of both file sets and child works. # Screenshots / Video <details> <summary></summary> ![Screenshot 2024-08-06 at 4 20 37 PM](https://github.com/user-attachments/assets/0b8ed05c-cde7-4734-a448-3ad5806e7e17) </details> # Notes

we will update the submodule instead since the changes were made in hyku proper.

the override thumbnail feature was intentionally deprecated. ref: - https://github.com/scientist-softserv/adventist-dl/blob/main/app/models/concerns/bulkrax/has_local_processing.rb#L9-L11

OAI import was not using the thumbnail url.

Remove solr index by slug if a resource is removed.

… from the Dockerfile that is pinned to that specific sha 20b8c56e, already

ref: - https://github.com/scientist-softserv/palni-palci/pull/1039/files

# Story Refs #718 Removes solr index by slug if a resource is removed. Completes prior work to set up listener. # Expected Behavior Before Changes # Expected Behavior After Changes # Screenshots / Video <details> <summary></summary> </details> # Notes

…/adventist_knapsack into pull-in-hyku-knapsack

… where all fired

the correct json_canonicalization version is set in Hyku

This commit will ensure that the FindBySlug query is added to the metadata adapters. Ref: - #743

This commit will remove the `SimpleSchemaLoaderDecorator` and instead use the Hyrax config method ``:simple_schema_loader_config_search_paths` to set the config search paths. Ref: - samvera/hyrax@9d8d5f8 - samvera/hyku@e29c291

This commit will change the dns of this project to `adl.test` so we can run Hyku at the same time which is on `hyku.test`

It was advised that this should not be there. I will be keeping an eye out for weirdnesses in the meantime.

updating metadata from single to multiple property definitions since the specs previously expected them to be multiple.

adds missing processor chains from updates

…ck' into pull-in-hyku-knapsack

most fail because factories are resources instead of fedora.

- Refactors some previous remote_files logic, including moving the migration to Bulkrax since the new column is used in bulkrax. - Supports overriding the standard thumbnail via the thumbnail_url coming through the bulkrax import data. - Modifies registering custom queries so they don't get clobbered.

This commit will move a lot of the stuff over to the Engine's to_prepare block so we can have a better developer experience. Prior, every time you changed code, we would need to restart the application which made for slow feedback.

These two yml will override the Hyku version and give us a new option (Adventist Digital Library and ADL Show Page) so wed can start adding Knapsack specific themes.

Add IiifPrint::Engine.root to simple_schema_loader_config_search_paths so tests can run.

This commit will resolve load ordering. Previously, we were loading the decorators from HykuKnapsack before we load the App's, which is standard behavior, but we actually want the decorators from HykuKnapsack to load last.

The main issue was the masthead was underneath the background image so adding a z-index of 1 on it made it visible again. Now we can get rid of it and just dial in the css to make it look better.

# Story Locally, point to bulkrax branch: handle-remote-files-for-valkyrie Refs - #708 - #723 # Expected Behavior Before Changes # Expected Behavior After Changes # Screenshots / Video <details> <summary></summary> </details> # Notes

Updated user_util_links to match Hyku's user_util_links. The only difference is the extra links that Adventist uses. I also moved it into the themes directory.

This commit will update the search form area styling on the homepage and also move the updated partials into the themes directory.

Import_url was missing.

# Story Import_url is needed in file_set metadata

This commit will fix the homepage body and footer styling and move the files into the appropriate themes directory.

# Story ![adl_homepage](https://github.com/user-attachments/assets/d9988647-4468-4e28-a5db-e41b0c660547)

This commit will move the css for the adventist_digital_library theme to only affect things when it is on that theme. Also removed the home_content partial since it was not used in the theme. It would throw and error if used on the Default Theme so it was no longer needed. Also added a screenshot for the adventist_digital_library theme so it can be previewed in the admin appearance themes section.

This commit fixes the linting issues on the Adventist Valkyrie project. The files in this commit have been modified by either rubocop auto fixes or manual disable and enable notations. There should not be any changes to the functionality of the application. Ref: - #741

This commit fixes the linting issues on the Adventist Valkyrie project. The files in this commit contain only whitespace changes or changing Note comments to NOTE as suggested by Rubocop. There should not be any changes to the functionality of the application. Ref: - #741

Moving the application and homepage templates to the theme directory. Also, changing the name of the show theme to 'adl_show' so we don't have any conflicts with the homepage theme.

This commit will adjust the styles for the adl_show page theme to match closer to the pre-Valkyrie version.

This commit will make the appearance styling match Hyku's appearance styling. I am removing the default_fonts_form partial because it doesn't seem any different than the one in Hyku.

This commit will bring over the build-test-lint yaml that we've been using in HykuUp Knapsack. The problem is that we ran out of space in CI.

This commit will fix the styling of the featured works on the homepage. by bringing back the background and adding a gradient like before.

There was an override in the knapsack that wasn't needed anymore and it was causing the catalog index page to crash. Also, added the themes behavior mixin to the catalog controller as well because of the custom user_util_links and controls partial that is used. We need to inject those paths into the view paths.

This gets it pretty close, we can chat with Katharine to see what she wants to change.

Prior to this commit, feature collections were hard coded. This commit will bring the feature collections in line with Hyku which will allow the user to choose which collections are featured on the homepage.

This commit will add the themes behavior to Collections show so the masthead and controls will look consistent with the rest of the pages.

This commit excludes the hash alignment cop from the decorator file. There was a previous pattern established concerning hash alignments that conflicted with Rubocop's standards. We will be staying with the established pattern in the application. Ref: - #741

This commit updates depricated Rubocop syntax. `IgnoredMethods` for `Metrics/BlockLength` in the file `rubocop.yml` is replaced with `AllowedMethods`. `Metrics/LineLength` is replaced with `Layout/LineLength` in all appropriate files. Ref: - #741

# Story The Lint step is failing on the adventist pipeline. Run rubocop and correct the reported errors. Refs - [ ] #741 # Expected Behavior Before Changes Linting does not pass. # Expected Behavior After Changes Linting pipeline should pass. # Screenshots / Video # Notes - Run `bundle exec rubocop` in the `samvera/` directory. All tests should pass.

There seems to be a bigger issue going on where some fields are getting `['']` as a value. This is a quick fix to prevent the view from bugging out when it encounters this.

Not sure how these got in here but we don't need these in the Knapsack so I'm removing them for now.

…ilds

…ilds (#757)

Fixes admin set migration and updates bulkrax.

# Story Update submodule to bring in admin set fix and bulkrax fix. Refs - #755 and #746 # Expected Behavior Before Changes - Admin set edit failed - Imports using unmigrated admin sets failed # Expected Behavior After Changes # Screenshots / Video <details> <summary></summary> </details> # Notes

Update submodule to pull in thumbnail rendering fix + set HYKU_FILE_ACL to 'true' to fix permission issues seen in staging Issue: - #763

Update submodule to pull in thumbnail rendering fix + set HYKU_FILE_ACL to 'true' to fix permission issues seen in staging Issue: - #763 # Screenshots / Video ## BEFORE <img width="1169" alt="Screenshot 2024-08-20 at 3 11 07 PM" src="https://github.com/user-attachments/assets/402953fa-3a92-45f0-a639-dbcbc34c86ba"> ## AFTER <img width="1171" alt="Screenshot 2024-08-20 at 3 11 49 PM" src="https://github.com/user-attachments/assets/b49dfb7f-dd1f-48d0-8718-9e418197886e">

This commit fixes the linting issues on the Adventist Valkyrie project. The files in this commit have been modified by either rubocop auto fixes or manual disable and enable notations. There should not be any changes to the functionality of the application. Ref: - #741

This commit fixes the linting issues on the Adventist Valkyrie project. The files in this commit contain only whitespace changes or changing Note comments to NOTE as suggested by Rubocop. There should not be any changes to the functionality of the application. Ref: - #741

This commit excludes the hash alignment cop from the decorator file. There was a previous pattern established concerning hash alignments that conflicted with Rubocop's standards. We will be staying with the established pattern in the application. Ref: - #741

This commit updates depricated Rubocop syntax. `IgnoredMethods` for `Metrics/BlockLength` in the file `rubocop.yml` is replaced with `AllowedMethods`. `Metrics/LineLength` is replaced with `Layout/LineLength` in all appropriate files. Ref: - #741

There seems to be a bigger issue going on where some fields are getting `['']` as a value. This is a quick fix to prevent the view from bugging out when it encounters this.

Not sure how these got in here but we don't need these in the Knapsack so I'm removing them for now.

…ilds

This commit fixes the failing application_spec and ignores the splash page spec that is currently failing due to the changes in styling. The client requested the styling be reverted to base Hyku. We are waiting to get feedback from the client on the styling of the splash page. If the page stays as is, this spec can be removed. If the styling is updated, this spec will need to be updated. Ref: - [741](#741)

Originally we had a require 'frigg' in this initializer because we want frigg to log and then load the slug logic. However, this threw off the load order of things and caused the Hyrax::PcdmCollection to be registered for Collection instead of CollectionResource. Wrapping this in a to_prepare will ensure it's loaded at the right time and keep it loaded in dev.

# Story This commit fixes the failing tests in the CI pipeline. Refs - [ ] #741 # Expected Behavior Before Changes Testing pipeline had two failing tests. # Expected Behavior After Changes There are no failing tests in the pipeline. # Screenshots / Video

# Story Refs #770 # Expected Behavior Before Changes Bulkrax imports were failing. # Expected Behavior After Changes Bulkrax imports successfully. # Screenshots / Video <details> <summary></summary> </details> # Notes

We had custom code for PDF.js to work with Adventist but it wasn't being honored because Hyku has a helper by the same name, so the Adventist one wasn't getting hit. Issue: - #731

GenericWork and Image resource models come from Hyku. They need to use custom configuration.

# Story Refs - #774 # Expected Behavior Before Changes PDF files did not split for Image & GenericWork resources. # Expected Behavior After Changes PDF files split into pages of the same model as the parent. # Screenshots / Video <details> <summary></summary> ![Screenshot 2024-08-27 at 5 03 09 PM](https://github.com/user-attachments/assets/f067704c-a29c-4cde-8085-7ebc552bd84d) </details> # Notes

Brings in bulkrax update.

# Story Refs - #770 # Expected Behavior Before Changes Reingesting a work failed due to expecting remote files. # Expected Behavior After Changes Able to reingest a work. # Screenshots / Video <details> <summary></summary> </details> # Notes

Provides a way to turn off pdf splitting for a tenant.

Doing it in the splitter meant the job errored instead of just not splitting.

# Story Refs - #779 # Expected Behavior Before Changes If the original file has a .pdf suffix, IiifPrint split will be attempted. # Expected Behavior After Changes PDFjs/UV feature flipper `use_iiif_print` will bypass splitting when set to PDFjs. # Screenshots / Video <details> <summary></summary> </details> # Notes Adding the flag to the splitter allowed the jobs to run and fail because no images were split. Instead the flag was moved to the beginning of the job itself, allowing the process to stop before submitting any further jobs.

Serverless Iiif does not support valkyrie. Issue: - #786

This commit hides the User Collection and Public tags from the public collection show pages (admin dashbaord) and the catalog search results page. Ref: - #791

Commits on Sep 19, 2023

fixes for build

orangewolf committed Sep 19, 2023

Configuration menu

View commit details

Copy full SHA for 1e6b11c

Browse repository at this point

Copy the full SHA

1e6b11c View commit details

Browse the repository at this point in the history

Commits on Feb 1, 2024

get fixes from adventist

orangewolf committed Feb 1, 2024

Configuration menu

View commit details

Copy full SHA for 672dc9b

Browse repository at this point

Copy the full SHA

672dc9b View commit details

Browse the repository at this point in the history

Commits on Sep 5, 2024

Update hyrax-webapp

ShanaLMoore committed Sep 5, 2024

Configuration menu

View commit details

Copy full SHA for eac35dd

Browse repository at this point

Copy the full SHA

eac35dd View commit details

Browse the repository at this point in the history

Hide user collection tag #794

Hide user collection tag #794

Commits on Sep 19, 2023

Commits on Dec 20, 2023

Commits on Jan 8, 2024

Commits on Jan 9, 2024

Commits on Jan 10, 2024

Commits on Jan 11, 2024

Commits on Feb 1, 2024

Commits on Feb 19, 2024

Commits on Feb 20, 2024

Commits on Mar 14, 2024

Commits on Mar 15, 2024

Commits on Mar 18, 2024

Commits on Apr 2, 2024

Commits on Apr 3, 2024

Commits on May 15, 2024

Commits on Jul 3, 2024

Commits on Jul 12, 2024

Commits on Jul 15, 2024

Commits on Jul 17, 2024

Commits on Jul 18, 2024

Commits on Jul 19, 2024

Commits on Jul 22, 2024

Commits on Jul 23, 2024

Commits on Jul 24, 2024

Commits on Jul 25, 2024

Commits on Jul 26, 2024

Commits on Jul 30, 2024

Commits on Aug 1, 2024

Commits on Aug 2, 2024

Commits on Aug 5, 2024

Commits on Aug 6, 2024

Commits on Aug 7, 2024

Commits on Aug 8, 2024

Commits on Aug 9, 2024

Commits on Aug 12, 2024

Commits on Aug 13, 2024

Commits on Aug 14, 2024

Commits on Aug 15, 2024

Commits on Aug 16, 2024

Commits on Aug 17, 2024

Commits on Aug 18, 2024

Commits on Aug 19, 2024

Commits on Aug 20, 2024

Commits on Aug 21, 2024

Commits on Aug 23, 2024

Commits on Aug 27, 2024

Commits on Aug 28, 2024

Commits on Aug 29, 2024

Commits on Aug 30, 2024

Commits on Sep 5, 2024

Commits on Sep 9, 2024