* Add 'show' CLI for system-health feature

Signed-off-by: Shlomi Bitton <shlomibi@mellanox.com>

* Add unit test for 'system-health' feature, add support for testing in 'show' script, Fix comments

Signed-off-by: Shlomi Bitton <shlomibi@mellanox.com>

* Fix additional comments

* Fix comments

* Update Command-Reference.md

Add a CLI reference for system-health feature.

* Fix LGTM alerts

* Fix comment

Change 'Ignore' to 'Ignored'

* Update Command-Reference.md

Fix example output

* Update Command-Reference.md

* Change 'summary' output and adapt test and reference to the new change

* Update main.py

* Fix multiline output for expected output

* keep output aligned

* Fix import for unit testing after community change

* Add clicommon for @cli.group after community change

* Align changes in the feature to the CLI on commit
sonic-net/sonic-buildimage@8ea2ab5

Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>

* Update main.py

* Move new group CLI into a separate file

* Organize imports per PEP8 standards

* Organize imports per PEP8 standards

* Reformat docstring for readability

…onic-net#1162)


Previous code only enumerate on distinct neighbors, thus only one
port is shown for a neighbor.

Signed-off-by: Guohan Lu <lguohan@gmail.com>

…1155)

* Update lib.py
* Keep the code format align see add spaces for special symbols
* remove unused code

The 'ipaddress.ip_interface' accepts only unicode str as input, which is
default in python3. However, an exception will raise when running in
python2. This commit fix the issue.

Signed-off-by: bingwang <bingwang@microsoft.com>

…-net#1157)

* Add watermark testcases and mock counters

Signed-off-by: Neetha John <nejo@microsoft.com>

…xists (sonic-net#1173)

Signed-off-by: Jing Kan jika@microsoft.com

sonic-net#1166)

Signed-off-by: Jing Kan jika@microsoft.com

…ce (sonic-net#1177)

Signed-off-by: Jing Kan jika@microsoft.com

* Add `config vlan proxy_arp <vlan id> <enable/disable>`
* Add proxy ARP info to `show vlan brief`

…unters. (sonic-net#1180)

* Fix for Issue: sonic-net/sonic-buildimage#5655

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>

* Updated the the fix for pfc/queue counters also.

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>

…et#1174)

Counter polling is enabled via enable_counters script when booting
into new image and these configuration is written to config_db.
However, subsequent fast-reboot into the same image will have counter
polling enabled by default. This affect fast-reboot time. As a workaround,
we will disable counter poll when entering fast-reboot.

singed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>

…t#1182)

stdeb.cfg was needed for building Debian package. Now that we build a Python wheel, it is no longer used.

…and remove all the decode() (sonic-net#1187)

* [CLI][show][platform] Added ASIC count in the output. Also added option for JSON output.

Set min log priority of fwutil to INFO

Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>

Add LICENSE file, remove ThirdPartyLicenses.txt, as most of the files it referred to have moved to the sonic-platform-common repo, and sfputil has been completely refactored.

…cted (sonic-net#1188)

Remove `device2interface_dict` in `expect` as it is no longer needed.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>

1. show fg-nhg-hash-view
   (shows the current hash bucket view of fg nhg)

2. show fg-nhg-active-hops
   (shows which set of next-hops are active)

Currently, "Not Present" will be shown at non-sfp ports. This enhancement will show "N/A" instead of "Not Present" at non-sfp ports.

* [consutil] Store console port state in STATE_DB
* Fix LGTM issues
* Update a naming

Signed-off-by: Jing Kan jika@microsoft.com

…onic-net#1215)

route_check.py will report an ERROR in syslog if route mismatch is
found, which is out control of monit config file. This commit add an
option (-s) to control whether error will be reported in syslog.

**- How to verify it**
The update is verified on Arista-7260.
1. Add a static route whose nexthop is not reachable.

```
ip route add 1.1.1.1 via 192.168.1.101
```
2. Run ```route_check.py```, and error msg is only printed on stdout. Nothing is writen to syslog
3. Run ```route_check.py -s```. and error msg is writen to both stdout and syslog
4. Wait for 15 minutes, and confirm that monit will report the error
```
Nov  4 09:30:36.917367 str-7260cx3-acs-2 ERR monit[631]: 'routeCheck' status failed (255) -- results: { {sonic-net#12    "missed_ROUTE_TABLE_routes": [sonic-net#12        "1.1.1.1/32"sonic-net#12    ]sonic-net#12} }sonic-net#12 Failed. Look at reported mismatches above
```

Signed-off-by: bingwang <bingwang@microsoft.com>

- Replace tabs with spaces
- Fix alignment
- Remove trailing whitespace
- Remove spaces where not necessary, add spaces where necessary
- Reorganize imports per PEP8 standards

…c-net#1197)

* SONiC installer - fix string formatting during image typer check
`sonic_installer` error message misses the filename due to string formatting error. This fixes the missing string substitution in the message:
Before - Image file '{}' is of a different type than running image.
Now - Image file 'sonic-broadcom.bin' is of a different type than running image.

I added a new script file sonic_sku_create.py to generate a new HWSKU based on XML file or Minigraph. But, focus is on creating HWSKU based on XML file and not on the minigraph and l2 mode. I also added a unit test pyTest script sku_create_test.py in sonic-utilities-test folder to test the script in Unit Testing mode.
Motivation: To create SKU for Mellanox platforms based on XML file with Port related inputs and also through Minigraph file.
This tool also allows to split a port or unsplit ports based on configuration which modifies the port related information in port_config.ini and config_db.json

usage: sonic_sku_create.py [-h] [-v]
(-f FILE | -m [MINIGRAPH_FILE] | -j JSON_FILE | -pp PORT_SPLIT PORT_SPLIT)
[-b BASE] [-r] [-k HWSKU] [-p] [-vv]

Create a new SKU

optional arguments:
-h, --help show this help message and exit
-v, --version show program's version number and exit
-f FILE, --file FILE SKU definition from xml file. -f OR -m or -j must be provided when creating a new SKU
-m [MINIGRAPH_FILE], --minigraph_file [MINIGRAPH_FILE]
SKU definition from minigraph file. -f OR -m or -j must be provided when creating a new SKU
-j JSON_FILE, --json_file JSON_FILE
SKU definition from config_db.json file. -f OR -m OR -j must be provided when creating a new SKU
-pp PORT_SPLIT PORT_SPLIT, --port_split PORT_SPLIT PORT_SPLIT
port name and split
-b BASE, --base BASE SKU base definition
-r, --remove Remove SKU folder
-k HWSKU, --hwsku HWSKU
SKU name to be used when creating a new SKU or for L2 configuration mode
-p, --print Print port_config.ini without creating a new SKU
-vv, --verbose Verbose output

)

* Simply remove the check
* Add unit test for consutil show command
* Fix a known typo (found by adding unittest)

Signed-off-by: Jing Kan jika@microsoft.com

…ommands (sonic-net#1214)

admin@sonic:~$ sudo connect line --devicename switch1
Successful connection to line 1
Press ^A ^X to disconnect


admin@sonic:~$ sudo sonic-clear line --devicename switch1
admin@sonic:~$ sudo show line -b
  Line    Baud    PID    Start Time    Device
------  ------  -----  ------------  --------
     1    9600      -             -   switch1

…n task (sonic-net#1209)

…IG wrapper of C++ implementation) in production code (sonic-net#1217)

**- What I did**
This is the following step for merging sonic-py-swsssdk into sonic-swss-common sonic-net/sonic-swss-common#387

**- How I did it**

**- How to verify it**
Unit test and tested in DUT

* Replace swsssdk.SonicV2Connector with swsscommon.SonicV2Connector (SWIG wrapper of C++ implementation) in production code
* Remove extra statement
* Move back the import to original place

…ests/ folder (sonic-net#1222)

Move all files currently in sonic-utilities-tests folder to tests folder of sonic-utilities repository

Co-authored-by: Madhan Babu <madhan@arc-build-server.mtr.labs.mlnx>

Function `is_ipv6_address` and `is_ipv4_address` use `ipaddress` as
function argument, which override the module in global namespace.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>

…n multi ASIC platform (sonic-net#1193)

Modified generate_dump script to run relevant commands on all namespaces for multi ASIC platform. On single ASIC the commands are run in default (host) namesapce.

…ipt (sonic-net#1226)

Remove SKU create pytest output directory before execution of the script

Co-authored-by: Madhan Babu <madhan@arc-build-server.mtr.labs.mlnx>

…et#1127)

- What I did
Updated the CRM show/config commands to handle the multi-ASIC platforms.

- How I did it
The threshold values configured by user is programmed in the CONFIG_DB in all the namespaces. While show/displaying the thresholds, it is retrieved from the database docker in case of single asic, and from the first namespace docker eg: database0 in case of multi-asic platforms.

The crm resources usage details are retrieved from the databases in the respective namespaces and displayed with the additional "ASIC name" as a header.

- How to verify it
Verified on the single and multi-asic devices.

…-net#1225)

* Remove root check for consutil connect
* Add unit tests

Signed-off-by: Jing Kan jika@microsoft.com

…#1145)

* Configure and show for platform chassis_modules

Adding support for below CLI commands
$config plaform chassis_modules admin_down <chassis_module_name>
<instance> <module_type>
$show platform chassis_modules

```
admin@sonic:~$ show chassis-modules status
         Name        Description    Slot    Oper-Status    Admin-Status
-------------  -----------------  ------  -------------  --------------
CONTROL-CARD1           cpm2-ixr      16         Online              up
 FABRIC-CARD1               SFM1      17          Empty              up
 FABRIC-CARD2               SFM2      18          Empty              up
 FABRIC-CARD3               SFM3      19          Empty              up
 FABRIC-CARD4               SFM4      20          Empty              up
 FABRIC-CARD5               SFM5      21         Online              up
 FABRIC-CARD6               SFM6      22          Empty              up
   LINE-CARD1  imm36-400g-qsfpdd       1         Online            down
   LINE-CARD2  imm36-400g-qsfpdd       2         Online              up
   LINE-CARD3          line-card       3          Empty              up
   LINE-CARD4          line-card       4          Empty              up

admin@sonic:~$ show chassis-modules status LINE-CARD1 
         Name        Description    Slot    Oper-Status    Admin-Status
-------------  -----------------  ------  -------------  --------------
  LINE-CARD1  imm36-400g-qsfpdd       1         Online            down
```

…platforms (sonic-net#1203)

When ports are specified as option to 'pfcwd start', port validation fails on multi ASIC platform as the validation logic is executed on each ASIC namespace. Validation for valid ports fails as the port exits in only one namespace and not in others.

Changed logic to perform port validation after collecting ports from all namespaces. If port validation fails there is no config change on other valid ports

Added DB migrator script for removing old copp APP DB entries.

Co-authored-by: dgsudharsan <sudharsan_gopalarat@dell.com>

Add mVRF support and options to CLICK CLI to allow mVRF configuration for sFlow collectors

Signed-off-by: Garrick He <garrick_he@dell.com>

If FEATURE table is not present in CONFIG_DB.

When I issue - "config feature state nat enabled", seeing below errors

root@sonic:/home/admin# config feature state nat enabled
Feature 'nat' doesn't exist
Traceback (most recent call last):
File "/usr/local/bin/config", line 10, in
sys.exit(config())
File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 764, in call
return self.main(*args, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 717, in main
rv = self.invoke(ctx)
File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 1137, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 1137, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 956, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 555, in invoke
return callback(*args, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/click/decorators.py", line 64, in new_func
return ctx.invoke(f, obj, *args, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 555, in invoke
return callback(*args, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/config/feature.py", line 26, in feature_state
sys.exit(1)
NameError: global name 'sys' is not defined
root@sonic:/home/admin#

Fix: Added 'import sys' in feature.py file.

After Fix:
root@sonic:/home/admin# config feature state nat enabled
Feature 'nat' doesn't exist
root@sonic:/home/admin#

Signed-off-by: Akhilesh Samineni akhilesh.samineni@broadcom.com

Signed-off-by: Akhilesh Samineni <akhilesh.samineni@broadcom.com>

Vlan interfaces need capitalized "V" in "Vlan" to be accepted.

…ic-net#1204)

Signed-off-by: Akhilesh Samineni <akhilesh.samineni@broadcom.com>

…ble (sonic-net#1224)

- What I did
Updates to bgp config and show commands with the movement of internal bgp sessions to a new table BGP_INTERNAL_NEIGHBOR table.
With the introduction of BGP_INERNAL_NEIGHBOR table, the user cannot start/stop/remove internal neighbors which I feel is not needed as these internal bgp sessions which are supposed to be UP always.

- How I did it
Updated the show/bgp util so that it gets the internal bgp sessions from BGP_INTERNAL_NEIGHBOR table.
Removed the API's to get the local_as in config/bgp which is not required now.

- How to verify it
Made sure that the output remain same with the new internal bgp neighbor table.

…x shebangs in scripts (sonic-net#1233)

Some tests were trimming the last item from system PATH, but they never appended anything to it, thus these tests were trimming valid entries from the tail of the system path, which in turn caused scripts with shebangs like `#!/usr/bin/env python` to fail, because once `/usr/bin` was removed from PATH, `python` could not be found.

**- How I did it**

- Remove lines which trimmed the last entry from system PATH in the teardown function if nothing was appended to PATH in the setup method.
- Remove shebangs from non-executable Python files
- Fix shebangs which had a space in them
- Replace `#!/usr/bin/python` shebangs with the preferred, more portable `#!/usr/bin/env python` in executable scripts

…ller code will be the same as python2 (sonic-net#1238)

The python2 behavior is not changed.

Conform syntax to support Python 3 using 2to3 tool and manual assessment

The `requests` package is used by a couple modules (config/kube.py and scripts/neighbor_advertiser), but it was not specified as an install-time dependency. Now that the package is built as Python 3, some commands are crashing with `ModuleNotFoundError: No module named 'requests'`.

…into fwutil