Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prebid upgrade 1 36 0 20181227122309 #309

Merged
merged 261 commits into from
Jan 11, 2019

Conversation

pm-shashank-jain
Copy link
Collaborator

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

jaiminpanchal27 and others added 30 commits August 28, 2018 10:43
* initial commit

* updated contact and tag details

* changes ti support the renderers

* changes to pass dimId

* fixed names of internal mapping

* added comment

* added gdpr param to request and other fixes

* modified api url
* replace arrow function in describe calls

* replace arrow function in it calls

* replace arrow function in before, beforeEach, after and afterEach calls

* Merge remote-tracking branch 'upstream/master'

# Conflicts:
#	test/spec/modules/improvedigitalBidAdapter_spec.js
* YieldNexus Bid Adapter v1

* Apply code-review changes requested by @jsneker

Removed redundant decration of 'onTik which does nothing.
Import banner & video constants instead of hard-coding them.
Remove usage of "config.getConfig('pageurl')".

Also updated the "spid" to 1249.

* Remove unused 'config' import

* Update demo account IDs for both banner & video

* Add video renderer support

* Fix unit test checking url

* Fix code linting errors

* Add missing import statement
* adding DMX

test @97%, two files added one updated

* Update districtm_spec.js

* Update districtmDMX.js

* adding all districtm needed file

* remove legacy file

* remove typo || 0 in the test method

* force default to return a valid width and height

* update unit test code for failing test

* changed class for an object

* remove package-lock.json

* change file name for dmx adapter

* renamed files

* restaure package-lock.json

* update to last package-lock state

* update gdpr user consent

* fix sizes issue

* Documentation updates

Adding the readme.md info

* update file name and update unit testing import file location
* upgrade to gulp 4

* update circleci config

* removed some tasks and added notest flag

* update lint dependency for test task
New zone and slot Ids were created for Prebid testing
* Fix creativeId field in bid response 

We had an issue whereby prebid wasn't passing us yieldmo bids even though we could see them in the network requests. Turned out that the `creativeId` field was being set to `undefined` because the response body from the yieldmo server uses snake case, not camel case. Tested the proposed fix and saw prebid log the bid as expected.

* Fix test
* added UserSync

* added UserSync Unit Test
* Changes on AdSize + gdpr

- Primary adsize is now the prebid slot adsize
- On bidder.params you can now overwrite the prebid slot size (Not primary size anymore)
- gdpr string will be only attached if "gdprApplies=true"

* Update yieldlabBidAdapter.js
…ion (prebid#3051)

* Fixed default values in bidResponse and added changes to the description

* Added unit test for default cpm and netRevenue, removed placementId from tests and description
)

* updates per previous discussion

* updates per review
* Added static consentData to consentManagement config

* Added test for static cmpApi

* logError instead of logInfo
* Add dgads adapter

* Add dgads adapter

* Add spec file for dgads

* Add spec file for dgads

* Add dgads bid adapter

* Add dgads bid adapter

* fix

* fix

* fix email

* remove  semi-colon

* Add mediaType native

* Add import medaTypes

* Change method to 'GET' and Change parameter name and Add get cookie.

* fix camelcase

* fix space

* revert to normal function
…rebid#3062)

* Fix prebid#3059 by returning both hb_deal and hb_deal_${bidder_code}

* Add unit test per @mkendall07
* Add Piximedia adapter

* Fix piximediaBidAdapter_spec.js style
* Media.net bid adapter: firing logs on 'bidWon' and 'onTimeout' events

* Media.net Bid Adapter: removed use of prebid global to save page meta data
* Fix the secure creative resize

* do not use template litterals
…ued server-side (prebid#3068)

* Add AOL defaults for currency and creative ID until fix issued server-side

* Satisfy linter single quotes
* done cb cleanup

* rename some vars

* added unit tests, updates after changes requested

* add deprecated notice to function
* add referere detection module

* dont log all errors on console

* Update message

* Add jsdoc
jsnellbaker and others added 29 commits December 4, 2018 15:04
…bid#3349)

removing out console.log statements in ozoneBidAdapter test file
* Bidfluence Adapter update

Support single call to server for all bids

* Bidfluence Adapter update

Support single call to server for all bids - relative to adapter update
* conditionally adds another param to browserParams

* fixes lint error
* update unit test example to mocha recommendations

* fix formatting
* Added Supply2 Bid Adapter with spec file

* Supply2BidAdapter: fix typo
* changes to not show dctr message when none of the adunits have dctr set

* added usage description for dctr and currency params
* Add user sync pixel logic in Adtelligent adapter

* Add gdpr support

* Add gdpr support

* Update tests
* updating appnexus debug auction to be cookie-only

* adding getCookie to utils

* remove LGTM alert on getCookie

* fix failed tests
* Create collectcentBidAdapter.js

New bider adapter for collectcent

* Create collectcentBidAdapter.md

Description and integration example

* Create collectcentBidAdapter_spec.js

Collectcent bidder adapter tests added

* Update collectcentBidAdapter_spec.js

edit

* Update collectcentBidAdapter.js

Used bidderRequest.refererInfo.referer instead of window.location

* Update collectcentBidAdapter.js

* Update collectcentBidAdapter.js

Rename URL to URL_MULTI
* fix indent

* add handling iframe user sync
Prebid upgarde automate- test pull request created through git api please ignore it
@pm-shashank-jain pm-shashank-jain merged commit dc07bdc into nightly Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.