Get our master up to date #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* initial commit - add filterSettings config option for userSync * remove commented code * refactored filterSettings logic, added filter default and changed bidders wildcard * update logic to support all config type
…le in bidrequest sizes array (#2716)
…on (#2562) * Allow user to override which gpt slots should be targeted at invocation time * Added filter example
* Fyber Bid Adapter * Jenkins build file * Updates based on PR - #2709 * Removing test Jenkinsfile
- Added GDPR consent management support - Description updated
* move generation of transactionIds to requestBids over addAdUnits * remove transactionId generation for arrays as well * move transactionId check in tests * remove errant debugger statement
* bugfix: separate ajax for client side and s2s requests * Fix lint error
* update some unit tests to clean-up gdpr module hooks * add cleanup for pubCommonId requestBids hook
* new debugging functionality with bid overrides * update name from bidderOverrides to debugging * change sessionStorage to window.sessionStorage * solve sinon stubbing sessionStorage issue with dependency injection
* initial attempt at limiting concurrenet auctions by origin * fix queueing of auctions for max origin * don't decrement on timeout as it is already called by onreadystatechange * move auction timer so it doesn't start until queued auction starts * set default max concurrent origin requests to 4 and make configurable * fix tests to not queue for auction.callBids * change MAX_REQUEST_PER_ORIGIN to local var
* allow s2s adapters call pbs without client adapter file * add support in aliasBidAdapter for s2s-only bidders
* Add GDPR support for Quantcast adapter * Fix lint error
* ixBidAdapter.js: allow siteId param to be number In v0.x, the siteID param would be string or number. Somehow, this was restricted to just a string in v1.x. * ixBidAdapter.js logical error (not enough coffee) * ixBidAdapter_spec.js: allow number for backwards compat
Remove deprecated pbv param
* update ios browsers * removing ios browsers
* Add colombia adapter * Add https in the url * update files * add test cases and update md file * remove native from package.json and update colombia test cases
* add: Documentation of RDN BidAdapter * fix: inside documentation of Placement ID item area * add: RDN bid adapter * fix: modify ENDPOINT constant name * add: rdnBidAdapter_spec(work in progress) * add: interpretResponse unit test * fix: adUnits format * fix: adSpotId key * fix: interpretResponse process * fix: nobid response spec * fix: cpm value * change param key * Added UID sync correspondence. Expand the response SyncURL as a beacon. Delete language acquisition deplecated method. * Bid end point changed to destination. * test code url fixed * Corrected items pointed out · Extra definition deletion · Remove unnecessary processing * Added test code of getUserSyncs. * test parameter fixed.
* check gdpr in buildRequest * User sync based on whether gdpr applies or not * check if consent data exists during user sync * split user sync into further branches: 1) when gdpr does not apply 2) when consent data is unavailable * contribute viewability to ttxRequest * update tests * remove window mock from tests * use local variables * introduce ServerRequestBuilder * add withOptions() method to ServerRequestBuilder * add semicolons * sync up package-lock.json with upstream/master * stub window.top in tests * introduce getTopWindowSize() for test purpose * reformat code * add withSite() method to TtxRequestBuilder add withSite() method to TtxRequestBuilder * add isIframe() and _isViewabilityMeasurable() * handle NON_MEASURABLE viewability in nested iframes * consider page visibility, stub utils functions getWindowTop() and getWindowSelf() * contribute viewability as 0 for inactive tab
* add stickyadsTV bidder adapter * init unit test file * ad some unit tests * fix unit test on ad format with parameters * add some unit tests * add unit tests on getBid method * add some test cases in unit tests * minor fix on component id tag. * remove adapters-sticky.json test file * use top most accessible window instead of window.top * Pass in the bid request in the createBid call. * use top most accessible window instead of window.top * add unit tests * update unit tests * fix unit test. * fix CI build * add alias freewheel-ssp * update unit tests on bidderCode value * fix component id values and add unit tests * allws to use any outstream format. * fix ASLoader on futur outstream format versions * minor: fix code format. * update unit tests * minor fix code format * minor: add missing new line at eof * replace StickyAdsTVAdapter by freewheel ssp bd adapter (for prebid 1.0) * remove old stickyadstv unittest spec. * fix server response parsing if sent as object with 'body' field * use the vastXml field for video mediatype * add user sync pixel in freewheel ssp adapter * remove all console log calls (replaced using util helper) * remove useless bidderCode (automatically added by the bidderFactory) * Return the SYNC pixel to be added in the page by Prebid.js * remove instance level properties to enable concurrent bids with the same adapter instance. * fix the request apss through and corresponding unit tests * fix 'freeheelssp' typo * add vast parameters feature and GDPR params in VAST request * fix lint issues * add gdpr parameter support on freewheelSSPBidAdapter * use bidderrequest to read gdpr parameters and update unit tests * fix lint errors * fix lint errors * fix typo and bidderRequest reference. * fix bidderRequest reference. * add missing declaration for 'key' variable * rename frewheel ssp bid adapter files to match the bidder code (fix custom download issues) * update unit tests using the new name freewheel-ssp * update documented test zone to a more recent one * target created div insitead of original placement (avoid some misplaced ad) * fix target div size * add key and timestamp parameters for a better request identification. * Remove the arrow function call so the style is consistent throughout the file
* Switched to native Prebid user syncs support. * Removed bid CPM adjustment warning to prevent using globals.
* adds jcsi param * adds try catch
* Initial revision of adocean bid adapter (ADOCEAN-13634, ADOCEAN-13635) * Minor fixes * new demo placement * formating after lint * move request parameters to params * adocean adpater tests * minor fixes * added ttl, netRevenue nad creativeId. merged with upstream * GDPR support * do not send empty gdpr_consent * GDPR support * do not send empty gdpr_consent * AdOcean adapter: tests for gdpr_support * remove old comment * Added possibility to use multiple times same ad placement * Tests for placement duplication and gdpr support. * formating
* Trafficroots bid adapter submission. Thank you! * unit test * typo fix
* adding account_id to s2s bidder-sync request * changed param name from account_id to account
* bug fix for Prebid issue 3111 * adding try-catch around the fix * added a warning on exception handling * updated the message * using util.deepClone * changed variable name from original_bid to originalBid * unit test case for checking original object modification
* encoding ref param in sbi.js * fixed unit tests * template stringed creative * fixed unit test checking ref param * add some missing colons
* add playback method to video targeting * bump adapter version * add maxduration to video targeting
StefanWallin
pushed a commit
that referenced
this pull request
Sep 28, 2018
* PET-239 IAS bid adapter multiple slot fix (#1) * PET-239 Fix. Performs the request for multiple slots on 1 call. * PET-239 Fixed Prebid tests * PET-239 Additional unit tests * Fixed errors for PR 2653 (#2) * Pet 239 ias bid adapter bug fix for multiple slots (#3) * Fixed errors for PR 2653 * Removed unnecessary block from iasBidAdapter from the comments in pull 2653
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.