Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR addressing Issue #150 #184

Merged
merged 40 commits into from
Dec 13, 2022
Merged

PR addressing Issue #150 #184

merged 40 commits into from
Dec 13, 2022

Commits on Mar 9, 2022

  1. Fix for Issue #150

    Max-Bladen committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    6c3f988 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2022

  1. Added test-plotArrow.R

    The file allows for testing of the `plotArrow()` function. Two included tests check for general functionality on DIABLO objects as well as inability to function on `(mint).(s)plsda` objects
    Max-Bladen committed Mar 13, 2022
    Configuration menu
    Copy the full SHA
    681895a View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2022

  1. Configuration menu
    Copy the full SHA
    dd98c6e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1d2d37c View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2022

  1. Configuration menu
    Copy the full SHA
    81d0cd7 View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'bioc/master'

    $MAINTAINER_NAME authored and $MAINTAINER_NAME committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    dd72bd5 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2022

  1. Fix for Issue #237 (#238)

    fix: `plotVar()` can now utilise `block.pls` and `block.spls` objects which have a single Y feature (ie. (s)PLS1)
    Max-Bladen authored Sep 15, 2022
    Configuration menu
    Copy the full SHA
    41d0ac4 View commit details
    Browse the repository at this point in the history
  2. Fix for Issue #192 (#194)

    fix: predict function has updated error messages for when feature sets are different or in different order
    Max-Bladen authored Sep 15, 2022
    Configuration menu
    Copy the full SHA
    2a828e3 View commit details
    Browse the repository at this point in the history
  3. Fix to issue #182 (#183)

    refactor: cleaned output of `test_that` tests to increase ease of debugging
    Max-Bladen authored Sep 15, 2022
    Configuration menu
    Copy the full SHA
    cf4f6a5 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2022

  1. Fix for Issue #196 (#197)

    fix: resolved issue preventing `perf()` from properly accounting for near-zero-variance features
    Max-Bladen authored Sep 19, 2022
    Configuration menu
    Copy the full SHA
    34025c5 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2022

  1. Enhancement for #145 (#201)

    feat: added `plot.graph` parameter to network to allow user control over whether to plot the network or just return the output. Either way, the returned object is the same
    Max-Bladen authored Sep 22, 2022
    Configuration menu
    Copy the full SHA
    4940737 View commit details
    Browse the repository at this point in the history
  2. Fix for Issue #213 (#215)

    fix: if `validation = "loo"` in `tune.block.splsda()`, the parameter `n` would not be set. moved the lines which define `n` to outside of the  `if(validation= "Mfold")` statement so its run in all cases. Additionally, increased the specificity of some warnings and errors in this function
    Max-Bladen authored Sep 22, 2022
    Configuration menu
    Copy the full SHA
    f3027e2 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2022

  1. Fix for Issue #189 (#190)

    refactor: removed depreciated `plot.tune.splsda()`. Reduces package clutter and document repetition
    Max-Bladen authored Sep 26, 2022
    Configuration menu
    Copy the full SHA
    970e8a9 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2022

  1. Fix for Issue #252 (#253)

    tests: increased suffix length in `plotLoadings()` label-length check
    Max-Bladen authored Oct 6, 2022
    Configuration menu
    Copy the full SHA
    0dbf928 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2022

  1. Test commit

    test commit
    Max-Bladen committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    45f3c77 View commit details
    Browse the repository at this point in the history
  2. test

    test
    Max-Bladen committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    10abbc6 View commit details
    Browse the repository at this point in the history
  3. increment version

    Max-Bladen committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    431163e View commit details
    Browse the repository at this point in the history
  4. Update DESCRIPTION

    Max-Bladen committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    f1487cd View commit details
    Browse the repository at this point in the history
  5. revert test changes

    Max-Bladen committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    17c6472 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2022

  1. Fix for issue #262 (#263)

    * Attempted fix for issue #262
    
    fix: adjusting action `setup-r` version call to `v2` rather than `master`
    
    * Attempted fix for Issue #262
    
    fix: adjusting another action `setup-r` version call to `v2` rather than `master`
    Max-Bladen authored Nov 14, 2022
    Configuration menu
    Copy the full SHA
    7a5464e View commit details
    Browse the repository at this point in the history
  2. Fix for Issue #264 (#265)

    * Fix for Issue #264
    
    fix: updating `set-output` commands in `Get R/Bioc versions` action
    Max-Bladen authored Nov 14, 2022
    Configuration menu
    Copy the full SHA
    b79fe51 View commit details
    Browse the repository at this point in the history
  3. Enhancement for Issue #260 (#261)

    * Enhancement for Issue #260
    
    feat: added 'legend.title' parameter (takes a string) for `circosPlot()`. Allows for control over legend title
    
    * Enhancement for Issue #260
    
    docs: updated documentatation with `legend.title` parameter
    Max-Bladen authored Nov 14, 2022
    Configuration menu
    Copy the full SHA
    580b82e View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2022

  1. Fix for Issue #266 (#267)

    * Fix for Issue #266
    
    fix: added fail safe for when `Inf` or `-Inf` are found in transformed `newdata` data frame.
    
    Changes them to `NaN` which can be safely handled by downstream functions
    
    * Fix for Issue #266
    
    tests: added test to maintain coverage
    Max-Bladen authored Nov 15, 2022
    Configuration menu
    Copy the full SHA
    7252d3b View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2022

  1. Fix for Issue #268 (#269)

    fix: improved nzv feature handling for block contexts, particularly via `auroc()`
    
    Filtration applied more consistently via `Check.entry.wrapper.mint.block()` . Additional failsafe added here for zero variance features. `predict()` also now checks to see if filtration has been applied to prevent it applying filtering twice.
    
    
    tests: adjusted new test to ensure it passes
    Max-Bladen authored Nov 17, 2022
    Configuration menu
    Copy the full SHA
    3869fb0 View commit details
    Browse the repository at this point in the history
  2. Increment Version

    Max-Bladen committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    89fe810 View commit details
    Browse the repository at this point in the history
  3. Increment Version

    Max-Bladen committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    9f4479c View commit details
    Browse the repository at this point in the history
  4. Adjust version

    Max-Bladen committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    eb20647 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2022

  1. Fix for Issue #270 (#271)

    fix: changed the depreciated `size` parameter to `linewidth` and changed `aes_string()` to `aes()`
    
    fix: additional `aes_string()` call changed to `aes()`
    
    fix: changing `aes_string()` to `aes()` introduced error. Adjusted `geom_path` calls so X and Y vectors are appropriately set
    
    refactor: removed some commented lines
    
    tests: added test for `plotIndiv.mint.plsda()` with `ellipse = TRUE`
    Max-Bladen authored Nov 22, 2022
    Configuration menu
    Copy the full SHA
    7427868 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2022

  1. Updated authors

    docs: added my name to author list and updated maintainer
    Max-Bladen committed Nov 27, 2022
    Configuration menu
    Copy the full SHA
    13e5804 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2022

  1. PR addressing Issue #275 (#276)

    refactor: adjusted order of processes to increase efficiency in `repeat_cv_j()` within `tune.spca()`
    
    enhance: added safety catch for NAs provided to `tune.spca()`. It replaces NAs with 0 and notifies user of the change
    
    test: added new test file for `tune.spca()`
    Max-Bladen authored Dec 6, 2022
    Configuration menu
    Copy the full SHA
    bae5bb5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8e69634 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'dev-tools'

    Max-Bladen committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    3f550a8 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2022

  1. Configuration menu
    Copy the full SHA
    6530fdc View commit details
    Browse the repository at this point in the history
  2. PR addressing Issue #172 (#177)

    `perf()` now only runs T-test when `nrepeat` >= 3. Notifies user on unreliable results if `nrepeat` < 3. New `test` file for `perf()` functions to maintain coverage
    Max-Bladen authored Dec 8, 2022
    Configuration menu
    Copy the full SHA
    8cf27e0 View commit details
    Browse the repository at this point in the history
  3. PR addressing Issue #43 (#191)

    Homogenised way in which `tune.mint.splsda()` and `perf.mint.splsda()` calculate BER, such that now both use weighted average of BER across studies. Added unit tests to ensure this homogenity
    Max-Bladen authored Dec 8, 2022
    Configuration menu
    Copy the full SHA
    5b1c57a View commit details
    Browse the repository at this point in the history
  4. Fix for Issue #277

    test: removed some `expect_equal()` states from `test-tune.spca()` as they were producing inconsistent values locally vs via GitHub Actions
    Max-Bladen committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    7de79f8 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2022

  1. PR addressing Issue #280 (#281)

    build: added explicit global definition for `setNames()`. Resolves NOTE in R-CMD-Check
    
    build: removed `middle` parameter from Al Abadi's reference in DESCRIPTION
    Max-Bladen authored Dec 13, 2022
    Configuration menu
    Copy the full SHA
    1820bef View commit details
    Browse the repository at this point in the history
  2. Fix for Issue #150

    Max-Bladen committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    756ff5e View commit details
    Browse the repository at this point in the history
  3. Added test-plotArrow.R

    The file allows for testing of the `plotArrow()` function. Two included tests check for general functionality on DIABLO objects as well as inability to function on `(mint).(s)plsda` objects
    Max-Bladen committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    c9732f1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    fc43d6b View commit details
    Browse the repository at this point in the history