Update #1
Merged
Update #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adds jcsi param * adds try catch
* Initial revision of adocean bid adapter (ADOCEAN-13634, ADOCEAN-13635) * Minor fixes * new demo placement * formating after lint * move request parameters to params * adocean adpater tests * minor fixes * added ttl, netRevenue nad creativeId. merged with upstream * GDPR support * do not send empty gdpr_consent * GDPR support * do not send empty gdpr_consent * AdOcean adapter: tests for gdpr_support * remove old comment * Added possibility to use multiple times same ad placement * Tests for placement duplication and gdpr support. * formating
* Trafficroots bid adapter submission. Thank you! * unit test * typo fix
* adding account_id to s2s bidder-sync request * changed param name from account_id to account
* bug fix for Prebid issue 3111 * adding try-catch around the fix * added a warning on exception handling * updated the message * using util.deepClone * changed variable name from original_bid to originalBid * unit test case for checking original object modification
* encoding ref param in sbi.js * fixed unit tests * template stringed creative * fixed unit test checking ref param * add some missing colons
* add playback method to video targeting * bump adapter version * add maxduration to video targeting
…er (#3131) * passing new copy of adUnits object to every adapter * add test to verify bidders can't mutate eachothers bid requests
* initial commit * updated contact and tag details * changes ti support the renderers * changes to pass dimId * fixed names of internal mapping * added comment * added gdpr param to request and other fixes * modified api url * fix * fixed the secure api call * rolled back video event callback till we support it
* add stickyadsTV bidder adapter * init unit test file * ad some unit tests * fix unit test on ad format with parameters * add some unit tests * add unit tests on getBid method * add some test cases in unit tests * minor fix on component id tag. * remove adapters-sticky.json test file * use top most accessible window instead of window.top * Pass in the bid request in the createBid call. * use top most accessible window instead of window.top * add unit tests * update unit tests * fix unit test. * fix CI build * add alias freewheel-ssp * update unit tests on bidderCode value * fix component id values and add unit tests * allws to use any outstream format. * fix ASLoader on futur outstream format versions * minor: fix code format. * update unit tests * minor fix code format * minor: add missing new line at eof * replace StickyAdsTVAdapter by freewheel ssp bd adapter (for prebid 1.0) * remove old stickyadstv unittest spec. * fix server response parsing if sent as object with 'body' field * use the vastXml field for video mediatype * add user sync pixel in freewheel ssp adapter * remove all console log calls (replaced using util helper) * remove useless bidderCode (automatically added by the bidderFactory) * Return the SYNC pixel to be added in the page by Prebid.js * remove instance level properties to enable concurrent bids with the same adapter instance. * fix the request apss through and corresponding unit tests * fix 'freeheelssp' typo * add vast parameters feature and GDPR params in VAST request * fix lint issues * add gdpr parameter support on freewheelSSPBidAdapter * use bidderrequest to read gdpr parameters and update unit tests * fix lint errors * fix lint errors * fix typo and bidderRequest reference. * fix bidderRequest reference. * add missing declaration for 'key' variable * rename frewheel ssp bid adapter files to match the bidder code (fix custom download issues) * update unit tests using the new name freewheel-ssp * update documented test zone to a more recent one * target created div insitead of original placement (avoid some misplaced ad) * fix target div size * add key and timestamp parameters for a better request identification. * Remove the arrow function call so the style is consistent throughout the file * update position configuration for freewheel-sspBidAdapter * add unit tests for the new display case
…#3087) * DecodeUrl if url is encoded Appnexus new module is passing the encoded url and sometimes Publisher are passing encoded url in the referrer parameter. This fix is a protection in case a module is update and start passing encode url. Our AE is not decoding and from some test I did, monetisation could be highly impacted. * Update rubiconBidAdapter.js * Update rubiconBidAdapter_spec.js * Update rubiconBidAdapter_spec.js * Update rubiconBidAdapter_spec.js * Update rubiconBidAdapter_spec.js * Update rubiconBidAdapter_spec.js * Update rubiconBidAdapter_spec.js * Update rubiconBidAdapter.js * Update rubiconBidAdapter.js * Update rubiconBidAdapter_spec.js * Update rubiconBidAdapter.js * Update rubiconBidAdapter_spec.js * Update rubiconBidAdapter_spec.js
* Add: rxrtb prebidAdapter * Update: params for test * Update: code format * Update: code format * Update: code format * Fix param check * Update rxrtbBidAdapter.js * Remove required source param * Update and rename rxrtbBidAdapter.js to rexrtbBidAdapter.js * Update and rename rxrtbBidAdapter.md to rexrtbBidAdapter.md * Update and rename rxrtbBidAdapter_spec.js to rexrtbBidAdapter_spec.js * Revert "Update rxrtbBidAdapter.js" This reverts commit 09bca02. * Revert "Update and rename rxrtbBidAdapter_spec.js to rexrtbBidAdapter_spec.js" This reverts commit 2481c58. * Revert "Update and rename rxrtbBidAdapter.md to rexrtbBidAdapter.md" This reverts commit af9a491. * Revert "Update and rename rxrtbBidAdapter.js to rexrtbBidAdapter.js" This reverts commit 81a17ad. * Revert "Remove required source param" This reverts commit 38b273d. * Revert "Update rxrtbBidAdapter.js" * Update and rename rexrtbPrebid
* Add ADSpend bidder adapter * Remove superfluous argument and fix bug with sizes * Change bidder aliases * Replace fetch with ajax from src/ajax.js * Store win event URL in memory, not in cookie * Use getConfig(...) instead of nested access * Add sending multiple impressions to bidder
* Add Adagio bidder and analytics adapters * Adagio - removed the superfluous argument passed to `_getDevice()` * Adagio - IE11 fix - replaced Array.prototype.find by its core-js equivalent * Adagio - linting. * Adagio - Renamed the property 'gdpr_consent' to 'gdpr' in our adRequest. * Adagio - Send one HTTP request per siteId - add the suffix `Id` to most params - add `dealId` and `timeout` to the payload of the analytics adapter - move `siteId` at the top-level of the ad request - remov the param `Publisher` * Removed the analytics adapters, they are not ready from prime time. * Removed the analytics adapter, it's not ready from prime time. * Added adagioAnalyticsAdapter as a 'bundle'.
* make sizeMapping mediaTypes aware * no sizeMapping if the only mediaType is not banner * better logging for size mapping and no auction when no bids * fix size mapping tests to ignore filter results (which are only for logging)
* moved NATIVE_KEYS to constants * Changed TARGETING_KEYS from array to an array - Now you can change key names - Made changes in code at auction.js and targeting.js to handle the TARGETING_KEYS object than array * fixed aauctionmanager test cases for dynamic targeting key names * fixed native test cases for dynamic targeting key names * fixed test cases of targeting for dynamic targeting key names * in-dev changes * replace old keys with new keys * fixed a typo * fixed a unit case in utils * updated convertTargetingsFromOldToNew in fixtures this will now replace partner specific keys as well as per config * removed a log * keep test case as it was * improved convertTargetingsFromOldToNew in fixtures * Capitalized key names in TARGETING_KEYS object; not values in object * using computed properties * using computed properties * fixed eslint suggestion * fixed eslint suggestions * keeping unit tests more compliant with Mocha
…eturned (#3136) * corrected user sync type * add alias pxyz add version to endpoint add validation for 204 bid response * add validation with serverResponse is undefined fix test for 204 (no bid response) * remove package lock * restore package-lock
* Add teads bidder adapter * Remove bidder code & tests arrow functions
…#3165) * rubiconBidAdapter - Checking FPD values are defined before toString() - Added two tests for this behavior * Removing unused variable * changed to compare against null added some null params to the tests to verify
…ct parse Size method correct. (#3166)
* in-dev changes
* included config
* Unit test cases for DigitrustId passing in PubMatic bid adapter
* eslint fixes
* removed a comment
* replaced "() => {" with "() => {"
circleci is still failing, but I cannot find a workaround for this PR at the moment
…3167) * Update rubiconBidAdapter.js
* adds openxoutstreamadapter files * cleans up url, adds bidder config and version, removes unused code * updates template ad response * remove final unused custom param code * add openrtb to list of params again. * add payload back so we can read bidId * extra checks for cpm (pub_rev) * adds unit tests * adds unit tests * update md page * undo openx adapter space changes from autosave * undo openx adapter space changes from autosave * test cleanup * test cleanup * update md file * update example page params * remove sneaky console.log * return false * adds yieldmo to the md. remove useless docEl assignment * remove useless docEl assignments * move crid and adid to constants * fix test * remove another useless variable assignment caught by LGTM * changes CR_ID. moves tdoc to within if scope * updates crid on test * use more constants and use crid for lfid * remove superfluous trailing argument * adds viewport meta tag to header. removes unnecessary string interpolation. * move ad_id to a string * undo changes for pacakge-lock * fixes lfid to lfId, pID to pId * fixes lfid to lfId, pID to pId * remove rti:1 * adds openx maintainer email
* removing cookieSet * removing blank line * not including src/cookie anymore
* Adding GDPR support * Always drop user syncs when available * Set dealID based on buying type
* add stub for adloader in various adapter test files * remove unneeded commented line of code
* stub adloader across the board to prevent requests going out * add the adloader stub
* add adapter and doc * add test * fix adapter * fix adapter * fix adapter * correct code after tests * fix tests * fix adapter and test * fix buildQueryString and tests * fix cpm devisor * fix cpm devisor test * fix doc * fix tests * add adapter and doc * add test * fix adapter * fix adapter * fix adapter * correct code after tests * fix tests * fix adapter and test * fix buildQueryString and tests * fix cpm devisor * fix cpm devisor test * fix doc * fix tests * change referer source and remove userSync
* send request to endpoint * tests * improve tests * Add description. Small fix * add maintainer email * restore origin package.json * add getUserSyncs function * remove userSyncs * change endpoint_url params * change test params * change netRevenue to false
* Refactor rtbhouseBidAdapter and spec * Add native support to RTB House adapter
* initial commit * updated contact and tag details * changes ti support the renderers * changes to pass dimId * fixed names of internal mapping * added comment * added gdpr param to request and other fixes * modified api url * fix * fixed the secure api call * rolled back video event callback till we support it * updated doc with video details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.