[Fix-3.0](iot) Avoid coredump because of NullPointerException #55597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the previo… (apache#54008) …us queryId when parseSQL fails. (apache#53107) pick: apache#53107
…e#53842 (apache#53880) Cherry-picked from apache#53842 Co-authored-by: XueYuhai <382297540@qq.com>
apache#54037) ### What problem does this PR solve? As title. Branch master do not have this problem
…order (apache#54024) (apache#54072) (apache#54109) ### What problem does this PR solve? cherry-pick: apache#54024 apache#54072
…e#54103) ### What problem does this PR solve? Fix missing logic 1. https://github.com/apache/doris/pull/46221/files fix rename 2. but when developing vcg logic, missing pr 46221 functionality 3. pick form vcg branch, so miss 46221 logic,
apache#54073) …scheduling time errors apache#51647 (apache#51687)" This reverts commit 75d29d8.
…ons (apache#53855) …53660) apache#53660 my_double_round did not handle NaN values correctly. For example, when dec is very large and value is 0, there will be a case of 0 * inf, resulting in a NaN value. do_format_round assumes the input is always a valid double value, which causes a core dump when a NaN is passed in. Additionally, (value.size() - (is_positive ? (decimal_places + 2) : (decimal_places + 3))) / 3; This code does not account for the situation where value.size() is 0. Currently, a custom add_thousands_separator function is implemented. If the fmt library is upgraded in the future, we should use fmt to add thousands separators. ### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
…dy exists issue apache#54031 (apache#54168) Cherry-picked from apache#54031 Co-authored-by: camby <104178625@qq.com>
… sc job on failure apache#53952 (apache#54064) Cherry-picked from apache#53952 Co-authored-by: Siyang Tang <tangsiyang@selectdb.com>
…#54171) Cherry-picked from apache#54129 Co-authored-by: yiguolei <guolei@selectdb.com>
…ache#53925 (apache#53953) Cherry-picked from apache#53925 Co-authored-by: Gavin Chou <gavin@selectdb.com>
…ing apache#53984 (apache#54162) Cherry-picked from apache#53984 Co-authored-by: abmdocrt <lianyukang@selectdb.com>
…#54017 (apache#54047) Cherry-picked from apache#54017 Co-authored-by: Yongqiang YANG <yangyongqiang@selectdb.com>
…pache#54146) Cherry-picked from apache#54058 Co-authored-by: zy-kkk <zhongyk10@gmail.com>
…#54063 (apache#54203) Cherry-picked from apache#54063 Co-authored-by: Yongqiang YANG <yangyongqiang@selectdb.com>
…he#54092 (apache#54209) Cherry-picked from apache#54092 Co-authored-by: Gavin Chou <gavin@selectdb.com>
…kends except for warmup jobs (apache#54131) ### What problem does this PR solve? Problem Summary: Fix logic conflict of apache#52514 and apache#52440 ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
…#54282 (apache#54298) Cherry-picked from apache#54282 Co-authored-by: Yongqiang YANG <yangyongqiang@selectdb.com>
…pache#54327) Cherry-picked from apache#54319 Co-authored-by: Yongqiang YANG <yangyongqiang@selectdb.com>
…index file incorrectly (apache#53876)" (apache#54334) Pick apache#53876 Co-authored-by: Uniqueyou <wangyixuan@selectdb.com>
…#54306) Cherry-picked from apache#54287 Co-authored-by: hui lai <laihui@selectdb.com>
…tion test [f… apache#54360 (apache#54398) Cherry-picked from apache#54360 Co-authored-by: Yongqiang YANG <yangyongqiang@selectdb.com> Co-authored-by: Yongqiang YANG <yangyogqiang@selectdb.com>
(apache#54410) Cherry-picked from apache#54362 Co-authored-by: Yongqiang YANG <yangyongqiang@selectdb.com>
…ache#54403 (apache#54469) Cherry-picked from apache#54403 Co-authored-by: Uniqueyou <wangyixuan@selectdb.com>
…lap table have auto partitions apache#54983 (apache#55028) Cherry-picked from apache#54983 Co-authored-by: 924060929 <lanhuajian@selectdb.com>
…auto_cast for insert value truncate long string apache#55325 (apache#55423) cherry pick from apache#55325
Cherry-picked from apache#55606 Co-authored-by: bobhan1 <baohan@selectdb.com>
… (apache#55452) Cherry-picked from apache#55365 Co-authored-by: Kaijie Chen <chenkaijie@selectdb.com>
…true apache#55109 (apache#55439) Cherry-picked from apache#55109 Co-authored-by: Yongqiang YANG <yangyongqiang@selectdb.com>
… key twice (apache#54137) (apache#54271) ### What problem does this PR solve? Problem Summary: cherry-pick from master (apache#54137) ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
apache#55697) * step1: MS txn lazy commit convert tmp rowsets and make txn visible commit failed due to unexpected fdb error * step2: BE schema change job convert historical data and prepare/commit rowsets with the same txn_id and tablet_id for new tablet rowset meta, tmp rowset key is decided by (txn_id, tablet_id) * step3: MS retry lazy commit will convert tmp rowset which write by schema change job ### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [x] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
…le with oss-hdfs (apache#55565) … ### What problem does this PR solve? When inserting into a Hive partitioned table stored on oss-hdfs, the following issue occurs: First insert succeeds: Since the partition does not exist yet, HiveTableSink#setPartitionValues does not set storage-related information for the partition. Subsequent inserts fail: Once the partition exists, the system tries to resolve the partition’s storage information. At this stage, oss-hdfs is incorrectly treated as s3 instead of being recognized as hdfs, leading to insert failure. This PR fixes the storage type handling logic so that oss-hdfs partitions are correctly recognized as hdfs. #### How to Reproduce ``` Step 1: Create a Hive catalog whose storage is configured to use oss-hdfs. CREATE TABLE hive_partition_table ( `ts` DATETIME COMMENT 'ts', `col1` BOOLEAN COMMENT 'col1', `col2` INT COMMENT 'col2', `col3` BIGINT COMMENT 'col3', `col4` FLOAT COMMENT 'col4', `col5` DOUBLE COMMENT 'col5', `col6` DECIMAL(9,4) COMMENT 'col6', `col7` STRING COMMENT 'col7', `col8` DATE COMMENT 'col8', `col9` DATETIME COMMENT 'col9', `pt1` STRING COMMENT 'pt1', `pt2` STRING COMMENT 'pt2' ) PARTITION BY LIST (day(ts), pt1, pt2) () PROPERTIES ( 'write-format'='orc', 'compression-codec'='zlib' ); -- First insert (works fine) INSERT INTO hive_partition_table VALUES ('2023-01-01 00:00:00', true, 1, 1, 1.0, 1.0, 1.0000, '1', '2023-01-01', '2023-01-01 00:00:00', 'a', '1'), ('2023-01-02 00:00:00', false, 2, 2, 2.0, 2.0, 2.0000, '2', '2023-01-02', '2023-01-02 00:00:00', 'b', '2'), ('2023-01-03 00:00:00', true, 3, 3, 3.0, 3.0, 3.0000, '3', '2023-01-03', '2023-01-03 00:00:00', 'c', '3'); -- Second insert (fails) INSERT INTO hive_partition_table VALUES ('2023-01-01 00:00:00', true, 1, 1, 1.0, 1.0, 1.0000, '1', '2023-01-01', '2023-01-01 00:00:00', 'a', '1'), ('2023-01-02 00:00:00', false, 2, 2, 2.0, 2.0, 2.0000, '2', '2023-01-02', '2023-01-02 00:00:00', 'b', '2'), ('2023-01-03 00:00:00', true, 3, 3, 3.0, 3.0, 3.0000, '3', '2023-01-03', '2023-01-03 00:00:00', 'c', '3'); Error message on the second insert: [INVALID_ARGUMENT] Invalid S3 URI: oss://emr-ssss-oss.cn-beijing.oss-dls.aliyuncs.com/tmp/.sss/root/4118a835d5d948f8adc34107230c9b9b/pt1=a/pt2=1/727bd17a7b9541db-8f4bb2fbfda35b86_6ec0a4b4-cacc-4dd3-b3fc-b130cadcd508-0.zlib.orc ``` ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
…r can not access. apache#55256 (apache#55559) Cherry-picked from apache#55256 Co-authored-by: daidai <changyuwei@selectdb.com>
…during commit txn apache#55340 (apache#55715) cherry pick from apache#55340
…nconcurrent apache#52004 (apache#55707) Cherry-picked from apache#52004 Co-authored-by: lihangyu <lihangyu@selectdb.com>
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
|
run buildall |
TPC-H: Total hot run time: 39639 ms |
TPC-DS: Total hot run time: 192207 ms |
ClickBench: Total hot run time: 29.75 s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avoid coredump like: