[Fix] no-invalid-html-attribute: convert autofix to suggestion

[himanshu007-creator]

Fixes : #3458

[ljharb]

This seems pretty reasonable - with test changes, and the appropriate descriptions, this should be good to go

[ljharb]

Looks good! Let's update the tests and get this landed :-)

[ljharb]

@himanshu007-creator any test updates? there's a bunch of failing tests :-)

[himanshu007-creator]

Hi @ljharb , i would require some help on this

[ljharb]

I think what's needed is that all the test cases that were asserting output - ie, an autofixer - instead need to assert suggestions with NO output.

I'm also seeing a syntax error in the logs, which I'll rereview for.

[ljharb]

ok, i think this will probably get most of them passing

[ljharb]

ok, now the failures are expected :-) all the "output" test cases will need to be updated to not have output, but to have suggestions.

[codecov]

Codecov Report

Merging #3474 (94cf97b) into master (01ab399) will decrease coverage by 3.09%.
The diff coverage is 54.54%.

❗ Current head 94cf97b differs from pull request most recent head a522476. Consider uploading reports for the commit a522476 to get more accurate results

@@            Coverage Diff             @@
##           master    #3474      +/-   ##
==========================================
- Coverage   97.58%   94.48%   -3.10%     
==========================================
  Files         130      129       -1     
  Lines        9218     9189      -29     
  Branches     3341     3333       -8     
==========================================
- Hits         8995     8682     -313     
- Misses        223      507     +284     

Impacted Files	Coverage Δ
lib/rules/no-invalid-html-attribute.js	91.94% <54.54%> (-4.77%)	⬇️
lib/util/propTypes.js	68.21% <0.00%> (-29.22%)	⬇️
lib/util/ast.js	73.19% <0.00%> (-23.20%)	⬇️
lib/rules/hook-use-state.js	89.87% <0.00%> (-10.13%)	⬇️
lib/rules/boolean-prop-naming.js	91.56% <0.00%> (-7.84%)	⬇️
lib/rules/no-unused-state.js	93.12% <0.00%> (-6.11%)	⬇️
lib/rules/jsx-props-no-multi-spaces.js	94.11% <0.00%> (-5.89%)	⬇️
lib/rules/no-unused-prop-types.js	91.83% <0.00%> (-4.09%)	⬇️
lib/rules/jsx-no-constructed-context-values.js	91.34% <0.00%> (-1.93%)	⬇️
lib/rules/require-default-props.js	98.38% <0.00%> (-1.62%)	⬇️
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[ljharb]

Looks better! Seems like for the error cases, each error needs to supply a suggestions array.

[himanshu007-creator]

@ljharb finally tests passed! :)