Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] no-is-mounted: fix logic in method name check #3821

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

Mathias-S
Copy link
Contributor

The last change to no-is-mounted caused the rule to error with any method name, not just with "isMounted".

Fixes #3819

The last change to `no-is-mounted` caused the rule to error with any method name, not just with "isMounted".
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.97%. Comparing base (1df23d2) to head (a09083b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3821      +/-   ##
==========================================
+ Coverage   94.52%   95.97%   +1.44%     
==========================================
  Files         133      136       +3     
  Lines        9916     9929      +13     
  Branches     3676     3677       +1     
==========================================
+ Hits         9373     9529     +156     
+ Misses        543      400     -143     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@ljharb ljharb merged commit a09083b into jsx-eslint:master Sep 12, 2024
342 checks passed
lindboe added a commit to infinitered/ignite that referenced this pull request Sep 12, 2024
They added a bug, there's a fix but it's unreleased: jsx-eslint/eslint-plugin-react#3821
lindboe added a commit to infinitered/ignite that referenced this pull request Sep 12, 2024
…2772)

* Initial change of imports to use a unified alias

* More import updates to fix router app generation

* Lint fix

* Update test

* Fix demo removal for i18n

These lines weren't getting removed in demo and failed tests. Did we not
have a test for removing demo and compiling?

* Need to also transform test setup file

* Lint fix

* Print command output when it fails for easier debugging

* Need to remove App.tsx when using expo-router

* Fix patch removal

I'm confused about this one, it appeared to work and printed
`patches/patch.patch` originally, but now the path isn't including the
directory. So added a new CWD to make sure the file gets deleted,
otherwise bun fails.

* This only applied for the splashscreen changes

...from the test it was copied from

* Add error output to ignite-new test as well

* Remove test output change for now

Potential issue with buffer size. Update to use spawn later so we can
stream output.

* Make sure test doesn't time out

* Pin eslint react plugin version

They added a bug, there's a fix but it's unreleased: jsx-eslint/eslint-plugin-react#3821
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: "Do not use isMounted" linting errors after upgrading to latest eslint-plugin-react (v7.36.0)
3 participants