Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] jsx-curly-brace-presence: do not trigger on strings containing a quote character #3798

Merged
merged 1 commit into from
Aug 9, 2024
Merged

[Fix] jsx-curly-brace-presence: do not trigger on strings containing a quote character #3798

merged 1 commit into from
Aug 9, 2024

Conversation

akulsr0
Copy link
Contributor

@akulsr0 akulsr0 commented Aug 8, 2024 •
edited by ljharb
Loading

Fixes #3795

@ljharb ljharb changed the title [Fix] jsx-curly-brace-presence: doesn't trigger on strings containing a quote character [Fix] jsx-curly-brace-presence: do not trigger on strings containing a quote character Aug 9, 2024
@ljharb ljharb merged commit 10eb235 into jsx-eslint:master Aug 9, 2024
343 checks passed
renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request Sep 3, 2024
@renovate
fix(deps): update dependency eslint-plugin-react to v7.35.1
ad4a432 
##### [v7.35.1](https://github.com/jsx-eslint/eslint-plugin-react/blob/HEAD/CHANGELOG.md#7351---20240902)

##### Fixed

-   \[`jsx-curly-brace-presence`]: do not trigger on strings containing a quote character ([#3798][] [@akulsr0](https://github.com/akulsr0))

[7.35.1]: jsx-eslint/eslint-plugin-react@v7.35.0...v7.35.1

[#3798]: jsx-eslint/eslint-plugin-react#3798
@dennisoelkers
Copy link

dennisoelkers commented Sep 3, 2024 •
edited
Loading

@akulsr0, @ljharb: This PR is introducing a regression for us, it is changing:

help={'The maximum time range for searches. (i.e. "P30D" for 30 days, "PT24H" for 24 hours)'}

to

help="The maximum time range for searches. (i.e. "P30D" for 30 days, "PT24H" for 24 hours)"

which is obviously an incorrect string.

@ljharb
Copy link
Member

ljharb commented Sep 3, 2024

@dennisoelkers you’re right; could you file a new issue for that?

@gabrc52 gabrc52 mentioned this pull request Sep 3, 2024
Merged
@dennisoelkers dennisoelkers mentioned this pull request Sep 3, 2024
Closed
2 tasks
@dennisoelkers
Copy link

@ljharb: There you go: #3814

@Luis-Kristen Luis-Kristen mentioned this pull request Sep 24, 2024
Open
@zdr4k zdr4k mentioned this pull request Sep 24, 2024
Open
@Tanver-Hasan Tanver-Hasan mentioned this pull request Sep 24, 2024
Open
This was referenced Sep 24, 2024
Open
Open
@Balantion2020 Balantion2020 mentioned this pull request Sep 24, 2024
Open
@ManuelDevWeb ManuelDevWeb mentioned this pull request Sep 24, 2024
Open
This was referenced Sep 24, 2024
Open
Open
Open
Open
Open
@patooworld patooworld mentioned this pull request Sep 24, 2024
Open
@scatools-demo scatools-demo mentioned this pull request Sep 24, 2024
Open
@Exkaleburx Exkaleburx mentioned this pull request Sep 25, 2024
Open
@DadonStyle DadonStyle mentioned this pull request Sep 25, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Sep 25, 2024
Open
@Luis-Kristen Luis-Kristen mentioned this pull request Sep 25, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Oct 4, 2024
Open
@scatools-demo scatools-demo mentioned this pull request Oct 4, 2024
Open
This was referenced Oct 4, 2024
Open
Open
@Exkaleburx Exkaleburx mentioned this pull request Oct 4, 2024
Open
@CASABECI CASABECI mentioned this pull request Oct 6, 2024
Open
@scatools-demo scatools-demo mentioned this pull request Oct 6, 2024
Open
@Sarrac3873 Sarrac3873 mentioned this pull request Oct 16, 2024
Open
@zdr4k zdr4k mentioned this pull request Oct 20, 2024
Open
This was referenced Oct 22, 2024
Open
Open
Open
@Loonz206 Loonz206 mentioned this pull request Oct 23, 2024
Open
This was referenced Oct 23, 2024
Open
Open
Open
@ManuelDevWeb ManuelDevWeb mentioned this pull request Oct 25, 2024
Open
@Exkaleburx Exkaleburx mentioned this pull request Oct 26, 2024
Open
@richyhoopd richyhoopd mentioned this pull request Oct 26, 2024
Open
@scatools-demo scatools-demo mentioned this pull request Oct 26, 2024
Open
@ManuelDevWeb ManuelDevWeb mentioned this pull request Oct 26, 2024
Open
@Vishesh7797 Vishesh7797 mentioned this pull request Oct 27, 2024
Open
@Exkaleburx Exkaleburx mentioned this pull request Oct 27, 2024
Open
@zdr4k zdr4k mentioned this pull request Oct 27, 2024
Open
@DadonStyle DadonStyle mentioned this pull request Oct 27, 2024
Open
@ManuelDevWeb ManuelDevWeb mentioned this pull request Oct 28, 2024
Open
@Tanver-Hasan Tanver-Hasan mentioned this pull request Oct 31, 2024
Open
@scatools-demo scatools-demo mentioned this pull request Nov 2, 2024
Open
@Balantion2020 Balantion2020 mentioned this pull request Nov 2, 2024
Open
@DadonStyle DadonStyle mentioned this pull request Nov 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: jsx-curly-brace-presence doesn't trigger on strings containing a quote character
3 participants
@akulsr0 @dennisoelkers @ljharb