[New] no-unstable-nested-components: add propNamePattern to support custom render prop naming conventions
#3826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt custom render prop naming conventions
danreeves
force-pushed
the
no-unstable-component-prop-pattern
branch
from
ab0943d
to
18a2d38
Compare
ljharb
requested changes
Sep 17, 2024
2 tasks
ljharb
force-pushed
the
no-unstable-component-prop-pattern
branch
from
399954f
to
a1273d5
Compare
ljharb
approved these changes
Sep 26, 2024
ljharb
changed the title
no-unstable-component-prop-patternno-unstable-nested-components: add propNamePattern to support custom render prop naming conventions
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3826 +/- ##
==========================================
- Coverage 97.77% 94.36% -3.41%
==========================================
Files 135 133 -2
Lines 9750 9946 +196
Branches 3575 3688 +113
==========================================
- Hits 9533 9386 -147
- Misses 217 560 +343
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
renovate bot
added a commit
to mmkal/eslint-plugin-mmkal
that referenced
this pull request
Sep 27, 2024
##### [v7.37.0](https://github.com/jsx-eslint/eslint-plugin-react/blob/HEAD/CHANGELOG.md#7370---20240926) ##### Added - add type generation ([#3830][] [@voxpelli](https://github.com/voxpelli)) - \[`no-unescaped-entities`]: add suggestions ([#3831][] [@StyleShit](https://github.com/StyleShit)) - \[`forbid-component-props`]: add `allowedForPatterns`/`disallowedForPatterns` options ([#3805][] [@Efimenko](https://github.com/Efimenko)) - \[`no-unstable-nested-components`]: add `propNamePattern` to support custom render prop naming conventions ([#3826][] [@danreeves](https://github.com/danreeves)) ##### Changed - \[readme] flat config example for react 17+ ([#3824][] [@GabenGar](https://github.com/GabenGar)) [7.36.2]: jsx-eslint/eslint-plugin-react@v7.36.1...v7.36.2 [#3831]: jsx-eslint/eslint-plugin-react#3831 [#3830]: jsx-eslint/eslint-plugin-react#3830 [#3826]: jsx-eslint/eslint-plugin-react#3826 [#3824]: jsx-eslint/eslint-plugin-react#3824 [#3805]: jsx-eslint/eslint-plugin-react#3805
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to adopt this rule but
render*is not the only render prop naming convention in my codebases. Namely libraries such as react-virtualized have a*Rendererconvention.This PR adds the ability to customize the prop name matcher.
At the same time I cleaned up thecustomValidatorsdocumentation that appears to have been copy/paste error at implementation. I believe this would close 3664, which asks to document this non-existent option.