-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] jsx-boolean-value
: assumeUndefinedIsFalse
with never
must not allow explicit true
value
#3757
Conversation
… not allow explicit `true` value
Can you elaborate a bit more? |
Yes, sure. I think the new test cases are self-explaining but I can give more examples here. So if I turn on the rule with the config "never" my expectation is that I don't need to set boolean values explicitly. For Concrete examples, you can see problematic valid and invalid code in the second column highlighted with bold:
|
jsx-boolean-value
: assumeUndefinedIsFalse
with never
must not allow explicit true
value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
assumeUndefinedIsFalse should not affect the behaviour of props with true values when we have the "never" setting