-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] jsx-key
: detect conditional returns
#3630
Merged
ljharb
merged 1 commit into
jsx-eslint:master
from
yialo:fix/jsx-key-unblocked-conditional-return
Sep 5, 2023
Merged
[Fix] jsx-key
: detect conditional returns
#3630
ljharb
merged 1 commit into
jsx-eslint:master
from
yialo:fix/jsx-key-unblocked-conditional-return
Sep 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3630 +/- ##
=======================================
Coverage 97.64% 97.64%
=======================================
Files 132 132
Lines 9358 9360 +2
Branches 3425 3426 +1
=======================================
+ Hits 9138 9140 +2
Misses 220 220
|
ljharb
approved these changes
Sep 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems straightforward, thanks!
ljharb
force-pushed
the
fix/jsx-key-unblocked-conditional-return
branch
from
September 5, 2023 17:22
9acfec2
to
ecadb92
Compare
ljharb
changed the title
[fix]
[Fix] Sep 5, 2023
jsx-key
: unblocked conditional returnjsx-key
: detect conditional returns
This was referenced May 24, 2024
This was referenced Aug 22, 2024
This was referenced Sep 12, 2024
This was referenced Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catch React key absence for conditional return without block statement: