merge develop into my fork#1
Merged
praneetap merged 865 commits intopraneetap:developfrom Jan 23, 2022
Merged
Conversation
#2740) * Extract the logic of managing SAM cloudformation stack from the the S3-bucket bootstrap logic * Move ManagedStackError class to the module 'managed_cloudformation_stack'
…start-lambda and local invoke (#2700)
* fix: sam build fails when layer logicalID shared across stacks * Add flanky annotation to integ test * Allow local invoke the pass-up case
* Native Installer script/configs for nightly builds * resolve comments * parameterize the pyinstaller script * fix dist folder name * Update the path of samcli.spec * sed command for linux * reslove the case that dist_folder includes a space * reslove comments * upgrade pip * update installer script * minor fix on bash script style Co-authored-by: Cosh_ <CoshUS@users.noreply.github.com>
* replace --config-prefix by --config-env * update previous changelog entry Co-authored-by: Cosh_ <CoshUS@users.noreply.github.com> Co-authored-by: Sriram Madapusi Vasudevan <3770774+sriram-mv@users.noreply.github.com> Co-authored-by: Mohamed Elasmar <71043312+moelasmar@users.noreply.github.com>
…ads (#2667) Co-authored-by: Mohamed Elasmar <71043312+moelasmar@users.noreply.github.com>
* Added CR LF to LF Conversion for gradlew * Added convert_files_to_unix_line_endings to osutils * Removed Unused Import * Added More Comments * Updated Tests
* edit: print outdated version message to stderr * edit: black fmt * fix the failing unit test cases Co-authored-by: Mohamed Elasmar <71043312+moelasmar@users.noreply.github.com> Co-authored-by: Mohamed Elasmar <melasmar@amazon.com>
The region_name value when a profile does not specify a region or when there is not a 'default' profile resulted in a crash since _get_aws_region_choice attempted to perform concatenation using the `+` operator (which is undefined for str + NoneType). Using an actual string formatting method fixes that issue. Additionally, it is useless to prompt the user whether not to use the 'default' profile since doing so is impossible. They need to be prompted. Additionally, it is slightly more 'intelligent' to create a new session after the user has chosen a new profile so that a better default region can be chosen. Co-authored-by: _sam <3804518+aahung@users.noreply.github.com> Co-authored-by: Mohamed Elasmar <71043312+moelasmar@users.noreply.github.com>
Should be 'modifies' instead of 'modified' Co-authored-by: Redouane Achouri <redouane.achouri@klarna.com>
* refactor: Extract logics into _locate_layer_from_ref() * providers no longer extract functions/layers with s3 uri
* fix: Skip building functions/layers if codeuri is a zip file
* feat(Public ECR): Changed Build Image Registry to Public ECR (#2708) * Changed Build Image Registry to Public ECR * Added _IMAGE_URI_PREFIX * Fixed Unit Tests * Updated Image Format * feat(Public ECR): Updated Test Image Name and Added Latest Tag Check (#2720) * Added Tests for Latest Tag * Added use_container Check for Verify Latest Tag Tests * Fixed DotNet and Go Build Tests * Added Missing use_container Check for test_build_function_and_layer * feat(Public ECR): Changed Build Image Registry to Public ECR (#2708) * Changed Build Image Registry to Public ECR * Added _IMAGE_URI_PREFIX * Fixed Unit Tests * Updated Image Format * feat(Public ECR): Updated Test Image Name and Added Latest Tag Check (#2720) * Added Tests for Latest Tag * Added use_container Check for Verify Latest Tag Tests * Fixed DotNet and Go Build Tests * Added Missing use_container Check for test_build_function_and_layer * feat(Public ECR): Added --build-image Options (#2725) * Added Latest Tag Check * Added --build-image Option * Added Unit Tests * Added Help Text and Fixed PyLint * Fixed Path Validation for Unit Tests * Updated Type Hintings * Added _parse_key_value_pair * Updated tag Handling for Image Pulls * Added Throwing Exception with Invalid Build Images * Fixed PyLint Issue * Feat: added integration tests, container tag check and layer support (#2780) * Added integration tests * Added click requirement on -u presence for container based options * Added click class that checks -u presence for container based options * Reformatting and fixing test cases * Fix for integration test failures * Added support for layers * Resolve conflict * Refactoring file location * Addressing review comments, refactoring * Reformatting logging sentence * Refactoring container check for simplicity * Clarifying test case * Added unit tests on layer builds * Improving readability * Refactoring to simplify * Removing unnecessary lines * Refactoring integration test * Shortening error message * Adjusting test behaviour * Added new unit tests * Test refactoring * Added new test class * Removed unused import * Improving help text Co-authored-by: Qingchuan Ma <69653965+qingchm@users.noreply.github.com>
* chore: bump version to 1.22.0
* chore: Use BUILD_TAG instead of JENKINS_URL to identify Jenkins env * Keep JENKINS_URL
* Updated Deprecated compile to implementation * Updated Tabs to Spaces * Updated for Kotlin * Updated More Tabs to Spaces
* Added Auto Create ECR Design Doc * Updated Format * Addressed feedback
When validating the sam template, SAM CLI requires credentials to get the IAM Manged Policies. SAM Translator also requires the region in order to figure out the parition. Previously, SAM Translator assumed this to be on the Env but SAM CLI could get this information from a command line argument or a profile. This commit passes the boto_session into the SAM Translator lib (v1.35.0 or later), so that SAM Translator can figure out the partition from the information passed to SAM CLI. Co-authored-by: Jacob Fuss <jfuss@users.noreply.github.com> Co-authored-by: Mathieu Grandis <73313235+mgrandis@users.noreply.github.com>
…am local commands (#2806)
Co-authored-by: Xia Zhao <xazhao@amazon.com>
…2821) * [Refactor] extract git-clone functionality out of InitTemplates class to its own class * apply review comments * typo * apply review comments
* chore: add command line options to pyinstaller build script * Update quotes * fix the dist folder name * update logs * trigger appveyor build
Co-authored-by: Slava Senchenko <sencslav@amazon.com>
* add github actions to automate our github issue workflow * reformat * update name format * update response message to be more precise * updated with the correct sam bot login name * updated with the correct token name * updated label name and bot name Co-authored-by: Mathieu Grandis <73313235+mgrandis@users.noreply.github.com>
* Point numpy version to <1.19 to avoid PEP 317 failure * Update integ test python requirements which contain numpy * Fixing to numpy 1.20.2 * Revert "Fixing to numpy 1.20.2" This reverts commit a03f4d7. * Fixing numpy version to <1.20.3
Issue: #2355 Added integration tests for `validate` command Co-authored-by: Slava Senchenko <sencslav@amazon.com> Co-authored-by: _sam <3804518+aahung@users.noreply.github.com>
* (fix) stop resolve relative paths for function imageUri * fix unit testing
* SAM INIT Update * resolved conflict * test added and updated * block default prompt when Image packageType is provide and skip use case prompt when --app-template is provided * update default hello world prompt * filtering updates * added typing * Fixing failed canaries (#3532) * (fix) stop resolving relative paths for Function image URI (#3531) * (fix) stop resolve relative paths for function imageUri * fix unit testing * update template_does_not_meet_filter_criteria use <dict>.get Co-authored-by: Mehmet Nuri Deveci <5735811+mndeveci@users.noreply.github.com> Co-authored-by: Qingchuan Ma <69653965+qingchm@users.noreply.github.com> Co-authored-by: Mohamed Elasmar <71043312+moelasmar@users.noreply.github.com>
…zed templates (#3545) * add unsupported command to asm validate in case of CDK synthesized templates * fix integration testing use case name
…ces with Image package type, and its code is local image uri. (#3529) * (fix) allow sam to deploy templates contain CFN Lambda Function resources with Image package type, and its code is local image uri, * make reformat * (fix) fix sam build failure for templates contians function without Docker Metadata * run black format * resolve PR comments
* support invoking lambda functions using function full_path * add more unit testing
…ed functions (#3543) * - Skip building Functions/Layers that are already built by CDK (Runtime Functions, Bundled Assets) - Add support to flag a function with SkipBuild metadata. * - Skip building Functions/Layers that are already built by CDK (Runtime Functions, Bundled Assets) - Add support to flag a function with SkipBuild metadata. * merge and do black changes
* fix Lambda LayerVersion resource content property * add integration test case
… commands (#3554) * support package and deploy CDK synthesized templates * add unit testing, and integration testing * run black * add deploy integration testing * fix failed integration test cases * apply pr comments * fix package image, check if ecr_repository is not empty * black and use Asset parameters pattern * apply pr comments
* feat: allow invoking built CDK synthesized templates * run black * fixing testing issue * add unit testing to cover custom resource Id * run black * skip normalizing the resources that have been normalized before * apply pr comments * apply pr comments
…rt CDK, and nested stacks (#3560) * use Iac Id, and Full Path for Functions and Layers * use Iac Id, and Full Path for stacks * use full path and CDK Id for image repositories validation * allow using full_path and CDK ids in sam sync, package, deploy * add CDK and nested CDK stacks integration test cases, and fix some issues * Update build_graph.py apply pr comments
* support warm-containers to CDK templates * fix integration test cases
* fix: copy normalized metadata to built resources only * fix: use layer full path to unique define the layer build definition * fix: add logging to file_observer, and add locking
* split testing in separate jobs * fix appveyor templates * fix appveyor templates * add a separate appveyor template for ubuntu jobs
* fix package regression test cases to remove the new added SAM related metadata. * fix failing windows issue * update ruby version. Ruby v2.5 is not supported any more * update ruby version. Ruby v2.5 is not supported any more * use layer full path to generate the dependency layer
* Revert "release: 0.20.0" * chore: Update version to 0.20.1 * Revert "Revert "release: 0.20.0"" (#1377) This reverts commit 2090431. * Add CFN stack sets to supported resources Adds the ability to upload CloudFormation StackSet `TemplateURL` files Co-authored-by: Sanath Kumar Ramesh <sanathkr@amazon.com> Co-authored-by: Jacob Fuss <32497805+jfuss@users.noreply.github.com> Co-authored-by: Sriram Madapusi Vasudevan <3770774+TheSriram@users.noreply.github.com> Co-authored-by: Alex Wood <awood45@gmail.com> Co-authored-by: Tarun <c2tarun@users.noreply.github.com> Co-authored-by: Sriram Madapusi Vasudevan <3770774+sriram-mv@users.noreply.github.com> Co-authored-by: aws-sam-cli-bot <46753707+aws-sam-cli-bot@users.noreply.github.com> Co-authored-by: _sam <3804518+aahung@users.noreply.github.com>
Co-authored-by: Raymond Wang <14915548+wchengru@users.noreply.github.com> Co-authored-by: Mohamed Elasmar <71043312+moelasmar@users.noreply.github.com>
* fix flaky warm containers testing * use py3.7 instead of 3.8, as it is not available in testing windows host * selectors are not working in windows * ruby 2.5 is not supported, use 2.7 instead * fix the logic to wait till apis are running in windows * add auto generated S3 Prefix * fix ruby version * move s3 prefix creation to Setup method * fix the sync integration testing * remove appveyor sync Co-authored-by: Mehmet Nuri Deveci <5735811+mndeveci@users.noreply.github.com>
* chore: Add warning about implicit logical ID usage in sam build * Update samcli/lib/providers/sam_api_provider.py Co-authored-by: Chris Rehn <crehn@outlook.com> * Fix a smoke test case where "Transform" is not a str Co-authored-by: Chris Rehn <crehn@outlook.com>
…match deployed one (#3497) * fix: make routeKey and queryStringParameters for local HttpApi event match deployed ones * update test default Co-authored-by: Wing Fung Lau <4760060+hawflau@users.noreply.github.com>
* Added ECR Policy Check Tests * Updated Dict Get Default * Added Companion Stack Asserts to PackageIntegBase Co-authored-by: Mehmet Nuri Deveci <5735811+mndeveci@users.noreply.github.com>
* bug fix for sunning samcli when cloning fails * fixed failing test in Appveyor * change os.path to pathlib.Path
* Fix for a bug that some resource syncs do not respect base dir option * Adding testcases for base dir specified * Refine test case for multi system compatibility Co-authored-by: Mehmet Nuri Deveci <5735811+mndeveci@users.noreply.github.com>
* fix flaky warm containers testing * use py3.7 instead of 3.8, as it is not available in testing windows host * selectors are not working in windows * ruby 2.5 is not supported, use 2.7 instead * fix the logic to wait till apis are running in windows * add auto generated S3 Prefix * fix ruby version * move s3 prefix creation to Setup method * fix the sync integration testing * remove appveyor sync * Add TypeScript CDK V1 && V2 * Add appveyor yaml file * fix appveyor yaml file * fix appveyor yaml file * fix appveyor template * fix appveyor template - update nodejs version * fix appveyor template - install latest nodejs version * add sudo * testing * testing - add sudo * testing - add sudo2 * testing - add sudo3 * testing - add sudo4 * testing - add sudo5 * add some print out * add some logs for investigation * remove bundled java test cases, and use bundled python instead * add CDK python examples * remove shared layers * update python cdk.json files * debugging * revert debugging * revert wrong committed changes * remove py2.7 installation. * Add Java CDK application * install maven Co-authored-by: Mehmet Nuri Deveci <5735811+mndeveci@users.noreply.github.com>
* feat: allow include of openapi definition to pass validation * fix: type error * chore: increase unit test coverage * chore: black format change * chore: add more tests * fix: cleanup for pr Change to use pathlib. Move debug log statement to before next statement. Remove unused test file. * fix: use mocks instead of file system * feat: integration tests fix: add debug message when import file can't be found Co-authored-by: Wing Fung Lau <4760060+hawflau@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Checklist:
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.