chore: build go bindings for monocdk #13399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `go` configuration to the `monocdk` package. To be able to generate go bindings a few tweaks to the current codebase were needed: BREAKING CHANGE: The deprecated `Duration.toISOString()` method is no longer available. Please use `Duration.toIsoString()` instead. Unfortunteally this API needs to be broken to disambiguate the two methods in the Go generated code.
eladb
requested review from
RomainMuller,
rix0rrr,
iliapolo,
MrArnoldPalmer and
nija-at
|
|
Package name for yum is not awscli. This causes the command to have a return code different than 0, which fails the user-data script. This change addresses the issue: #13654 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…this time (#13550) This PR adds a note that at most one listener may be added to a Virtual Node until App Mesh team adds support for multiple listeners per aws/aws-app-mesh-roadmap#120 Closes #13549 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
There was an unnecessary ')' in a Markdown link, making it render incorrectly on our API page. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
`.npmignore` did not use to be copied into the directories of the monopackage, leading to files that *ought* to have been excluded to not be excluded. Remove the file from the list of files that doesn't get copied to fix this. This fix is not along the lines of the method suggested in the linked issue, but it does address the original problem. Fixes #12292. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…#13665) These changes (plus import changes) were necessary to make these tests pass on the `v2-main` branch. Back-porting to `master` to (hopefully) reduce future forward-merge pain. The 'returns base construct info if no more specific info is present' test was removed as is wasn't truly necessary, and does not work with V2, where Construct comes from the `constructs` library instead of `core.Construct`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
fixes #13640 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Across the CDK repo, remove the usage of deprecated symbols. These are going to be removed in CDKv2, and these changes make the codebases on the two branches more aligned. However, this does not remove *all* usages of deprecated symbols, but only the changes that are backwards compatible. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
If the installed node version is >= 14, use Node.js 14.x. Otherwise, use Node.js 12.x. This removes a default on the deprecated Node.js 10.x runtime. BREAKING CHANGE: the default runtime of a `NodejsFunction` is now Node.js 14.x if the environment from which it is deployed uses Node.js >= 14 and Node.js 12.x otherwise. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
We need this to have `jsii-rosetta` runs that try to translate READMEs from submodules not crash (because it can't find the referenced fixture files). This is not a correct final state yet, but it makes the build not crash. Hopefully allows aws/jsii#2712 to be merged. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…13667) The allowed values for `UntrustedArtifactOnDeployment` in the `AWS::Lambda::CodeSigningConfig` resource type are 'Warn' and 'Enforce'. This was incorrectly set in the CDK. fixes #13586 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
CloudFormation supports only one resource type for AWS Signer, namely [Signing Profile]. This is a very simple resource type with effectively two properties, both of which, have been modeled according to the latest expectations of the CDK construct library. There is no good reason why this module ought to stay as experimental. Given the standard nature of this module, I do not expect much customer feedback on usability that would require backwards incompatible changes. Hence, marking this as stable. Motivation The `ISigner` interface is referenced by the `Function` construct in the `aws-lambda` module. This is an instance of a stable module depending on an experimental module. In CDKv2, we plan to ship only stable modules as part of the mono-release of the cdk (aka, `aws-cdk-lib`). A prerequisite to achieve this is to avoid such dependencies (stable → experimental). In this specific case, we are fixing this by promoting the `aws-signer` module to stable. [Signing Profile]: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-signer-signingprofile.html
…#13696) How the `env` parameter is supposed to be used is still confusing to a lot of users. Add uncommentable lines to the init templates showing and describing the 3 alternatives. Fixes #12321. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Add support for client VPN endpoints with the following L2s: `ClientVpnEndpoint`, `ClientVpnAuthorizationRule` and `ClientVpnRoute`. Client VPN endpoints can be added to VPCs with the `addClientVpnEndpoint()` method. Both mutual and user-based authentication are supported. The `ClientVpnEndpoint` class implements `IConnectable`. Use a custom resource to import server and client certificates in ACM for the integration test. Close #4206 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…ceAction (#13656) Adds optional `DetectChanges` to BitBucketSourceAction https://docs.aws.amazon.com/codepipeline/latest/userguide/action-reference-CodestarConnectionSource.html This option is available in the AWS console when configuring the Source stage. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…n CORS (#13313) API gateway expects `*` to represent `ANY` HTTP method. `HttpMethod` enum doesn't have a value for that, thus causing errors when passing `HttpMethod` 's `ANY` option. This commit introduces `CorsHttpMethod` enum which has a proper `ANY` mapping to `*`. Closes #13280. Closes #13643. BREAKING CHANGE: The type of `allowMethods` property under `corsPreflight` section is changed from `HttpMethod` to `CorsHttpMethod`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…onds results in an error (#13689) A previous change - b1449a1 - introduced a validation that should have been applied only when Duration is specified as a token. Instead, it was applied for non token values as well. Adjusting the validation so it only applies to when the duration is a token. fixes #13566 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…ed" error (#13637) Previously access control lists for putObject was not called. This had led in getting access denied issue when trying to upload objects into the s3 bucket fixes #13557 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Bumps [hmarr/auto-approve-action](https://github.com/hmarr/auto-approve-action) from v2.0.0 to v2.1.0. - [Release notes](https://github.com/hmarr/auto-approve-action/releases) - [Commits](hmarr/auto-approve-action@v2.0.0...5d04a5c) Signed-off-by: dependabot[bot] <support@github.com>
Add retry policy (+ dead letter queue) support for the following targets: - Lambda - LogGroup - CodeBuild - CodePipeline - StepFunction Closes #13659 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Ran npm-check-updates and yarn upgrade to keep the `yarn.lock` file up-to-date.
Required for publishing Go bindings. Related #13399
MrArnoldPalmer
approved these changes
Mar 24, 2021
Co-authored-by: Mitchell Valine <valinm@amazon.com>
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
corrjo
pushed a commit
to corrjo/aws-cdk
that referenced
this pull request
Mar 25, 2021
Add `go` configuration to the `monocdk` and `aws-cdk-lib` packages. Resolves aws/jsii#2611 The following jsii bugs were fixed to enable this: - [x] aws/jsii#2648 - [x] aws/jsii#2649 - [x] aws/jsii#2647 - [x] aws/jsii#2617 - [x] aws/jsii#2632 - [x] aws/jsii#2651 - [x] aws/jsii#2508 - [x] aws/jsii#2692 - [x] aws/jsii#2700 - [x] aws/jsii#2702 --- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Mar 31, 2021
Add `go` configuration to the `monocdk` and `aws-cdk-lib` packages. Resolves aws/jsii#2611 The following jsii bugs were fixed to enable this: - [x] aws/jsii#2648 - [x] aws/jsii#2649 - [x] aws/jsii#2647 - [x] aws/jsii#2617 - [x] aws/jsii#2632 - [x] aws/jsii#2651 - [x] aws/jsii#2508 - [x] aws/jsii#2692 - [x] aws/jsii#2700 - [x] aws/jsii#2702 --- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
Add `go` configuration to the `monocdk` and `aws-cdk-lib` packages. Resolves aws/jsii#2611 The following jsii bugs were fixed to enable this: - [x] aws/jsii#2648 - [x] aws/jsii#2649 - [x] aws/jsii#2647 - [x] aws/jsii#2617 - [x] aws/jsii#2632 - [x] aws/jsii#2651 - [x] aws/jsii#2508 - [x] aws/jsii#2692 - [x] aws/jsii#2700 - [x] aws/jsii#2702 --- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
goconfiguration to themonocdkandaws-cdk-libpackages.Resolves aws/jsii#2611
The following jsii bugs were fixed to enable this:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license