update #1
Merged
update #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Create yieldmoBidAdapter file * Copy over TL adapter and change name spacing * Update bid adapter naming to Yieldmo * Init tests for yieldmoBidAdapter * Add yeildmo config to pbjs_example_gpt * feature/yieldmoBidAdapter: added request build * Update ym response to have placement and impression level info * Remove environment param * Update ym tests for single bid request structure * Update url to use _ instead of camelcase * Update YMCB to handle multiple placements in one response * Clean up and remove TODO from adapter * Update response tests to work with single response structure * Remove trailing space * Cleanup * Adjusted code according to CR comments * Update bid adapter with fallback for incorrect bid response * Update yeildmo prebid endpoint * Add check to make sure response is an Array * Remove environment tracking as we are no going to use this * Update test to pass with new Yieldmo endpoint * Update return obj and remove node debug comments * Remove changes to hello_world and yarn.lock files * Remove unneeded comments
* Added tremor bid adapter for prebid.js * - Fixed some tests. * - Added some comments and changed a few variable names to be in line with what we use at tremor. - Changed a test to look for document.location.href instead of a hardcoded localhost url. * - Some formatting. * - Removed the vastUrl field from the adapter.
…1570) * allow bundle task to be run programmatically from node * add bundle-to-stdout task to gulpFile.js * fixed bug with double-prepending __dirname in module bundling
* Added a base adapter for single-request adapters, and ported the appnexusAst adapter onto it * Renamed the SingleRequestBidder to BidderFactory. Updated it to handle multi-request architecture adapters. * Added a unit test for the delayExecution function. * Made newBidder a default import. Added some unit tests. * Added more tests. * Added more tests, and fixed a few bugs. * Changed an error to a log message. Fixed a small bug. * Did the no-brainer improvements from PR comments. * Added spec-level support for aliases and mediaTypes. Aliases may still be broken. * Added support for aliases. Added more tests * Cleaned up some unnecessary code. * Removed the GET/POST constants. Fixed some typos, and renamed some Request-related properties for consistency with the native object. * Re-added some code for outstream rendering, which was apparently lost in the merges somewhere. * Removed confusing use of this * Fixed lint error * Moved JSON parsing into the bidderFactory, and moved the JSDocs to the top. * Removed placementCode from everywhere I could.
Update tests to match.
* Add support for video stream context * Define adapter as supporting video * Use mediaTypes param to specify context * Use utils.deepAccess * Check for outstream bids * Add JSDoc and validation * Rename functions and add unit test * Update property name * Update stubs to new sinon stub syntax * Only check context when mediaTypes.video was defined * Retain video-outstream compatibility * Revert to Sinon 1 syntax * Server and bid response ad type for any stream type is always 'video' * Update to address code review
* Adding Orbitsoft module * Adding Orbitsoft module (corrected) * Adding Orbitsoft module (correction of remarks) * Adding Orbitsoft module (correction of remarks) * Adding Orbitsoft module (correction to alias-able) * Adding Orbitsoft module (correction to alias-able) * Adding Orbitsoft module (correction to alias-able) * Adding Orbitsoft module (correction to alias-able) * Adding Orbitsoft module (correction to new constructor) * Adding Orbitsoft module (delete unnecessary aliases) * Adding Orbitsoft module (delete unnecessary aliases)
* Add new user sync module * Rename user sync file * Reset image pixel queue after firing pixels * Added unit test for user sync * Fixed typo * Overlooked conflict from master * Improvements based on peer feedback for user sync * Added global user sync config * Allow auto-syncing override * Prevent syncing if there is no cookie support * Only trigger sync once per page * Limit number of user syncs per bidder * User syncs should fire pixels without adding element to DOM * Randomize user sync order by type * Comment about shuffling user syncs * Remove karma.conf.js and fix unused default value * Fix prebid server adapter test to use the right cookie function * Added iframe support to user sync * Fix oversights for user sync * Move try catch block for user sync * Option to disable user sync * Enable specific bidders for user sync * Encapsulate the user sync module Protect the user sync scope * Remove unused functions for user sync * Clean merge markers * fix usersync test problems * added setConfig to userSync * fixed lint problem * Change override user sync API and how user sync uses config * Fixed registerSync API to avoid spread operator * Fixed issues from last conflict resolution * Small refactoring to inject dependencies better. * Added a test for when user syncs are disabled. * Implemented usersync in the base adapter. * user-sync updates * not tracking client bidder syncs
* Connectad alias, request-level configuration, new ad sizes - Add 3 new ad sizes. - Create connectad alias. - Refactor to support whitelabel URLs by alias. - Add support for window.<ADAPTER>_CONFIG object for request level params. * Add oft-media alias for serverbid * serverbidBidAdapter:Fixed formatting issues * Serverbid: Updated smartsync urls, removed oft-media alias
* Add trustx adapter and tests for it * update integration example * Update trustx adapter * Post-review fixes of Trustx adapter
* Renamed areParamsValid to isBidRequestValid. Added the bidrequest to interpretResponse. * Changed areParamsValid into isBidRequestValid. * Updated the unit tests.
* fix for #1582 * fixed typo and add unit tests
* add Adomik Analytics Adapter * clean code * refactoring & tests
* fix log message not displaying when referencing missing bidder * add test for missing bidder log message * move test to adaptermanager_spec
* Add PlatformioBidAdapter * Update platformioBidAdapter.js * Add files via upload * Update hello_world.html * Update platformioBidAdapter.js * Update platformioBidAdapter_spec.js * Update hello_world.html * Update platformioBidAdapter_spec.js * Update platformioBidAdapter.js * Update hello_world.html * Add files via upload * Update platformioBidAdapter ## Type of change - [x] Other ## Description of change 1. RequestURL changes 2. Add placementCode to request params * Update platformioBidAdapter * Update platformioBidAdapter ## Type of change - [x] Other ## Description of change 1. RequestURL changes 2. Add placementCode to request params * Add files via upload * Add files via upload * Add files via upload * Update platformioBidAdapter.js Endpoint URL change * Update platformioBidAdapter_spec.js Endpoint URL change * Update platformioBidAdapter_spec.js * Update platformioBidAdapter_spec.js * Update platformioBidAdapter.js * Update platformioBidAdapter.js * Update platformioBidAdapter_spec.js * Add files via upload * Add files via upload * Add files via upload
* Add files via upload * Update package.json * Add files via upload Test for jcm adapter * Add files via upload * Add files via upload * Add files via upload * Add files via upload * Delete jcm.js * Add files via upload * Add files via upload * Add files via upload * Delete jcm_spec.js * Add files via upload * Add files via upload * Add files via upload * Add files via upload * Add files via upload * Delete adapters.json * Update package.json
* add option to run tests in a specific file * add option to run tests in a specific file * Update gulpfile.js * Update karma.conf.maker.js
* Updated the bidderFactory to make headers accessible to the spec files. * Updated the platform.io adapter to handle the new format. * Updated the jcm adapter.
* validating bid response params * added all required params * replaced id with correct param requestid * keeping only common keys to validate
* nanointeractive bid adapter * nanointeractive bid adapter * - using utils.getParameterByName instead of utils.getTopWindowLocation().href - bidderCode is removed - Default ALG changed to 'ihr' - added protocol to 'cors' param * markdown file * enabling localhost for bid requests
* Update Improve Digital adapter for Prebid 1.0 * Removed bidderCode from bids * Added creativeId to bid response; updated format of the first argument of interpretResponse
* Add trustx adapter and tests for it * update integration example * Update trustx adapter * Post-review fixes of Trustx adapter * Code improvement for trustx adapter: changed default price type from gross to net * Update TrustX adapter to support the 1.0 version * Make requested changes for TrustX adapter * Updated markdown file for TrustX adapter * Fix TrustX adapter and spec file
* Fixed a bug in test-coverage single-file tests. * Reverted unintended changes.
* Conversant adapter initial support for prebid 1.0 * Add video support for conversant adapter * Add tests and md * Update conversant contact address * Return data object in buildRequests without converting it to a string * Conversant adapter initial support for prebid 1.0 * Add video support for conversant adapter * Add tests and md * Update conversant contact address * Return data object in buildRequests without converting it to a string * Better validation for site id * Switch to use utils._each and utils._map * Add tests for displaymanagerver * Review changes for conversant
* Initial revision of adocean bid adapter (ADOCEAN-13634, ADOCEAN-13635) * Minor fixes * new demo placement * formating after lint * move request parameters to params * adocean adpater tests * minor fixes * added ttl, netRevenue nad creativeId. merged with upstream
* Fidelity Media Adapter update. Prebid v1.0. Fidelity Media Adapter update. Prebid v1.0 plus featutes update. Add Prebid v1.0 support Add parameter "floor" Removed: "Loc" "Click" "SubId" Subid=HB trasferred to SSP by default now. * Fidelity Media Adapter update. Prebid v1.0. Fidelity Media Adapter update. Prebid v1.0 plus featutes update. Add Prebid v1.0 support Add parameter "floor" Removed: "Loc" "Click" "SubId" Subid=HB trasferred to SSP by default now. * Fidelity Media fmxSSP Adapter update. Prebid v1.0 * Fidelity Media. Prebid v 1.0 Add tmax * Fidelity Media. Prebid v 1.0. ttl * Fidelity Media. Prebid v 1.0. spec * Less bidderCode, add creativeId * Adapter v.1, less bidderCode, add creativeId * Prebid v1. InterpretResponse. Spec. * InterpretResponse * InterpretResponse
* Add v1.0 adapter skeleton * Fix a typo in variable name declaration * Change spec dependencies * Add new describes for test * Move URL detechtion inside buildRequests method * Add necessary cases * Clean test cases * Export Quantcast adapter constants * Implemenent test cases * Fix wrong ports number * Correct test cases * Make string with single quote * Remove unused statements * Revert "Remove unused statements" This reverts commit 459ca31. * Remove unused statements * Change string to single quote * Fix sizes type * Fix the sizes propty name typo in the spec * Remove unused method, key value and comments * Update the spec * Change code using single quote * Update the first argument for interpretResponse method and its spec * Handle undefined Server Response * Add required params from the server response
* updated adxcg adapter for prebid 1.0 * update for prebid 1.0 with dead code and bidder removed * updates to spec file for prebid 1.0 - removal of biddercode check * updated adxcg bidadapter for prebid-1.0 with response headers
* add vastUrl + media type for video bids * updates per review * updates per review * updates per review
* Add centro adapter and tests for it. * fix bug with different types of bid.sectionID and bid.unit from config * add query parameter adapter=prebid * update tests for centro adapter * fixed bug with call of JSONP callback with name, that contain invalid characters * Centro adapter fix: do not call logError if 'No Bid' was received * Centro adapter: pass the bid request object to bidfactory.createBid * Centro adapter: fix ESLintError * Fix Centro adapter to allow requests of the same units * Fix spec file for Centro adapter
* added hook module to prebid core that allows extension of arbitrary functions * remove unused dependency tiny-queue * change PluginFunction to HookedFunction * more hook documentation fixes * allow context for hooked functions * added tests for context * remove withContext, just use bind * fix in hooks so asyncSeries keeps proper bound context
* AD-2311: Make GetIntent adapter compatible with Prebid.js 1.0 version * AD-2311: remove blank line * Trigger * GetIntent adapter - added bid response fields: currency, ttl and netRevenue; fixed creative size selector (#1721) * GetIntent adapter - added bid response fields: bidId, creativeId (#1721)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
Other information