Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix up linting, make lint clean #10

Closed
wants to merge 1 commit into from
Closed

Fix up linting, make lint clean #10

wants to merge 1 commit into from

Conversation

jakebailey
Copy link
Owner

@jakebailey jakebailey commented May 31, 2022 •
edited
Loading

Now that we are modules, there's no reason to ban multiple namespaces
per file; each file is its own scope and declaring a namespace won't
merge it into any other files.

Please do not comment on this PR. Depending on how this set of PRs evolves, this PR's contents may change entirely based on the order of commits.

This PR is a part of a stack:

  1. Make a few changes to allow all code to be loaded as one project
  2. Explicitly reference ts namespace in tsserverlibrary
  3. Generated module conversion step - unindent
  4. Generated module conversion step - explicitify
  5. Generated module conversion step - stripNamespaces
  6. Generated module conversion step - inlineImports
  7. Generated module conversion step - .git-ignore-blame-revs
  8. Add gitlens settings suggestion
  9. Make processDiagnosticMessages generate a module
  10. Fix up linting, make lint clean (this PR)
  11. Undo changes needed to load codebase into ts-morph
  12. Add JSDoc eslint rule
  13. Fix all internal JSDoc comments
  14. Convert require calls to imports
  15. Remove typescriptServices, protocol.d.ts, typescript_standalone.d.ts
  16. Get codebase building pre bundling
  17. Add build via esbuild
  18. Add dts bundling
  19. Consolidate checks that test if the current environment is Node
  20. Add ts to globalThis in run.js for convenience during debugging
  21. Rename Gulpfile to Herebyfile for improved git diff
  22. Change build system to hereby
  23. Update baselines for corrected line endings in lib files
  24. Use jsonc-parser instead of LKG compiler in build
  25. Modernize localize script, use new XML library
  26. Don't use needsUpdate for quick tasks
  27. Remove mkdirp
  28. Export ts namespace from tsserver for hacky-post patching
  29. Directly import namespaces for improved esbuild output
  30. Ensure ts object passed to plugins contains deprecatedCompat declarations
  31. Move compiler-debug into Debug namespace, which allows the compiler to be tree shaken
  32. Remove Promise redeclaration
  33. Remove globalThisShim and globalThis modification for TypeScriptServicesFactory
  34. Disable slow CodeQL queries
  35. Remove outFiles from launch.json
  36. Remove dynamicImport and setDynamicImport

@jakebailey jakebailey force-pushed the transform-stack-commit-9 branch from 862b53a to b303800 Compare June 1, 2022 00:11
@jakebailey jakebailey force-pushed the transform-stack-commit-10 branch from de15745 to 21d2bb9 Compare June 1, 2022 00:11
@jakebailey jakebailey force-pushed the transform-stack-commit-9 branch from b303800 to a9b1b81 Compare July 26, 2022 23:06
@jakebailey jakebailey force-pushed the transform-stack-commit-9 branch 5 times, most recently from 447b364 to 4be74e4 Compare August 29, 2022 23:17
@jakebailey jakebailey changed the title Bad attempt to solve some cycles (not complete) Get test suites running Aug 29, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-10 branch from 21d2bb9 to dd3abe2 Compare August 29, 2022 23:17
@jakebailey jakebailey force-pushed the transform-stack-commit-9 branch from 4be74e4 to 0bdfaab Compare August 31, 2022 21:28
@jakebailey jakebailey force-pushed the transform-stack-commit-10 branch from dd3abe2 to 8d3b866 Compare August 31, 2022 21:28
@jakebailey jakebailey force-pushed the transform-stack-commit-9 branch from 0bdfaab to ed1fa01 Compare September 3, 2022 04:21
@jakebailey jakebailey force-pushed the transform-stack-commit-10 branch from 8d3b866 to ec3de2a Compare September 3, 2022 04:21
@jakebailey jakebailey force-pushed the transform-stack-commit-9 branch from ed1fa01 to 719036a Compare September 3, 2022 04:43
@jakebailey jakebailey force-pushed the transform-stack-commit-10 branch from ec3de2a to ce5df67 Compare September 3, 2022 04:43
@jakebailey jakebailey force-pushed the transform-stack-commit-9 branch from 719036a to 626c88b Compare September 7, 2022 22:31
@jakebailey jakebailey changed the title Get test suites running Convert require calls to imports Sep 7, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-10 branch from ce5df67 to d40d483 Compare September 7, 2022 22:31
@jakebailey jakebailey force-pushed the transform-stack-commit-9 branch from 626c88b to 44fab70 Compare September 13, 2022 16:51
@jakebailey jakebailey force-pushed the transform-stack-commit-10 branch from d40d483 to b576e05 Compare September 13, 2022 16:51
@jakebailey jakebailey force-pushed the transform-stack-commit-9 branch from 44fab70 to 53c4f2c Compare September 13, 2022 20:27
@jakebailey jakebailey force-pushed the transform-stack-commit-10 branch from b576e05 to 529ac2b Compare September 13, 2022 20:27
@jakebailey jakebailey force-pushed the transform-stack-commit-9 branch from 53c4f2c to bb30e75 Compare September 13, 2022 21:02
@jakebailey jakebailey force-pushed the transform-stack-commit-10 branch from 529ac2b to 3460bfe Compare September 13, 2022 21:02
@jakebailey jakebailey force-pushed the transform-stack-commit-9 branch from bb30e75 to 804627b Compare September 13, 2022 21:47
@jakebailey jakebailey force-pushed the transform-stack-commit-10 branch from 3460bfe to 7f20686 Compare September 13, 2022 21:47
@jakebailey jakebailey force-pushed the transform-stack-commit-9 branch from 804627b to 3cbc760 Compare September 13, 2022 21:57
@jakebailey jakebailey force-pushed the transform-stack-commit-10 branch from 7f20686 to 6854688 Compare September 13, 2022 21:58
@jakebailey jakebailey force-pushed the transform-stack-commit-9 branch from 3cbc760 to 197b5d4 Compare September 13, 2022 23:22
@jakebailey jakebailey force-pushed the transform-stack-commit-9 branch from 45bb1c4 to 65a5c16 Compare October 25, 2022 02:23
@jakebailey jakebailey force-pushed the transform-stack-commit-10 branch from d7b3bd8 to 957ef92 Compare October 25, 2022 02:23
@jakebailey jakebailey force-pushed the transform-stack-commit-9 branch from 65a5c16 to 47b47af Compare October 27, 2022 04:20
@jakebailey jakebailey force-pushed the transform-stack-commit-10 branch from 957ef92 to 0e834c3 Compare October 27, 2022 04:20
@jakebailey jakebailey force-pushed the transform-stack-commit-9 branch from 47b47af to eed82a9 Compare October 27, 2022 17:38
@jakebailey jakebailey force-pushed the transform-stack-commit-10 branch from 0e834c3 to 569de72 Compare October 27, 2022 17:38
@jakebailey jakebailey force-pushed the transform-stack-commit-9 branch from eed82a9 to 7333bc0 Compare October 28, 2022 02:20
@jakebailey jakebailey force-pushed the transform-stack-commit-10 branch from 569de72 to d404cae Compare October 28, 2022 02:21
@jakebailey jakebailey force-pushed the transform-stack-commit-9 branch from 7333bc0 to c4c7d43 Compare October 31, 2022 21:31
@jakebailey jakebailey force-pushed the transform-stack-commit-10 branch from d404cae to 4b3fd48 Compare October 31, 2022 21:31
@jakebailey jakebailey force-pushed the transform-stack-commit-9 branch from c4c7d43 to 21462ed Compare November 2, 2022 00:41
@jakebailey jakebailey force-pushed the transform-stack-commit-10 branch from 4b3fd48 to 3de666e Compare November 2, 2022 00:42
@jakebailey jakebailey force-pushed the transform-stack-commit-9 branch from 21462ed to 83439fd Compare November 2, 2022 16:53
@jakebailey jakebailey force-pushed the transform-stack-commit-10 branch from 3de666e to 3c6209e Compare November 2, 2022 16:53
@jakebailey jakebailey force-pushed the transform-stack-commit-9 branch from 83439fd to 1f31fcc Compare November 2, 2022 19:43
@jakebailey jakebailey force-pushed the transform-stack-commit-10 branch from 3c6209e to 203a53e Compare November 2, 2022 19:44
@jakebailey jakebailey force-pushed the transform-stack-commit-9 branch from 1f31fcc to 53cfcc5 Compare November 6, 2022 21:52
@jakebailey jakebailey force-pushed the transform-stack-commit-10 branch from 203a53e to ea6fd46 Compare November 6, 2022 21:52
@jakebailey jakebailey force-pushed the transform-stack-commit-9 branch from 53cfcc5 to 70509fe Compare November 6, 2022 21:57
@jakebailey jakebailey force-pushed the transform-stack-commit-10 branch from ea6fd46 to c16b625 Compare November 6, 2022 21:58
@jakebailey jakebailey force-pushed the transform-stack-commit-9 branch from 70509fe to 2123f0e Compare November 7, 2022 03:53
@jakebailey jakebailey force-pushed the transform-stack-commit-10 branch from c16b625 to 5d834f1 Compare November 7, 2022 03:53
@jakebailey jakebailey force-pushed the transform-stack-commit-9 branch from 2123f0e to 0b309d6 Compare November 7, 2022 19:27
@jakebailey jakebailey force-pushed the transform-stack-commit-10 branch from 5d834f1 to e9d7536 Compare November 7, 2022 19:27
@jakebailey jakebailey force-pushed the transform-stack-commit-9 branch from 0b309d6 to d9374d7 Compare November 7, 2022 21:37
@jakebailey
Fix up linting, make lint clean
9ff5d03 
Now that we are modules, there's no reason to ban multiple namespaces
per file; each file is its own scope and declaring a namespace won't
merge it into any other files.
@jakebailey jakebailey force-pushed the transform-stack-commit-10 branch from e9d7536 to 9ff5d03 Compare November 7, 2022 21:37
@jakebailey jakebailey deleted the branch transform-stack-commit-9 November 7, 2022 23:54
@jakebailey jakebailey closed this Nov 7, 2022
@jakebailey jakebailey deleted the transform-stack-commit-10 branch November 7, 2022 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jakebailey