Skip to content

Change build system to hereby #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

jakebailey
Copy link
Owner

@jakebailey jakebailey commented Sep 24, 2022

This eliminates a significant number of dependencies, eliminating all
npm audit issues, speeding up npm ci by 20%, and overall making the
build faster (faster startup, direct code is faster than streams, etc)
and clearer to understand.

I'm finding it much easier to make build changes for the module
transform with this; I can more clearly indicate task dependencies and
prevent running tasks that don't need to be run.

Given we're changing our build process entirely (new deps, new steps),
it seems like this is a good time to change things up.


Please do not comment on this PR. Depending on how this set of PRs evolves, this PR's contents may change entirely based on the order of commits.

This PR is a part of a stack:

  1. Make a few changes to allow all code to be loaded as one project
  2. Explicitly reference ts namespace in tsserverlibrary
  3. Generated module conversion step - unindent
  4. Generated module conversion step - explicitify
  5. Generated module conversion step - stripNamespaces
  6. Generated module conversion step - inlineImports
  7. Generated module conversion step - .git-ignore-blame-revs
  8. Add gitlens settings suggestion
  9. Make processDiagnosticMessages generate a module
  10. Fix up linting, make lint clean
  11. Undo changes needed to load codebase into ts-morph
  12. Add JSDoc eslint rule
  13. Fix all internal JSDoc comments
  14. Convert require calls to imports
  15. Remove typescriptServices, protocol.d.ts, typescript_standalone.d.ts
  16. Get codebase building pre bundling
  17. Add build via esbuild
  18. Add dts bundling
  19. Consolidate checks that test if the current environment is Node
  20. Add ts to globalThis in run.js for convenience during debugging
  21. Rename Gulpfile to Herebyfile for improved git diff
  22. Change build system to hereby (this PR)
  23. Update baselines for corrected line endings in lib files
  24. Use jsonc-parser instead of LKG compiler in build
  25. Modernize localize script, use new XML library
  26. Don't use needsUpdate for quick tasks
  27. Remove mkdirp
  28. Export ts namespace from tsserver for hacky-post patching
  29. Directly import namespaces for improved esbuild output
  30. Ensure ts object passed to plugins contains deprecatedCompat declarations
  31. Move compiler-debug into Debug namespace, which allows the compiler to be tree shaken
  32. Remove Promise redeclaration
  33. Remove globalThisShim and globalThis modification for TypeScriptServicesFactory
  34. Disable slow CodeQL queries
  35. Remove outFiles from launch.json
  36. Remove dynamicImport and setDynamicImport

@jakebailey jakebailey force-pushed the transform-stack-commit-21 branch from 5dd39a6 to d6f739a Compare September 26, 2022 23:10
@jakebailey jakebailey force-pushed the transform-stack-commit-22 branch from 3226085 to d375574 Compare September 26, 2022 23:10
@jakebailey jakebailey force-pushed the transform-stack-commit-21 branch 5 times, most recently from 9e940bc to b3cfe4f Compare September 28, 2022 07:46
@jakebailey jakebailey changed the title Some changes to improve api-extractor output Remove configureLanguageServiceBuild/createLanguageServiceBuild Sep 28, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-22 branch from d375574 to 459e8a7 Compare September 28, 2022 07:46
@jakebailey jakebailey force-pushed the transform-stack-commit-21 branch from b3cfe4f to b143f9b Compare September 28, 2022 19:40
@jakebailey jakebailey force-pushed the transform-stack-commit-22 branch from 459e8a7 to a7df000 Compare September 28, 2022 19:40
@jakebailey jakebailey force-pushed the transform-stack-commit-21 branch from b143f9b to d051afa Compare September 28, 2022 22:03
@jakebailey jakebailey force-pushed the transform-stack-commit-22 branch from a7df000 to ffd5699 Compare September 28, 2022 22:03
@jakebailey jakebailey force-pushed the transform-stack-commit-21 branch from d051afa to 9ff95ce Compare October 3, 2022 21:41
@jakebailey jakebailey force-pushed the transform-stack-commit-22 branch from ffd5699 to 7cb5a91 Compare October 3, 2022 21:41
@jakebailey jakebailey force-pushed the transform-stack-commit-21 branch from 9ff95ce to 52b1b07 Compare October 3, 2022 23:34
@jakebailey jakebailey force-pushed the transform-stack-commit-22 branch from 7cb5a91 to 4ada7a6 Compare October 3, 2022 23:34
@jakebailey jakebailey force-pushed the transform-stack-commit-21 branch from 52b1b07 to 2c247fb Compare October 4, 2022 17:59
@jakebailey jakebailey changed the title Remove configureLanguageServiceBuild/createLanguageServiceBuild Remove generation of protocol.d.ts Oct 4, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-22 branch from 4ada7a6 to 16238e3 Compare October 4, 2022 17:59
@jakebailey jakebailey force-pushed the transform-stack-commit-21 branch from 2c247fb to 93f3463 Compare October 4, 2022 19:06
@jakebailey jakebailey changed the title Remove generation of protocol.d.ts Consolidate checks that test if the current environment is Node Oct 4, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-22 branch from 16238e3 to ca1ee4b Compare October 4, 2022 19:06
@jakebailey jakebailey force-pushed the transform-stack-commit-21 branch from 93f3463 to 34ac679 Compare October 4, 2022 19:53
@jakebailey jakebailey force-pushed the transform-stack-commit-22 branch from ca1ee4b to 948cdee Compare October 4, 2022 19:53
@jakebailey jakebailey force-pushed the transform-stack-commit-21 branch from 34ac679 to fd53551 Compare October 4, 2022 21:02
@jakebailey jakebailey changed the title Consolidate checks that test if the current environment is Node Add dts bundling Oct 4, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-22 branch from 948cdee to 7fed31f Compare October 4, 2022 21:02
@jakebailey jakebailey force-pushed the transform-stack-commit-21 branch from fd53551 to b90bad3 Compare October 4, 2022 22:19
@jakebailey jakebailey changed the title Add dts bundling Update baselines Oct 4, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-22 branch from 07e6e98 to 57a42fd Compare October 24, 2022 23:15
@jakebailey jakebailey force-pushed the transform-stack-commit-21 branch from d11a9bf to ec996eb Compare October 25, 2022 02:24
@jakebailey jakebailey force-pushed the transform-stack-commit-22 branch from 57a42fd to b937aa1 Compare October 25, 2022 02:24
@jakebailey jakebailey force-pushed the transform-stack-commit-21 branch from ec996eb to 8c7aa6d Compare October 27, 2022 04:25
@jakebailey jakebailey force-pushed the transform-stack-commit-22 branch from b937aa1 to f9dfd0d Compare October 27, 2022 04:25
@jakebailey jakebailey force-pushed the transform-stack-commit-21 branch from 8c7aa6d to e9faf2b Compare October 27, 2022 17:43
@jakebailey jakebailey force-pushed the transform-stack-commit-22 branch from f9dfd0d to 3904a77 Compare October 27, 2022 17:43
@jakebailey jakebailey force-pushed the transform-stack-commit-21 branch from e9faf2b to b9364c2 Compare October 28, 2022 02:25
@jakebailey jakebailey force-pushed the transform-stack-commit-22 branch from 3904a77 to 2a7ca51 Compare October 28, 2022 02:25
@jakebailey jakebailey force-pushed the transform-stack-commit-21 branch from b9364c2 to 4df9da7 Compare October 31, 2022 21:36
@jakebailey jakebailey force-pushed the transform-stack-commit-22 branch from 2a7ca51 to 6f6eb7a Compare October 31, 2022 21:36
@jakebailey jakebailey force-pushed the transform-stack-commit-21 branch from 4df9da7 to ac6e224 Compare November 2, 2022 00:46
@jakebailey jakebailey force-pushed the transform-stack-commit-22 branch from 6f6eb7a to d731c76 Compare November 2, 2022 00:46
@jakebailey jakebailey force-pushed the transform-stack-commit-21 branch from ac6e224 to 0170def Compare November 2, 2022 16:58
@jakebailey jakebailey force-pushed the transform-stack-commit-22 branch from d731c76 to 2737d5e Compare November 2, 2022 16:58
@jakebailey jakebailey force-pushed the transform-stack-commit-21 branch from 0170def to 87ff7a9 Compare November 2, 2022 19:48
@jakebailey jakebailey force-pushed the transform-stack-commit-22 branch from 2737d5e to 5d97edb Compare November 2, 2022 19:48
@jakebailey jakebailey force-pushed the transform-stack-commit-21 branch from 87ff7a9 to d731995 Compare November 6, 2022 21:52
@jakebailey jakebailey force-pushed the transform-stack-commit-22 branch from 5d97edb to 5622ce9 Compare November 6, 2022 21:52
@jakebailey jakebailey force-pushed the transform-stack-commit-21 branch from d731995 to 09c2a03 Compare November 6, 2022 21:58
@jakebailey jakebailey force-pushed the transform-stack-commit-22 branch from 5622ce9 to 8db2dd8 Compare November 6, 2022 21:58
@jakebailey jakebailey force-pushed the transform-stack-commit-21 branch from 09c2a03 to 4cd9643 Compare November 7, 2022 03:53
@jakebailey jakebailey force-pushed the transform-stack-commit-22 branch from 8db2dd8 to 831f6f1 Compare November 7, 2022 03:54
@jakebailey jakebailey force-pushed the transform-stack-commit-21 branch from 4cd9643 to ec50b19 Compare November 7, 2022 19:28
@jakebailey jakebailey force-pushed the transform-stack-commit-22 branch from 831f6f1 to 1dce951 Compare November 7, 2022 19:28
@jakebailey jakebailey force-pushed the transform-stack-commit-21 branch from ec50b19 to ee3f3d5 Compare November 7, 2022 21:38
This eliminates a significant number of dependencies, eliminating all
npm audit issues, speeding up `npm ci` by 20%, and overall making the
build faster (faster startup, direct code is faster than streams, etc)
and clearer to understand.

I'm finding it much easier to make build changes for the module
transform with this; I can more clearly indicate task dependencies and
prevent running tasks that don't need to be run.

Given we're changing our build process entirely (new deps, new steps),
it seems like this is a good time to change things up.
@jakebailey jakebailey force-pushed the transform-stack-commit-22 branch from 1dce951 to ab8acee Compare November 7, 2022 21:38
@jakebailey jakebailey closed this Nov 7, 2022
@jakebailey jakebailey deleted the transform-stack-commit-22 branch November 7, 2022 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant