Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gitlens settings suggestion #8

Closed
wants to merge 1 commit into from
Closed

Add gitlens settings suggestion #8

wants to merge 1 commit into from

Conversation

jakebailey
Copy link
Owner

@jakebailey jakebailey commented May 27, 2022 •
edited
Loading

While GitHub automatically uses this file if present, GitLens in VS Code
does not. Add the right option to our example settings.json for those
who use the extension.

Unfortunately, you can't leave this enabled if you want to look at the
repo without the file; git blame just crashes when the file isn't
present. I'm not sure that there's a workaround for that.

Please do not comment on this PR. Depending on how this set of PRs evolves, this PR's contents may change entirely based on the order of commits.

This PR is a part of a stack:

  1. Make a few changes to allow all code to be loaded as one project
  2. Explicitly reference ts namespace in tsserverlibrary
  3. Generated module conversion step - unindent
  4. Generated module conversion step - explicitify
  5. Generated module conversion step - stripNamespaces
  6. Generated module conversion step - inlineImports
  7. Generated module conversion step - .git-ignore-blame-revs
  8. Add gitlens settings suggestion (this PR)
  9. Make processDiagnosticMessages generate a module
  10. Fix up linting, make lint clean
  11. Undo changes needed to load codebase into ts-morph
  12. Add JSDoc eslint rule
  13. Fix all internal JSDoc comments
  14. Convert require calls to imports
  15. Remove typescriptServices, protocol.d.ts, typescript_standalone.d.ts
  16. Get codebase building pre bundling
  17. Add build via esbuild
  18. Add dts bundling
  19. Consolidate checks that test if the current environment is Node
  20. Add ts to globalThis in run.js for convenience during debugging
  21. Rename Gulpfile to Herebyfile for improved git diff
  22. Change build system to hereby
  23. Update baselines for corrected line endings in lib files
  24. Use jsonc-parser instead of LKG compiler in build
  25. Modernize localize script, use new XML library
  26. Don't use needsUpdate for quick tasks
  27. Remove mkdirp
  28. Export ts namespace from tsserver for hacky-post patching
  29. Directly import namespaces for improved esbuild output
  30. Ensure ts object passed to plugins contains deprecatedCompat declarations
  31. Move compiler-debug into Debug namespace, which allows the compiler to be tree shaken
  32. Remove Promise redeclaration
  33. Remove globalThisShim and globalThis modification for TypeScriptServicesFactory
  34. Disable slow CodeQL queries
  35. Remove outFiles from launch.json
  36. Remove dynamicImport and setDynamicImport

@jakebailey jakebailey force-pushed the transform-stack-commit-7 branch from 4bc100d to 2784548 Compare May 27, 2022 04:16
@jakebailey jakebailey changed the title [7/8] Remove a bunch of namespace uses [8/8] Remove a bunch of namespace uses May 27, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-8 branch from 1fe1940 to 2c43171 Compare May 27, 2022 04:16
@jakebailey jakebailey force-pushed the transform-stack-commit-7 branch from 2784548 to 1590a5c Compare May 27, 2022 04:23
@jakebailey jakebailey changed the title [8/8] Remove a bunch of namespace uses Remove a bunch of namespace uses May 27, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-8 branch from 2c43171 to a94650d Compare May 27, 2022 04:23
@jakebailey jakebailey force-pushed the transform-stack-commit-7 branch from 1590a5c to 9ca16e2 Compare May 27, 2022 18:02
@jakebailey jakebailey force-pushed the transform-stack-commit-8 branch from a94650d to c210b6a Compare May 27, 2022 18:02
@jakebailey jakebailey force-pushed the transform-stack-commit-7 branch from 9ca16e2 to 9a4d35c Compare May 27, 2022 18:24
@jakebailey jakebailey force-pushed the transform-stack-commit-8 branch from c210b6a to fd22919 Compare May 27, 2022 18:24
@jakebailey jakebailey force-pushed the transform-stack-commit-7 branch from 9a4d35c to 171fb6e Compare May 27, 2022 18:28
@jakebailey jakebailey force-pushed the transform-stack-commit-8 branch from fd22919 to 5a0276a Compare May 27, 2022 18:28
@jakebailey jakebailey force-pushed the transform-stack-commit-7 branch from 171fb6e to 8fad258 Compare May 27, 2022 18:35
@jakebailey jakebailey force-pushed the transform-stack-commit-8 branch from 5a0276a to 367479c Compare May 27, 2022 18:36
@jakebailey jakebailey force-pushed the transform-stack-commit-7 branch from 8fad258 to 3bced09 Compare May 27, 2022 18:36
@jakebailey jakebailey force-pushed the transform-stack-commit-8 branch from 367479c to 4831c6e Compare May 27, 2022 18:36
@jakebailey jakebailey force-pushed the transform-stack-commit-7 branch from 3bced09 to ef8b3dc Compare May 27, 2022 21:31
@jakebailey jakebailey force-pushed the transform-stack-commit-8 branch from 4831c6e to 42a5ee7 Compare May 27, 2022 21:31
@jakebailey jakebailey force-pushed the transform-stack-commit-7 branch from ef8b3dc to ff4135c Compare May 27, 2022 22:25
@jakebailey jakebailey force-pushed the transform-stack-commit-8 branch from 42a5ee7 to 8b2dc85 Compare May 27, 2022 22:25
@jakebailey jakebailey force-pushed the transform-stack-commit-7 branch from ff4135c to dbb5960 Compare May 27, 2022 22:40
@jakebailey jakebailey force-pushed the transform-stack-commit-8 branch from 8b2dc85 to 926060a Compare May 27, 2022 22:40
@jakebailey jakebailey force-pushed the transform-stack-commit-7 branch from dbb5960 to 021768d Compare May 27, 2022 23:19
@jakebailey jakebailey force-pushed the transform-stack-commit-8 branch from 926060a to 3b6e30f Compare May 27, 2022 23:19
@jakebailey jakebailey force-pushed the transform-stack-commit-7 branch from 021768d to 4ccc889 Compare May 27, 2022 23:57
@jakebailey jakebailey force-pushed the transform-stack-commit-8 branch from 3b6e30f to 73f8cc9 Compare May 27, 2022 23:57
@jakebailey jakebailey force-pushed the transform-stack-commit-7 branch from 4ccc889 to 4167e86 Compare May 28, 2022 00:52
@jakebailey jakebailey force-pushed the transform-stack-commit-8 branch from 73f8cc9 to 0192dc8 Compare May 28, 2022 00:52
@jakebailey jakebailey force-pushed the transform-stack-commit-7 branch from 4167e86 to a0680c6 Compare May 28, 2022 01:52
@jakebailey jakebailey force-pushed the transform-stack-commit-8 branch from 0192dc8 to 63c269b Compare May 28, 2022 01:52
@jakebailey jakebailey force-pushed the transform-stack-commit-8 branch from 10b0dcd to c3615b8 Compare October 25, 2022 02:23
@jakebailey jakebailey force-pushed the transform-stack-commit-7 branch from fc82a6a to c684c22 Compare October 27, 2022 04:19
@jakebailey jakebailey force-pushed the transform-stack-commit-8 branch from c3615b8 to 0c8b87f Compare October 27, 2022 04:20
@jakebailey jakebailey force-pushed the transform-stack-commit-7 branch 2 times, most recently from 957c2b2 to 95a031c Compare October 27, 2022 17:37
@jakebailey jakebailey force-pushed the transform-stack-commit-8 branch from 0c8b87f to 000cb6a Compare October 27, 2022 17:38
@jakebailey jakebailey force-pushed the transform-stack-commit-7 branch from 95a031c to ad677d7 Compare October 28, 2022 02:19
@jakebailey jakebailey force-pushed the transform-stack-commit-8 branch from 000cb6a to 72d3b72 Compare October 28, 2022 02:20
@jakebailey jakebailey force-pushed the transform-stack-commit-7 branch from ad677d7 to 19b69bd Compare October 31, 2022 21:30
@jakebailey jakebailey force-pushed the transform-stack-commit-8 branch from 72d3b72 to 500ea65 Compare October 31, 2022 21:31
@jakebailey jakebailey force-pushed the transform-stack-commit-7 branch from 19b69bd to 64f5289 Compare November 2, 2022 00:41
@jakebailey jakebailey force-pushed the transform-stack-commit-8 branch from 500ea65 to f9f3283 Compare November 2, 2022 00:41
@jakebailey jakebailey force-pushed the transform-stack-commit-7 branch from 64f5289 to 6471fc4 Compare November 2, 2022 16:52
@jakebailey jakebailey force-pushed the transform-stack-commit-8 branch from f9f3283 to 8228c04 Compare November 2, 2022 16:53
@jakebailey jakebailey force-pushed the transform-stack-commit-7 branch from 6471fc4 to 59d5d27 Compare November 2, 2022 19:43
@jakebailey jakebailey force-pushed the transform-stack-commit-8 branch from 8228c04 to 852cf4b Compare November 2, 2022 19:43
@jakebailey jakebailey force-pushed the transform-stack-commit-7 branch from 59d5d27 to e5b58c4 Compare November 6, 2022 21:52
@jakebailey jakebailey force-pushed the transform-stack-commit-8 branch from 852cf4b to 8671acf Compare November 6, 2022 21:52
@jakebailey jakebailey force-pushed the transform-stack-commit-7 branch from e5b58c4 to 89c215d Compare November 6, 2022 21:57
@jakebailey jakebailey force-pushed the transform-stack-commit-8 branch from 8671acf to 058699a Compare November 6, 2022 21:57
@jakebailey jakebailey force-pushed the transform-stack-commit-7 branch from 89c215d to 20572cc Compare November 7, 2022 03:53
@jakebailey jakebailey force-pushed the transform-stack-commit-8 branch from 058699a to e47b50d Compare November 7, 2022 03:53
@jakebailey jakebailey force-pushed the transform-stack-commit-7 branch from 20572cc to e5b97c7 Compare November 7, 2022 19:27
@jakebailey jakebailey force-pushed the transform-stack-commit-8 branch from e47b50d to 7823493 Compare November 7, 2022 19:27
@jakebailey jakebailey force-pushed the transform-stack-commit-7 branch from e5b97c7 to 050363e Compare November 7, 2022 21:37
@jakebailey
Add gitlens settings suggestion
aeff496 
While GitHub automatically uses this file if present, GitLens in VS Code
does not. Add the right option to our example settings.json for those
who use the extension.

Unfortunately, you can't leave this enabled if you want to look at the
repo _without_ the file; git blame just crashes when the file isn't
present. I'm not sure that there's a workaround for that.
@jakebailey jakebailey force-pushed the transform-stack-commit-8 branch from 7823493 to aeff496 Compare November 7, 2022 21:37
@jakebailey jakebailey deleted the branch transform-stack-commit-7 November 7, 2022 23:54
@jakebailey jakebailey closed this Nov 7, 2022
@jakebailey jakebailey deleted the transform-stack-commit-8 branch November 7, 2022 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jakebailey