Skip to content

Update baselines for corrected line endings in lib files #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update baselines for corrected line endings in lib files #25

wants to merge 1 commit into from

Conversation

jakebailey
Copy link
Owner

@jakebailey jakebailey commented Sep 26, 2022 •
edited
Loading

The old gulpfile produced lib.d.ts files with mixed newlines, thanks to
the files containing CRLF, but the gulp streams adding in LF.

Now they're all LF, which matches every other file in built / lib, but
our baselines are sensitive to this. Rerun the tests and accept them.

Please do not comment on this PR. Depending on how this set of PRs evolves, this PR's contents may change entirely based on the order of commits.

This PR is a part of a stack:

  1. Make a few changes to allow all code to be loaded as one project
  2. Explicitly reference ts namespace in tsserverlibrary
  3. Generated module conversion step - unindent
  4. Generated module conversion step - explicitify
  5. Generated module conversion step - stripNamespaces
  6. Generated module conversion step - inlineImports
  7. Generated module conversion step - .git-ignore-blame-revs
  8. Add gitlens settings suggestion
  9. Make processDiagnosticMessages generate a module
  10. Fix up linting, make lint clean
  11. Undo changes needed to load codebase into ts-morph
  12. Add JSDoc eslint rule
  13. Fix all internal JSDoc comments
  14. Convert require calls to imports
  15. Remove typescriptServices, protocol.d.ts, typescript_standalone.d.ts
  16. Get codebase building pre bundling
  17. Add build via esbuild
  18. Add dts bundling
  19. Consolidate checks that test if the current environment is Node
  20. Add ts to globalThis in run.js for convenience during debugging
  21. Rename Gulpfile to Herebyfile for improved git diff
  22. Change build system to hereby
  23. Update baselines for corrected line endings in lib files (this PR)
  24. Use jsonc-parser instead of LKG compiler in build
  25. Modernize localize script, use new XML library
  26. Don't use needsUpdate for quick tasks
  27. Remove mkdirp
  28. Export ts namespace from tsserver for hacky-post patching
  29. Directly import namespaces for improved esbuild output
  30. Ensure ts object passed to plugins contains deprecatedCompat declarations
  31. Move compiler-debug into Debug namespace, which allows the compiler to be tree shaken
  32. Remove Promise redeclaration
  33. Remove globalThisShim and globalThis modification for TypeScriptServicesFactory
  34. Disable slow CodeQL queries
  35. Remove outFiles from launch.json
  36. Remove dynamicImport and setDynamicImport

@jakebailey jakebailey force-pushed the transform-stack-commit-22 branch from d375574 to 459e8a7 Compare September 28, 2022 07:46
@jakebailey jakebailey changed the title Fix APISample tests to not depend on the existence of the ts namespace Remove generation of protocol.d.ts Sep 28, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-23 branch from ea93e92 to ee472f3 Compare September 28, 2022 07:46
@jakebailey jakebailey force-pushed the transform-stack-commit-22 branch from 459e8a7 to a7df000 Compare September 28, 2022 19:40
@jakebailey jakebailey force-pushed the transform-stack-commit-23 branch from ee472f3 to 6dac7c1 Compare September 28, 2022 19:40
@jakebailey jakebailey force-pushed the transform-stack-commit-22 branch from a7df000 to ffd5699 Compare September 28, 2022 22:03
@jakebailey jakebailey force-pushed the transform-stack-commit-23 branch from 6dac7c1 to edb57ce Compare September 28, 2022 22:04
@jakebailey jakebailey force-pushed the transform-stack-commit-22 branch from ffd5699 to 7cb5a91 Compare October 3, 2022 21:41
@jakebailey jakebailey force-pushed the transform-stack-commit-23 branch from edb57ce to b0cf9f5 Compare October 3, 2022 21:41
@jakebailey jakebailey force-pushed the transform-stack-commit-22 branch from 7cb5a91 to 4ada7a6 Compare October 3, 2022 23:34
@jakebailey jakebailey force-pushed the transform-stack-commit-23 branch from b0cf9f5 to 119e8e2 Compare October 3, 2022 23:34
@jakebailey jakebailey force-pushed the transform-stack-commit-22 branch from 4ada7a6 to 16238e3 Compare October 4, 2022 17:59
@jakebailey jakebailey changed the title Remove generation of protocol.d.ts Ensure all projects are listed in root tsconfig.json Oct 4, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-23 branch from 119e8e2 to b51bb17 Compare October 4, 2022 17:59
@jakebailey jakebailey force-pushed the transform-stack-commit-22 branch from 16238e3 to ca1ee4b Compare October 4, 2022 19:06
@jakebailey jakebailey changed the title Ensure all projects are listed in root tsconfig.json Add dts bundling Oct 4, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-23 branch from b51bb17 to b71a1dd Compare October 4, 2022 19:06
@jakebailey jakebailey force-pushed the transform-stack-commit-22 branch from ca1ee4b to 948cdee Compare October 4, 2022 19:53
@jakebailey jakebailey force-pushed the transform-stack-commit-23 branch from b71a1dd to 64c42a5 Compare October 4, 2022 19:53
@jakebailey jakebailey force-pushed the transform-stack-commit-22 branch from 948cdee to 7fed31f Compare October 4, 2022 21:02
@jakebailey jakebailey changed the title Add dts bundling Ensure all projects are listed in root tsconfig.json Oct 4, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-23 branch from 64c42a5 to b77418d Compare October 4, 2022 21:02
@jakebailey jakebailey force-pushed the transform-stack-commit-22 branch from 7fed31f to eba9674 Compare October 4, 2022 22:19
@jakebailey jakebailey force-pushed the transform-stack-commit-23 branch from b77418d to a02e266 Compare October 4, 2022 22:19
@jakebailey jakebailey force-pushed the transform-stack-commit-22 branch from eba9674 to 2b5bb22 Compare October 4, 2022 22:49
@jakebailey jakebailey changed the title Ensure all projects are listed in root tsconfig.json Update baselines Oct 4, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-23 branch from a02e266 to 03c218e Compare October 4, 2022 22:49
@jakebailey jakebailey force-pushed the transform-stack-commit-22 branch from 2b5bb22 to 743892c Compare October 4, 2022 23:14
@jakebailey jakebailey changed the title Update baselines Consolidate checks that test if the current environment is Node Oct 4, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-23 branch from 03c218e to 4a86b4c Compare October 4, 2022 23:14
@jakebailey jakebailey force-pushed the transform-stack-commit-23 branch from fb71dc7 to 2c74e88 Compare October 24, 2022 23:15
@jakebailey jakebailey force-pushed the transform-stack-commit-22 branch from 57a42fd to b937aa1 Compare October 25, 2022 02:24
@jakebailey jakebailey force-pushed the transform-stack-commit-23 branch from 2c74e88 to 2ec34bf Compare October 25, 2022 02:24
@jakebailey jakebailey force-pushed the transform-stack-commit-22 branch from b937aa1 to f9dfd0d Compare October 27, 2022 04:25
@jakebailey jakebailey force-pushed the transform-stack-commit-23 branch from 2ec34bf to 10fbfc8 Compare October 27, 2022 04:25
@jakebailey jakebailey force-pushed the transform-stack-commit-22 branch from f9dfd0d to 3904a77 Compare October 27, 2022 17:43
@jakebailey jakebailey force-pushed the transform-stack-commit-23 branch from 10fbfc8 to 2b8cf0b Compare October 27, 2022 17:43
@jakebailey jakebailey force-pushed the transform-stack-commit-22 branch from 3904a77 to 2a7ca51 Compare October 28, 2022 02:25
@jakebailey jakebailey force-pushed the transform-stack-commit-23 branch from 2b8cf0b to c113f79 Compare October 28, 2022 02:26
@jakebailey jakebailey force-pushed the transform-stack-commit-22 branch from 2a7ca51 to 6f6eb7a Compare October 31, 2022 21:36
@jakebailey jakebailey force-pushed the transform-stack-commit-23 branch from c113f79 to 0c6b69c Compare October 31, 2022 21:36
@jakebailey jakebailey force-pushed the transform-stack-commit-22 branch from 6f6eb7a to d731c76 Compare November 2, 2022 00:46
@jakebailey jakebailey force-pushed the transform-stack-commit-23 branch from 0c6b69c to fbcfb3b Compare November 2, 2022 00:47
@jakebailey jakebailey force-pushed the transform-stack-commit-22 branch from d731c76 to 2737d5e Compare November 2, 2022 16:58
@jakebailey jakebailey force-pushed the transform-stack-commit-23 branch from fbcfb3b to 03dc75c Compare November 2, 2022 16:59
@jakebailey jakebailey force-pushed the transform-stack-commit-22 branch from 2737d5e to 5d97edb Compare November 2, 2022 19:48
@jakebailey jakebailey force-pushed the transform-stack-commit-23 branch from 03dc75c to ca31a4b Compare November 2, 2022 19:49
@jakebailey jakebailey force-pushed the transform-stack-commit-22 branch from 5d97edb to 5622ce9 Compare November 6, 2022 21:52
@jakebailey jakebailey force-pushed the transform-stack-commit-23 branch from ca31a4b to 5117c83 Compare November 6, 2022 21:53
@jakebailey jakebailey force-pushed the transform-stack-commit-22 branch from 5622ce9 to 8db2dd8 Compare November 6, 2022 21:58
@jakebailey jakebailey force-pushed the transform-stack-commit-23 branch from 5117c83 to 017ae89 Compare November 6, 2022 21:58
@jakebailey jakebailey force-pushed the transform-stack-commit-22 branch from 8db2dd8 to 831f6f1 Compare November 7, 2022 03:54
@jakebailey jakebailey force-pushed the transform-stack-commit-23 branch from 017ae89 to 25958b6 Compare November 7, 2022 03:54
@jakebailey jakebailey force-pushed the transform-stack-commit-22 branch from 831f6f1 to 1dce951 Compare November 7, 2022 19:28
@jakebailey jakebailey force-pushed the transform-stack-commit-23 branch from 25958b6 to 147cd71 Compare November 7, 2022 19:28
@jakebailey
Update baselines for corrected line endings in lib files
b520f09 
The old gulpfile produced lib.d.ts files with mixed newlines, thanks to
the files containing CRLF, but the gulp streams adding in LF.

Now they're all LF, which matches every other file in built / lib, but
our baselines are sensitive to this. Rerun the tests and accept them.
@jakebailey jakebailey force-pushed the transform-stack-commit-22 branch from 1dce951 to ab8acee Compare November 7, 2022 21:38
@jakebailey jakebailey force-pushed the transform-stack-commit-23 branch from 147cd71 to b520f09 Compare November 7, 2022 21:38
@jakebailey jakebailey closed this Nov 7, 2022
@jakebailey jakebailey deleted the transform-stack-commit-23 branch November 7, 2022 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jakebailey