Skip to content

Directly import namespaces for improved esbuild output #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Directly import namespaces for improved esbuild output #31

wants to merge 1 commit into from
+122 −93

Conversation

jakebailey
Copy link
Owner

@jakebailey jakebailey commented Oct 3, 2022 •
edited
Loading

I should report this upstream, if I can manage to minimize this.

Please do not comment on this PR. Depending on how this set of PRs evolves, this PR's contents may change entirely based on the order of commits.

This PR is a part of a stack:

  1. Make a few changes to allow all code to be loaded as one project
  2. Explicitly reference ts namespace in tsserverlibrary
  3. Generated module conversion step - unindent
  4. Generated module conversion step - explicitify
  5. Generated module conversion step - stripNamespaces
  6. Generated module conversion step - inlineImports
  7. Generated module conversion step - .git-ignore-blame-revs
  8. Add gitlens settings suggestion
  9. Make processDiagnosticMessages generate a module
  10. Fix up linting, make lint clean
  11. Undo changes needed to load codebase into ts-morph
  12. Add JSDoc eslint rule
  13. Fix all internal JSDoc comments
  14. Convert require calls to imports
  15. Remove typescriptServices, protocol.d.ts, typescript_standalone.d.ts
  16. Get codebase building pre bundling
  17. Add build via esbuild
  18. Add dts bundling
  19. Consolidate checks that test if the current environment is Node
  20. Add ts to globalThis in run.js for convenience during debugging
  21. Rename Gulpfile to Herebyfile for improved git diff
  22. Change build system to hereby
  23. Update baselines for corrected line endings in lib files
  24. Use jsonc-parser instead of LKG compiler in build
  25. Modernize localize script, use new XML library
  26. Don't use needsUpdate for quick tasks
  27. Remove mkdirp
  28. Export ts namespace from tsserver for hacky-post patching
  29. Directly import namespaces for improved esbuild output (this PR)
  30. Ensure ts object passed to plugins contains deprecatedCompat declarations
  31. Move compiler-debug into Debug namespace, which allows the compiler to be tree shaken
  32. Remove Promise redeclaration
  33. Remove globalThisShim and globalThis modification for TypeScriptServicesFactory
  34. Disable slow CodeQL queries
  35. Remove outFiles from launch.json
  36. Remove dynamicImport and setDynamicImport

@jakebailey jakebailey force-pushed the transform-stack-commit-28 branch from 586a05e to 5b31ac2 Compare October 3, 2022 23:34
@jakebailey jakebailey force-pushed the transform-stack-commit-29 branch from 6f93bd7 to 638ebf8 Compare October 3, 2022 23:34
@jakebailey jakebailey force-pushed the transform-stack-commit-28 branch from 5b31ac2 to 7a5cd70 Compare October 4, 2022 18:00
@jakebailey jakebailey changed the title Add ts to globalThis for convenience during debugging Undo changes needed to load codebase into ts-morph Oct 4, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-29 branch from 638ebf8 to ddc6627 Compare October 4, 2022 18:00
@jakebailey jakebailey force-pushed the transform-stack-commit-28 branch from 7a5cd70 to d38dfd9 Compare October 4, 2022 19:07
@jakebailey jakebailey changed the title Undo changes needed to load codebase into ts-morph Restore self-compilation using built compiler in CI tests Oct 4, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-29 branch from ddc6627 to 29fa121 Compare October 4, 2022 19:07
@jakebailey jakebailey force-pushed the transform-stack-commit-28 branch from d38dfd9 to 9ca6bf1 Compare October 4, 2022 19:53
@jakebailey jakebailey force-pushed the transform-stack-commit-29 branch from 29fa121 to df3357f Compare October 4, 2022 19:54
@jakebailey jakebailey force-pushed the transform-stack-commit-28 branch 4 times, most recently from f10b875 to d3deabd Compare October 9, 2022 00:42
@jakebailey jakebailey changed the title Restore self-compilation using built compiler in CI tests Use jsonc-parser instead of LKG compiler in build Oct 9, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-29 branch from df3357f to 68929dd Compare October 9, 2022 00:42
@jakebailey jakebailey force-pushed the transform-stack-commit-28 branch from d3deabd to f0607de Compare October 10, 2022 17:10
@jakebailey jakebailey force-pushed the transform-stack-commit-29 branch from 68929dd to 5d22fdb Compare October 10, 2022 17:10
@jakebailey jakebailey force-pushed the transform-stack-commit-28 branch from f0607de to e4bcd8e Compare October 10, 2022 21:05
@jakebailey jakebailey changed the title Use jsonc-parser instead of LKG compiler in build Temporarily disable template literals Oct 10, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-29 branch 2 times, most recently from a520d61 to 5844106 Compare October 10, 2022 22:55
@jakebailey jakebailey force-pushed the transform-stack-commit-28 branch from 2925d14 to 792c2cb Compare October 10, 2022 23:13
@jakebailey jakebailey force-pushed the transform-stack-commit-29 branch from 5844106 to 2977b78 Compare October 10, 2022 23:14
@jakebailey jakebailey force-pushed the transform-stack-commit-28 branch from 792c2cb to 7006861 Compare October 10, 2022 23:31
@jakebailey jakebailey force-pushed the transform-stack-commit-29 branch from 2977b78 to a10c176 Compare October 10, 2022 23:31
@jakebailey jakebailey force-pushed the transform-stack-commit-28 branch from 7006861 to 6778006 Compare October 11, 2022 23:15
@jakebailey jakebailey force-pushed the transform-stack-commit-29 branch from a10c176 to 6b92337 Compare October 11, 2022 23:15
@jakebailey jakebailey force-pushed the transform-stack-commit-28 branch from 6778006 to b4f2f48 Compare October 11, 2022 23:31
@jakebailey jakebailey force-pushed the transform-stack-commit-29 branch from 6b92337 to b0404d2 Compare October 11, 2022 23:31
@jakebailey jakebailey force-pushed the transform-stack-commit-29 branch from e349e38 to 6a282bf Compare October 24, 2022 23:15
@jakebailey jakebailey changed the title Export ts namespace from tsserver for hacky-post patching Directly import namespaces for improved esbuild output Oct 24, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-28 branch from 0708798 to 35d4b72 Compare October 25, 2022 02:24
@jakebailey jakebailey force-pushed the transform-stack-commit-29 branch from 6a282bf to 3d30fcf Compare October 25, 2022 02:24
@jakebailey jakebailey force-pushed the transform-stack-commit-28 branch 2 times, most recently from b3b2ea3 to 6d144e1 Compare October 27, 2022 17:45
@jakebailey jakebailey force-pushed the transform-stack-commit-29 branch from 3d30fcf to 00984a4 Compare October 27, 2022 17:46
@jakebailey jakebailey force-pushed the transform-stack-commit-28 branch from 6d144e1 to a27dbb6 Compare October 28, 2022 02:28
@jakebailey jakebailey force-pushed the transform-stack-commit-29 branch from 00984a4 to f9a1913 Compare October 28, 2022 02:28
@jakebailey jakebailey force-pushed the transform-stack-commit-28 branch from a27dbb6 to cd922a6 Compare October 31, 2022 21:38
@jakebailey jakebailey force-pushed the transform-stack-commit-29 branch from f9a1913 to f2b4185 Compare October 31, 2022 21:39
@jakebailey jakebailey force-pushed the transform-stack-commit-28 branch from cd922a6 to 375e65c Compare November 2, 2022 00:49
@jakebailey jakebailey force-pushed the transform-stack-commit-29 branch from f2b4185 to f9a2bfc Compare November 2, 2022 00:49
@jakebailey jakebailey force-pushed the transform-stack-commit-28 branch from 375e65c to dbfacd0 Compare November 2, 2022 17:01
@jakebailey jakebailey force-pushed the transform-stack-commit-29 branch from f9a2bfc to 1c3f00f Compare November 2, 2022 17:01
@jakebailey jakebailey force-pushed the transform-stack-commit-28 branch from dbfacd0 to 7135ee3 Compare November 2, 2022 19:51
@jakebailey jakebailey force-pushed the transform-stack-commit-29 branch from 1c3f00f to 118bcb5 Compare November 2, 2022 19:51
@jakebailey jakebailey force-pushed the transform-stack-commit-28 branch from 7135ee3 to 500db6f Compare November 6, 2022 21:53
@jakebailey jakebailey force-pushed the transform-stack-commit-29 branch from 118bcb5 to a9f4fb1 Compare November 6, 2022 21:53
@jakebailey jakebailey force-pushed the transform-stack-commit-28 branch from 500db6f to 4a472cd Compare November 6, 2022 21:59
@jakebailey jakebailey force-pushed the transform-stack-commit-29 branch from a9f4fb1 to dcc8574 Compare November 6, 2022 21:59
@jakebailey jakebailey force-pushed the transform-stack-commit-28 branch from 4a472cd to e1fe2d4 Compare November 7, 2022 03:54
@jakebailey jakebailey force-pushed the transform-stack-commit-29 branch from dcc8574 to 3e85de5 Compare November 7, 2022 03:54
@jakebailey jakebailey force-pushed the transform-stack-commit-28 branch from e1fe2d4 to 0d0089e Compare November 7, 2022 19:28
@jakebailey jakebailey force-pushed the transform-stack-commit-29 branch from 3e85de5 to 3459e46 Compare November 7, 2022 19:28
@jakebailey jakebailey force-pushed the transform-stack-commit-28 branch from 0d0089e to 2607563 Compare November 7, 2022 21:38
@jakebailey
Directly import namespaces for improved esbuild output
fa143d7 
I should report this upstream, if I can manage to minimize this.
@jakebailey jakebailey force-pushed the transform-stack-commit-29 branch from 3459e46 to fa143d7 Compare November 7, 2022 21:38
@jakebailey jakebailey closed this Nov 7, 2022
@jakebailey jakebailey deleted the transform-stack-commit-29 branch November 7, 2022 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jakebailey