Skip to content

Add build via esbuild #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

jakebailey
Copy link
Owner

@jakebailey jakebailey commented Sep 13, 2022

This configures the existing build tasks to use esbuild by default. If
using the plain files is desired, passing --bundle=false will build
using plain files and still produce a runnable system.

This is only a basic build; a more efficient build is provided later
when gulp is replaced by hereby.


Please do not comment on this PR. Depending on how this set of PRs evolves, this PR's contents may change entirely based on the order of commits.

This PR is a part of a stack:

  1. Make a few changes to allow all code to be loaded as one project
  2. Explicitly reference ts namespace in tsserverlibrary
  3. Generated module conversion step - unindent
  4. Generated module conversion step - explicitify
  5. Generated module conversion step - stripNamespaces
  6. Generated module conversion step - inlineImports
  7. Generated module conversion step - .git-ignore-blame-revs
  8. Add gitlens settings suggestion
  9. Make processDiagnosticMessages generate a module
  10. Fix up linting, make lint clean
  11. Undo changes needed to load codebase into ts-morph
  12. Add JSDoc eslint rule
  13. Fix all internal JSDoc comments
  14. Convert require calls to imports
  15. Remove typescriptServices, protocol.d.ts, typescript_standalone.d.ts
  16. Get codebase building pre bundling
  17. Add build via esbuild (this PR)
  18. Add dts bundling
  19. Consolidate checks that test if the current environment is Node
  20. Add ts to globalThis in run.js for convenience during debugging
  21. Rename Gulpfile to Herebyfile for improved git diff
  22. Change build system to hereby
  23. Update baselines for corrected line endings in lib files
  24. Use jsonc-parser instead of LKG compiler in build
  25. Modernize localize script, use new XML library
  26. Don't use needsUpdate for quick tasks
  27. Remove mkdirp
  28. Export ts namespace from tsserver for hacky-post patching
  29. Directly import namespaces for improved esbuild output
  30. Ensure ts object passed to plugins contains deprecatedCompat declarations
  31. Move compiler-debug into Debug namespace, which allows the compiler to be tree shaken
  32. Remove Promise redeclaration
  33. Remove globalThisShim and globalThis modification for TypeScriptServicesFactory
  34. Disable slow CodeQL queries
  35. Remove outFiles from launch.json
  36. Remove dynamicImport and setDynamicImport

@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from 0b8b109 to 9890b10 Compare September 13, 2022 20:28
@jakebailey jakebailey force-pushed the transform-stack-commit-17 branch from bb294f7 to b8bbc7b Compare September 13, 2022 20:28
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from 9890b10 to d768606 Compare September 13, 2022 21:03
@jakebailey jakebailey force-pushed the transform-stack-commit-17 branch from b8bbc7b to 638f503 Compare September 13, 2022 21:03
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from d768606 to cf88621 Compare September 13, 2022 21:47
@jakebailey jakebailey force-pushed the transform-stack-commit-17 branch from 638f503 to 413881f Compare September 13, 2022 21:47
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from cf88621 to b4dd985 Compare September 13, 2022 21:58
@jakebailey jakebailey changed the title Ensure emitted d.ts files do not contain extraneous import expressions Work around api-extractor import bug Sep 13, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-17 branch from 413881f to 2f311a5 Compare September 13, 2022 21:58
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from b4dd985 to 594728a Compare September 13, 2022 23:22
@jakebailey jakebailey force-pushed the transform-stack-commit-17 branch from 2f311a5 to 2ceb74c Compare September 13, 2022 23:22
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from 594728a to f07182a Compare September 14, 2022 17:26
@jakebailey jakebailey force-pushed the transform-stack-commit-17 branch from 2ceb74c to cf0ff15 Compare September 14, 2022 17:26
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from f07182a to 8187c8b Compare September 16, 2022 04:36
@jakebailey jakebailey force-pushed the transform-stack-commit-17 branch from cf0ff15 to d5e59b6 Compare September 16, 2022 04:36
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from 8187c8b to dd3c92a Compare September 16, 2022 04:37
@jakebailey jakebailey force-pushed the transform-stack-commit-17 branch from d5e59b6 to ae931a4 Compare September 16, 2022 04:37
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from dd3c92a to a64011e Compare September 16, 2022 05:43
@jakebailey jakebailey force-pushed the transform-stack-commit-17 branch from ae931a4 to c7ebf14 Compare September 16, 2022 05:43
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from a64011e to 72bcb7d Compare September 19, 2022 20:11
@jakebailey jakebailey force-pushed the transform-stack-commit-17 branch from c7ebf14 to 5bc9cf4 Compare September 19, 2022 20:11
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from 72bcb7d to 6db765e Compare September 19, 2022 20:38
@jakebailey jakebailey force-pushed the transform-stack-commit-17 branch from 5bc9cf4 to fb8179c Compare September 19, 2022 20:38
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from 6db765e to 89a75d5 Compare September 20, 2022 05:06
@jakebailey jakebailey force-pushed the transform-stack-commit-17 branch from fb8179c to 85e19f5 Compare September 20, 2022 05:06
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from 89a75d5 to 8ce2c5c Compare September 20, 2022 05:11
@jakebailey jakebailey force-pushed the transform-stack-commit-17 branch from 85e19f5 to 65d03e2 Compare September 20, 2022 05:11
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from 8ce2c5c to b4f7f15 Compare September 20, 2022 17:00
@jakebailey jakebailey force-pushed the transform-stack-commit-17 branch from 65d03e2 to 8303e2d Compare September 20, 2022 17:00
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from b4f7f15 to 1c6e1f4 Compare September 24, 2022 16:51
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from a59c58c to ee65f9b Compare October 25, 2022 02:24
@jakebailey jakebailey force-pushed the transform-stack-commit-17 branch from 0bbd0ea to 7fc6c57 Compare October 25, 2022 02:24
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from ee65f9b to 5302707 Compare October 27, 2022 04:23
@jakebailey jakebailey force-pushed the transform-stack-commit-17 branch from 7fc6c57 to 204ee9e Compare October 27, 2022 04:23
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from 5302707 to 6ee719a Compare October 27, 2022 17:41
@jakebailey jakebailey force-pushed the transform-stack-commit-17 branch from 204ee9e to f11d2c8 Compare October 27, 2022 17:41
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from 6ee719a to fa26911 Compare October 28, 2022 02:23
@jakebailey jakebailey force-pushed the transform-stack-commit-17 branch from f11d2c8 to 76cc77c Compare October 28, 2022 02:23
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from fa26911 to 5e7fc79 Compare October 31, 2022 21:34
@jakebailey jakebailey force-pushed the transform-stack-commit-17 branch from 76cc77c to 5b26c41 Compare October 31, 2022 21:34
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from 5e7fc79 to 0749b20 Compare November 2, 2022 00:44
@jakebailey jakebailey force-pushed the transform-stack-commit-17 branch from 5b26c41 to 2934115 Compare November 2, 2022 00:44
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from 0749b20 to 2718cbf Compare November 2, 2022 16:56
@jakebailey jakebailey force-pushed the transform-stack-commit-17 branch from 2934115 to a572343 Compare November 2, 2022 16:56
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from 2718cbf to 77fb04e Compare November 2, 2022 19:46
@jakebailey jakebailey force-pushed the transform-stack-commit-17 branch from a572343 to 365ffa9 Compare November 2, 2022 19:46
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from 77fb04e to 0f31519 Compare November 6, 2022 21:52
@jakebailey jakebailey force-pushed the transform-stack-commit-17 branch from 365ffa9 to 7b7f70d Compare November 6, 2022 21:52
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from 0f31519 to 760ae38 Compare November 6, 2022 21:58
@jakebailey jakebailey force-pushed the transform-stack-commit-17 branch from 7b7f70d to 1b7362b Compare November 6, 2022 21:58
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from 760ae38 to 73d6fd0 Compare November 7, 2022 03:53
@jakebailey jakebailey force-pushed the transform-stack-commit-17 branch from 1b7362b to 2ebfb58 Compare November 7, 2022 03:53
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from 73d6fd0 to 56a4606 Compare November 7, 2022 19:27
@jakebailey jakebailey force-pushed the transform-stack-commit-17 branch from 2ebfb58 to e13f8d7 Compare November 7, 2022 19:28
@jakebailey jakebailey force-pushed the transform-stack-commit-16 branch from 56a4606 to 248fbdc Compare November 7, 2022 21:38
This configures the existing build tasks to use esbuild by default. If
using the plain files is desired, passing `--bundle=false` will build
using plain files and still produce a runnable system.

This is only a basic build; a more efficient build is provided later
when gulp is replaced by hereby.
@jakebailey jakebailey force-pushed the transform-stack-commit-17 branch from e13f8d7 to 37aa5e5 Compare November 7, 2022 21:38
@jakebailey jakebailey deleted the branch transform-stack-commit-16 November 7, 2022 23:54
@jakebailey jakebailey closed this Nov 7, 2022
@jakebailey jakebailey deleted the transform-stack-commit-17 branch November 7, 2022 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant