forked from microsoft/TypeScript
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix all internal JSDoc comments #14
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
September 13, 2022 16:52
7bb2d56
to
efaf2d7
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
September 13, 2022 16:52
739e71d
to
a31b0ef
Compare
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
September 13, 2022 20:27
efaf2d7
to
9d46c28
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
September 13, 2022 20:27
a31b0ef
to
223a3f5
Compare
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
September 13, 2022 21:02
9d46c28
to
2e6b763
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
September 13, 2022 21:02
223a3f5
to
9b79d42
Compare
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
September 13, 2022 21:47
2e6b763
to
0c5afda
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
September 13, 2022 21:47
9b79d42
to
72d390c
Compare
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
September 13, 2022 21:58
0c5afda
to
bb1c98d
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
September 13, 2022 21:58
72d390c
to
ff637c0
Compare
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
September 13, 2022 23:22
bb1c98d
to
b75e466
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
September 13, 2022 23:22
ff637c0
to
40f3f72
Compare
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
September 14, 2022 17:26
b75e466
to
980ee49
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
September 14, 2022 17:26
40f3f72
to
d4005a7
Compare
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
September 16, 2022 04:35
980ee49
to
ee7ee41
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
September 16, 2022 04:35
d4005a7
to
c80e914
Compare
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
September 16, 2022 04:37
ee7ee41
to
8debd97
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
September 16, 2022 04:37
c80e914
to
1764185
Compare
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
September 16, 2022 05:43
8debd97
to
d7091d6
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
September 16, 2022 05:43
1764185
to
ebf0539
Compare
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
September 19, 2022 20:11
d7091d6
to
7d9b69a
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
September 19, 2022 20:11
ebf0539
to
22a440a
Compare
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
September 19, 2022 20:37
7d9b69a
to
df9f2b8
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
September 19, 2022 20:38
22a440a
to
e744bbc
Compare
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
September 20, 2022 05:06
df9f2b8
to
d6035b0
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
September 20, 2022 05:06
e744bbc
to
0d8842b
Compare
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
September 20, 2022 05:10
d6035b0
to
94dedfd
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
September 20, 2022 05:10
0d8842b
to
99362b4
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
October 24, 2022 23:14
4ff5210
to
fb79c58
Compare
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
October 25, 2022 02:23
1d08a7a
to
efb82d0
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
October 25, 2022 02:23
fb79c58
to
d611199
Compare
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
October 27, 2022 04:21
efb82d0
to
67fb332
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
October 27, 2022 04:22
d611199
to
f73b5d5
Compare
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
October 27, 2022 17:39
67fb332
to
af3c30f
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
October 27, 2022 17:40
f73b5d5
to
f9a831b
Compare
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
October 28, 2022 02:21
af3c30f
to
763d093
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
October 28, 2022 02:22
f9a831b
to
55034d7
Compare
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
October 31, 2022 21:32
763d093
to
f63b759
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
October 31, 2022 21:33
55034d7
to
875c9e5
Compare
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
November 2, 2022 00:43
f63b759
to
8dd2d7a
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
November 2, 2022 00:43
875c9e5
to
a976a7b
Compare
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
November 2, 2022 16:54
8dd2d7a
to
75cbb86
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
November 2, 2022 16:55
a976a7b
to
0034428
Compare
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
November 2, 2022 19:44
75cbb86
to
80efc34
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
November 2, 2022 19:45
0034428
to
bd75883
Compare
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
November 6, 2022 21:52
80efc34
to
2141f05
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
November 6, 2022 21:52
bd75883
to
6549b80
Compare
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
November 6, 2022 21:58
2141f05
to
86f4fd2
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
November 6, 2022 21:58
6549b80
to
48ab28c
Compare
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
November 7, 2022 03:53
86f4fd2
to
41f98af
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
November 7, 2022 03:53
48ab28c
to
b71c759
Compare
jakebailey
force-pushed
the
transform-stack-commit-12
branch
from
November 7, 2022 19:27
41f98af
to
b718f5a
Compare
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
November 7, 2022 19:27
b71c759
to
dcef3b9
Compare
If these are regular comments, then they won't appear in our d.ts files. But, now we are relying on an external d.ts bundler to produce our final merged, so they need to be present in the "input" d.ts files, meaning they have to be JSDoc comments. These comments only work today because all of our builds load their TS files from scratch, so they see the actual source files and their non-JSDoc comments. The comments also need to be attached to a declaration, not floating, otherwise they won't be used by api-extractor, so move them if needed.
jakebailey
force-pushed
the
transform-stack-commit-13
branch
from
November 7, 2022 21:37
dcef3b9
to
597e4a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If these are regular comments, then they won't appear in our d.ts files.
But, now we are relying on an external d.ts bundler to produce our final
merged, so they need to be present in the "input" d.ts files, meaning
they have to be JSDoc comments.
These comments only work today because all of our builds load their TS
files from scratch, so they see the actual source files and their
non-JSDoc comments.
The comments also need to be attached to a declaration, not floating,
otherwise they won't be used by api-extractor, so move them if needed.
Please do not comment on this PR. Depending on how this set of PRs evolves, this PR's contents may change entirely based on the order of commits.
This PR is a part of a stack: