Skip to content

Generated module conversion step - inlineImports #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

jakebailey
Copy link
Owner

@jakebailey jakebailey commented May 27, 2022

This step converts as many explicit accesses as possible in favor of direct imports from the modules in which things were declared. This restores the code (as much as possible) back to how it looked originally before the explicitify step, e.g. instead of "ts.Node" and "ts.Symbol", we have just "Node" and "Symbol".


Please do not comment on this PR. Depending on how this set of PRs evolves, this PR's contents may change entirely based on the order of commits.

This PR is a part of a stack:

  1. Make a few changes to allow all code to be loaded as one project
  2. Explicitly reference ts namespace in tsserverlibrary
  3. Generated module conversion step - unindent
  4. Generated module conversion step - explicitify
  5. Generated module conversion step - stripNamespaces
  6. Generated module conversion step - inlineImports (this PR)
  7. Generated module conversion step - .git-ignore-blame-revs
  8. Add gitlens settings suggestion
  9. Make processDiagnosticMessages generate a module
  10. Fix up linting, make lint clean
  11. Undo changes needed to load codebase into ts-morph
  12. Add JSDoc eslint rule
  13. Fix all internal JSDoc comments
  14. Convert require calls to imports
  15. Remove typescriptServices, protocol.d.ts, typescript_standalone.d.ts
  16. Get codebase building pre bundling
  17. Add build via esbuild
  18. Add dts bundling
  19. Consolidate checks that test if the current environment is Node
  20. Add ts to globalThis in run.js for convenience during debugging
  21. Rename Gulpfile to Herebyfile for improved git diff
  22. Change build system to hereby
  23. Update baselines for corrected line endings in lib files
  24. Use jsonc-parser instead of LKG compiler in build
  25. Modernize localize script, use new XML library
  26. Don't use needsUpdate for quick tasks
  27. Remove mkdirp
  28. Export ts namespace from tsserver for hacky-post patching
  29. Directly import namespaces for improved esbuild output
  30. Ensure ts object passed to plugins contains deprecatedCompat declarations
  31. Move compiler-debug into Debug namespace, which allows the compiler to be tree shaken
  32. Remove Promise redeclaration
  33. Remove globalThisShim and globalThis modification for TypeScriptServicesFactory
  34. Disable slow CodeQL queries
  35. Remove outFiles from launch.json
  36. Remove dynamicImport and setDynamicImport

@jakebailey jakebailey force-pushed the transform-stack-commit-5 branch from 329f521 to 2313137 Compare May 27, 2022 04:16
@jakebailey jakebailey changed the title [5/8] Make processDiagnosticMessages generate a module [6/8] Make processDiagnosticMessages generate a module May 27, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-6 branch from 247c864 to 242d1c6 Compare May 27, 2022 04:16
@jakebailey jakebailey force-pushed the transform-stack-commit-5 branch from 2313137 to 7d283a7 Compare May 27, 2022 04:23
@jakebailey jakebailey changed the title [6/8] Make processDiagnosticMessages generate a module Make processDiagnosticMessages generate a module May 27, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-6 branch from 242d1c6 to c18fa64 Compare May 27, 2022 04:23
@jakebailey jakebailey force-pushed the transform-stack-commit-5 branch from 7d283a7 to 3a0814e Compare May 27, 2022 18:02
@jakebailey jakebailey force-pushed the transform-stack-commit-6 branch from c18fa64 to c28a0b1 Compare May 27, 2022 18:02
@jakebailey jakebailey force-pushed the transform-stack-commit-5 branch from 3a0814e to 9a87f02 Compare May 27, 2022 18:24
@jakebailey jakebailey force-pushed the transform-stack-commit-6 branch from c28a0b1 to 79541db Compare May 27, 2022 18:24
@jakebailey jakebailey force-pushed the transform-stack-commit-5 branch from 9a87f02 to cd17d62 Compare May 27, 2022 18:27
@jakebailey jakebailey force-pushed the transform-stack-commit-6 branch from 79541db to 2e6ace5 Compare May 27, 2022 18:28
@jakebailey jakebailey force-pushed the transform-stack-commit-5 branch from cd17d62 to 77acbad Compare May 27, 2022 18:35
@jakebailey jakebailey force-pushed the transform-stack-commit-6 branch from 2e6ace5 to 3b71964 Compare May 27, 2022 18:35
@jakebailey jakebailey force-pushed the transform-stack-commit-5 branch from 77acbad to 6eaa4d7 Compare May 27, 2022 18:36
@jakebailey jakebailey force-pushed the transform-stack-commit-6 branch from 3b71964 to 44341e4 Compare May 27, 2022 18:36
@jakebailey jakebailey force-pushed the transform-stack-commit-5 branch from 6eaa4d7 to 85db2a2 Compare May 27, 2022 21:31
@jakebailey jakebailey force-pushed the transform-stack-commit-6 branch from 44341e4 to 134a2c7 Compare May 27, 2022 21:31
@jakebailey jakebailey force-pushed the transform-stack-commit-5 branch from 85db2a2 to 5825466 Compare May 27, 2022 22:25
@jakebailey jakebailey force-pushed the transform-stack-commit-6 branch from 134a2c7 to cd2e1dd Compare May 27, 2022 22:25
@jakebailey jakebailey force-pushed the transform-stack-commit-5 branch from 5825466 to 0b8b75d Compare May 27, 2022 22:40
@jakebailey jakebailey force-pushed the transform-stack-commit-6 branch from cd2e1dd to 865fab5 Compare May 27, 2022 22:40
@jakebailey jakebailey force-pushed the transform-stack-commit-5 branch from 0b8b75d to ca0e93f Compare May 27, 2022 23:19
@jakebailey jakebailey force-pushed the transform-stack-commit-6 branch from 865fab5 to d6d8c40 Compare May 27, 2022 23:19
@jakebailey jakebailey force-pushed the transform-stack-commit-5 branch from ca0e93f to 449c9cf Compare May 27, 2022 23:56
@jakebailey jakebailey force-pushed the transform-stack-commit-6 branch from d6d8c40 to b74523a Compare May 27, 2022 23:57
@jakebailey jakebailey force-pushed the transform-stack-commit-5 branch from 449c9cf to 3069f69 Compare May 28, 2022 00:52
@jakebailey jakebailey force-pushed the transform-stack-commit-6 branch from b74523a to 2298837 Compare May 28, 2022 00:52
@jakebailey jakebailey force-pushed the transform-stack-commit-5 branch from 3069f69 to 4a7abaa Compare May 28, 2022 01:52
@jakebailey jakebailey force-pushed the transform-stack-commit-6 branch from 2298837 to 92fa215 Compare May 28, 2022 01:52
@jakebailey jakebailey force-pushed the transform-stack-commit-5 branch from 7329445 to 2b3e70f Compare October 27, 2022 04:18
@jakebailey jakebailey force-pushed the transform-stack-commit-6 branch from b5ac5a4 to 8cb5e90 Compare October 27, 2022 04:19
@jakebailey jakebailey force-pushed the transform-stack-commit-5 branch from 2b3e70f to 5a2ca2c Compare October 27, 2022 17:32
@jakebailey jakebailey force-pushed the transform-stack-commit-6 branch from 8cb5e90 to 7f6742c Compare October 27, 2022 17:32
@jakebailey jakebailey force-pushed the transform-stack-commit-5 branch from 5a2ca2c to 2f88db2 Compare October 27, 2022 17:36
@jakebailey jakebailey force-pushed the transform-stack-commit-6 branch from 7f6742c to baf09bf Compare October 27, 2022 17:37
@jakebailey jakebailey force-pushed the transform-stack-commit-5 branch from 2f88db2 to bdff460 Compare October 28, 2022 02:19
@jakebailey jakebailey force-pushed the transform-stack-commit-6 branch from baf09bf to 980493e Compare October 28, 2022 02:19
@jakebailey jakebailey force-pushed the transform-stack-commit-5 branch from bdff460 to 312b309 Compare October 31, 2022 21:29
@jakebailey jakebailey force-pushed the transform-stack-commit-6 branch from 980493e to 001a187 Compare October 31, 2022 21:30
@jakebailey jakebailey force-pushed the transform-stack-commit-5 branch from 312b309 to 054cfb6 Compare November 2, 2022 00:40
@jakebailey jakebailey force-pushed the transform-stack-commit-6 branch from 001a187 to 27c2ef0 Compare November 2, 2022 00:40
@jakebailey jakebailey force-pushed the transform-stack-commit-5 branch from 054cfb6 to 4b63095 Compare November 2, 2022 16:51
@jakebailey jakebailey force-pushed the transform-stack-commit-6 branch from 27c2ef0 to 3a2dd8c Compare November 2, 2022 16:52
@jakebailey jakebailey force-pushed the transform-stack-commit-5 branch from 4b63095 to f17f50a Compare November 2, 2022 19:42
@jakebailey jakebailey force-pushed the transform-stack-commit-6 branch from 3a2dd8c to 7141a5b Compare November 2, 2022 19:42
@jakebailey jakebailey force-pushed the transform-stack-commit-5 branch from f17f50a to 8e611f8 Compare November 6, 2022 21:52
@jakebailey jakebailey force-pushed the transform-stack-commit-6 branch from 7141a5b to 0d3be92 Compare November 6, 2022 21:52
@jakebailey jakebailey force-pushed the transform-stack-commit-5 branch from 8e611f8 to 70b4b5e Compare November 6, 2022 21:57
@jakebailey jakebailey force-pushed the transform-stack-commit-6 branch from 0d3be92 to 40b963a Compare November 6, 2022 21:57
@jakebailey jakebailey force-pushed the transform-stack-commit-5 branch from 70b4b5e to b48ab3d Compare November 7, 2022 03:52
@jakebailey jakebailey force-pushed the transform-stack-commit-6 branch from 40b963a to d0e4481 Compare November 7, 2022 03:53
@jakebailey jakebailey force-pushed the transform-stack-commit-5 branch from b48ab3d to 46802eb Compare November 7, 2022 19:27
@jakebailey jakebailey force-pushed the transform-stack-commit-6 branch from d0e4481 to d9d9c50 Compare November 7, 2022 19:27
This step converts as many explicit accesses as possible in favor of direct imports from the modules in which things were declared. This restores the code (as much as possible) back to how it looked originally before the explicitify step, e.g. instead of "ts.Node" and "ts.Symbol", we have just "Node" and "Symbol".
@jakebailey jakebailey force-pushed the transform-stack-commit-5 branch from 46802eb to ec16755 Compare November 7, 2022 21:37
@jakebailey jakebailey force-pushed the transform-stack-commit-6 branch from d9d9c50 to d762022 Compare November 7, 2022 21:37
@jakebailey jakebailey deleted the branch transform-stack-commit-5 November 7, 2022 23:54
@jakebailey jakebailey closed this Nov 7, 2022
@jakebailey jakebailey deleted the transform-stack-commit-6 branch November 7, 2022 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant