Skip to content

Remove dynamicImport and setDynamicImport #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Remove dynamicImport and setDynamicImport #43

wants to merge 1 commit into from

Conversation

jakebailey
Copy link
Owner

@jakebailey jakebailey commented Oct 10, 2022 •
edited
Loading

It turns out that the import expression won't actally be rewritten by
esbuild, so we can just write it directly.

While this won't help CJS emit, that already didn't work anyway, and
it's likely that this code is going to be moved outside of the codebase
into VS Code or a shared package elsewhere anyway.

Please do not comment on this PR. Depending on how this set of PRs evolves, this PR's contents may change entirely based on the order of commits.

This PR is a part of a stack:

  1. Make a few changes to allow all code to be loaded as one project
  2. Explicitly reference ts namespace in tsserverlibrary
  3. Generated module conversion step - unindent
  4. Generated module conversion step - explicitify
  5. Generated module conversion step - stripNamespaces
  6. Generated module conversion step - inlineImports
  7. Generated module conversion step - .git-ignore-blame-revs
  8. Add gitlens settings suggestion
  9. Make processDiagnosticMessages generate a module
  10. Fix up linting, make lint clean
  11. Undo changes needed to load codebase into ts-morph
  12. Add JSDoc eslint rule
  13. Fix all internal JSDoc comments
  14. Convert require calls to imports
  15. Remove typescriptServices, protocol.d.ts, typescript_standalone.d.ts
  16. Get codebase building pre bundling
  17. Add build via esbuild
  18. Add dts bundling
  19. Consolidate checks that test if the current environment is Node
  20. Add ts to globalThis in run.js for convenience during debugging
  21. Rename Gulpfile to Herebyfile for improved git diff
  22. Change build system to hereby
  23. Update baselines for corrected line endings in lib files
  24. Use jsonc-parser instead of LKG compiler in build
  25. Modernize localize script, use new XML library
  26. Don't use needsUpdate for quick tasks
  27. Remove mkdirp
  28. Export ts namespace from tsserver for hacky-post patching
  29. Directly import namespaces for improved esbuild output
  30. Ensure ts object passed to plugins contains deprecatedCompat declarations
  31. Move compiler-debug into Debug namespace, which allows the compiler to be tree shaken
  32. Remove Promise redeclaration
  33. Remove globalThisShim and globalThis modification for TypeScriptServicesFactory
  34. Disable slow CodeQL queries
  35. Remove outFiles from launch.json
  36. Remove dynamicImport and setDynamicImport (this PR)

@jakebailey jakebailey force-pushed the transform-stack-commit-35 branch from c7de568 to ffc6ec7 Compare October 10, 2022 22:54
@jakebailey jakebailey force-pushed the transform-stack-commit-36 branch from a2bb6c6 to 5d68bf1 Compare October 10, 2022 22:54
@jakebailey jakebailey force-pushed the transform-stack-commit-35 branch from ffc6ec7 to 3969a14 Compare October 10, 2022 23:14
@jakebailey jakebailey force-pushed the transform-stack-commit-36 branch from 5d68bf1 to f1fe3ba Compare October 10, 2022 23:14
@jakebailey jakebailey force-pushed the transform-stack-commit-35 branch from 3969a14 to da4179f Compare October 10, 2022 23:31
@jakebailey jakebailey changed the title Don't check needsUpdate for localize, now that it is fast Switch to faster XML parsing library for localize Oct 10, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-36 branch from f1fe3ba to e4dc113 Compare October 10, 2022 23:31
@jakebailey jakebailey force-pushed the transform-stack-commit-35 branch from da4179f to 9096423 Compare October 11, 2022 23:16
@jakebailey jakebailey force-pushed the transform-stack-commit-36 branch from e4dc113 to cf57a08 Compare October 11, 2022 23:16
@jakebailey jakebailey force-pushed the transform-stack-commit-35 branch from 9096423 to 8016f34 Compare October 11, 2022 23:32
@jakebailey jakebailey force-pushed the transform-stack-commit-36 branch from cf57a08 to 0218820 Compare October 11, 2022 23:32
@jakebailey jakebailey force-pushed the transform-stack-commit-35 branch from 8016f34 to c82877a Compare October 12, 2022 22:48
@jakebailey jakebailey force-pushed the transform-stack-commit-36 branch from 0218820 to 1656093 Compare October 12, 2022 22:48
@jakebailey jakebailey force-pushed the transform-stack-commit-35 branch from c82877a to 21bb51f Compare October 14, 2022 19:36
@jakebailey jakebailey changed the title Switch to faster XML parsing library for localize Don't use needsUpdate for quick tasks Oct 14, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-36 branch from 1656093 to 4375119 Compare October 14, 2022 19:36
@jakebailey jakebailey force-pushed the transform-stack-commit-35 branch from 21bb51f to 76abc2c Compare October 14, 2022 21:21
@jakebailey jakebailey changed the title Don't use needsUpdate for quick tasks Remove mkdirp Oct 14, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-36 branch from 4375119 to 674d9ae Compare October 14, 2022 21:21
@jakebailey jakebailey force-pushed the transform-stack-commit-35 branch from 76abc2c to d5045ae Compare October 14, 2022 22:28
@jakebailey jakebailey force-pushed the transform-stack-commit-36 branch from 674d9ae to 0b3648c Compare October 14, 2022 22:28
@jakebailey jakebailey force-pushed the transform-stack-commit-35 branch from d5045ae to 82a6121 Compare October 14, 2022 23:35
@jakebailey jakebailey force-pushed the transform-stack-commit-36 branch from 0b3648c to 37d8997 Compare October 14, 2022 23:35
@jakebailey jakebailey force-pushed the transform-stack-commit-35 branch from 82a6121 to 3382b8e Compare October 20, 2022 00:50
@jakebailey jakebailey changed the title Remove mkdirp Replace all files arrays with include wildcards Oct 20, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-36 branch from 37d8997 to 053f738 Compare October 20, 2022 00:50
@jakebailey jakebailey force-pushed the transform-stack-commit-35 branch from 3382b8e to 13fd5ce Compare October 20, 2022 01:25
@jakebailey jakebailey changed the title Replace all files arrays with include wildcards Build fixups Oct 20, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-36 branch from 053f738 to a737ae8 Compare October 20, 2022 01:25
@jakebailey jakebailey force-pushed the transform-stack-commit-35 branch from 13fd5ce to 59e7b6f Compare October 20, 2022 20:14
@jakebailey jakebailey force-pushed the transform-stack-commit-36 branch from 63285f4 to 4035673 Compare October 20, 2022 22:04
@jakebailey jakebailey force-pushed the transform-stack-commit-35 branch from 2e54cad to b040906 Compare October 21, 2022 23:26
@jakebailey jakebailey force-pushed the transform-stack-commit-36 branch from 4035673 to 0de4c0c Compare October 21, 2022 23:26
@jakebailey jakebailey force-pushed the transform-stack-commit-35 branch from b040906 to ef3b6a0 Compare October 22, 2022 17:00
@jakebailey jakebailey force-pushed the transform-stack-commit-36 branch from 0de4c0c to ac438bc Compare October 22, 2022 17:00
@jakebailey jakebailey force-pushed the transform-stack-commit-35 branch from ef3b6a0 to 72b92d6 Compare October 23, 2022 00:11
@jakebailey jakebailey force-pushed the transform-stack-commit-36 branch from ac438bc to 5245654 Compare October 23, 2022 00:11
@jakebailey jakebailey force-pushed the transform-stack-commit-35 branch from 72b92d6 to c02560b Compare October 24, 2022 04:39
@jakebailey jakebailey changed the title Build fixups Disable slow CodeQL queries Oct 24, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-36 branch from 5245654 to 1e4f974 Compare October 24, 2022 04:39
@jakebailey jakebailey force-pushed the transform-stack-commit-35 branch 4 times, most recently from 51779c7 to 4d427a0 Compare October 28, 2022 02:30
@jakebailey jakebailey force-pushed the transform-stack-commit-35 branch 7 times, most recently from dbe3815 to 89b9d71 Compare November 7, 2022 03:54
@jakebailey jakebailey changed the title Disable slow CodeQL queries Remove dynamicImport and setDynamicImport Nov 7, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-36 branch from 1e4f974 to 06cf9a0 Compare November 7, 2022 03:54
@jakebailey jakebailey force-pushed the transform-stack-commit-35 branch from 89b9d71 to d2c8b44 Compare November 7, 2022 19:29
@jakebailey jakebailey force-pushed the transform-stack-commit-36 branch from 06cf9a0 to f200724 Compare November 7, 2022 19:29
@jakebailey jakebailey force-pushed the transform-stack-commit-35 branch from d2c8b44 to 4eab497 Compare November 7, 2022 21:39
@jakebailey
Remove dynamicImport and setDynamicImport
484acf1 
It turns out that the import expression won't actally be rewritten by
esbuild, so we can just write it directly.

While this won't help CJS emit, that already didn't work anyway, and
it's likely that this code is going to be moved outside of the codebase
into VS Code or a shared package elsewhere anyway.
@jakebailey jakebailey force-pushed the transform-stack-commit-36 branch from f200724 to 484acf1 Compare November 7, 2022 21:39
@jakebailey jakebailey closed this Nov 7, 2022
@jakebailey jakebailey deleted the transform-stack-commit-36 branch November 7, 2022 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jakebailey