forked from microsoft/TypeScript
-
Notifications
You must be signed in to change notification settings - Fork 0
Remove dynamicImport and setDynamicImport #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c7de568 to
ffc6ec7
Compare
a2bb6c6 to
5d68bf1
Compare
ffc6ec7 to
3969a14
Compare
5d68bf1 to
f1fe3ba
Compare
3969a14 to
da4179f
Compare
f1fe3ba to
e4dc113
Compare
da4179f to
9096423
Compare
e4dc113 to
cf57a08
Compare
9096423 to
8016f34
Compare
cf57a08 to
0218820
Compare
8016f34 to
c82877a
Compare
0218820 to
1656093
Compare
c82877a to
21bb51f
Compare
1656093 to
4375119
Compare
21bb51f to
76abc2c
Compare
4375119 to
674d9ae
Compare
76abc2c to
d5045ae
Compare
674d9ae to
0b3648c
Compare
d5045ae to
82a6121
Compare
0b3648c to
37d8997
Compare
82a6121 to
3382b8e
Compare
37d8997 to
053f738
Compare
3382b8e to
13fd5ce
Compare
053f738 to
a737ae8
Compare
13fd5ce to
59e7b6f
Compare
63285f4 to
4035673
Compare
2e54cad to
b040906
Compare
4035673 to
0de4c0c
Compare
b040906 to
ef3b6a0
Compare
0de4c0c to
ac438bc
Compare
ef3b6a0 to
72b92d6
Compare
ac438bc to
5245654
Compare
72b92d6 to
c02560b
Compare
5245654 to
1e4f974
Compare
51779c7 to
4d427a0
Compare
dbe3815 to
89b9d71
Compare
1e4f974 to
06cf9a0
Compare
89b9d71 to
d2c8b44
Compare
06cf9a0 to
f200724
Compare
d2c8b44 to
4eab497
Compare
It turns out that the import expression won't actally be rewritten by esbuild, so we can just write it directly. While this won't help CJS emit, that already didn't work anyway, and it's likely that this code is going to be moved outside of the codebase into VS Code or a shared package elsewhere anyway.
f200724 to
484acf1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that the import expression won't actally be rewritten by
esbuild, so we can just write it directly.
While this won't help CJS emit, that already didn't work anyway, and
it's likely that this code is going to be moved outside of the codebase
into VS Code or a shared package elsewhere anyway.
Please do not comment on this PR. Depending on how this set of PRs evolves, this PR's contents may change entirely based on the order of commits.
This PR is a part of a stack: