Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated module conversion step - unindent #3

Closed
wants to merge 1 commit into from
Closed

Generated module conversion step - unindent #3

wants to merge 1 commit into from

Conversation

jakebailey
Copy link
Owner

@jakebailey jakebailey commented May 14, 2022 •
edited
Loading

This step makes further commits look clearer by unindenting all of the top level namespaces preemptively.

Please do not comment on this PR. Depending on how this set of PRs evolves, this PR's contents may change entirely based on the order of commits.

This PR is a part of a stack:

  1. Make a few changes to allow all code to be loaded as one project
  2. Explicitly reference ts namespace in tsserverlibrary
  3. Generated module conversion step - unindent (this PR)
  4. Generated module conversion step - explicitify
  5. Generated module conversion step - stripNamespaces
  6. Generated module conversion step - inlineImports
  7. Generated module conversion step - .git-ignore-blame-revs
  8. Add gitlens settings suggestion
  9. Make processDiagnosticMessages generate a module
  10. Fix up linting, make lint clean
  11. Undo changes needed to load codebase into ts-morph
  12. Add JSDoc eslint rule
  13. Fix all internal JSDoc comments
  14. Convert require calls to imports
  15. Remove typescriptServices, protocol.d.ts, typescript_standalone.d.ts
  16. Get codebase building pre bundling
  17. Add build via esbuild
  18. Add dts bundling
  19. Consolidate checks that test if the current environment is Node
  20. Add ts to globalThis in run.js for convenience during debugging
  21. Rename Gulpfile to Herebyfile for improved git diff
  22. Change build system to hereby
  23. Update baselines for corrected line endings in lib files
  24. Use jsonc-parser instead of LKG compiler in build
  25. Modernize localize script, use new XML library
  26. Don't use needsUpdate for quick tasks
  27. Remove mkdirp
  28. Export ts namespace from tsserver for hacky-post patching
  29. Directly import namespaces for improved esbuild output
  30. Ensure ts object passed to plugins contains deprecatedCompat declarations
  31. Move compiler-debug into Debug namespace, which allows the compiler to be tree shaken
  32. Remove Promise redeclaration
  33. Remove globalThisShim and globalThis modification for TypeScriptServicesFactory
  34. Disable slow CodeQL queries
  35. Remove outFiles from launch.json
  36. Remove dynamicImport and setDynamicImport

@jakebailey jakebailey force-pushed the transform-stack-commit-2 branch from e13cf71 to ebf5725 Compare May 14, 2022 22:18
@jakebailey jakebailey force-pushed the transform-stack-commit-3 branch from 1e12bf2 to f846641 Compare May 14, 2022 22:18
@jakebailey jakebailey force-pushed the transform-stack-commit-2 branch from ebf5725 to a4af808 Compare May 14, 2022 22:19
@jakebailey jakebailey force-pushed the transform-stack-commit-3 branch from f846641 to ac0cefd Compare May 14, 2022 22:19
@jakebailey jakebailey force-pushed the transform-stack-commit-2 branch from a4af808 to 4cd003d Compare May 14, 2022 22:19
@jakebailey jakebailey force-pushed the transform-stack-commit-3 branch from ac0cefd to bbaf149 Compare May 14, 2022 22:19
@jakebailey jakebailey force-pushed the transform-stack-commit-2 branch from 4cd003d to 1e02836 Compare May 14, 2022 22:21
@jakebailey jakebailey force-pushed the transform-stack-commit-3 branch from bbaf149 to c5e0dc1 Compare May 14, 2022 22:22
@jakebailey jakebailey force-pushed the transform-stack-commit-2 branch from 1e02836 to 8f83dbb Compare May 14, 2022 22:27
@jakebailey jakebailey force-pushed the transform-stack-commit-3 branch from c5e0dc1 to 1ad68ac Compare May 14, 2022 22:27
@jakebailey jakebailey force-pushed the transform-stack-commit-2 branch from 8f83dbb to a0d1d6b Compare May 14, 2022 22:27
@jakebailey jakebailey force-pushed the transform-stack-commit-3 branch from 1ad68ac to ef15a20 Compare May 14, 2022 22:27
@jakebailey jakebailey force-pushed the transform-stack-commit-2 branch from a0d1d6b to 461a72f Compare May 14, 2022 22:28
@jakebailey jakebailey force-pushed the transform-stack-commit-3 branch from ef15a20 to 60dae0f Compare May 14, 2022 22:28
@jakebailey jakebailey force-pushed the transform-stack-commit-2 branch from 461a72f to 29d02b1 Compare May 14, 2022 22:28
@jakebailey jakebailey force-pushed the transform-stack-commit-3 branch from 60dae0f to 1d0ae84 Compare May 14, 2022 22:28
@jakebailey jakebailey force-pushed the transform-stack-commit-2 branch from 29d02b1 to bb65665 Compare May 15, 2022 02:24
@jakebailey jakebailey force-pushed the transform-stack-commit-3 branch from 1d0ae84 to 9f480b6 Compare May 15, 2022 02:24
@jakebailey jakebailey force-pushed the transform-stack-commit-2 branch from bb65665 to 98c1e64 Compare May 15, 2022 02:25
@jakebailey jakebailey force-pushed the transform-stack-commit-3 branch from 9f480b6 to bf0ee60 Compare May 15, 2022 02:25
@jakebailey jakebailey force-pushed the transform-stack-commit-2 branch from 98c1e64 to a70d5bd Compare May 15, 2022 02:28
@jakebailey jakebailey force-pushed the transform-stack-commit-3 branch from bf0ee60 to de9dede Compare May 15, 2022 02:28
@jakebailey jakebailey force-pushed the transform-stack-commit-2 branch from a70d5bd to e864b41 Compare May 15, 2022 02:48
@jakebailey jakebailey force-pushed the transform-stack-commit-3 branch from de9dede to aa41b1f Compare May 15, 2022 02:48
@jakebailey jakebailey force-pushed the transform-stack-commit-2 branch from e864b41 to 6f4e7a6 Compare May 15, 2022 03:04
@jakebailey jakebailey force-pushed the transform-stack-commit-3 branch from aa41b1f to 4a471fd Compare May 15, 2022 03:04
@jakebailey jakebailey force-pushed the transform-stack-commit-2 branch from 6f4e7a6 to d197ea1 Compare May 17, 2022 00:43
@jakebailey jakebailey changed the title UNINDENT CONVERSION STEP - stripNamespaces May 17, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-3 branch from 4a471fd to 9683b0a Compare May 17, 2022 00:43
@jakebailey jakebailey force-pushed the transform-stack-commit-2 branch from d197ea1 to 35432e3 Compare May 17, 2022 01:05
@jakebailey jakebailey force-pushed the transform-stack-commit-2 branch from 6f36b56 to 1f8119b Compare October 27, 2022 04:17
@jakebailey jakebailey force-pushed the transform-stack-commit-3 branch from 6a98718 to 23c7eee Compare October 27, 2022 04:18
@jakebailey jakebailey force-pushed the transform-stack-commit-2 branch from 1f8119b to ef56134 Compare October 27, 2022 17:30
@jakebailey jakebailey force-pushed the transform-stack-commit-3 branch from 23c7eee to f98b049 Compare October 27, 2022 17:31
@jakebailey jakebailey force-pushed the transform-stack-commit-2 branch from ef56134 to 1409555 Compare October 27, 2022 17:35
@jakebailey jakebailey force-pushed the transform-stack-commit-3 branch from f98b049 to 7ce18fa Compare October 27, 2022 17:36
@jakebailey jakebailey force-pushed the transform-stack-commit-2 branch from 1409555 to 39243ff Compare October 28, 2022 02:17
@jakebailey jakebailey force-pushed the transform-stack-commit-3 branch from 7ce18fa to e804a13 Compare October 28, 2022 02:18
@jakebailey jakebailey force-pushed the transform-stack-commit-2 branch from 39243ff to 6f0d69d Compare October 31, 2022 21:28
@jakebailey jakebailey force-pushed the transform-stack-commit-3 branch from e804a13 to a67847a Compare October 31, 2022 21:28
@jakebailey jakebailey force-pushed the transform-stack-commit-2 branch from 6f0d69d to 410dbe7 Compare November 2, 2022 00:39
@jakebailey jakebailey force-pushed the transform-stack-commit-3 branch from a67847a to 65a391d Compare November 2, 2022 00:39
@jakebailey jakebailey force-pushed the transform-stack-commit-2 branch from 410dbe7 to b96c9ec Compare November 2, 2022 16:50
@jakebailey jakebailey force-pushed the transform-stack-commit-3 branch from 65a391d to bfc0a00 Compare November 2, 2022 16:51
@jakebailey jakebailey force-pushed the transform-stack-commit-2 branch from b96c9ec to 48f996c Compare November 2, 2022 19:40
@jakebailey jakebailey force-pushed the transform-stack-commit-3 branch from bfc0a00 to 6798fd4 Compare November 2, 2022 19:41
@jakebailey jakebailey force-pushed the transform-stack-commit-2 branch from 48f996c to 21e44de Compare November 6, 2022 21:51
@jakebailey jakebailey force-pushed the transform-stack-commit-3 branch from 6798fd4 to 81ff1b4 Compare November 6, 2022 21:51
@jakebailey jakebailey force-pushed the transform-stack-commit-2 branch from 21e44de to ec6d244 Compare November 6, 2022 21:57
@jakebailey jakebailey force-pushed the transform-stack-commit-3 branch from 81ff1b4 to 6b4080a Compare November 6, 2022 21:57
@jakebailey jakebailey force-pushed the transform-stack-commit-2 branch from ec6d244 to 33147cb Compare November 7, 2022 03:52
@jakebailey jakebailey force-pushed the transform-stack-commit-3 branch from 6b4080a to fb39d27 Compare November 7, 2022 03:52
@jakebailey jakebailey force-pushed the transform-stack-commit-2 branch from 33147cb to 24aae59 Compare November 7, 2022 19:27
@jakebailey jakebailey force-pushed the transform-stack-commit-3 branch from fb39d27 to 1de6c28 Compare November 7, 2022 19:27
@jakebailey jakebailey force-pushed the transform-stack-commit-2 branch from 24aae59 to 31e6de8 Compare November 7, 2022 21:37
@jakebailey
Generated module conversion step - unindent
f533e5f 
This step makes further commits look clearer by unindenting all of the top level namespaces preemptively.
@jakebailey jakebailey force-pushed the transform-stack-commit-3 branch from 1de6c28 to f533e5f Compare November 7, 2022 21:37
@jakebailey jakebailey deleted the branch transform-stack-commit-2 November 7, 2022 23:54
@jakebailey jakebailey closed this Nov 7, 2022
@jakebailey jakebailey deleted the transform-stack-commit-3 branch November 7, 2022 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jakebailey