forked from microsoft/TypeScript
-
Notifications
You must be signed in to change notification settings - Fork 0
Add JSDoc eslint rule #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cd1a0b4
to
14a4530
Compare
ce4b3b5
to
0810976
Compare
14a4530
to
c8c2f6e
Compare
0810976
to
7bb2d56
Compare
c8c2f6e
to
a3f6679
Compare
7bb2d56
to
efaf2d7
Compare
a3f6679
to
e1cf7e2
Compare
efaf2d7
to
9d46c28
Compare
e1cf7e2
to
1710f42
Compare
9d46c28
to
2e6b763
Compare
1710f42
to
4c9d190
Compare
2e6b763
to
0c5afda
Compare
4c9d190
to
47cd884
Compare
0c5afda
to
bb1c98d
Compare
47cd884
to
48837fd
Compare
bb1c98d
to
b75e466
Compare
48837fd
to
34b5a83
Compare
b75e466
to
980ee49
Compare
34b5a83
to
572883e
Compare
980ee49
to
ee7ee41
Compare
572883e
to
89e8b12
Compare
ee7ee41
to
8debd97
Compare
89e8b12
to
ca17f3f
Compare
8debd97
to
d7091d6
Compare
ca17f3f
to
a91f9b4
Compare
d7091d6
to
7d9b69a
Compare
a91f9b4
to
1b1c620
Compare
763d093
to
f63b759
Compare
f1a12d2
to
9cbb403
Compare
f63b759
to
8dd2d7a
Compare
9cbb403
to
fd1d9d5
Compare
8dd2d7a
to
75cbb86
Compare
fd1d9d5
to
fde6c03
Compare
75cbb86
to
80efc34
Compare
fde6c03
to
b71dbbe
Compare
80efc34
to
2141f05
Compare
b71dbbe
to
c927b0b
Compare
2141f05
to
86f4fd2
Compare
c927b0b
to
b6458c5
Compare
86f4fd2
to
41f98af
Compare
This step makes further commits look clearer by unindenting all of the top level namespaces preemptively.
This step makes all implicit namespace accesses explicit, e.g. "Node" turns into "ts.Node".
This step converts each file into an exported module by hoisting the namespace bodies into the global scope and transferring internal markers down onto declarations as needed. The namespaces are reconstructed as "barrel"-style modules, which are identical to the old namespace objects in structure. These reconstructed namespaces are then imported in the newly module-ified files, making existing expressions like "ts." valid.
This step converts as many explicit accesses as possible in favor of direct imports from the modules in which things were declared. This restores the code (as much as possible) back to how it looked originally before the explicitify step, e.g. instead of "ts.Node" and "ts.Symbol", we have just "Node" and "Symbol".
While GitHub automatically uses this file if present, GitLens in VS Code does not. Add the right option to our example settings.json for those who use the extension. Unfortunately, you can't leave this enabled if you want to look at the repo _without_ the file; git blame just crashes when the file isn't present. I'm not sure that there's a workaround for that.
Now that we are modules, there's no reason to ban multiple namespaces per file; each file is its own scope and declaring a namespace won't merge it into any other files.
See the next commit for a more fleshed-out description.
b6458c5
to
4584e55
Compare
41f98af
to
b718f5a
Compare
4584e55
to
b1fc250
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the next commit for a more fleshed-out description.
Please do not comment on this PR. Depending on how this set of PRs evolves, this PR's contents may change entirely based on the order of commits.
This PR is a part of a stack: