forked from microsoft/TypeScript
-
Notifications
You must be signed in to change notification settings - Fork 0
Use jsonc-parser instead of LKG compiler in build #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6dac7c1 to
edb57ce
Compare
2c19997 to
9028920
Compare
edb57ce to
b0cf9f5
Compare
9028920 to
6d3661d
Compare
b0cf9f5 to
119e8e2
Compare
6d3661d to
b066bd6
Compare
119e8e2 to
b51bb17
Compare
b066bd6 to
1f08f8c
Compare
b51bb17 to
b71a1dd
Compare
1f08f8c to
072f98b
Compare
b71a1dd to
64c42a5
Compare
072f98b to
497c663
Compare
64c42a5 to
b77418d
Compare
497c663 to
792b782
Compare
b77418d to
a02e266
Compare
792b782 to
0f369f3
Compare
a02e266 to
03c218e
Compare
0f369f3 to
9f5b4d3
Compare
03c218e to
4a86b4c
Compare
9f5b4d3 to
751f57a
Compare
4a86b4c to
0fb1ba9
Compare
751f57a to
6578dbb
Compare
0fb1ba9 to
e9d7918
Compare
6578dbb to
48673d2
Compare
e9d7918 to
38e1f6f
Compare
1d5bed3 to
c28d68c
Compare
2c74e88 to
2ec34bf
Compare
c28d68c to
a9b166d
Compare
2ec34bf to
10fbfc8
Compare
a9b166d to
b52815c
Compare
10fbfc8 to
2b8cf0b
Compare
b52815c to
8431802
Compare
2b8cf0b to
c113f79
Compare
8431802 to
57d2fef
Compare
c113f79 to
0c6b69c
Compare
57d2fef to
f73c69a
Compare
0c6b69c to
fbcfb3b
Compare
f73c69a to
b033d0c
Compare
fbcfb3b to
03dc75c
Compare
b033d0c to
9f8832c
Compare
03dc75c to
ca31a4b
Compare
9f8832c to
25e6634
Compare
ca31a4b to
5117c83
Compare
25e6634 to
6e69116
Compare
5117c83 to
017ae89
Compare
6e69116 to
6715a98
Compare
017ae89 to
25958b6
Compare
6715a98 to
c497480
Compare
25958b6 to
147cd71
Compare
c497480 to
058b59f
Compare
147cd71 to
b520f09
Compare
Profiling the build roughly half of the time spent loading the build is spent importing typescript.js, for this one function. Since this stack is already adding required devDependencies, switch readJson to use jsonc-parser (published by the VS Code team), rather than importing the entire LKG typescript.js library.
058b59f to
fe08021
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Profiling the build roughly half of the time spent loading the
build is spent importing typescript.js, for this one function.
Since this stack is already adding required devDependencies, switch
readJson to use jsonc-parser (published by the VS Code team), rather
than importing the entire LKG typescript.js library.
Please do not comment on this PR. Depending on how this set of PRs evolves, this PR's contents may change entirely based on the order of commits.
This PR is a part of a stack: