forked from microsoft/TypeScript
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use jsonc-parser instead of LKG compiler in build #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakebailey
force-pushed
the
transform-stack-commit-23
branch
from
September 28, 2022 22:04
6dac7c1
to
edb57ce
Compare
jakebailey
force-pushed
the
transform-stack-commit-24
branch
from
September 28, 2022 22:04
2c19997
to
9028920
Compare
jakebailey
force-pushed
the
transform-stack-commit-23
branch
from
October 3, 2022 21:41
edb57ce
to
b0cf9f5
Compare
jakebailey
force-pushed
the
transform-stack-commit-24
branch
from
October 3, 2022 21:41
9028920
to
6d3661d
Compare
jakebailey
force-pushed
the
transform-stack-commit-23
branch
from
October 3, 2022 23:34
b0cf9f5
to
119e8e2
Compare
jakebailey
force-pushed
the
transform-stack-commit-24
branch
from
October 3, 2022 23:34
6d3661d
to
b066bd6
Compare
jakebailey
force-pushed
the
transform-stack-commit-23
branch
from
October 4, 2022 17:59
119e8e2
to
b51bb17
Compare
jakebailey
force-pushed
the
transform-stack-commit-24
branch
from
October 4, 2022 17:59
b066bd6
to
1f08f8c
Compare
jakebailey
force-pushed
the
transform-stack-commit-23
branch
from
October 4, 2022 19:06
b51bb17
to
b71a1dd
Compare
jakebailey
changed the title
Clean up some TODOs
Ensure all projects are listed in root tsconfig.json
Oct 4, 2022
jakebailey
force-pushed
the
transform-stack-commit-24
branch
from
October 4, 2022 19:06
1f08f8c
to
072f98b
Compare
jakebailey
force-pushed
the
transform-stack-commit-23
branch
from
October 4, 2022 19:53
b71a1dd
to
64c42a5
Compare
jakebailey
force-pushed
the
transform-stack-commit-24
branch
from
October 4, 2022 19:53
072f98b
to
497c663
Compare
jakebailey
force-pushed
the
transform-stack-commit-23
branch
from
October 4, 2022 21:02
64c42a5
to
b77418d
Compare
jakebailey
changed the title
Ensure all projects are listed in root tsconfig.json
Clean up some TODOs
Oct 4, 2022
jakebailey
force-pushed
the
transform-stack-commit-24
branch
from
October 4, 2022 21:02
497c663
to
792b782
Compare
jakebailey
force-pushed
the
transform-stack-commit-23
branch
from
October 4, 2022 22:19
b77418d
to
a02e266
Compare
jakebailey
force-pushed
the
transform-stack-commit-24
branch
from
October 4, 2022 22:19
792b782
to
0f369f3
Compare
jakebailey
force-pushed
the
transform-stack-commit-23
branch
from
October 4, 2022 22:49
a02e266
to
03c218e
Compare
jakebailey
changed the title
Clean up some TODOs
Add ts to globalThis for convenience during debugging
Oct 4, 2022
jakebailey
force-pushed
the
transform-stack-commit-24
branch
from
October 4, 2022 22:49
0f369f3
to
9f5b4d3
Compare
jakebailey
force-pushed
the
transform-stack-commit-23
branch
from
October 4, 2022 23:14
03c218e
to
4a86b4c
Compare
jakebailey
force-pushed
the
transform-stack-commit-24
branch
from
October 4, 2022 23:14
9f5b4d3
to
751f57a
Compare
jakebailey
force-pushed
the
transform-stack-commit-23
branch
from
October 4, 2022 23:35
4a86b4c
to
0fb1ba9
Compare
jakebailey
force-pushed
the
transform-stack-commit-24
branch
from
October 4, 2022 23:35
751f57a
to
6578dbb
Compare
jakebailey
force-pushed
the
transform-stack-commit-23
branch
from
October 6, 2022 18:35
0fb1ba9
to
e9d7918
Compare
jakebailey
changed the title
Add ts to globalThis for convenience during debugging
Restore self-compilation using built compiler in CI tests
Oct 6, 2022
jakebailey
force-pushed
the
transform-stack-commit-24
branch
from
October 6, 2022 18:35
6578dbb
to
48673d2
Compare
jakebailey
force-pushed
the
transform-stack-commit-23
branch
from
October 7, 2022 18:34
e9d7918
to
38e1f6f
Compare
jakebailey
force-pushed
the
transform-stack-commit-24
branch
from
October 24, 2022 23:15
1d5bed3
to
c28d68c
Compare
jakebailey
force-pushed
the
transform-stack-commit-23
branch
from
October 25, 2022 02:24
2c74e88
to
2ec34bf
Compare
jakebailey
force-pushed
the
transform-stack-commit-24
branch
from
October 25, 2022 02:24
c28d68c
to
a9b166d
Compare
jakebailey
force-pushed
the
transform-stack-commit-23
branch
from
October 27, 2022 04:25
2ec34bf
to
10fbfc8
Compare
jakebailey
force-pushed
the
transform-stack-commit-24
branch
from
October 27, 2022 04:26
a9b166d
to
b52815c
Compare
jakebailey
force-pushed
the
transform-stack-commit-23
branch
from
October 27, 2022 17:43
10fbfc8
to
2b8cf0b
Compare
jakebailey
force-pushed
the
transform-stack-commit-24
branch
from
October 27, 2022 17:44
b52815c
to
8431802
Compare
jakebailey
force-pushed
the
transform-stack-commit-23
branch
from
October 28, 2022 02:26
2b8cf0b
to
c113f79
Compare
jakebailey
force-pushed
the
transform-stack-commit-24
branch
from
October 28, 2022 02:26
8431802
to
57d2fef
Compare
jakebailey
force-pushed
the
transform-stack-commit-23
branch
from
October 31, 2022 21:36
c113f79
to
0c6b69c
Compare
jakebailey
force-pushed
the
transform-stack-commit-24
branch
from
October 31, 2022 21:37
57d2fef
to
f73c69a
Compare
jakebailey
force-pushed
the
transform-stack-commit-23
branch
from
November 2, 2022 00:47
0c6b69c
to
fbcfb3b
Compare
jakebailey
force-pushed
the
transform-stack-commit-24
branch
from
November 2, 2022 00:47
f73c69a
to
b033d0c
Compare
jakebailey
force-pushed
the
transform-stack-commit-23
branch
from
November 2, 2022 16:59
fbcfb3b
to
03dc75c
Compare
jakebailey
force-pushed
the
transform-stack-commit-24
branch
from
November 2, 2022 16:59
b033d0c
to
9f8832c
Compare
jakebailey
force-pushed
the
transform-stack-commit-23
branch
from
November 2, 2022 19:49
03dc75c
to
ca31a4b
Compare
jakebailey
force-pushed
the
transform-stack-commit-24
branch
from
November 2, 2022 19:49
9f8832c
to
25e6634
Compare
jakebailey
force-pushed
the
transform-stack-commit-23
branch
from
November 6, 2022 21:53
ca31a4b
to
5117c83
Compare
jakebailey
force-pushed
the
transform-stack-commit-24
branch
from
November 6, 2022 21:53
25e6634
to
6e69116
Compare
jakebailey
force-pushed
the
transform-stack-commit-23
branch
from
November 6, 2022 21:58
5117c83
to
017ae89
Compare
jakebailey
force-pushed
the
transform-stack-commit-24
branch
from
November 6, 2022 21:58
6e69116
to
6715a98
Compare
jakebailey
force-pushed
the
transform-stack-commit-23
branch
from
November 7, 2022 03:54
017ae89
to
25958b6
Compare
jakebailey
force-pushed
the
transform-stack-commit-24
branch
from
November 7, 2022 03:54
6715a98
to
c497480
Compare
jakebailey
force-pushed
the
transform-stack-commit-23
branch
from
November 7, 2022 19:28
25958b6
to
147cd71
Compare
jakebailey
force-pushed
the
transform-stack-commit-24
branch
from
November 7, 2022 19:28
c497480
to
058b59f
Compare
jakebailey
force-pushed
the
transform-stack-commit-23
branch
from
November 7, 2022 21:38
147cd71
to
b520f09
Compare
Profiling the build roughly half of the time spent loading the build is spent importing typescript.js, for this one function. Since this stack is already adding required devDependencies, switch readJson to use jsonc-parser (published by the VS Code team), rather than importing the entire LKG typescript.js library.
jakebailey
force-pushed
the
transform-stack-commit-24
branch
from
November 7, 2022 21:38
058b59f
to
fe08021
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Profiling the build roughly half of the time spent loading the
build is spent importing typescript.js, for this one function.
Since this stack is already adding required devDependencies, switch
readJson to use jsonc-parser (published by the VS Code team), rather
than importing the entire LKG typescript.js library.
Please do not comment on this PR. Depending on how this set of PRs evolves, this PR's contents may change entirely based on the order of commits.
This PR is a part of a stack: