forked from microsoft/TypeScript
-
Notifications
You must be signed in to change notification settings - Fork 0
Add ts to globalThis in run.js for convenience during debugging #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1a97904
to
c388116
Compare
e666aad
to
a88fedb
Compare
c292ea6
to
bb4001f
Compare
a88fedb
to
0b39eda
Compare
bb4001f
to
5813ec9
Compare
0b39eda
to
472b33b
Compare
5813ec9
to
58f41e1
Compare
472b33b
to
41cda7d
Compare
58f41e1
to
eac528e
Compare
41cda7d
to
bde0986
Compare
eac528e
to
04898d5
Compare
bde0986
to
3ee116d
Compare
04898d5
to
6726b3b
Compare
3ee116d
to
3065851
Compare
6726b3b
to
e57029d
Compare
3065851
to
9f09312
Compare
e57029d
to
75162a2
Compare
9f09312
to
7eb1f08
Compare
75162a2
to
01112ec
Compare
7eb1f08
to
d46fefa
Compare
01112ec
to
d4decce
Compare
d46fefa
to
074ba8f
Compare
d4decce
to
d29dbf6
Compare
074ba8f
to
4d20fcf
Compare
1667a2e
to
1b5c731
Compare
084b7ea
to
aab52d6
Compare
1b5c731
to
c35d3e3
Compare
aab52d6
to
de670ad
Compare
c35d3e3
to
e5098d0
Compare
de670ad
to
384fe8d
Compare
e5098d0
to
6d97c8e
Compare
384fe8d
to
026e6e9
Compare
6d97c8e
to
2b3207e
Compare
026e6e9
to
af1a0d3
Compare
2b3207e
to
d408983
Compare
af1a0d3
to
d93aadf
Compare
d408983
to
85ac80a
Compare
d93aadf
to
2601d2b
Compare
85ac80a
to
45ad420
Compare
2601d2b
to
fd98dd3
Compare
45ad420
to
7b878a9
Compare
fd98dd3
to
231f965
Compare
7b878a9
to
3cd4a8a
Compare
231f965
to
8e7607f
Compare
3cd4a8a
to
9665d34
Compare
8e7607f
to
ba01ac8
Compare
9665d34
to
40c61ca
Compare
ba01ac8
to
cd0bfbc
Compare
40c61ca
to
eaf22e3
Compare
In namespaces, we'd have access to a variable named "ts" when debugging, because that was just the ts namespace in the current file. But when modules, that variable doesn't exist, either because we are pure modules (so no ts variable), or named something else (when bundled, for export). Tack a "ts" object onto the globals, which should make this easier. Of course, someone may eventually declare a variable in the top level scope named "ts" and break this, but we can cross that bridge when we come to it.
cd0bfbc
to
423ad68
Compare
eaf22e3
to
96627f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In namespaces, we'd have access to a variable named "ts" when debugging,
because that was just the ts namespace in the current file. But when
modules, that variable doesn't exist, either because we are pure modules
(so no ts variable), or named something else (when bundled, for export).
Tack a "ts" object onto the globals, which should make this easier. Of
course, someone may eventually declare a variable in the top level scope
named "ts" and break this, but we can cross that bridge when we come to
it.
Please do not comment on this PR. Depending on how this set of PRs evolves, this PR's contents may change entirely based on the order of commits.
This PR is a part of a stack: