Skip to content

Remove Promise redeclaration #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Remove Promise redeclaration #39

wants to merge 1 commit into from

Conversation

jakebailey
Copy link
Owner

@jakebailey jakebailey commented Oct 10, 2022 •
edited
Loading

Now that we target ES2018, we don't need to declare this ourselves.

Please do not comment on this PR. Depending on how this set of PRs evolves, this PR's contents may change entirely based on the order of commits.

This PR is a part of a stack:

  1. Make a few changes to allow all code to be loaded as one project
  2. Explicitly reference ts namespace in tsserverlibrary
  3. Generated module conversion step - unindent
  4. Generated module conversion step - explicitify
  5. Generated module conversion step - stripNamespaces
  6. Generated module conversion step - inlineImports
  7. Generated module conversion step - .git-ignore-blame-revs
  8. Add gitlens settings suggestion
  9. Make processDiagnosticMessages generate a module
  10. Fix up linting, make lint clean
  11. Undo changes needed to load codebase into ts-morph
  12. Add JSDoc eslint rule
  13. Fix all internal JSDoc comments
  14. Convert require calls to imports
  15. Remove typescriptServices, protocol.d.ts, typescript_standalone.d.ts
  16. Get codebase building pre bundling
  17. Add build via esbuild
  18. Add dts bundling
  19. Consolidate checks that test if the current environment is Node
  20. Add ts to globalThis in run.js for convenience during debugging
  21. Rename Gulpfile to Herebyfile for improved git diff
  22. Change build system to hereby
  23. Update baselines for corrected line endings in lib files
  24. Use jsonc-parser instead of LKG compiler in build
  25. Modernize localize script, use new XML library
  26. Don't use needsUpdate for quick tasks
  27. Remove mkdirp
  28. Export ts namespace from tsserver for hacky-post patching
  29. Directly import namespaces for improved esbuild output
  30. Ensure ts object passed to plugins contains deprecatedCompat declarations
  31. Move compiler-debug into Debug namespace, which allows the compiler to be tree shaken
  32. Remove Promise redeclaration (this PR)
  33. Remove globalThisShim and globalThis modification for TypeScriptServicesFactory
  34. Disable slow CodeQL queries
  35. Remove outFiles from launch.json
  36. Remove dynamicImport and setDynamicImport

@jakebailey jakebailey force-pushed the transform-stack-commit-31 branch from b88df81 to 5c81d1a Compare October 10, 2022 21:05
@jakebailey jakebailey changed the title Don't use needsUpdate for quick tasks Change build system to hereby Oct 10, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-32 branch from 1280b76 to 330c672 Compare October 10, 2022 21:05
@jakebailey jakebailey force-pushed the transform-stack-commit-31 branch from 5c81d1a to 3d4c9f0 Compare October 10, 2022 22:54
@jakebailey jakebailey force-pushed the transform-stack-commit-32 branch from 330c672 to 0c3c6a5 Compare October 10, 2022 22:54
@jakebailey jakebailey force-pushed the transform-stack-commit-31 branch from 3d4c9f0 to 2d7af0f Compare October 10, 2022 23:14
@jakebailey jakebailey force-pushed the transform-stack-commit-32 branch from 0c3c6a5 to e988f28 Compare October 10, 2022 23:14
@jakebailey jakebailey force-pushed the transform-stack-commit-31 branch from 2d7af0f to 41e57d6 Compare October 10, 2022 23:31
@jakebailey jakebailey force-pushed the transform-stack-commit-32 branch from e988f28 to 2bb8bea Compare October 10, 2022 23:31
@jakebailey jakebailey force-pushed the transform-stack-commit-31 branch from 41e57d6 to 95bb6e2 Compare October 11, 2022 23:15
@jakebailey jakebailey force-pushed the transform-stack-commit-32 branch from 2bb8bea to 8daa230 Compare October 11, 2022 23:15
@jakebailey jakebailey force-pushed the transform-stack-commit-31 branch from 95bb6e2 to f782b2c Compare October 11, 2022 23:31
@jakebailey jakebailey force-pushed the transform-stack-commit-32 branch from 8daa230 to 1dfcafc Compare October 11, 2022 23:32
@jakebailey jakebailey force-pushed the transform-stack-commit-31 branch from f782b2c to e5fd341 Compare October 12, 2022 22:48
@jakebailey jakebailey force-pushed the transform-stack-commit-32 branch from 1dfcafc to bc2e7d0 Compare October 12, 2022 22:48
@jakebailey jakebailey force-pushed the transform-stack-commit-31 branch from e5fd341 to 26ba28d Compare October 14, 2022 19:36
@jakebailey jakebailey force-pushed the transform-stack-commit-32 branch from bc2e7d0 to 3f1e529 Compare October 14, 2022 19:36
@jakebailey jakebailey force-pushed the transform-stack-commit-31 branch from 26ba28d to 9c72255 Compare October 14, 2022 21:20
@jakebailey jakebailey changed the title Change build system to hereby Update baselines for corrected line endings in lib files Oct 14, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-32 branch from 3f1e529 to 0a1199d Compare October 14, 2022 21:20
@jakebailey jakebailey force-pushed the transform-stack-commit-31 branch from 9c72255 to 229d522 Compare October 14, 2022 22:28
@jakebailey jakebailey force-pushed the transform-stack-commit-32 branch from 0a1199d to 4eb7f2b Compare October 14, 2022 22:28
@jakebailey jakebailey force-pushed the transform-stack-commit-31 branch from 229d522 to 9e92519 Compare October 14, 2022 23:35
@jakebailey jakebailey force-pushed the transform-stack-commit-32 branch from 4eb7f2b to 4673a15 Compare October 14, 2022 23:35
@jakebailey jakebailey force-pushed the transform-stack-commit-31 branch from 9e92519 to c2e8900 Compare October 20, 2022 00:50
@jakebailey jakebailey changed the title Update baselines for corrected line endings in lib files Switch to faster XML parsing library for localize Oct 20, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-32 branch from 4673a15 to 574778b Compare October 20, 2022 00:50
@jakebailey jakebailey force-pushed the transform-stack-commit-31 branch from c2e8900 to 3b55b02 Compare October 20, 2022 01:25
@jakebailey jakebailey changed the title Switch to faster XML parsing library for localize Specify rootDir and outDir in tsconfig-base rather than in each tsconfig Oct 20, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-32 branch from 574778b to ab07115 Compare October 20, 2022 01:25
@jakebailey jakebailey force-pushed the transform-stack-commit-31 branch from e1ee5ae to 384ab90 Compare October 24, 2022 23:16
@jakebailey jakebailey changed the title Move compiler-debug into Debug namespace, which allows the compiler to be tree shaken Remove Promise redeclaration Oct 24, 2022
@jakebailey jakebailey force-pushed the transform-stack-commit-32 branch from 1d1fdfc to df79610 Compare October 24, 2022 23:16
@jakebailey jakebailey force-pushed the transform-stack-commit-31 branch from 384ab90 to 9f324c5 Compare October 25, 2022 02:25
@jakebailey jakebailey force-pushed the transform-stack-commit-32 branch from df79610 to 5428a1b Compare October 25, 2022 02:25
@jakebailey jakebailey force-pushed the transform-stack-commit-31 branch from 9f324c5 to 67d85a4 Compare October 27, 2022 17:47
@jakebailey jakebailey force-pushed the transform-stack-commit-32 branch from 5428a1b to cdaee78 Compare October 27, 2022 17:47
@jakebailey jakebailey force-pushed the transform-stack-commit-31 branch from 67d85a4 to 7360152 Compare October 28, 2022 02:29
@jakebailey jakebailey force-pushed the transform-stack-commit-32 branch from cdaee78 to 9ae2a86 Compare October 28, 2022 02:29
@jakebailey jakebailey force-pushed the transform-stack-commit-31 branch from 7360152 to 6aa7f3e Compare October 31, 2022 21:40
@jakebailey jakebailey force-pushed the transform-stack-commit-32 branch from 9ae2a86 to bbdce63 Compare October 31, 2022 21:40
@jakebailey jakebailey force-pushed the transform-stack-commit-31 branch from 6aa7f3e to 47028cb Compare November 2, 2022 00:50
@jakebailey jakebailey force-pushed the transform-stack-commit-32 branch from bbdce63 to d6c1a92 Compare November 2, 2022 00:50
@jakebailey jakebailey force-pushed the transform-stack-commit-31 branch from 47028cb to c2c6386 Compare November 2, 2022 17:02
@jakebailey jakebailey force-pushed the transform-stack-commit-32 branch from d6c1a92 to 3f03d48 Compare November 2, 2022 17:02
@jakebailey jakebailey force-pushed the transform-stack-commit-31 branch from c2c6386 to a524243 Compare November 2, 2022 19:52
@jakebailey jakebailey force-pushed the transform-stack-commit-32 branch from 3f03d48 to 8ba14a9 Compare November 2, 2022 19:52
@jakebailey jakebailey force-pushed the transform-stack-commit-31 branch from a524243 to 08fe163 Compare November 6, 2022 21:53
@jakebailey jakebailey force-pushed the transform-stack-commit-32 branch from 8ba14a9 to f8f2c6b Compare November 6, 2022 21:53
@jakebailey jakebailey force-pushed the transform-stack-commit-31 branch from 08fe163 to 654a6e3 Compare November 6, 2022 21:59
@jakebailey jakebailey force-pushed the transform-stack-commit-32 branch from f8f2c6b to 6b01bff Compare November 6, 2022 21:59
@jakebailey jakebailey force-pushed the transform-stack-commit-31 branch from 654a6e3 to 175fc44 Compare November 7, 2022 03:54
@jakebailey jakebailey force-pushed the transform-stack-commit-32 branch from 6b01bff to 1978ea6 Compare November 7, 2022 03:54
@jakebailey jakebailey force-pushed the transform-stack-commit-31 branch from 175fc44 to a6091c0 Compare November 7, 2022 19:28
@jakebailey jakebailey force-pushed the transform-stack-commit-32 branch from 1978ea6 to 5f534d6 Compare November 7, 2022 19:29
@jakebailey jakebailey force-pushed the transform-stack-commit-31 branch from a6091c0 to 32515e4 Compare November 7, 2022 21:39
@jakebailey
Remove Promise redeclaration
5a5a2fe 
Now that we target ES2018, we don't need to declare this ourselves.
@jakebailey jakebailey force-pushed the transform-stack-commit-32 branch from 5f534d6 to 5a5a2fe Compare November 7, 2022 21:39
@jakebailey jakebailey closed this Nov 7, 2022
@jakebailey jakebailey deleted the transform-stack-commit-32 branch November 7, 2022 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jakebailey