Skip to content

feature/format: Merge VS 2019 16.8 Preview 1 toolset update #1177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StephanTLavavej merged 50 commits into from
Aug 10, 2020
Merged

feature/format: Merge VS 2019 16.8 Preview 1 toolset update #1177

StephanTLavavej merged 50 commits into from
Aug 10, 2020

Conversation

@StephanTLavavej
Copy link
Member

@StephanTLavavej StephanTLavavej commented Aug 10, 2020

Merge #1153 into feature/format so we can delete the old VMSS pool.

⚠️ Note to self: Commit this as a merge, not a squash!

miscco and others added 30 commits July 16, 2020 21:54
@miscco @StephanTLavavej
Implement ranges::transform (#941)
002cdc6 
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
@miscco
Implement ranges::remove family (#1005)
16db993
@Chronial
Use permissive wide-to-narrow transcoding in filesystem_error (#1010)
0965ada
@CaseyCarter @StephanTLavavej
Implement ranges::copy_backward (#1026)
21acd23 
* Implement ranges::copy_backward

Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
@CaseyCarter @ahanamuk
Implement ranges::reverse (#1028)
4f949af 
Co-authored-by: Ahana Mukhopadhyay <t-ahmukh@microsoft.com>
@CaseyCarter @statementreply @StephanTLavavej
<compare>: Fix 0 <=> partial_ordering::unordered (#1049)
7930d35 
* Break <compare> ABI again, and fix #1050.

* Remove obsolete conditional compilation from <compare>.

Co-authored-by: statementreply <statementreply@gmail.com>
Co-authored-by: Stephan T. Lavavej <stl@microsoft.com>
@BillyONeal @CaseyCarter @StephanTLavavej
<system_error> Enable [[msvc::noop_dtor]] from Visual Studio 2019 ver…
6c04496 
…sion 16.8. (#1016)

Co-authored-by: Casey Carter <cartec69@gmail.com>
Co-authored-by: Stephan T. Lavavej <stl@microsoft.com>
@AlexGuteniev @StephanTLavavej
@BillyONeal @CaseyCarter
Atomic CAS with pad (#23, P0528R3) (#1029)
c10ae01 
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
Co-authored-by: Billy Robert O'Neal III <bion@microsoft.com>
Co-authored-by: Casey Carter <cartec69@gmail.com>
@pawREP @BillyONeal @StephanTLavavej
Vectorize reverse_copy() (#804)
1555e0b 
Co-authored-by: Billy Robert O'Neal III <bion@microsoft.com>
Co-authored-by: Stephan T. Lavavej <stl@microsoft.com>
@statementreply
<random>: Fix discrete_distribution result out of range (#1025)
8e8770c 
Mathematically, `_Par0._Pcdf.back()` should be one. However, when it is
actually slightly smaller than one due to rounding error, there is a
small probability that `_Px > _Par0._Pcdf.back()` and the original code
returns the invalid value of `_Par0._Pcdf.size()`.
@miscco @StephanTLavavej @CaseyCarter
Implement ranges::unique family (#1039)
28efc70 
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
Co-authored-by: Casey Carter <Casey@Carter.net>
@miscco @statementreply
Implement ranges::sample and ranges::shuffle (#1052)
99241dc 
Co-authored-by: statementreply <statementreply@gmail.com>
@miscco @CaseyCarter @StephanTLavavej
Modernize the ranges::find family (#1058)
98f37c3 
Co-authored-by: Casey Carter <cartec69@gmail.com>
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
@miscco
Modernize ranges::for_each (#1060)
5ada43e
@miscco
Modernize ranges::all_of and friends (#1061)
fc3df2f
@StephanTLavavej
Update .clang-format for Clang 10 (#1075)
b2f1556 
* Remove unnecessary comments in ranges tests.

We taught clang-format how to sort like this automatically.

* Fix x86 compiler error in stljobs.h.

This never compiled for x86 where size_t and SIZE_T are different types.

* Update .clang-format for Clang 10.

AllowShortBlocksOnASingleLine changed from false/true to
Never/Empty/Always. We still want the default of Never, as Empty
appears to misbehave.

DeriveLineEnding was added, defaulting to true. We want to disable line
ending auto-detection.

SortPriority was added. Its documentation is difficult to understand,
but it can be used to group includes together while modifying their
otherwise-lexicographic ordering. Here, I'm using it to group WinSDK
includes together, while still sorting WinIoCtl.h last.

IncludeIsMainSourceRegex was added. This doesn't appear to be relevant
to us.

IndentGotoLabels was added. We've avoided goto.

SpaceInEmptyBlock was added. We prefer the default of no space.

SpacesInConditionalStatement was added. We definitely prefer the
default of no space.

SpaceBeforeSquareBrackets was added. Again, we definitely prefer the
default of no space.

The Standard option was overhauled. Previously, Cpp11 meant "use the
latest supported standard". That was confusing, so it has been
deprecated in favor of Latest.

UseCRLF was added. We currently use CRLF for all files. (Previously,
validate.cpp would detect LF files, but clang-format wouldn't fix
them.)

* In .clang-format, delete empty lines and move comment.

The empty lines were intended to make it easier to see customized
options, but they were actually making it harder to diff the default
config against our config.

Move the StatementMacros comment next to our customized settings,
and rewrap it.

* Reformat filesystem.cpp.
@miscco
Uglify the current member of move_iterator (#1080)
f49ffaf
@CaseyCarter
Implement Ranges Set Operations (#1044)
3659f3d 
Includes the `mergeable` concept and algorithms `ranges::includes`, `ranges::set_union`, `ranges::set_intersection`, `ranges::set_difference`, and `ranges::set_symmetric_difference`.
@CaseyCarter @StephanTLavavej @mnatsuhara
Implement ranges::move_backward (#1053)
868cf26 
* Implement ranges::move_backward

Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
Co-authored-by: mnatsuhara <46756417+mnatsuhara@users.noreply.github.com>
@CaseyCarter
Fix the interaction between _Pass_fn and invoke (#1091)
35ce1cf 
`_Pass_fn` returns a copy of arguments no larger than `void*`, and a call-forwarding reference-wrapper-alike `_Ref_fn` for larger function objects. This became a problem when Ranges started throwing pointers-to-member at `_Pass_fn` with the expectation that they would eventually be `invoke`d: pointers-to-member can be larger than `void*`, but `_Ref_fn` doesn't speak the `invoke` protocol.

There are two relatively obvious possible fixes:
1. Teach `_Pass_fn` to always return copies of pointers-to-member regardless of size
2. Teach `_Ref_fn` to obey the `invoke` protocol

(1) results in "large" pointers-to-member that can't be enregistered being copied and passed by hidden reference resulting in larger codesize than (2), but with no corresponding performance benefits. We therefore implement (2) by teaching `_Ref_fn` to call-forward through `invoke` when it wraps a pointer-to-member.

Fixes GH-1089.
@AlexGuteniev @cpplearner
@CaseyCarter @StephanTLavavej
<valarray>: Implement copies for slice_array, gslice_array, mask_arra…
0e7b5d2 
…y, and indirect_array (#988)

Co-authored-by: S. B. Tam <cpplearner@outlook.com>
Co-authored-by: Casey Carter <cartec69@gmail.com>
Co-authored-by: Stephan T. Lavavej <stl@microsoft.com>
@statementreply @StephanTLavavej
Finish P0811R3 midpoint and lerp (#1048)
e9f56a6 
* Removes workaround for missing `bit_cast` and mark `lerp` constexpr.

* Changes how `lerp` handles infinite inputs according to
  #65 (comment) and
  #65 (comment).

* Adds constexpr tests.

Co-authored-by: Stephan T. Lavavej <stl@microsoft.com>
@CaseyCarter
Fix thinko in ranges::iter_swap (#1072)
30777d5 
...by transposing arguments to `_Iter_exchange_move`.

Fixes #1067
@miscco @CaseyCarter
Implement ranges::rotate and ranges::rotate_copy (#1073)
58a8a39 
Co-authored-by: Casey Carter <Casey@Carter.net>
@CaseyCarter
Comparison category types become aggregates (#1065)
4e97255 
... for enregistration, to improve performance. Per a suggestion from Statementreply in the discussion at #1049 (comment).
@ArtemSarmini @CaseyCarter @StephanTLavavej
<type_traits>: is_function simplification (#460)
0381c25 
Fixes #198.

Co-authored-by: Casey Carter <cacarter@microsoft.com>
Co-authored-by: Stephan T. Lavavej <stl@microsoft.com>
@miscco @BillyONeal @StephanTLavavej
Optimize fill and fill_n for vector<bool> (#879)
1ff3d1e 
Co-authored-by: Billy Robert O'Neal III <bion@microsoft.com>
Co-authored-by: Stephan T. Lavavej <stl@microsoft.com>
@miscco @CaseyCarter @StephanTLavavej
Modernize ranges::swap_ranges and ranges::distance (#1062)
accaf18 
Co-authored-by: Casey Carter <Casey@Carter.net>
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
@CaseyCarter
Implement ranges::nth_element (#1063)
e58a945
@CaseyCarter
Implement ranges::ssize (#1076)
e2912b6
StephanTLavavej and others added 20 commits August 1, 2020 16:36
@StephanTLavavej
Fix weak_ptr conversions, preserving control blocks for expired objec…
57db210 
…ts (#1104)

Fixes #1102.
@AlexGuteniev
<bit>: Fix countl_zero to switch between lzcnt and bsr correctly (#1108)
782cd65 
Fixes #1103.
@CaseyCarter
Enable tests Dev09_172666_tr1_tuple_odr and VSO_0000000_matching_npos…
a712fe5 
…_address (#1109)
@BillyONeal
P1001R2 execution::unseq (#1111)
8ec6b33 
Resolves #44.
@AlexGuteniev @cbezault
@StephanTLavavej @BillyONeal @CaseyCarter
Implement std::atomic::wait (#593)
e4b75dc 
Co-authored-by: Curtis J Bezault <curtbezault@gmail.com>
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
Co-authored-by: Billy Robert O'Neal III <bion@microsoft.com>
Co-authored-by: Casey Carter <cartec69@gmail.com>
@StephanTLavavej
Cleanup std qualification and old bug citations (#1119)
12c684b
@BillyONeal
Change CMakeLists.txt to default to our submodule'd vcpkg copy. (#1124)
b57b768
@AlexGuteniev
Remove timing assumption that causes test to fail spuriously (#1129)
b74b618
@CaseyCarter @StephanTLavavej
Implement ranges::reverse_copy (#1095)
622b62a 
Co-authored-by: Stephan T. Lavavej <stl@microsoft.com>
@CaseyCarter
Implement ranges::next_permutation and ranges::prev_permutation (#1099)
0eb754d
@CaseyCarter
Implement ranges::merge (#1101)
5d00b60
@StephanTLavavej
Fix build warning "restarting link with /LTCG". (#1140)
06c2c54
@leejy12
Update _MSVC_STL_UPDATE to August 2020 (#1144)
cbfc527
@JonCavesMSFT @StephanTLavavej @CaseyCarter
Disable a libcxx test due to the impact of P0960R3 (#1138)
e000d3f 
Disable some tests due to impact of P0960R3: allow initializing aggregates from a parenthesized list of values
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
Co-authored-by: Casey Carter <cartec69@gmail.com>
@StephanTLavavej
Upgrade toolset to VS 2019 16.8 Preview 1 (#1153)
d83bc99 
Fixes #1051.
@CaseyCarter
Implement ranges::lexicographical_compare (#1081)
eb33f1a
@CaseyCarter
partial_sort_copy bugfix (#1088)
af3db68 
Fixes #1086.
@AlexGuteniev @AdamBucior
wait/notify atomic<shared_ptr<T>> (#52, P1644R0) (#1136)
bdf7710 
Co-authored-by: Adam Bucior <35536269+AdamBucior@users.noreply.github.com>
@AlexGuteniev @CaseyCarter @BillyONeal
Cache hardware thread count for <execution> (#1143)
392fb6d 
Fixes #1134.

Co-authored-by: Casey Carter <cartec69@gmail.com>
Co-authored-by: Billy O'Neal <bion@microsoft.com>
@Arzaghi
Fix unnecessary self-move-assignments in deque erase(iter, iter) (#1148)
1913566 
Fixes #1118.
@StephanTLavavej StephanTLavavej added the infrastructure Related to repository automation label Aug 10, 2020
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner August 10, 2020 00:00
@StephanTLavavej StephanTLavavej merged commit 7f4bbce into feature/format Aug 10, 2020
@StephanTLavavej StephanTLavavej mentioned this pull request Aug 10, 2020
Closed
@StephanTLavavej StephanTLavavej added the uncharted Excluded from the Status Chart label Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

infrastructure Related to repository automation uncharted Excluded from the Status Chart

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.